You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by BuDongDong <gi...@git.apache.org> on 2014/10/09 11:48:22 UTC
[GitHub] storm pull request: update worker.clj-delete "missing-tasks" check...
GitHub user BuDongDong opened a pull request:
https://github.com/apache/storm/pull/288
update worker.clj-delete "missing-tasks" checking
missing-tasks set is created by two times filter my-assignment map, so i think keys(my-assignment) contains missing-tasks set.
missing-tasks is always empty. (empty? missing-tasks) always return true.
(let [missing-tasks (->> needed-tasks
(filter (complement my-assignment)))]
(when-not (empty? missing-tasks)
(log-warn "Missing assignment for following tasks: " (pr-str missing-tasks))
))
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BuDongDong/incubator-storm patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #288
----
commit 4b65d8152527f6770db6d103a7e2950f1a1f5f91
Author: zhangjinlong <zh...@126.com>
Date: 2014-10-09T09:48:00Z
update worker.clj-delete "missing-tasks" checking
missing-tasks set is created by two times filter my-assignment map, so i think keys(my-assignment) contains missing-tasks set.
missing-tasks is always empty. (empty? missing-tasks) always return true.
(let [missing-tasks (->> needed-tasks
(filter (complement my-assignment)))]
(when-not (empty? missing-tasks)
(log-warn "Missing assignment for following tasks: " (pr-str missing-tasks))
))
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: update worker.clj-delete "missing-tasks" check...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/288#issuecomment-72536306
@BuDongDong I merged this in, but because your repo was deleted the pull request is not automatically recognizing that it was pulled in. Could you check master and close this pull request if it looks OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: update worker.clj-delete "missing-tasks" check...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/288#issuecomment-69103211
@BuDongDong from what I can tell you are correct on this. My only comment is that you probably also want to remove ``` needed-tasks (-> needed-assignment keys)``` too, as needed-tasks is only used in the code you just deleted. If you want to file a JIRA for this under STORM in http://issue.apache.org/jira that would be great. But I can do that if you would prefer.
Sorry it took so long for me to review this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: update worker.clj-delete "missing-tasks" check...
Posted by BuDongDong <gi...@git.apache.org>.
Github user BuDongDong commented on the pull request:
https://github.com/apache/storm/pull/288#issuecomment-74460727
@revans2 ok, i will close this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: update worker.clj-delete "missing-tasks" check...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/288#issuecomment-69103370
After that one minor change I am +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: update worker.clj-delete "missing-tasks" check...
Posted by BuDongDong <gi...@git.apache.org>.
Github user BuDongDong commented on the pull request:
https://github.com/apache/storm/pull/288#issuecomment-69576596
@revans2 I have filed a JIRA(STORM-527) for this, please see https://issues.apache.org/jira/browse/STORM-527
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: update worker.clj-delete "missing-tasks" check...
Posted by BuDongDong <gi...@git.apache.org>.
Github user BuDongDong commented on the pull request:
https://github.com/apache/storm/pull/288#issuecomment-69574937
@revans2 thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: update worker.clj-delete "missing-tasks" check...
Posted by BuDongDong <gi...@git.apache.org>.
Github user BuDongDong closed the pull request at:
https://github.com/apache/storm/pull/288
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---