You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by ykopel <gi...@git.apache.org> on 2017/02/19 08:06:35 UTC
[GitHub] trafficserver pull request #1471: is_transparent_passthrough_allowed always ...
GitHub user ykopel opened a pull request:
https://github.com/apache/trafficserver/pull/1471
is_transparent_passthrough_allowed always returns false
In the "parent" class "ProxyClientSession.h" the function "is_transparent_passthrough_allowed()" always return false (hard-coded). The inherited class "Http1ClientSession.h" contains internal variable "f_transparent_passthrough" but doesn't implement the "is_transparent_passthrough_allowed()" function to return this its value.
My commit, just implement the function in the inherited class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ykopel/trafficserver is_transparent_passthrough_allowed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1471.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1471
----
commit daaa9e31c17c8a33190ed41edc1338b00b5215fd
Author: Yakov Kopel <ya...@gmail.com>
Date: 2017-02-19T08:05:43Z
is_transparent_passthrough_allowed always returns false
In the "parent" class "ProxyClientSession.h" the function "is_transparent_passthrough_allowed()" always return false (hard-coded). The inherited class "Http1ClientSession.h" contains internal variable "f_transparent_passthrough" but doesn't implement the "is_transparent_passthrough_allowed()" function to return this its value.
My commit, just implement the function in the inherited class.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1471: is_transparent_passthrough_allowed always returns...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1471
Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1494/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1471: is_transparent_passthrough_allowed always returns...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1471
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1471: is_transparent_passthrough_allowed always returns...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1471
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1471: is_transparent_passthrough_allowed always returns...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1471
clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/164/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1471: is_transparent_passthrough_allowed always returns...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1471
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1600/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1471: is_transparent_passthrough_allowed always returns...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1471
Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/32/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1471: is_transparent_passthrough_allowed always returns...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1471
Linux build *successful*! See https://ci.trafficserver.apache.org/job/RAT-github/9/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---