You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/03 09:29:33 UTC
[GitHub] [incubator-nuttx] raiden00pl opened a new pull request, #6771: arch/stm32xx/Kconfig: simplify and unify PWM options
raiden00pl opened a new pull request, #6771:
URL: https://github.com/apache/incubator-nuttx/pull/6771
## Summary
- arch/stm32xx/Kconfig: simplify PWM options and unify them among stm32 chips
## Impact
Configurations using PWM for STM32L4/F0/L0/G0 must be updated:
- CONFIG_STM32F0L0G0_TIMx_PWM=y doesn't select CONFIG_PWM=y automatically,
- CONFIG_STM32F0L0G0_PWM_MULTICHAN=y doesn't select CONFIG_PWM_MULTICHAN=y automatically
- CONFIG_STM32L4_TIMx_PWM=y doesn't select CONFIG_PWM=y automatically,
- CONFIG_STM32U5_TIMx_PWM=y doesn't select CONFIG_PWM=y automatically,
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on pull request #6771: arch/stm32xx/Kconfig: simplify and unify PWM options
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on PR #6771:
URL: https://github.com/apache/incubator-nuttx/pull/6771#issuecomment-1203860682
@davids5 only nucleo-g070rb/nsh is affected. There is no more PWM configurations for F0/L0/G0 or L4. All other STM32 families don't require any changes (no `select PWM` in arch Kconfig options)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #6771: arch/stm32xx/Kconfig: simplify and unify PWM options
Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #6771:
URL: https://github.com/apache/incubator-nuttx/pull/6771#issuecomment-1203831047
> Configurations using PWM for STM32L4/F0/L0/G0 must be updated:
@raiden00pl I only saw one, were all the in-tree defconfig updated?
Do we have enough configs to get good CI coverage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on pull request #6771: arch/stm32xx/Kconfig: simplify and unify PWM options
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on PR #6771:
URL: https://github.com/apache/incubator-nuttx/pull/6771#issuecomment-1203951180
@hartmannathan Not really. The upper-half PWM driver logic is just an option and it is very limited. We can use the PWM lower-half logic to build more complex and application specific drivers (eg. FOC driver). The same applies to ADC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6771: arch/stm32xx/Kconfig: simplify and unify PWM options
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6771:
URL: https://github.com/apache/incubator-nuttx/pull/6771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org