StateChangedNotifier

[Mike Kienenberger <mk...@gmail.com>]

Hey Werner,

Any chance you could fix the MyFaces-Impl dependencies for
StateChangedNotifier since you've been doing some work on it?

http://issues.apache.org/jira/browse/TOMAHAWK-220

org.apache.myfaces.custom.statechangednotifier.StateChangedNotifierTag
org.apache.myfaces.custom.statechangednotifier.StateChangedNotifierRenderer

Re: StateChangedNotifier

[Werner Punz <we...@gmx.at>]

Mike Kienenberger schrieb:
> Hey Werner,
> 
> Any chance you could fix the MyFaces-Impl dependencies for
> StateChangedNotifier since you've been doing some work on it?
> 
> http://issues.apache.org/jira/browse/TOMAHAWK-220
> 
> org.apache.myfaces.custom.statechangednotifier.StateChangedNotifierTag
> org.apache.myfaces.custom.statechangednotifier.StateChangedNotifierRenderer
> 
We ran into some performance issues with that component anyway, so it 
might get a bigger overhaul :-(

Re: StateChangedNotifier

[Werner Punz <we...@gmx.at>]

Mike Kienenberger schrieb:
> Hey Werner,
> 
> Any chance you could fix the MyFaces-Impl dependencies for
> StateChangedNotifier since you've been doing some work on it?
> 
> http://issues.apache.org/jira/browse/TOMAHAWK-220
> 
> org.apache.myfaces.custom.statechangednotifier.StateChangedNotifierTag
> org.apache.myfaces.custom.statechangednotifier.StateChangedNotifierRenderer
> 
yes... will happen within a weeks timeframe or so.

Re: StateChangedNotifier

[Werner Punz <we...@gmx.at>]

Mike Kienenberger schrieb:
> On 4/7/06, Werner Punz <we...@gmx.at> wrote:
>> Ok then I will fix that reference as well on the weekend.
>> (if it was not fixed by an eclipse import automatically ;-) )
> 
> Because of the test classes, the default setup in eclipse has
> myfaces-impl and myfaces-shared-impl classes on the build path.    And
> unfortunately, I think a shared_impl import is chosen before a
> shared_tomahawk import (alphabetical), so an automatic import actually
> makes things worse.
> 
> For now, I think the best solution is to remove myfaces-impl from the
> build path and remove the test classes from the source path.   Run the
> tests either from the command-line or manually add them back in later.
> 
Not really I fixed the outstanding issue on friday, and the whole import
is done in case of an anbiquity with a popup dialog asking you for
the correct import, the main issue in this case is that the wrong shared 
lib is listed as the first choice.

Btw. has this stuff been written down somewhere, it might
get confusing in the long run if there are no clear guidelines being 
written down.

Re: StateChangedNotifier

[Mike Kienenberger <mk...@gmail.com>]

On 4/7/06, Werner Punz <we...@gmx.at> wrote:
> Ok then I will fix that reference as well on the weekend.
> (if it was not fixed by an eclipse import automatically ;-) )

Because of the test classes, the default setup in eclipse has
myfaces-impl and myfaces-shared-impl classes on the build path.    And
unfortunately, I think a shared_impl import is chosen before a
shared_tomahawk import (alphabetical), so an automatic import actually
makes things worse.

For now, I think the best solution is to remove myfaces-impl from the
build path and remove the test classes from the source path.   Run the
tests either from the command-line or manually add them back in later.

Re: StateChangedNotifier

[Werner Punz <we...@gmx.at>]

Mike Kienenberger schrieb:
> On 4/6/06, Werner Punz <we...@gmx.at> wrote:
>> Btw. are there clear guidlines which parts can
>> be used and which not, I am still relying on a
>> myfaces-impl_shared class currently.
> 
> You can depend on anything except the myfaces-impl classes and the
> myfaces-impl_shared classes.
> 
> In the case above, just change from impl_shared to tomahawk_shared.
> 
> In eclipse,  you can just remove the myfaces-impl project and see what
> still needs to be fixed.
> 
> In maven, you can change the myfaces-impl dependency from provided to
> test to check it.
> 
Ok then I will fix that reference as well on the weekend.
(if it was not fixed by an eclipse import automatically ;-) )

Re: StateChangedNotifier

[Mike Kienenberger <mk...@gmail.com>]

On 4/6/06, Werner Punz <we...@gmx.at> wrote:
> Btw. are there clear guidlines which parts can
> be used and which not, I am still relying on a
> myfaces-impl_shared class currently.

You can depend on anything except the myfaces-impl classes and the
myfaces-impl_shared classes.

In the case above, just change from impl_shared to tomahawk_shared.

In eclipse,  you can just remove the myfaces-impl project and see what
still needs to be fixed.

In maven, you can change the myfaces-impl dependency from provided to
test to check it.

Re: StateChangedNotifier

[Werner Punz <we...@gmx.at>]

Depends, we will definitely get some code duplication.

Btw. are there clear guidlines which parts can
be used and which not, I am still relying on a
myfaces-impl_shared class currently.

I can fix that as well, but I havent seen a need for that
because to my knowledge all shared stuff will be bound to
the jars anyway.

Werner


Mike Kienenberger schrieb:
> I saw that!  Thanks!
> 
> I'm glad you worked on it instead of me.   I wouldn't have considered
> that approach.   Maybe we can apply the approach of depending on the
> jsf-api classes for the other broken components as well.
> 
> Yes, Jira is down for me as well.
> 
> 
> On 4/6/06, Werner Punz <we...@gmx.at> wrote:
>> Mike Kienenberger schrieb:
>>> Hey Werner,
>>>
>>> Any chance you could fix the MyFaces-Impl dependencies for
>>> StateChangedNotifier since you've been doing some work on it?
>>>
>>> http://issues.apache.org/jira/browse/TOMAHAWK-220
>>>
>>> org.apache.myfaces.custom.statechangednotifier.StateChangedNotifierTag
>>> org.apache.myfaces.custom.statechangednotifier.StateChangedNotifierRenderer
>>>
>> Ok Mike, since I cannot reach the jira currently. Both classes are fixed
>> now.
>>
>> Werner
>>
>>
> 

Re: StateChangedNotifier

[Mike Kienenberger <mk...@gmail.com>]

I saw that!  Thanks!

I'm glad you worked on it instead of me.   I wouldn't have considered
that approach.   Maybe we can apply the approach of depending on the
jsf-api classes for the other broken components as well.

Yes, Jira is down for me as well.


On 4/6/06, Werner Punz <we...@gmx.at> wrote:
> Mike Kienenberger schrieb:
> > Hey Werner,
> >
> > Any chance you could fix the MyFaces-Impl dependencies for
> > StateChangedNotifier since you've been doing some work on it?
> >
> > http://issues.apache.org/jira/browse/TOMAHAWK-220
> >
> > org.apache.myfaces.custom.statechangednotifier.StateChangedNotifierTag
> > org.apache.myfaces.custom.statechangednotifier.StateChangedNotifierRenderer
> >
> Ok Mike, since I cannot reach the jira currently. Both classes are fixed
> now.
>
> Werner
>
>

Re: StateChangedNotifier

[Werner Punz <we...@gmx.at>]

Mike Kienenberger schrieb:
> Hey Werner,
> 
> Any chance you could fix the MyFaces-Impl dependencies for
> StateChangedNotifier since you've been doing some work on it?
> 
> http://issues.apache.org/jira/browse/TOMAHAWK-220
> 
> org.apache.myfaces.custom.statechangednotifier.StateChangedNotifierTag
> org.apache.myfaces.custom.statechangednotifier.StateChangedNotifierRenderer
> 
Ok Mike, since I cannot reach the jira currently. Both classes are fixed
now.

Werner