You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2018/06/01 17:15:00 UTC
[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't
ignore trailing posInc when preservePositionIncrements=false
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498266#comment-16498266 ]
David Smiley commented on LUCENE-8344:
--------------------------------------
The patch fixes the issue and has a couple tests. It's a bit WIP; I just want to get this up here for you all to see. I don't intend on working more on it today. I think we need to identify back-compat issues with this. Is it okay to tell people that on a minor release that they need to rebuild their suggester index to avoid this edge case bug? For the NRT Doc Suggester, that may be a lot to task as it's not a side-car index.
> TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false
> -------------------------------------------------------------------------------------------
>
> Key: LUCENE-8344
> URL: https://issues.apache.org/jira/browse/LUCENE-8344
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/suggest
> Reporter: David Smiley
> Priority: Major
> Attachments: LUCENE-8344.patch
>
>
> TokenStreamToAutomaton in Lucene core is used by the AnalyzingSuggester (incl. FuzzySuggester subclass ) and NRT Document Suggester and soon the SolrTextTagger. It has a setting {{preservePositionIncrements}} defaulting to true. If it's set to false (e.g. to ignore stopwords) and if there is a _trailing_ position increment greater than 1, TS2A will _still_ add position increments (holes) into the automata even though it was configured not to.
> I'm filing this issue separate from LUCENE-8332 where I first found it. The fix is very simple but I'm concerned about back-compat ramifications so I'm filing it separately. I'll attach a patch to show the problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org