You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/12/02 17:13:22 UTC

[GitHub] [geode] yozaner1324 commented on a change in pull request #5800: GEODE-8755: Write bundled jars file to correct dir

yozaner1324 commented on a change in pull request #5800:
URL: https://github.com/apache/geode/pull/5800#discussion_r534338470



##########
File path: geode-assembly/src/integrationTest/java/org/apache/geode/BundledJarsJUnitTest.java
##########
@@ -67,7 +67,7 @@ public void verifyBundledJarsHaveNotChanged() throws IOException {
         sortedJars.entrySet().stream().map(entry -> removeVersion(entry.getKey()));
     Set<String> bundledJarNames = new TreeSet<>(lines.collect(Collectors.toSet()));
 
-    Files.write(Paths.get("bundled_jars.txt"), bundledJarNames);
+    Files.write(Paths.get("..", "bundled_jars.txt"), bundledJarNames);

Review comment:
       This change looks good, however, BundledJarsJUnitTest is not the only test that has this problem; AssemblyContentsIntegrationTest and GeodeDependencyJarIntegrationTest also need essentially the same change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org