You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/02/28 09:16:17 UTC
[Bug 124338] New: Crash when opening user guides from LibreOffice
https://issues.apache.org/ooo/show_bug.cgi?id=124338
Bug ID: 124338
Issue Type: DEFECT
Summary: Crash when opening user guides from LibreOffice
Product: Writer
Version: 4.1.0-dev
Hardware: PC
URL: http://www.libreoffice.org/get-help/documentation/
OS: Windows 7
Status: UNCONFIRMED
Keywords: crash, regression
Severity: major
Priority: P3
Component: code
Assignee: issues@openoffice.apache.org
Reporter: elish@apache.org
QA Contact: elish@apache.org
CC: issues@openoffice.apache.org
1) Download odt from URL
2) Open file
-> Crash (checked with Calc and Writer guides).
AOO410m14(Build:9760) - Rev. 1572807
Rev.1572807
OK with OpenOffice.org 2.4.3
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124338] Crash when opening user guides from LibreOffice
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124338
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |4.1.0
--- Comment #9 from Oliver-Rainer Wittmann <or...@apache.org> ---
Fixed for next release on trunk and on branch AOO410
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 124338] Crash when opening user guides from LibreOffice
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124338
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |4.1.0_release_blocker?
--- Comment #3 from Oliver-Rainer Wittmann <or...@apache.org> ---
fix in progress
This crash has been introduced in by the changes for the enhancement
'annotations/comments on text ranges' - bug 123771
--> it should be fixed for AOO 4.1
root cause:
the internally used containers for marks need to be sorted, but certain insert
text actions 'breaks' the sorting.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
4.1.0_release_blocker granted: [Bug 124338] Crash when opening user
guides from LibreOffice
Posted by bu...@apache.org.
jsc@apache.org has granted Oliver-Rainer Wittmann <or...@apache.org>'s request
for 4.1.0_release_blocker:
Bug 124338: Crash when opening user guides from LibreOffice
https://issues.apache.org/ooo/show_bug.cgi?id=124338
------- Additional Comments from jsc@apache.org
grant showstopper flag
4.1.0_release_blocker requested: [Bug 124338] Crash when opening
user guides from LibreOffice
Posted by bu...@apache.org.
Oliver-Rainer Wittmann <or...@apache.org> has asked for 4.1.0_release_blocker:
Bug 124338: Crash when opening user guides from LibreOffice
https://issues.apache.org/ooo/show_bug.cgi?id=124338
------- Additional Comments from Oliver-Rainer Wittmann <or...@apache.org>
fix in progress
This crash has been introduced in by the changes for the enhancement
'annotations/comments on text ranges' - bug 123771
--> it should be fixed for AOO 4.1
root cause:
the internally used containers for marks need to be sorted, but certain insert
text actions 'breaks' the sorting.
[Bug 124338] Crash when opening user guides from LibreOffice
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124338
Andre <aw...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
CC| |awf.aoo@googlemail.com
Assignee|issues@openoffice.apache.or |orw@apache.org
|g |
Ever confirmed|0 |1
--- Comment #1 from Andre <aw...@googlemail.com> ---
Crashes in MarkManager::deleteMark(const const_iterator_t)
(sw/source/core/doc/docbm.cxx:814) in the IDocumentMarkAccess::UNO_BOOKMARK
case:
lcl_FindMark() returns end() which is used unchecked as argument to erase().
@ORW: please have a look.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124338] Crash when opening ODF document containing combination
of alphabetical index mark and bookmark at a paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124338
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Crash when opening user |Crash when opening ODF
|guides from LibreOffice |document containing
| |combination of alphabetical
| |index mark and bookmark at
| |a paragraph
--- Comment #10 from Oliver-Rainer Wittmann <or...@apache.org> ---
The found defect is a general one when deleting a certain mark (1). The code
for deleting a mark relies on the fact that the internal used containers for
the marks are sorted. The sorting is based on the mark's starting position. The
sorting 'got lost' in the following use case:
- There is a mark M1 at certain position X in paragraph P. It marks the
position, not a text range
- There is another mark M2 which marks text range X..X+n in paragraph P.
- As M1's and M2's start position is X sorting in the internal containers is
not relevant. As M2 is created after M1 the containers hold M2 before M1.
- Now, a character is inserted at position X in paragraph P.
--> mark M1 still marks position X in paragraph P, while M2 marks now text
range X+1..X+1+n in paragraph P, but the internal containers holding M2 and M1
are not sorted.
- Now, delete M1
--> crash, because deleting code assumes sorted container and thus, does not
found corresponding mark in the containers.
In the given documents M1 is a UNO mark and M2 is a Bookmark. The inserted
character is a place-holder character inserted for the alphabetical index after
M1 and M2 has been created. The UNO mark holding certain text positions for the
ODF import is deleted afterwards and this caused the crash.
A manual use case is that M1 and M2 are both Bookmarks created by the user in a
new or existing text document. The inserted character is also inserted by the
user after the creation of M1 and M2. Afterwards M1 has to be deleted manually
by the user. This use case also causes a crash in former OpenOffice versions,
but not whose which are using STLport as STLport seems to be fault-tolerant
when erasing 'end' iterators from a container. Thus, AOO 4.0.0 and AOO 4.0.1
are crashing. Former version on non-Windows platform may be crashing.
The crash becomes more visible in 4.1.0 code line as for the annotation marks
further internal mark containers had been introduced.
Footnotes:
(1) Internally, OpenOffice Writer has certain mark types. These are:
- Bookmarks
- Cross-reference marks
- Fieldmarks
- Navigator reminders
- DDE marks
- UNO marks (also used during the ODF import)
- Annotation marks
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 124338] Crash when opening user guides from LibreOffice
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124338
--- Comment #8 from SVN Robot <sv...@dev.null.org> ---
"orw" committed SVN revision 1574113 into branches/AOO410:
124338: assure sorted mark containers when updating <SwIndex> instances due
t...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Issue 124338] Crash when opening ODF document containing
combination of alphabetical index mark and bookmark at a paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124338
--- Comment #11 from jsc@apache.org ---
not 100% sure if it is really platform dependent, no crash on MacOS. Will check
Windows and Linux as well
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Bug 124338] Crash when opening user guides from LibreOffice
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124338
--- Comment #6 from SVN Robot <sv...@dev.null.org> ---
"orw" committed SVN revision 1574058 into trunk:
124338: assure sorted mark containers when updating <SwIndex> instances due
t...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 124338] Crash when opening user guides from LibreOffice
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124338
--- Comment #4 from Oliver-Rainer Wittmann <or...@apache.org> ---
Created attachment 82788
--> https://issues.apache.org/ooo/attachment.cgi?id=82788&action=edit
simple sample document created with AOO 4.0.1
document created with AOO 4.0.1 to reproduce this crash
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 124338] Crash when opening user guides from LibreOffice
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124338
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |ACCEPTED
--- Comment #2 from Oliver-Rainer Wittmann <or...@apache.org> ---
working on a solution
Documents open fine in AOO 4.0.1
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Issue 124338] Crash when opening ODF document containing
combination of alphabetical index mark and bookmark at a paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124338
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #12 from jsc@apache.org ---
verified with AOO 4.1 RC on MacOS and Windows
AOO410m15(Build:9761) - Rev. 1583666
2014-04-01 13:46:49 (Tue, 01 Apr 2014)
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Bug 124338] Crash when opening user guides from LibreOffice
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124338
--- Comment #5 from Edwin Sharp <el...@apache.org> ---
(In reply to Oliver-Rainer Wittmann from comment #4)
> document created with AOO 4.0.1 to reproduce this crash
Crash with
AOO410m14(Build:9760) - Rev. 1572807
Rev.1572807
OK with OpenOffice.org 2.4.3
Win 7
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 124338] Crash when opening user guides from LibreOffice
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124338
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsc@apache.org
Flags|4.1.0_release_blocker? |4.1.0_release_blocker+
--- Comment #7 from jsc@apache.org ---
grant showstopper flag
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.