[GitHub] [spark] tgravescs commented on a change in pull request #26170: [SPARK-29397][core] Extend plugin interface to include the driver.

[GitBox <gi...@apache.org>]

tgravescs commented on a change in pull request #26170: [SPARK-29397][core] Extend plugin interface to include the driver.
URL: https://github.com/apache/spark/pull/26170#discussion_r337502705
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -1159,6 +1159,17 @@ package object config {
         s"The value must be in allowed range [1,048,576, ${MAX_BUFFER_SIZE_BYTES}].")
       .createWithDefault(1024 * 1024)
 
+  private[spark] val STATIC_PLUGINS_LIST = "spark.plugins.static"
+
+  private[spark] val PLUGINS =
+    ConfigBuilder("spark.plugins")
+      .withPrepended(STATIC_PLUGINS_LIST, separator = ",")
 
 Review comment:
   its to bad we don't have documentation on withPrepended as it was not clear what it did. My initial thought was it was something to do with the actual config name.   After investigating more and reading the code figured it out, but I guess that is a separate issue.
   
   It seems to me we have a couple of these, this one named .static., the java options with defaultJavaOptions.  It might be nice to keep a consistent naming theme if we are going to start supporting having cluster level ones and then user level ones and they aren't overrides, they are prepends. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org