You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2012/12/11 14:28:19 UTC
Review Request: [EC2 Query API] AuthorizeSecurityGroupIngress and
RevokeSecurityGroupIngress return false even when the request is successful.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8513/
-----------------------------------------------------------
Review request for cloudstack and Prachi Damle.
Description
-------
If the response is not null and if all the ruleid's(permissions) are present return true.
This addresses bug CLOUDSTACK-197.
Diffs
-----
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java eb25249
awsapi/src/com/cloud/stack/CloudStackApi.java 52c2459
Diff: https://reviews.apache.org/r/8513/diff/
Testing
-------
After setting up AWSAPI, using the boto client called
authorize_security_group(group_name=<sg_name>, ip_protocol=<protocol>, from_port=<from_port>, to_port=<to_port>, cidr_ip=<cidr>)
revoke_security_group(group_name=<sg_name>, ip_protocol=<protocol>, from_port=<from_port>, to_port=<to_port>, cidr_ip=<cidr>)
Result -> Successfully created and revoked a security group rule with a 'true' response.
Thanks,
Likitha Shetty
Re: Review Request: [EC2 Query API] AuthorizeSecurityGroupIngress and
RevokeSecurityGroupIngress return false even when the request is successful.
Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8513/#review15966
-----------------------------------------------------------
Ship it!
- Prachi Damle
On Dec. 12, 2012, 10:36 a.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8513/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2012, 10:36 a.m.)
>
>
> Review request for cloudstack and Prachi Damle.
>
>
> Description
> -------
>
> If the response is not null and if all the ruleid's(permissions) are present return true.
>
>
> This addresses bug CLOUDSTACK-612.
>
>
> Diffs
> -----
>
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java eb25249
> awsapi/src/com/cloud/stack/CloudStackApi.java 52c2459
>
> Diff: https://reviews.apache.org/r/8513/diff/
>
>
> Testing
> -------
>
> After setting up AWSAPI, using the boto client called
> authorize_security_group(group_name=<sg_name>, ip_protocol=<protocol>, from_port=<from_port>, to_port=<to_port>, cidr_ip=<cidr>)
> revoke_security_group(group_name=<sg_name>, ip_protocol=<protocol>, from_port=<from_port>, to_port=<to_port>, cidr_ip=<cidr>)
> Result -> Successfully created and revoked a security group rule with a 'true' response.
>
>
> Thanks,
>
> Likitha Shetty
>
>
Re: Review Request: [EC2 Query API] AuthorizeSecurityGroupIngress and
RevokeSecurityGroupIngress return false even when the request is successful.
Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8513/
-----------------------------------------------------------
(Updated Dec. 12, 2012, 10:36 a.m.)
Review request for cloudstack and Prachi Damle.
Changes
-------
Updating the bug-id
Description
-------
If the response is not null and if all the ruleid's(permissions) are present return true.
This addresses bug CLOUDSTACK-612.
Diffs
-----
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java eb25249
awsapi/src/com/cloud/stack/CloudStackApi.java 52c2459
Diff: https://reviews.apache.org/r/8513/diff/
Testing
-------
After setting up AWSAPI, using the boto client called
authorize_security_group(group_name=<sg_name>, ip_protocol=<protocol>, from_port=<from_port>, to_port=<to_port>, cidr_ip=<cidr>)
revoke_security_group(group_name=<sg_name>, ip_protocol=<protocol>, from_port=<from_port>, to_port=<to_port>, cidr_ip=<cidr>)
Result -> Successfully created and revoked a security group rule with a 'true' response.
Thanks,
Likitha Shetty