You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2019/03/21 18:35:01 UTC
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12824
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
This bumps the version of two toolchain components:
- IMPALA-8316: Update re2 to the latest version
This updates re2 to the latest tagged release from github.
Todd Lipcon benchmarked this with a simple query:
select sum(l_linenumber) from item_20x where length(regexp_extract(l_shipinstruct, '.*', 0)) > 0
Prior to the change:
- TotalCpuTime: 42s848ms
- wall time: ~19sec
With the change:
- TotalCpuTime: 33s634ms
- wall time: 14-15sec
- This patch also bumps the toolchain Kudu version to 1.9.0
Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/12824/1
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 )
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 25 Mar 2019 17:21:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 )
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2503/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 21 Mar 2019 19:16:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 )
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3946/
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 22 Mar 2019 22:25:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 )
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Patch Set 1:
Also, some additional context here: historically the Kudu version we've used has been a random git hash because we bumped the toolchain Kudu version frequently to ensure that we were building and testing against a very up to date version since Kudu is in very active development.
Now that we have the new USE_CDH_KUDU option, the toolchain Kudu is only used for platforms where CDH isn't supported, so we've been bumping the version much less often and I think it makes sense to go with an actual tagged version instead of a random git hash.
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 21 Mar 2019 18:43:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 )
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Patch Set 2:
gvo failed due to IMPALA-8336
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 25 Mar 2019 17:21:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 )
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3952/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 25 Mar 2019 17:21:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 )
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 25 Mar 2019 21:46:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 )
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Patch Set 1:
I was working with the new native-toolchain docker stuff to get the Kudu version bumped, so I went ahead and addressed the issues from https://gerrit.cloudera.org/#/c/12790/ at the same time
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 18:36:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 )
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3946/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 22 Mar 2019 17:31:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12824 )
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
This bumps the version of two toolchain components:
- IMPALA-8316: Update re2 to the latest version
This updates re2 to the latest tagged release from github.
Todd Lipcon benchmarked this with a simple query:
select sum(l_linenumber) from item_20x where length(regexp_extract(l_shipinstruct, '.*', 0)) > 0
Prior to the change:
- TotalCpuTime: 42s848ms
- wall time: ~19sec
With the change:
- TotalCpuTime: 33s634ms
- wall time: 14-15sec
- This patch also bumps the toolchain Kudu version to 1.9.0
Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Reviewed-on: http://gerrit.cloudera.org:8080/12824
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 )
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Patch Set 1:
> lgtm. Did you make sure the toolchain S3 has the artifacts for
> ubuntu, etc? last time I tried to bump the toolchain ID, it didn't
> have that, and broke that platform
Yes, I verified the contents of the new toolchain are the same (with expected differences) as the previous toolchain.
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 22 Mar 2019 17:31:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 )
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 22 Mar 2019 17:31:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 )
Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8
......................................................................
Patch Set 1: Code-Review+2
lgtm. Did you make sure the toolchain S3 has the artifacts for ubuntu, etc? last time I tried to bump the toolchain ID, it didn't have that, and broke that platform
--
To view, visit http://gerrit.cloudera.org:8080/12824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9298709c534beeccfe36e212e0064d575cec9ac
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 21 Mar 2019 18:45:12 +0000
Gerrit-HasComments: No