You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/06/23 22:37:51 UTC

[GitHub] [trafficcontrol] rob05c opened a new pull request, #6924: T3c add action log

rob05c opened a new pull request, #6924:
URL: https://github.com/apache/trafficcontrol/pull/6924

   Adds an "action log" to t3c.
   
   It can be difficult to figure out what "actions" t3c actually did, with how spammy the log is. But we need all that log data.
   This makes it easy to see changes with e.g. `tail -F syncds.log | grep ACTION`.
   
   It also adds the action data to the metadata file. 
   
   Both are independently useful: the log makes it possible to easily see where an action occurred respective to other log lines, and e.g. to find details about why an action failed in the previous lines. While the metadata file makes it easy to see what actions happened in the latest run, as well as what actions occurred and succeeded or failed in the git config history.
   
   This depends on #6905 - recommend merging that first.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Control Cache Config (`t3c`, formerly ORT)
   
   ## What is the best way to verify this PR?
   Run t3c, verify log and metadata file contain ACTION data.
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   Not a bug fix.
   
   ## PR submission checklist
   - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
   - ~[x] This PR has documentation~ no docs, log and metadata formats aren't documented or guaranteed to be consistent <!-- If not, please delete this text and explain why this PR does not need documentation. -->
   - ~[x] This PR has a CHANGELOG.md entry~ No changelog, log format isn't documented and metadata file isn't stable enough to be in a public changelog or feature list yet <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 merged pull request #6924: Add cache config action log

Posted by GitBox <gi...@apache.org>.
ocket8888 merged PR #6924:
URL: https://github.com/apache/trafficcontrol/pull/6924


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org