You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "mpoeter (via GitHub)" <gi...@apache.org> on 2024/12/13 08:38:09 UTC
[PR] Fix documentation to match implementation [thrift]
mpoeter opened a new pull request, #3076:
URL: https://github.com/apache/thrift/pull/3076
Boolean values are encoded as `BOOLEAN_TRUE` and `BOOLEAN_FALSE` which are defined as 1 and 2 instead of 1 and 0.
The element-type of a bool is encoded as `BOOLEAN_TRUE` so 1 instead of 2.
[skip ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix documentation to match implementation [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on code in PR #3076:
URL: https://github.com/apache/thrift/pull/3076#discussion_r1884606683
##########
doc/specs/thrift-compact-protocol.md:
##########
@@ -249,7 +249,7 @@ The short form should be used when the length is in the range 0 - 14 (inclusive)
The following element-types are used (see note below):
-* `BOOL`, encoded as `2`
+* `BOOL`, encoded as `1`
Review Comment:
That is debatable. A better word could be inconcistent.
* thrift_compact_protocol.erl does it acciotrding to the spec and writes 2
* anyone else writes 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix documentation to match implementation [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G closed pull request #3076: Fix documentation to match implementation
URL: https://github.com/apache/thrift/pull/3076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix documentation to match implementation [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on code in PR #3076:
URL: https://github.com/apache/thrift/pull/3076#discussion_r1884606683
##########
doc/specs/thrift-compact-protocol.md:
##########
@@ -249,7 +249,7 @@ The short form should be used when the length is in the range 0 - 14 (inclusive)
The following element-types are used (see note below):
-* `BOOL`, encoded as `2`
+* `BOOL`, encoded as `1`
Review Comment:
That is debatable. A better word could be inconcistent.
* erlang and swift do it according to the spec and write 2
* anyone else writes 1
Hard to say who's wrong here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org