[GitHub] [superset] willbarrett commented on a change in pull request #13223: chore: add logs to db test connection and post failures

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #13223:
URL: https://github.com/apache/superset/pull/13223#discussion_r578767797



##########
File path: superset/databases/api.py
##########
@@ -238,6 +238,7 @@ def post(self) -> Response:
         except DatabaseInvalidError as ex:
             return self.response_422(message=ex.normalized_messages())
         except DatabaseConnectionFailedError as ex:
+            logger.exception("Database connection failed")

Review comment:
       Can we downgrade these from exception logging? Connection failures are an expected part of setting up new database connections and shouldn't wind up in exception tracking systems.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org