[GitHub] [pulsar] sijie commented on issue #4879: [Transaction][Buffer]make the transaction index to store in the ledger

[GitBox <gi...@apache.org>]

sijie commented on issue #4879: [Transaction][Buffer]make the transaction index to store in the ledger
URL: https://github.com/apache/pulsar/pull/4879#issuecomment-518056305
 
 
   @zymap 
   
   There are many checkstyle violations. Can you please take a look?
   
   ```
   2019-08-03\T\09:45:55.953 [ERROR] src/main/java/org/apache/pulsar/transaction/buffer/impl/TransactionCursorImpl.java:[26,8] (imports) UnusedImports: Unused import: java.util.Enumeration.
   2019-08-03\T\09:45:55.953 [ERROR] src/main/java/org/apache/pulsar/transaction/buffer/impl/TransactionCursorImpl.java:[140] (sizes) LineLength: Line is longer than 120 characters (found 123).
   2019-08-03\T\09:45:55.953 [ERROR] src/main/java/org/apache/pulsar/transaction/buffer/impl/TransactionCursorImpl.java:[140,98] (blocks) LeftCurly: '{' at column 98 should have line break after.
   2019-08-03\T\09:45:55.954 [ERROR] src/main/java/org/apache/pulsar/transaction/buffer/impl/TransactionCursorImpl.java:[286,22] (whitespace) WhitespaceAround: 'else' is not preceded with whitespace.
   2019-08-03\T\09:45:55.954 [ERROR] src/main/java/org/apache/pulsar/transaction/buffer/impl/PersistentTransactionBufferReader.java:[76] (sizes) LineLength: Line is longer than 120 characters (found 135).
   2019-08-03\T\09:45:55.955 [ERROR] src/main/java/org/apache/pulsar/transaction/buffer/impl/TransactionMetaImpl.java:[27,8] (imports) UnusedImports: Unused import: lombok.Builder.
   20
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services