You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "KatalKavya96 (via GitHub)" <gi...@apache.org> on 2025/09/13 09:41:07 UTC
[PR] Pick/vite vitest full [airflow]
KatalKavya96 opened a new pull request, #55623:
URL: https://github.com/apache/airflow/pull/55623
This PR re-introduces the frontend toolchain upgrade that was previously proposed in #55593 and then auto-closed during a rebase. It cherry-picks the maintainer-approved commits and resolves the compiled asset conflicts.
### What’s in here
- Upgrade build/test toolchain
- Vite → v7
- Vitest → v3
- Require Node.js ≥ 22
- Regenerate compiled assets for Edge3 provider
- Rebuilt providers/edge3/.../www/dist with the new toolchain
-
- Updated providers/edge3/www-hash.txt
### Template & UI updates
- dev/react-plugin-tools/react_plugin_template bumped to match the new baseline
- Added corresponding pnpm-lock.yaml for the template
- Updated package files under airflow-core/src/airflow/ui and airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui to align with Vite/Vitest upgrades
### Why
- Keep Airflow’s UI toolchain up to date with current major versions
- Align plugin template and provider assets with the same baseline
- Unblock downstream work relying on Node 22 + latest vite/vitest behavior
### The regenerated hash
related: #55593
#55562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pick/vite vitest full [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #55623:
URL: https://github.com/apache/airflow/pull/55623#issuecomment-3288152792
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pick/vite vitest full [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #55623:
URL: https://github.com/apache/airflow/pull/55623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pick/vite vitest full [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55623:
URL: https://github.com/apache/airflow/pull/55623#issuecomment-3288161901
Huge thanks, @jscheffl — this wouldn’t have landed without your steady guidance.
Really appreciate your patience through the rebases, prek/assets regeneration, and CI wrinkles. I learned a lot about the UI build and release flow along the way.
Thanks again for the quick reviews and constant support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pick/vite vitest full [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55623:
URL: https://github.com/apache/airflow/pull/55623#issuecomment-3287949937
@jscheffl Finally i tried cherry picking from the draft you had created , I think i was successful in retrieving the code that way. Please test it and suggest any further Changes or cleanups required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pick/vite vitest full [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55623:
URL: https://github.com/apache/airflow/pull/55623#issuecomment-3288150780
@jscheffl All Tests have been successfully passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pick/vite vitest full [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55623:
URL: https://github.com/apache/airflow/pull/55623#issuecomment-3289335010
@jscheffl Yes, I also feel this is important. I would be glad to assist on CI or similar issues, so please tag me to any issues you think i could give a try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pick/vite vitest full [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #55623:
URL: https://github.com/apache/airflow/pull/55623#discussion_r2346367132
##########
providers/edge3/www-hash.txt:
##########
@@ -1 +1 @@
-9f73c6c0e510633e273fcea23d0bdac0b90b98f44cb3d7e872b8cc029b02f522
+2da02e206d8191429a083bda8c8b24ce1efa84c1a861541599151cdefdc91315
Review Comment:
WWW hash still seems not to be right, needs to be re-built with exact packages. Let's fix it here:
```suggestion
7bd9c9e39161fd873c231f70eb1a3552215aed06820c48a97da1dea0eef1a872
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pick/vite vitest full [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #55623:
URL: https://github.com/apache/airflow/pull/55623#issuecomment-3288168883
Thanks as well for your patience. Especially the problem that we are currently requiring to re-build code and commit is something that botheres me and urgently need to have this improved to ease CI experience. I am sorry that it was more complex than it is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org