[jira] [Commented] (DIRKRB-626) Some improvement work for exception handling

["Colm O hEigeartaigh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DIRKRB-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994457#comment-15994457 ] 

Colm O hEigeartaigh commented on DIRKRB-626:
--------------------------------------------

Thanks for the patch. For the tests, instead of having System.err.println("Err") and then an empty Assert.fail(), you should just put the error message in the "Assert.fail("Err")".

> Some improvement work for exception handling
> --------------------------------------------
>
>                 Key: DIRKRB-626
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-626
>             Project: Directory Kerberos
>          Issue Type: Bug
>    Affects Versions: 1.0.0-GA
>            Reporter: Lin Zeng
>            Assignee: Lin Zeng
>         Attachments: DIRKRB-626-01.patch
>
>
> This is from [~coheigea]'s comment:
> {quote}
> One improvement I'd like to see before the 1.0 GA release is to improve the exception handling. There are many examples of catch statements that just have a printStackTrace() leading to NPEs down the line. Apart from that, +1 from me on the release:
> find . -name "*.java" -path "*/main/*" | xargs grep "printStackTrace()" | wc -l
> 30
> {quote} 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)