You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bahir.apache.org by lresende <gi...@git.apache.org> on 2016/07/22 20:53:03 UTC

[GitHub] bahir pull request #12: [BAHIR-36] Update Readme.md with build and test inst...

GitHub user lresende opened a pull request:

    https://github.com/apache/bahir/pull/12

    [BAHIR-36] Update Readme.md with build and test instructions

    - Add how to build and test project

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lresende/bahir readme

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bahir/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12
    
----
commit 45a3597a9501a46d1f25ef2d18886b28128111eb
Author: Luciano Resende <lr...@apache.org>
Date:   2016-07-22T20:46:10Z

    [BAHIR-36] Update Readme.md
    
    - Add how to build and test project

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bahir pull request #12: [BAHIR-36] Update Readme.md with build and test inst...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/bahir/pull/12


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bahir pull request #12: [BAHIR-36] Update Readme.md with build and test inst...

Posted by ckadner <gi...@git.apache.org>.
Github user ckadner commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/12#discussion_r71946595
  
    --- Diff: README.md ---
    @@ -19,3 +23,31 @@ Folder structure:
       - python
     - ...
     ```
    +
    +## Building Bahir
    +
    +Bahir is built using [Apache Maven](http://maven.apache.org/).
    +To build Bahir and its example programs, run:
    +
    +    mvn -DskipTests clean install
    +
    +## Running Tests
    +
    +Testing first requires [building Bahir](#building-bahir). Once Bahir is built, tests
    --- End diff --
    
    Well, at least currently, it **is** possible to build **and** test the project in **one** shot `mvn clean install`, but this may change in the future and running the build and tests separately is fine as long as developers actually do run the tests ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bahir issue #12: [BAHIR-36] Update Readme.md with build and test instruction...

Posted by ckadner <gi...@git.apache.org>.
Github user ckadner commented on the issue:

    https://github.com/apache/bahir/pull/12
  
    @lresende - LGTM - This is concise and minimal. 
    
    We can fill in more details soon, but we definitely need to replace the current "working draft" of the `README.md`. That one was meant only to show and contrast different ways to structure the folders in the initial project import.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---