You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Noble Paul (JIRA)" <ji...@apache.org> on 2008/11/14 11:54:44 UTC
[jira] Created: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
---------------------------------------------------------
Key: SOLR-856
URL: https://issues.apache.org/jira/browse/SOLR-856
Project: Solr
Issue Type: Improvement
Reporter: Noble Paul
If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649906#action_12649906 ]
Noble Paul commented on SOLR-856:
---------------------------------
A [wiki page|http://wiki.apache.org/solr/SolrHttpCompression ] is created for this . I have made a humble beginning by documenting what I know.
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650575#action_12650575 ]
Shalin Shekhar Mangar commented on SOLR-856:
--------------------------------------------
bq. If that's the consensus then i'm okay with that, but my personal preference would be to do it in a container agnostic manner (by explicitly using a Filter that does this in the stock web.xml) so that it works well for all users, regardless of container, out of the box. users who are knowledgeable about java, servlet containers, load balancers, etc... can then comment that filter out of the web.xml (or replace it with something else)
I just committed SOLR-829 which makes it possible to use external compression (i.e. provided by containers) and also internal compression managed by ReplicationHandler itself. By default, compression is not used and it needs to be enabled explicitly on the slave's solconfig.xml so that the slave requests compression from the master. I feel that configuring internal compression is best configured through solrconfig.xml. Changing the web.xml after exploding the war is inconvenient. Also, compression logic is added directly to replication handler (for managing internal compression) because we do not need to compress other Solr responses. It is only the replication handler which needs this feature and that too only for replicating over slow connections (e.g. replicating across data centers).
bq. So .... is this a "Won't Fix" situation?
I think so.
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul closed SOLR-856.
---------------------------
Resolution: Fixed
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647914#action_12647914 ]
Erik Hatcher commented on SOLR-856:
-----------------------------------
I don't understand your comment about users having to edit web.xml. A gzip filter, such as http://sourceforge.net/projects/pjl-comp-filter, could be put into web.xml, filtering all URLs, and always there. Internally it can control based on headers and settings whether to gzip. What'd be the harm in that?
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648519#action_12648519 ]
Noble Paul commented on SOLR-856:
---------------------------------
Hoss, Please ignore my patch. I just gave a quick suggestion .
Now I am more or less convinced that we must not add a filter. We should have enough documentation on how these things are efficiently handled in each of the containers. Tomcat handles it well internally, Jetty has a filter which does it properly. Users like their own container's features or they may even setup an Apache in the front to do that. This is largely an ops preference. In our org we have standard packages of tomcat/apache which has standard settings for all these.
So , this is just a matter of documentation
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
Posted by Erik Hatcher <er...@ehatchersolutions.com>.
On Nov 16, 2008, at 11:58 PM, Noble Paul (JIRA) wrote:
> here is documentation on how to setup compression for jetty
>
> http://docs.codehaus.org/display/JETTY/GZIP+Compression
>
> Now we need to test and find if this works. I guess if we cover
> Tomcat/Jetty/Resin it should be OK
>
> Should we enable it as a part of our standard configuration ?
+1 to enabling by default with Jetty.
Erik
[jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648081#action_12648081 ]
Noble Paul commented on SOLR-856:
---------------------------------
here is documentation on how to setup compression for jetty
http://docs.codehaus.org/display/JETTY/GZIP+Compression
Now we need to test and find if this works. I guess if we cover Tomcat/Jetty/Resin it should be OK
Should we enable it as a part of our standard configuration ?
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649874#action_12649874 ]
Hoss Man commented on SOLR-856:
-------------------------------
bq. Now I am more or less convinced that we must not add a filter. We should have enough documentation on how these things are efficiently handled in each of the containers.
If that's the consensus then i'm okay with that, but my personal preference would be to do it in a container agnostic manner (by explicitly using a Filter that does this in the stock web.xml) so that it works well for all users, regardless of container, out of the box. users who are knowledgeable about java, servlet containers, load balancers, etc... can then comment that filter out of the web.xml (or replace it with something else)
punting on this to the servlet container puts a burden on novice users that seems easily avoidable.
But it's not really that big of a deal to me -- it's an optimization that's only really useful in low bandwidth situations anyway, so if it's something that's going to make a difference to people, it's probably fine to make them figure out the best way to turn it on in their specific situation.
So .... is this a "Won't Fix" situation?
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648512#action_12648512 ]
Hoss Man commented on SOLR-856:
-------------------------------
We should probably provide a simple means for recognizing and responding appropriately to "Accept-Encoding: *" requests out of the box without depending on support from the servlet container -- but we should make sure this is relatively easy to disable in the event that the solr administrator already has a preferred way of dealing with this (ie: a load balancer on the same switch as solr optimized for handling compression)
the current patch seem lacking to me because disabling the functionality is currently impossible without forcing people to gut the code. We could add special config options for it, but frankly using a standalone filter seems like the best bet: people who understand HTTP enough to want to disable the default encoding are likely to be comfortable commenting out a filter from the web.xml.
using an existing, robust, "supported", well tested, filter for this found online certainly seems preferable to trying to roll our own.
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647589#action_12647589 ]
Erik Hatcher commented on SOLR-856:
-----------------------------------
I'd rather see this implemented as a separate filter, and not blending this in with SolrDispatchFilter. Why? Separation of concerns. I have ideas of using a custom dispatch filter (for smarter request routing, cleaner URLs), but would still want to benefit from gzip.
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647797#action_12647797 ]
Noble Paul commented on SOLR-856:
---------------------------------
bq.I'd rather see this implemented as a separate filter, and not blending this in with SolrDispatchFilter.
I considered that option too. But , it means users editing web.xml (which is not a good idea). Then the extra filter means more overhead. I guess we should not do that.
bq.Isn't this usually handled as a configuration of the Container rather than at the servlet level?
I would love to hear that? Bbut can we rely on that and expect that all containers will have this .Consider the fact that a feature relies on this (SOLR-829) for a critical functionality
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-856) Support for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher updated SOLR-856:
------------------------------
Summary: Support for "Accept-Encoding : gzip" in SolrDispatchFilter (was: Suport for "Accept-Encoding : gzip" in SolrDispatchFilter)
Fix spelling in issue title
> Support for "Accept-Encoding : gzip" in SolrDispatchFilter
> ----------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Donovan Jimenez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647612#action_12647612 ]
Donovan Jimenez commented on SOLR-856:
--------------------------------------
Isn't this usually handled as a configuration of the Container rather than at the servlet level?
For example, in Tomcat, I'd use the compression option on the HTTP connector described in the documentation: http://tomcat.apache.org/tomcat-6.0-doc/config/http.html
I'm sure other containers have similar, already existing, functionality.
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648025#action_12648025 ]
Yonik Seeley commented on SOLR-856:
-----------------------------------
As Donovan pointed out, the alternative is to let the servlet container handle it. Upside is potentially greater speed if it's implemented in native code, and no new Solr dependency, but the downside is more config hassle for the user. Would it make sense to see how hard it is to configure for the major servlet containers before committing this?
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-856:
----------------------------
Attachment: SOLR-856.patch
implemented
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648038#action_12648038 ]
Erik Hatcher commented on SOLR-856:
-----------------------------------
For the record, I'm absolutely +1 on this being done by containers if the major ones can do it.
It'd be interesting if the containers that are doing it would strip the gzip accept header, that way it wouldn't matter if Solr had this in there or not.... but I doubt we're so lucky for that, eh?
Also worth noting is my take on "deployment descriptors". It was really designed (though not implemented so well) to be tweaked at deploy-time. So it would really be sufficient to document how to change web.xml to add in a filter if needed, and where to obtain the JAR file... how to repackage a .war. Yeah, it's a pain, but it does keep something that is obviously a separate concern entirely separate, and not all that difficult to manage the "hard" way just described.
Some containers, if I'm not mistaken, have control panels where .war deployment descriptors can be managed, right?
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SOLR-856) Suport for "Accept-Encoding
: gzip" in SolrDispatchFilter
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648519#action_12648519 ]
noble.paul edited comment on SOLR-856 at 11/17/08 11:21 PM:
------------------------------------------------------------
Hoss, Please ignore my patch. It was just a quick suggestion .
Now I am more or less convinced that we must not add a filter. We should have enough documentation on how these things are efficiently handled in each of the containers. Tomcat handles it well internally, Jetty has a filter which does it properly. Users like their own container's features or they may even setup an Apache in the front to do that. This is largely an ops preference. In our org we have standard packages of tomcat/apache which has standard settings for all these.
So , this is just a matter of documentation
was (Author: noble.paul):
Hoss, Please ignore my patch. I just gave a quick suggestion .
Now I am more or less convinced that we must not add a filter. We should have enough documentation on how these things are efficiently handled in each of the containers. Tomcat handles it well internally, Jetty has a filter which does it properly. Users like their own container's features or they may even setup an Apache in the front to do that. This is largely an ops preference. In our org we have standard packages of tomcat/apache which has standard settings for all these.
So , this is just a matter of documentation
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
Posted by Erik Hatcher <er...@ehatchersolutions.com>.
On Nov 16, 2008, at 5:53 AM, Shalin Shekhar Mangar wrote:
> Ehcache's GzipFilter will need to be modified. It compresses in-
> memory which
> will blow up when we transfer huge index files.
Ok - these are the changes that Noble already put into his
SolrDispatchFilter patch? If so, I recommend putting in the patched
filter as a separate filter, that's all.
Erik
Re: [jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
Posted by Shalin Shekhar Mangar <sh...@gmail.com>.
Ehcache's GzipFilter will need to be modified. It compresses in-memory which
will blow up when we transfer huge index files.
On Sun, Nov 16, 2008 at 4:10 PM, Erik Hatcher <er...@ehatchersolutions.com>wrote:
> I think pulling in the filter from EHCache is a fine solution. We could
> just pull in that single filter's source code (It is ASL 2.0) rather than
> add the entire JAR dependency - leaving the dispatch filter untouched.
>
> Erik
>
>
>
> On Nov 16, 2008, at 2:37 AM, Noble Paul (JIRA) wrote:
>
>
>> [
>> https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647939#action_12647939
>> ]
>>
>> Noble Paul commented on SOLR-856:
>> ---------------------------------
>>
>> bq.I don't understand your comment about users having to edit web.xml
>> OK . I see the argument of keeping it there always.
>>
>> This means adding a new library dependency . We need to now decide on
>> which one to choose. Is it mature ? is it buggy?
>>
>> My immediate concern is SOLR-829 . This issue blocks that. We need
>> SOLR-829 for our internal purposes (we do replication across datacenters)
>> and there are other users who need it ASAP.
>>
>> Any solution is fine
>>
>> The patch I submitted is the code taken from ehcache. I did not add extra
>> filter because every request goes through an extra layer .
>>
>> Do we really need that? Probably we can let the user choose a filter and
>> document that.
>>
>> Do we have to add this 60KB jar to our distribution?
>>
>>
>>
>> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
>>> ---------------------------------------------------------
>>>
>>> Key: SOLR-856
>>> URL: https://issues.apache.org/jira/browse/SOLR-856
>>> Project: Solr
>>> Issue Type: Improvement
>>> Reporter: Noble Paul
>>> Attachments: SOLR-856.patch
>>>
>>>
>>> If the client sends an Accept-Encoding : gzip header then
>>> SolrDispatchFilter should respect that and send back data as zipped
>>>
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>
>
--
Regards,
Shalin Shekhar Mangar.
Re: [jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
Posted by Erik Hatcher <er...@ehatchersolutions.com>.
I think pulling in the filter from EHCache is a fine solution. We
could just pull in that single filter's source code (It is ASL 2.0)
rather than add the entire JAR dependency - leaving the dispatch
filter untouched.
Erik
On Nov 16, 2008, at 2:37 AM, Noble Paul (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647939
> #action_12647939 ]
>
> Noble Paul commented on SOLR-856:
> ---------------------------------
>
> bq.I don't understand your comment about users having to edit web.xml
> OK . I see the argument of keeping it there always.
>
> This means adding a new library dependency . We need to now decide
> on which one to choose. Is it mature ? is it buggy?
>
> My immediate concern is SOLR-829 . This issue blocks that. We need
> SOLR-829 for our internal purposes (we do replication across
> datacenters) and there are other users who need it ASAP.
>
> Any solution is fine
>
> The patch I submitted is the code taken from ehcache. I did not add
> extra filter because every request goes through an extra layer .
>
> Do we really need that? Probably we can let the user choose a filter
> and document that.
>
> Do we have to add this 60KB jar to our distribution?
>
>
>
>> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
>> ---------------------------------------------------------
>>
>> Key: SOLR-856
>> URL: https://issues.apache.org/jira/browse/SOLR-856
>> Project: Solr
>> Issue Type: Improvement
>> Reporter: Noble Paul
>> Attachments: SOLR-856.patch
>>
>>
>> If the client sends an Accept-Encoding : gzip header then
>> SolrDispatchFilter should respect that and send back data as zipped
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-856) Suport for "Accept-Encoding : gzip" in
SolrDispatchFilter
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647939#action_12647939 ]
Noble Paul commented on SOLR-856:
---------------------------------
bq.I don't understand your comment about users having to edit web.xml
OK . I see the argument of keeping it there always.
This means adding a new library dependency . We need to now decide on which one to choose. Is it mature ? is it buggy?
My immediate concern is SOLR-829 . This issue blocks that. We need SOLR-829 for our internal purposes (we do replication across datacenters) and there are other users who need it ASAP.
Any solution is fine
The patch I submitted is the code taken from ehcache. I did not add extra filter because every request goes through an extra layer .
Do we really need that? Probably we can let the user choose a filter and document that.
Do we have to add this 60KB jar to our distribution?
> Suport for "Accept-Encoding : gzip" in SolrDispatchFilter
> ---------------------------------------------------------
>
> Key: SOLR-856
> URL: https://issues.apache.org/jira/browse/SOLR-856
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-856.patch
>
>
> If the client sends an Accept-Encoding : gzip header then SolrDispatchFilter should respect that and send back data as zipped
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.