[GitHub] [dubbo-go] zouyx commented on a change in pull request #633: Ftr: zk/consul Metadata

[GitBox <gi...@apache.org>]

zouyx commented on a change in pull request #633:
URL: https://github.com/apache/dubbo-go/pull/633#discussion_r448400163



##########
File path: metadata/report/report.go
##########
@@ -28,8 +28,8 @@ type MetadataReport interface {
 	StoreConsumerMetadata(*identifier.MetadataIdentifier, string) error
 	SaveServiceMetadata(*identifier.ServiceMetadataIdentifier, common.URL) error
 	RemoveServiceMetadata(*identifier.ServiceMetadataIdentifier) error
-	GetExportedURLs(*identifier.ServiceMetadataIdentifier) []string
-	SaveSubscribedData(*identifier.SubscriberMetadataIdentifier, []common.URL) error
-	GetSubscribedURLs(*identifier.SubscriberMetadataIdentifier) []string
-	GetServiceDefinition(*identifier.MetadataIdentifier) string
+	GetExportedURLs(*identifier.ServiceMetadataIdentifier) ([]string, error)
+	SaveSubscribedData(*identifier.SubscriberMetadataIdentifier, string) error
+	GetSubscribedURLs(*identifier.SubscriberMetadataIdentifier) ([]string, error)
+	GetServiceDefinition(*identifier.MetadataIdentifier) (string, error)

Review comment:
       add some comments for this file pls.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org