You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2017/01/17 04:36:39 UTC

Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55600/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Repository: mesos


Description
-------

Stout currently manually groups its source code by folder in order to
present the source nicely in IDEs like XCode and Visual Studio.

With the recently-introduced CMake function, `GROUP_SOURCE`, this
process is automated away. This commit will remove these manual groups
and replace it with a call to this function.


Diffs
-----

  3rdparty/stout/cmake/StoutConfigure.cmake bc27ac687bae4e1798eece562027ba33c6b32348 
  3rdparty/stout/tests/CMakeLists.txt a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae 

Diff: https://reviews.apache.org/r/55600/diff/


Testing
-------


Thanks,

Alex Clemmer

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

Posted by Alex Clemmer <cl...@gmail.com>.

> On Jan. 25, 2017, 12:27 a.m., Joseph Wu wrote:
> > 3rdparty/stout/cmake/StoutConfigure.cmake, line 47
> > <https://reviews.apache.org/r/55600/diff/2/?file=1606435#file1606435line47>
> >
> >     Why not use `*.hpp` instead?

Generally, we also would like to include .h files generated by protobufs, either those that exist, or those that might exist in the future. In Stout, for example, there is `protobuf_tests.proto` in the `tests/` folder. The Stout headers don't have any .proto files that I know of right now, but I think it's better just to use this one pattern everywhere.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55600/#review162882
-----------------------------------------------------------


On Jan. 17, 2017, 6:41 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55600/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2017, 6:41 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout currently manually groups its source code by folder in order to
> present the source nicely in IDEs like XCode and Visual Studio.
> 
> With the recently-introduced CMake function, `GROUP_SOURCE`, this
> process is automated away. This commit will remove these manual groups
> and replace it with a call to this function.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/StoutConfigure.cmake bc27ac687bae4e1798eece562027ba33c6b32348 
>   3rdparty/stout/tests/CMakeLists.txt a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae 
> 
> Diff: https://reviews.apache.org/r/55600/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

Posted by Joseph Wu <jo...@mesosphere.io>.

> On Jan. 24, 2017, 4:27 p.m., Joseph Wu wrote:
> > 3rdparty/stout/cmake/StoutConfigure.cmake, line 47
> > <https://reviews.apache.org/r/55600/diff/2/?file=1606435#file1606435line47>
> >
> >     Why not use `*.hpp` instead?
> 
> Alex Clemmer wrote:
>     Generally, we also would like to include .h files generated by protobufs, either those that exist, or those that might exist in the future. In Stout, for example, there is `protobuf_tests.proto` in the `tests/` folder. The Stout headers don't have any .proto files that I know of right now, but I think it's better just to use this one pattern everywhere.

Ok, but let's be explicit, say `*.h(pp)?`.  Otherwise, we'll be matching against `.hooligans` and `.hoopla` :)

Similar below.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55600/#review162882
-----------------------------------------------------------


On Jan. 16, 2017, 10:41 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55600/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 10:41 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout currently manually groups its source code by folder in order to
> present the source nicely in IDEs like XCode and Visual Studio.
> 
> With the recently-introduced CMake function, `GROUP_SOURCE`, this
> process is automated away. This commit will remove these manual groups
> and replace it with a call to this function.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/StoutConfigure.cmake bc27ac687bae4e1798eece562027ba33c6b32348 
>   3rdparty/stout/tests/CMakeLists.txt a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae 
> 
> Diff: https://reviews.apache.org/r/55600/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

Posted by Joseph Wu <jo...@mesosphere.io>.

> On Jan. 24, 2017, 4:27 p.m., Joseph Wu wrote:
> > 3rdparty/stout/cmake/StoutConfigure.cmake, line 47
> > <https://reviews.apache.org/r/55600/diff/2/?file=1606435#file1606435line47>
> >
> >     Why not use `*.hpp` instead?
> 
> Alex Clemmer wrote:
>     Generally, we also would like to include .h files generated by protobufs, either those that exist, or those that might exist in the future. In Stout, for example, there is `protobuf_tests.proto` in the `tests/` folder. The Stout headers don't have any .proto files that I know of right now, but I think it's better just to use this one pattern everywhere.
> 
> Joseph Wu wrote:
>     Ok, but let's be explicit, say `*.h(pp)?`.  Otherwise, we'll be matching against `.hooligans` and `.hoopla` :)
>     
>     Similar below.

Nevermind.  I didn't realize this was a glob expression, rather than a regex.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55600/#review162882
-----------------------------------------------------------


On Jan. 16, 2017, 10:41 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55600/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 10:41 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout currently manually groups its source code by folder in order to
> present the source nicely in IDEs like XCode and Visual Studio.
> 
> With the recently-introduced CMake function, `GROUP_SOURCE`, this
> process is automated away. This commit will remove these manual groups
> and replace it with a call to this function.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/StoutConfigure.cmake bc27ac687bae4e1798eece562027ba33c6b32348 
>   3rdparty/stout/tests/CMakeLists.txt a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae 
> 
> Diff: https://reviews.apache.org/r/55600/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

Posted by Alex Clemmer <cl...@gmail.com>.

> On Jan. 25, 2017, 12:27 a.m., Joseph Wu wrote:
> > 3rdparty/stout/cmake/StoutConfigure.cmake, line 47
> > <https://reviews.apache.org/r/55600/diff/2/?file=1606435#file1606435line47>
> >
> >     Why not use `*.hpp` instead?
> 
> Alex Clemmer wrote:
>     Generally, we also would like to include .h files generated by protobufs, either those that exist, or those that might exist in the future. In Stout, for example, there is `protobuf_tests.proto` in the `tests/` folder. The Stout headers don't have any .proto files that I know of right now, but I think it's better just to use this one pattern everywhere.
> 
> Joseph Wu wrote:
>     Ok, but let's be explicit, say `*.h(pp)?`.  Otherwise, we'll be matching against `.hooligans` and `.hoopla` :)
>     
>     Similar below.
> 
> Joseph Wu wrote:
>     Nevermind.  I didn't realize this was a glob expression, rather than a regex.

Ah, yes. I would have done it that way if I could have made it work.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55600/#review162882
-----------------------------------------------------------


On Jan. 17, 2017, 6:41 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55600/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2017, 6:41 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout currently manually groups its source code by folder in order to
> present the source nicely in IDEs like XCode and Visual Studio.
> 
> With the recently-introduced CMake function, `GROUP_SOURCE`, this
> process is automated away. This commit will remove these manual groups
> and replace it with a call to this function.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/StoutConfigure.cmake bc27ac687bae4e1798eece562027ba33c6b32348 
>   3rdparty/stout/tests/CMakeLists.txt a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae 
> 
> Diff: https://reviews.apache.org/r/55600/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55600/#review162882
-----------------------------------------------------------




3rdparty/stout/cmake/StoutConfigure.cmake (line 47)
<https://reviews.apache.org/r/55600/#comment234258>

    Why not use `*.hpp` instead?



3rdparty/stout/tests/CMakeLists.txt (line 116)
<https://reviews.apache.org/r/55600/#comment234259>

    How about `*.[ch]pp`?


- Joseph Wu


On Jan. 16, 2017, 10:41 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55600/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 10:41 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout currently manually groups its source code by folder in order to
> present the source nicely in IDEs like XCode and Visual Studio.
> 
> With the recently-introduced CMake function, `GROUP_SOURCE`, this
> process is automated away. This commit will remove these manual groups
> and replace it with a call to this function.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/StoutConfigure.cmake bc27ac687bae4e1798eece562027ba33c6b32348 
>   3rdparty/stout/tests/CMakeLists.txt a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae 
> 
> Diff: https://reviews.apache.org/r/55600/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55600/#review163216
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Jan. 16, 2017, 10:41 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55600/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 10:41 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout currently manually groups its source code by folder in order to
> present the source nicely in IDEs like XCode and Visual Studio.
> 
> With the recently-introduced CMake function, `GROUP_SOURCE`, this
> process is automated away. This commit will remove these manual groups
> and replace it with a call to this function.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/StoutConfigure.cmake bc27ac687bae4e1798eece562027ba33c6b32348 
>   3rdparty/stout/tests/CMakeLists.txt a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae 
> 
> Diff: https://reviews.apache.org/r/55600/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55600/
-----------------------------------------------------------

(Updated Jan. 17, 2017, 6:41 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Changes
-------

Fixup file matching pattern.


Repository: mesos


Description
-------

Stout currently manually groups its source code by folder in order to
present the source nicely in IDEs like XCode and Visual Studio.

With the recently-introduced CMake function, `GROUP_SOURCE`, this
process is automated away. This commit will remove these manual groups
and replace it with a call to this function.


Diffs (updated)
-----

  3rdparty/stout/cmake/StoutConfigure.cmake bc27ac687bae4e1798eece562027ba33c6b32348 
  3rdparty/stout/tests/CMakeLists.txt a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae 

Diff: https://reviews.apache.org/r/55600/diff/


Testing
-------


Thanks,

Alex Clemmer