You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2015/03/26 07:21:09 UTC

Review Request 32526: SQOOP-2229: Sqoop2: Kite connector should handle doubles

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32526/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2229
    https://issues.apache.org/jira/browse/SQOOP-2229


Repository: sqoop-sqoop2


Description
-------

commit 0eed47d3c68d2588b19fe467378d449a2d94e7a7
Author: Abraham Elmahrek <ab...@apache.org>
Date:   Wed Mar 25 23:00:03 2015 -0700

    SQOOP-2229: Sqoop2: Kite connector should handle doubles

:100644 100644 1074d37... 86aa44f... M  connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/KiteDataTypeUtil.java
:100644 100644 e789ce0... 7d762ae... M  test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java
:100644 100644 828d244... e74b3a6... M  test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java


Diffs
-----

  connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/KiteDataTypeUtil.java 1074d37 
  test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java e789ce0 
  test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java 828d244 

Diff: https://reviews.apache.org/r/32526/diff/


Testing
-------

mvn clean integration-test


Thanks,

Abraham Elmahrek


Re: Review Request 32526: SQOOP-2229: Sqoop2: Kite connector should handle doubles

Posted by Qian Xu <qi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32526/#review78008
-----------------------------------------------------------

Ship it!


Ship It!

- Qian Xu


On March 26, 2015, 2:21 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32526/
> -----------------------------------------------------------
> 
> (Updated March 26, 2015, 2:21 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2229
>     https://issues.apache.org/jira/browse/SQOOP-2229
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 0eed47d3c68d2588b19fe467378d449a2d94e7a7
> Author: Abraham Elmahrek <ab...@apache.org>
> Date:   Wed Mar 25 23:00:03 2015 -0700
> 
>     SQOOP-2229: Sqoop2: Kite connector should handle doubles
> 
> :100644 100644 1074d37... 86aa44f... M  connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/KiteDataTypeUtil.java
> :100644 100644 e789ce0... 7d762ae... M  test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java
> :100644 100644 828d244... e74b3a6... M  test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/KiteDataTypeUtil.java 1074d37 
>   test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java e789ce0 
>   test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java 828d244 
> 
> Diff: https://reviews.apache.org/r/32526/diff/
> 
> 
> Testing
> -------
> 
> mvn clean integration-test
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Re: Review Request 32526: SQOOP-2229: Sqoop2: Kite connector should handle doubles

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32526/
-----------------------------------------------------------

(Updated March 31, 2015, 1:26 a.m.)


Review request for Sqoop.


Changes
-------

Rebased + reverted test. We will have to test all types for kite.


Bugs: SQOOP-2229
    https://issues.apache.org/jira/browse/SQOOP-2229


Repository: sqoop-sqoop2


Description
-------

commit 0eed47d3c68d2588b19fe467378d449a2d94e7a7
Author: Abraham Elmahrek <ab...@apache.org>
Date:   Wed Mar 25 23:00:03 2015 -0700

    SQOOP-2229: Sqoop2: Kite connector should handle doubles

:100644 100644 1074d37... 86aa44f... M  connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/KiteDataTypeUtil.java
:100644 100644 e789ce0... 7d762ae... M  test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java
:100644 100644 828d244... e74b3a6... M  test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java


Diffs (updated)
-----

  connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/KiteDataTypeUtil.java 1074d37 
  test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java 6e49312 
  test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java b3ec1a9 

Diff: https://reviews.apache.org/r/32526/diff/


Testing
-------

mvn clean integration-test


Thanks,

Abraham Elmahrek