You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by ov...@apache.org on 2022/08/01 02:57:05 UTC
[echarts] branch fix-custom created (now f22be1926)
This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a change to branch fix-custom
in repository https://gitbox.apache.org/repos/asf/echarts.git
at f22be1926 fix(custom): set ignore only if old child exists
This branch includes the following new commits:
new f22be1926 fix(custom): set ignore only if old child exists
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[echarts] 01/01: fix(custom): set ignore only if old child exists
Posted by ov...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a commit to branch fix-custom
in repository https://gitbox.apache.org/repos/asf/echarts.git
commit f22be1926d17257705857b01e8dc534f741dfe93
Author: Ovilia <zw...@gmail.com>
AuthorDate: Mon Aug 1 10:56:11 2022 +0800
fix(custom): set ignore only if old child exists
---
src/chart/custom/CustomView.ts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/chart/custom/CustomView.ts b/src/chart/custom/CustomView.ts
index 215087b72..1b67dc7d9 100644
--- a/src/chart/custom/CustomView.ts
+++ b/src/chart/custom/CustomView.ts
@@ -1339,7 +1339,7 @@ function mergeChildren(
el
);
}
- else {
+ else if (oldChild) {
// If the new element option is null, it means to remove the old
// element. But we cannot really remove the element from the group
// directly, because the element order may not be stable when this
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org