You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Nikolay Petrov (JIRA)" <de...@myfaces.apache.org> on 2006/09/21 15:01:25 UTC
[jira] Created: (MYFACES-1419) javax.faces.convert - refactor
common behaviour + DateTimeConverter changes
javax.faces.convert - refactor common behaviour + DateTimeConverter changes
---------------------------------------------------------------------------
Key: MYFACES-1419
URL: http://issues.apache.org/jira/browse/MYFACES-1419
Project: MyFaces Core
Issue Type: Improvement
Components: JSR-127
Affects Versions: 1.1.4
Reporter: Nikolay Petrov
Priority: Minor
Fix For: 1.1.5-SNAPSHOT
All available converters look very similar. Extract the common behavior in base class.
Also DateTimeConverter can be migrated to work with type safe enums for style and type properties.
There are comments in source like //TODO: validate timeStyle. According to java doc of DateTimeConverter on sun there should not have validation. The validation of these will be performed when asString/asObject methods are called.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-1419) javax.faces.convert - refactor
common behaviour + DateTimeConverter changes
Posted by "Nikolay Petrov (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1419?page=all ]
Nikolay Petrov updated MYFACES-1419:
------------------------------------
Status: Patch Available (was: Open)
> javax.faces.convert - refactor common behaviour + DateTimeConverter changes
> ---------------------------------------------------------------------------
>
> Key: MYFACES-1419
> URL: http://issues.apache.org/jira/browse/MYFACES-1419
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-127
> Affects Versions: 1.1.4
> Reporter: Nikolay Petrov
> Priority: Minor
> Fix For: 1.1.5-SNAPSHOT
>
>
> All available converters look very similar. Extract the common behavior in base class.
> Also DateTimeConverter can be migrated to work with type safe enums for style and type properties.
> There are comments in source like //TODO: validate timeStyle. According to java doc of DateTimeConverter on sun there should not have validation. The validation of these will be performed when asString/asObject methods are called.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (MYFACES-1419) javax.faces.convert - refactor
common behaviour + DateTimeConverter changes
Posted by "Thomas Spiegl (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1419?page=all ]
Thomas Spiegl reopened MYFACES-1419:
------------------------------------
This patch needs to be reverted. Relevant converters are API classes and must extend from Object.
> javax.faces.convert - refactor common behaviour + DateTimeConverter changes
> ---------------------------------------------------------------------------
>
> Key: MYFACES-1419
> URL: http://issues.apache.org/jira/browse/MYFACES-1419
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-127
> Affects Versions: 1.1.4
> Reporter: Nikolay Petrov
> Assigned To: Martin Marinschek
> Priority: Minor
> Fix For: 1.1.5-SNAPSHOT
>
> Attachments: converter.patch
>
>
> All available converters look very similar. Extract the common behavior in base class.
> Also DateTimeConverter can be migrated to work with type safe enums for style and type properties.
> There are comments in source like //TODO: validate timeStyle. According to java doc of DateTimeConverter on sun there should not have validation. The validation of these will be performed when asString/asObject methods are called.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-1419) javax.faces.convert - refactor
common behaviour + DateTimeConverter changes
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1419?page=all ]
Martin Marinschek updated MYFACES-1419:
---------------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Thanks to Nikolay Petrov for supplying this patch.
Same reasoning applies here as with Validators, eventually we should prefix the base-class.
regards,
Martin
> javax.faces.convert - refactor common behaviour + DateTimeConverter changes
> ---------------------------------------------------------------------------
>
> Key: MYFACES-1419
> URL: http://issues.apache.org/jira/browse/MYFACES-1419
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-127
> Affects Versions: 1.1.4
> Reporter: Nikolay Petrov
> Assigned To: Martin Marinschek
> Priority: Minor
> Fix For: 1.1.5-SNAPSHOT
>
> Attachments: converter.patch
>
>
> All available converters look very similar. Extract the common behavior in base class.
> Also DateTimeConverter can be migrated to work with type safe enums for style and type properties.
> There are comments in source like //TODO: validate timeStyle. According to java doc of DateTimeConverter on sun there should not have validation. The validation of these will be performed when asString/asObject methods are called.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira