You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/14 08:01:59 UTC

[GitHub] [doris] HappenLee commented on a diff in pull request #13346: [Bug](function) Fix constant predicate evaluation

HappenLee commented on code in PR #13346:
URL: https://github.com/apache/doris/pull/13346#discussion_r995466887


##########
be/src/vec/exprs/vexpr.cpp:
##########
@@ -319,6 +319,7 @@ ColumnPtrWrapper* VExpr::get_const_col(VExprContext* context) {
 
     int result = -1;
     Block block;
+    block.insert({ColumnUInt8::create(1), std::make_shared<DataTypeUInt8>(), ""});

Review Comment:
   maybe we should add comment here to let other know the behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org