[jira] [Commented] (BEAM-2318) Flake in HBaseIOTest

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016587#comment-16016587 ] 

ASF GitHub Bot commented on BEAM-2318:
--------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/3179

    [BEAM-2318] Ensure that tables that don't exist are not created

    We use the same test table name in two tests: one that expects the table not to exist, another that
    creates the table. Obviously, the correctness of this will depend on the order in which unit tests
    are executed.
    
    Fix the flake by using different and more explicit test names.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam b2318-hbase-flaky

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3179
    
----
commit b36febcd92951bb6f95d57c1d84caf3c2c69110c
Author: Dan Halperin <dh...@google.com>
Date:   2017-05-18T22:43:31Z

    [BEAM-2318] Ensure that tables that don't exist are not created
    
    We use the same test table name in two tests: one that expects the table not to exist, another that
    creates the table. Obviously, the correctness of this will depend on the order in which unit tests
    are executed.
    
    Fix the flake by using different and more explicit test names.

----


> Flake in HBaseIOTest
> --------------------
>
>                 Key: BEAM-2318
>                 URL: https://issues.apache.org/jira/browse/BEAM-2318
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Kenneth Knowles
>            Assignee: Ismaël Mejía
>
> Saw this failure in the nightly snapshot, but it doesn't reproduce right away: https://builds.apache.org/job/beam_Release_NightlySnapshot/org.apache.beam$beam-sdks-java-io-hbase/419/testReport/junit/org.apache.beam.sdk.io.hbase/HBaseIOTest/testWritingFailsTableDoesNotExist/
> Excerpting, since that link will be GC'd at some point:
> {code}
> Error Message
> Expected test to throw (an instance of java.lang.IllegalArgumentException and exception with message a string containing "Table TEST-TABLE does not exist")
> Stacktrace
> java.lang.AssertionError: Expected test to throw (an instance of java.lang.IllegalArgumentException and exception with message a string containing "Table TEST-TABLE does not exist")
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.rules.ExpectedException.failDueToMissingException(ExpectedException.java:263)
> 	at org.junit.rules.ExpectedException.access$200(ExpectedException.java:106)
> 	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:245)
> 	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> 	at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:393)
> 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> 	at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)