You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by co...@apache.org on 2005/08/30 16:28:51 UTC
svn commit: r264788 - /httpd/httpd/trunk/modules/generators/mod_cgid.c
Author: colm
Date: Tue Aug 30 07:28:48 2005
New Revision: 264788
URL: http://svn.apache.org/viewcvs?rev=264788&view=rev
Log:
If uid_t and gid_t are unsigned on a platform (hurd, for example), using -1
may cause a compiler warning.
Modified:
httpd/httpd/trunk/modules/generators/mod_cgid.c
Modified: httpd/httpd/trunk/modules/generators/mod_cgid.c
URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/modules/generators/mod_cgid.c?rev=264788&r1=264787&r2=264788&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/generators/mod_cgid.c (original)
+++ httpd/httpd/trunk/modules/generators/mod_cgid.c Tue Aug 30 07:28:48 2005
@@ -91,7 +91,7 @@
static apr_pool_t *root_pool = NULL;
static const char *sockname;
static pid_t parent_pid;
-static ap_unix_identity_t empty_ugid = { -1, -1, -1 };
+static ap_unix_identity_t empty_ugid = { (uid_t)-1, (gid_t)-1, -1 };
/* Read and discard the data in the brigade produced by a CGI script */
static void discard_script_output(apr_bucket_brigade *bb);
Re: svn commit: r264788 - /httpd/httpd/trunk/modules/generators/mod_cgid.c
Posted by Colm MacCarthaigh <co...@stdlib.net>.
On Tue, Aug 30, 2005 at 07:58:01PM -0700, Paul Querna wrote:
> colm@apache.org wrote:
> > Author: colm
> > Date: Tue Aug 30 07:28:48 2005
> > New Revision: 264788
> >
> > URL: http://svn.apache.org/viewcvs?rev=264788&view=rev
> > Log:
> >
> > If uid_t and gid_t are unsigned on a platform (hurd, for example), using -1
> > may cause a compiler warning.
>
> Why are we re-inventing APR in mod_cgid?
That structure comes from unixd.c|h, and changing it would be a massive
API/ABI change breaking any third-party modules which implement the
get_identity hook. So I left it alone :)
> mod_cgid seriously needs a major cleaning to use all of the APR functions.
cgid is unix-only, is there much point?
--
Colm MacCárthaigh Public Key: colm+pgp@stdlib.net
Re: svn commit: r264788 - /httpd/httpd/trunk/modules/generators/mod_cgid.c
Posted by Paul Querna <ch...@force-elite.com>.
colm@apache.org wrote:
> Author: colm
> Date: Tue Aug 30 07:28:48 2005
> New Revision: 264788
>
> URL: http://svn.apache.org/viewcvs?rev=264788&view=rev
> Log:
>
> If uid_t and gid_t are unsigned on a platform (hurd, for example), using -1
> may cause a compiler warning.
Why are we re-inventing APR in mod_cgid?
mod_cgid seriously needs a major cleaning to use all of the APR functions.