You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/02 17:05:15 UTC
[GitHub] [pulsar] poorbarcode opened a new pull request, #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
poorbarcode opened a new pull request, #17441:
URL: https://github.com/apache/pulsar/pull/17441
### Motivation
See:
- #16729
I tried to run it 10,000 times, but could not reproduce the problem. Guessing it is not the problem with the current test, try adding information to determine the problem.
### Modifications
Try adding information to determine the problem.
### Documentation
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
URL: https://github.com/apache/pulsar/pull/17441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#issuecomment-1246292358
rebase master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on a diff in pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on code in PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#discussion_r962556580
##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerBkTest.java:
##########
@@ -336,9 +335,14 @@ public void deleteFailed(ManagedLedgerException exception, Object ctx) {
cursor.close();
ledger.close();
- assertFalse(gotException.get());
+ // Add information to determine the problem.
+ if (gotException.get() != null){
+ fail(ThrowableToStringUtil.toString(gotException.get()));
+ }
}
+
+
Review Comment:
Already fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#issuecomment-1242620050
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#issuecomment-1241442992
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#issuecomment-1248841298
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#issuecomment-1240086922
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#discussion_r962518602
##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerBkTest.java:
##########
@@ -336,9 +335,14 @@ public void deleteFailed(ManagedLedgerException exception, Object ctx) {
cursor.close();
ledger.close();
- assertFalse(gotException.get());
+ // Add information to determine the problem.
+ if (gotException.get() != null){
+ fail(ThrowableToStringUtil.toString(gotException.get()));
+ }
}
+
+
Review Comment:
Remove this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#issuecomment-1242609563
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#issuecomment-1243999353
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#issuecomment-1240184943
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#issuecomment-1240110575
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#issuecomment-1241898156
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#issuecomment-1237917242
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#issuecomment-1240067572
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17441:
URL: https://github.com/apache/pulsar/pull/17441#issuecomment-1240990131
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #17441: [flaky-test]Add information in ManagedLedgerBkTest to determine the problem
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17441:
URL: https://github.com/apache/pulsar/pull/17441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org