You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by pr...@apache.org on 2016/06/29 17:46:51 UTC

zeppelin git commit: [ZEPPELIN-1076] Set hbase.client.retries.number for JDBC

Repository: zeppelin
Updated Branches:
  refs/heads/master f6b48d3b6 -> f80a2bd66


[ZEPPELIN-1076] Set hbase.client.retries.number for JDBC

### What is this PR for?
If a user has "org.apache.phoenix:phoenix-core:4.x.x" jar added as a dependency in JDBC interpreter, and for some reason phoenix was not accessible or not properly configured; then the phoenix tries to for 35 times (which is default for hbase.client.retries.number) and each retires is 8 second apart, before it finally fails.

### What type of PR is it?
[Bug Fix]

### Todos
* [x] - Set phoenix.hbase.client.retries.number for JDBC

### What is the Jira issue?
* [ZEPPELIN-1076](https://issues.apache.org/jira/browse/ZEPPELIN-1076)

### How should this be tested?
In JDBC interpreter add `org.apache.phoenix:phoenix-core:4.4.0-HBase-1.0` as dependency, but don't configure phoenix setting.
Then try to run any sql query with any of the configured JDBC driver (like `show tables`)

 - Without this it will take slightly more than about 5 mins
 - With this it should fetch result sooner (in less than a minute)

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a

Author: Prabhjyot Singh <pr...@gmail.com>

Closes #1103 from prabhjyotsingh/ZEPPELIN-1076 and squashes the following commits:

4da9763 [Prabhjyot Singh] Set phoenix.hbase.client.retries.number for JDBC


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/f80a2bd6
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/f80a2bd6
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/f80a2bd6

Branch: refs/heads/master
Commit: f80a2bd665cb9e44de5a2e77558394813e8ea4b0
Parents: f6b48d3
Author: Prabhjyot Singh <pr...@gmail.com>
Authored: Tue Jun 28 23:42:03 2016 +0530
Committer: Prabhjyot Singh <pr...@gmail.com>
Committed: Wed Jun 29 23:16:44 2016 +0530

----------------------------------------------------------------------
 jdbc/src/main/resources/interpreter-setting.json | 6 ++++++
 1 file changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/f80a2bd6/jdbc/src/main/resources/interpreter-setting.json
----------------------------------------------------------------------
diff --git a/jdbc/src/main/resources/interpreter-setting.json b/jdbc/src/main/resources/interpreter-setting.json
index c60a987..16594eb 100644
--- a/jdbc/src/main/resources/interpreter-setting.json
+++ b/jdbc/src/main/resources/interpreter-setting.json
@@ -94,6 +94,12 @@
         "defaultValue": "org.apache.phoenix.jdbc.PhoenixDriver",
         "description": ""
       },
+      "phoenix.hbase.client.retries.number": {
+        "envName": null,
+        "propertyName": "phoenix.hbase.client.retries.number",
+        "defaultValue": "1",
+        "description": "Maximum retries.  Used as maximum for all retryable operations such as the getting of a cell's value, starting a row update, etc."
+      },
       "tajo.url": {
         "envName": null,
         "propertyName": "tajo.url",