You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by jm...@apache.org on 2017/06/05 03:19:41 UTC
[1/3] git commit: [flex-asjs] [refs/heads/develop] - positioner can
be null or undefined
Repository: flex-asjs
Updated Branches:
refs/heads/develop 407cacd15 -> 0d6965416
positioner can be null or undefined
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/66773dfe
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/66773dfe
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/66773dfe
Branch: refs/heads/develop
Commit: 66773dfeb7bf9bf228720d521f5e5682a12ee8c6
Parents: 407cacd
Author: Justin Mclean <jm...@apache.org>
Authored: Mon Jun 5 13:14:47 2017 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Mon Jun 5 13:14:47 2017 +1000
----------------------------------------------------------------------
.../projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/66773dfe/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as
index bf23ddf..efde41b 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as
@@ -1474,7 +1474,8 @@ package org.apache.flex.core
{
if (element === null)
element = document.createElement('div') as WrappedHTMLElement;
- if (positioner === null)
+ // initially undefined could be set to null
+ if (positioner == null)
positioner = element;
positioner.style.display = 'block';
//positioner.style.position = 'relative';
Odgovor: [3/3] git commit: [flex-asjs] [refs/heads/develop] - set input type back to text when bead is removed
Posted by Silvije Mudri <mu...@gmail.com>.
Bok na.
Poslano s pametnog telefona BlackBerry 10.
Originalna poruka
Šalje: Piotr Zarzycki
Poslano: ponedjeljak, 5. lipnja 2017. 17:26
Prima: dev@flex.apache.org
Odgovor za: dev@flex.apache.org
Predmet: Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - set input type back to text when bead is removed
Hi Justin,
Can it be close as part of separate bead ? What actually are you doing here
?
Piotr
2017-06-05 5:19 GMT+02:00 <jm...@apache.org>:
> set input type back to text when bead is removed
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/0d696541
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/0d696541
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/0d696541
>
> Branch: refs/heads/develop
> Commit: 0d69654163d8fe0ae7d027f027fa06bb7d71f4bd
> Parents: 385655a
> Author: Justin Mclean <jm...@apache.org>
> Authored: Mon Jun 5 13:17:04 2017 +1000
> Committer: Justin Mclean <jm...@apache.org>
> Committed: Mon Jun 5 13:17:04 2017 +1000
>
> ----------------------------------------------------------------------
> .../flex/html/accessories/PasswordInputBead.as | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 0d696541/frameworks/projects/Basic/src/main/flex/org/
> apache/flex/html/accessories/PasswordInputBead.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/accessories/PasswordInputBead.as b/frameworks/projects/Basic/
> src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as
> index e73822b..4312100 100644
> --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/accessories/PasswordInputBead.as
> +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/accessories/PasswordInputBead.as
> @@ -68,17 +68,27 @@ package org.apache.flex.html.accessories
> */
> public function set strand(value:IStrand):void
> {
> - _strand = value;
> -
> COMPILE::SWF
> {
> + _strand = value;
> IEventDispatcher(value).
> addEventListener("viewChanged",viewChangeHandler);
> }
> COMPILE::JS
> {
> - var host:UIBase = value as UIBase;
> - var e:HTMLInputElement = host.element as
> HTMLInputElement;
> - e.type = 'password';
> + var host:UIBase;
> + var e:HTMLInputElement;
> +
> + if (value !== null) {;
> + host = value as UIBase;
> + e = host.element as
> HTMLInputElement;
> + e.type = 'password';
> + }
> + else {
> + host = _strand as UIBase;
> + e = host.element as
> HTMLInputElement;
> + e.type = 'text';
> + }
> + _strand = value;
> }
> }
>
>
>
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - set input
type back to text when bead is removed
Posted by Piotr Zarzycki <pi...@gmail.com>.
Hi Justin,
Can it be close as part of separate bead ? What actually are you doing here
?
Piotr
2017-06-05 5:19 GMT+02:00 <jm...@apache.org>:
> set input type back to text when bead is removed
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/0d696541
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/0d696541
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/0d696541
>
> Branch: refs/heads/develop
> Commit: 0d69654163d8fe0ae7d027f027fa06bb7d71f4bd
> Parents: 385655a
> Author: Justin Mclean <jm...@apache.org>
> Authored: Mon Jun 5 13:17:04 2017 +1000
> Committer: Justin Mclean <jm...@apache.org>
> Committed: Mon Jun 5 13:17:04 2017 +1000
>
> ----------------------------------------------------------------------
> .../flex/html/accessories/PasswordInputBead.as | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 0d696541/frameworks/projects/Basic/src/main/flex/org/
> apache/flex/html/accessories/PasswordInputBead.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/accessories/PasswordInputBead.as b/frameworks/projects/Basic/
> src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as
> index e73822b..4312100 100644
> --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/accessories/PasswordInputBead.as
> +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/accessories/PasswordInputBead.as
> @@ -68,17 +68,27 @@ package org.apache.flex.html.accessories
> */
> public function set strand(value:IStrand):void
> {
> - _strand = value;
> -
> COMPILE::SWF
> {
> + _strand = value;
> IEventDispatcher(value).
> addEventListener("viewChanged",viewChangeHandler);
> }
> COMPILE::JS
> {
> - var host:UIBase = value as UIBase;
> - var e:HTMLInputElement = host.element as
> HTMLInputElement;
> - e.type = 'password';
> + var host:UIBase;
> + var e:HTMLInputElement;
> +
> + if (value !== null) {;
> + host = value as UIBase;
> + e = host.element as
> HTMLInputElement;
> + e.type = 'password';
> + }
> + else {
> + host = _strand as UIBase;
> + e = host.element as
> HTMLInputElement;
> + e.type = 'text';
> + }
> + _strand = value;
> }
> }
>
>
>
[3/3] git commit: [flex-asjs] [refs/heads/develop] - set input type
back to text when bead is removed
Posted by jm...@apache.org.
set input type back to text when bead is removed
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/0d696541
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/0d696541
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/0d696541
Branch: refs/heads/develop
Commit: 0d69654163d8fe0ae7d027f027fa06bb7d71f4bd
Parents: 385655a
Author: Justin Mclean <jm...@apache.org>
Authored: Mon Jun 5 13:17:04 2017 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Mon Jun 5 13:17:04 2017 +1000
----------------------------------------------------------------------
.../flex/html/accessories/PasswordInputBead.as | 20 +++++++++++++++-----
1 file changed, 15 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/0d696541/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as
index e73822b..4312100 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as
@@ -68,17 +68,27 @@ package org.apache.flex.html.accessories
*/
public function set strand(value:IStrand):void
{
- _strand = value;
-
COMPILE::SWF
{
+ _strand = value;
IEventDispatcher(value).addEventListener("viewChanged",viewChangeHandler);
}
COMPILE::JS
{
- var host:UIBase = value as UIBase;
- var e:HTMLInputElement = host.element as HTMLInputElement;
- e.type = 'password';
+ var host:UIBase;
+ var e:HTMLInputElement;
+
+ if (value !== null) {;
+ host = value as UIBase;
+ e = host.element as HTMLInputElement;
+ e.type = 'password';
+ }
+ else {
+ host = _strand as UIBase;
+ e = host.element as HTMLInputElement;
+ e.type = 'text';
+ }
+ _strand = value;
}
}
[2/3] git commit: [flex-asjs] [refs/heads/develop] - set strand to
null when removing bead - do this so beads can cleanly remove themselves
Posted by jm...@apache.org.
set strand to null when removing bead - do this so beads can cleanly remove themselves
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/385655aa
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/385655aa
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/385655aa
Branch: refs/heads/develop
Commit: 385655aa137456614c7b70d295f84f50046af64b
Parents: 66773df
Author: Justin Mclean <jm...@apache.org>
Authored: Mon Jun 5 13:16:36 2017 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Mon Jun 5 13:16:36 2017 +1000
----------------------------------------------------------------------
.../Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/385655aa/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as
index d67686e..30a67bb 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as
@@ -208,7 +208,7 @@ package org.apache.flex.core
if (bead === value)
{
_beads.splice(i, 1);
-
+ bead.strand = null;
return bead;
}
}