You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/08 02:38:57 UTC
[GitHub] [incubator-kyuubi] ulysses-you opened a new pull request, #2296: Fix operation log file handler leak
ulysses-you opened a new pull request, #2296:
URL: https://github.com/apache/incubator-kyuubi/pull/2296
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
If a session is empty which means that it does not contain any operation, then the OperationLog will never be closed.
This bug will happen if we enable `LaunchEngine`
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2296: Fix operation log file handler leak
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #2296:
URL: https://github.com/apache/incubator-kyuubi/pull/2296#issuecomment-1097475786
thank you for the confirming. FYI, this patch will land into comming 1.5.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #2296: Fix operation log file handler leak
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #2296:
URL: https://github.com/apache/incubator-kyuubi/pull/2296#discussion_r973868188
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/operation/log/OperationLog.scala:
##########
@@ -83,10 +83,10 @@ object OperationLog extends Logging {
class OperationLog(path: Path) {
- private val writer = Files.newBufferedWriter(path, StandardCharsets.UTF_8)
- private val reader = Files.newBufferedReader(path, StandardCharsets.UTF_8)
+ private lazy val writer = Files.newBufferedWriter(path, StandardCharsets.UTF_8)
Review Comment:
+1 for the initialized flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2296: Fix operation log file handler leak
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2296:
URL: https://github.com/apache/incubator-kyuubi/pull/2296#issuecomment-1092412177
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2296?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2296](https://codecov.io/gh/apache/incubator-kyuubi/pull/2296?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (22d07e1) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b41ec939913b540763e2e9f0cbd2005a9c720b25?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b41ec93) will **increase** coverage by `0.00%`.
> The diff coverage is `72.72%`.
```diff
@@ Coverage Diff @@
## master #2296 +/- ##
=========================================
Coverage 62.21% 62.22%
Complexity 69 69
=========================================
Files 353 353
Lines 16757 16760 +3
Branches 2269 2269
=========================================
+ Hits 10426 10429 +3
+ Misses 5370 5367 -3
- Partials 961 964 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/kyuubi/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `82.66% <ø> (-0.23%)` | :arrow_down: |
| [...org/apache/kyuubi/operation/log/OperationLog.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vbG9nL09wZXJhdGlvbkxvZy5zY2FsYQ==) | `89.23% <62.50%> (-2.58%)` | :arrow_down: |
| [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `68.00% <100.00%> (+1.33%)` | :arrow_up: |
| [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `89.28% <0.00%> (-3.58%)` | :arrow_down: |
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `39.72% <0.00%> (-1.37%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `69.87% <0.00%> (+4.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2296?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2296?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b41ec93...22d07e1](https://codecov.io/gh/apache/incubator-kyuubi/pull/2296?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2296: Fix operation log file handler leak
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2296:
URL: https://github.com/apache/incubator-kyuubi/pull/2296#discussion_r973741832
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/operation/log/OperationLog.scala:
##########
@@ -83,10 +83,10 @@ object OperationLog extends Logging {
class OperationLog(path: Path) {
- private val writer = Files.newBufferedWriter(path, StandardCharsets.UTF_8)
- private val reader = Files.newBufferedReader(path, StandardCharsets.UTF_8)
+ private lazy val writer = Files.newBufferedWriter(path, StandardCharsets.UTF_8)
Review Comment:
The lazy creating saves open files resource, but may cause NPE if we set a high threshold for loggers.
Simply reverting the lazy change should resolve the issue, right?
Another solution I think we can introduce a flag `initialized` to indicate where we start writing logs to the file, `initialized` starts w/ false and should be updated to true after writing the first line to the log file. The reader should get an empty array instead of an exception if `initialized` is false.
thought? @ulysses-you @Yikf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2296: Fix operation log file handler leak
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2296:
URL: https://github.com/apache/incubator-kyuubi/pull/2296#discussion_r973741832
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/operation/log/OperationLog.scala:
##########
@@ -83,10 +83,10 @@ object OperationLog extends Logging {
class OperationLog(path: Path) {
- private val writer = Files.newBufferedWriter(path, StandardCharsets.UTF_8)
- private val reader = Files.newBufferedReader(path, StandardCharsets.UTF_8)
+ private lazy val writer = Files.newBufferedWriter(path, StandardCharsets.UTF_8)
Review Comment:
The lazy creating saves open files resource, by may cause NPE if we set a high threshold for loggers.
Simply reverting the lazy change should resolve the issue, right?
Another solution I think we can introduce a flag `initialized` to indicate where we start writing logs to the file, `initialized` starts w/ false and should be updated to true after writing the first line to the log file. The reader should get an empty array instead of an exception if `initialized` is false.
thought? @ulysses-you @Yikf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2296: Fix operation log file handler leak
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #2296:
URL: https://github.com/apache/incubator-kyuubi/pull/2296#issuecomment-1094459123
also backport into branch-1.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Yikf commented on a diff in pull request #2296: Fix operation log file handler leak
Posted by GitBox <gi...@apache.org>.
Yikf commented on code in PR #2296:
URL: https://github.com/apache/incubator-kyuubi/pull/2296#discussion_r973818191
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/operation/log/OperationLog.scala:
##########
@@ -83,10 +83,10 @@ object OperationLog extends Logging {
class OperationLog(path: Path) {
- private val writer = Files.newBufferedWriter(path, StandardCharsets.UTF_8)
- private val reader = Files.newBufferedReader(path, StandardCharsets.UTF_8)
+ private lazy val writer = Files.newBufferedWriter(path, StandardCharsets.UTF_8)
Review Comment:
I prefer `initialized ` flag's thought
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2296: Fix operation log file handler leak
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #2296:
URL: https://github.com/apache/incubator-kyuubi/pull/2296#issuecomment-1096754932
@iodone thank you for the info. This pr can also fix your case right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] iodone commented on pull request #2296: Fix operation log file handler leak
Posted by GitBox <gi...@apache.org>.
iodone commented on PR #2296:
URL: https://github.com/apache/incubator-kyuubi/pull/2296#issuecomment-1097474399
> @iodone thank you for the info. This pr can also fix your case right ?
Yes, this pr solves the problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] iodone commented on pull request #2296: Fix operation log file handler leak
Posted by GitBox <gi...@apache.org>.
iodone commented on PR #2296:
URL: https://github.com/apache/incubator-kyuubi/pull/2296#issuecomment-1096648870
@ulysses-you Thank you for the fix, operation log file handler leaks can also occur when an exception occurs in` _remoteOpHandle = client.executeStatement(statement, confOverlay, true, queryTimeout)` . In our production environment, this bug causes the `too many open files `problem when Kyuubi Server runs for a long time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #2296: Fix operation log file handler leak
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #2296:
URL: https://github.com/apache/incubator-kyuubi/pull/2296#issuecomment-1093772358
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei closed pull request #2296: Fix operation log file handler leak
Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #2296: Fix operation log file handler leak
URL: https://github.com/apache/incubator-kyuubi/pull/2296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2296: Fix operation log file handler leak
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #2296:
URL: https://github.com/apache/incubator-kyuubi/pull/2296#issuecomment-1092386616
cc @turboFei @pan3793 @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org