You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celeborn.apache.org by zh...@apache.org on 2023/10/09 07:56:15 UTC
[incubator-celeborn] branch main updated: [CELEBORN-1022][TEST] Update log level from `FATAL` to `ERROR` for console output in unit tests
This is an automated email from the ASF dual-hosted git repository.
zhouky pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git
The following commit(s) were added to refs/heads/main by this push:
new b2412d077 [CELEBORN-1022][TEST] Update log level from `FATAL` to `ERROR` for console output in unit tests
b2412d077 is described below
commit b2412d077400bbc59aa65cde13e2c855c65e1988
Author: Fu Chen <cf...@gmail.com>
AuthorDate: Mon Oct 9 15:56:05 2023 +0800
[CELEBORN-1022][TEST] Update log level from `FATAL` to `ERROR` for console output in unit tests
### What changes were proposed in this pull request?
As title
### Why are the changes needed?
1. this is developer-friendly for debugging unit tests in IntelliJ IDEA, for example: Netty's memory leak reports are logged at the error level and won't cause unit tests to be marked as fatal.
```
23/10/09 09:57:26,422 ERROR [fetch-server-52-2] ResourceLeakDetector: LEAK: ByteBuf.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information.
Recent access records:
Created at:
io.netty.buffer.PooledByteBufAllocator.newDirectBuffer(PooledByteBufAllocator.java:403)
io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:188)
io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:179)
io.netty.buffer.AbstractByteBufAllocator.ioBuffer(AbstractByteBufAllocator.java:140)
io.netty.channel.DefaultMaxMessagesRecvByteBufAllocator$MaxMessageHandle.allocate(DefaultMaxMessagesRecvByteBufAllocator.java:120)
io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:150)
io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788)
io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724)
io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650)
io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562)
io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
java.lang.Thread.run(Thread.java:750)
```
2. this won't increase console output and affect the stability of CI.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GA
Closes #1958 from cfmcgrady/ut-console-log-level.
Authored-by: Fu Chen <cf...@gmail.com>
Signed-off-by: zky.zhoukeyong <zk...@alibaba-inc.com>
---
client-flink/flink-1.14/src/test/resources/log4j2-test.xml | 2 +-
client-spark/common/src/test/resources/log4j2-test.xml | 2 +-
.../spark-3-columnar-shuffle/src/test/resources/log4j2-test.xml | 2 +-
client-spark/spark-3/src/test/resources/log4j2-test.xml | 2 +-
client/src/test/resources/log4j2-test.xml | 2 +-
common/src/test/resources/log4j2-test.xml | 2 +-
master/src/test/resources/log4j2-test.xml | 2 +-
tests/flink-it/src/test/resources/log4j2-test.xml | 6 +++---
tests/kubernetes-it/src/test/resources/log4j2-test.xml | 2 +-
worker/src/test/resources/log4j2-test.xml | 2 +-
10 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/client-flink/flink-1.14/src/test/resources/log4j2-test.xml b/client-flink/flink-1.14/src/test/resources/log4j2-test.xml
index e91e2f312..9adcdccfd 100644
--- a/client-flink/flink-1.14/src/test/resources/log4j2-test.xml
+++ b/client-flink/flink-1.14/src/test/resources/log4j2-test.xml
@@ -21,7 +21,7 @@
<Console name="stdout" target="SYSTEM_OUT">
<PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
<Filters>
- <ThresholdFilter level="FATAL"/>
+ <ThresholdFilter level="ERROR"/>
</Filters>
</Console>
<File name="file" fileName="target/unit-tests.log">
diff --git a/client-spark/common/src/test/resources/log4j2-test.xml b/client-spark/common/src/test/resources/log4j2-test.xml
index e91e2f312..9adcdccfd 100644
--- a/client-spark/common/src/test/resources/log4j2-test.xml
+++ b/client-spark/common/src/test/resources/log4j2-test.xml
@@ -21,7 +21,7 @@
<Console name="stdout" target="SYSTEM_OUT">
<PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
<Filters>
- <ThresholdFilter level="FATAL"/>
+ <ThresholdFilter level="ERROR"/>
</Filters>
</Console>
<File name="file" fileName="target/unit-tests.log">
diff --git a/client-spark/spark-3-columnar-shuffle/src/test/resources/log4j2-test.xml b/client-spark/spark-3-columnar-shuffle/src/test/resources/log4j2-test.xml
index e91e2f312..9adcdccfd 100644
--- a/client-spark/spark-3-columnar-shuffle/src/test/resources/log4j2-test.xml
+++ b/client-spark/spark-3-columnar-shuffle/src/test/resources/log4j2-test.xml
@@ -21,7 +21,7 @@
<Console name="stdout" target="SYSTEM_OUT">
<PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
<Filters>
- <ThresholdFilter level="FATAL"/>
+ <ThresholdFilter level="ERROR"/>
</Filters>
</Console>
<File name="file" fileName="target/unit-tests.log">
diff --git a/client-spark/spark-3/src/test/resources/log4j2-test.xml b/client-spark/spark-3/src/test/resources/log4j2-test.xml
index e91e2f312..9adcdccfd 100644
--- a/client-spark/spark-3/src/test/resources/log4j2-test.xml
+++ b/client-spark/spark-3/src/test/resources/log4j2-test.xml
@@ -21,7 +21,7 @@
<Console name="stdout" target="SYSTEM_OUT">
<PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
<Filters>
- <ThresholdFilter level="FATAL"/>
+ <ThresholdFilter level="ERROR"/>
</Filters>
</Console>
<File name="file" fileName="target/unit-tests.log">
diff --git a/client/src/test/resources/log4j2-test.xml b/client/src/test/resources/log4j2-test.xml
index e91e2f312..9adcdccfd 100644
--- a/client/src/test/resources/log4j2-test.xml
+++ b/client/src/test/resources/log4j2-test.xml
@@ -21,7 +21,7 @@
<Console name="stdout" target="SYSTEM_OUT">
<PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
<Filters>
- <ThresholdFilter level="FATAL"/>
+ <ThresholdFilter level="ERROR"/>
</Filters>
</Console>
<File name="file" fileName="target/unit-tests.log">
diff --git a/common/src/test/resources/log4j2-test.xml b/common/src/test/resources/log4j2-test.xml
index e91e2f312..9adcdccfd 100644
--- a/common/src/test/resources/log4j2-test.xml
+++ b/common/src/test/resources/log4j2-test.xml
@@ -21,7 +21,7 @@
<Console name="stdout" target="SYSTEM_OUT">
<PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
<Filters>
- <ThresholdFilter level="FATAL"/>
+ <ThresholdFilter level="ERROR"/>
</Filters>
</Console>
<File name="file" fileName="target/unit-tests.log">
diff --git a/master/src/test/resources/log4j2-test.xml b/master/src/test/resources/log4j2-test.xml
index e91e2f312..9adcdccfd 100644
--- a/master/src/test/resources/log4j2-test.xml
+++ b/master/src/test/resources/log4j2-test.xml
@@ -21,7 +21,7 @@
<Console name="stdout" target="SYSTEM_OUT">
<PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
<Filters>
- <ThresholdFilter level="FATAL"/>
+ <ThresholdFilter level="ERROR"/>
</Filters>
</Console>
<File name="file" fileName="target/unit-tests.log">
diff --git a/tests/flink-it/src/test/resources/log4j2-test.xml b/tests/flink-it/src/test/resources/log4j2-test.xml
index 607cbb578..9adcdccfd 100644
--- a/tests/flink-it/src/test/resources/log4j2-test.xml
+++ b/tests/flink-it/src/test/resources/log4j2-test.xml
@@ -16,12 +16,12 @@
~ limitations under the License.
-->
-<Configuration status="DEBUG">
+<Configuration status="INFO">
<Appenders>
<Console name="stdout" target="SYSTEM_OUT">
<PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
<Filters>
- <ThresholdFilter level="DEBUG"/>
+ <ThresholdFilter level="ERROR"/>
</Filters>
</Console>
<File name="file" fileName="target/unit-tests.log">
@@ -29,7 +29,7 @@
</File>
</Appenders>
<Loggers>
- <Root level="DEBUG">
+ <Root level="INFO">
<AppenderRef ref="stdout"/>
<AppenderRef ref="file"/>
</Root>
diff --git a/tests/kubernetes-it/src/test/resources/log4j2-test.xml b/tests/kubernetes-it/src/test/resources/log4j2-test.xml
index 9bcf7f263..9141ac4d1 100644
--- a/tests/kubernetes-it/src/test/resources/log4j2-test.xml
+++ b/tests/kubernetes-it/src/test/resources/log4j2-test.xml
@@ -21,7 +21,7 @@
<Console name="stdout" target="SYSTEM_OUT">
<PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
<Filters>
- <ThresholdFilter level="FATAL"/>
+ <ThresholdFilter level="ERROR"/>
</Filters>
</Console>
<File name="file" fileName="target/unit-tests.log">
diff --git a/worker/src/test/resources/log4j2-test.xml b/worker/src/test/resources/log4j2-test.xml
index e91e2f312..9adcdccfd 100644
--- a/worker/src/test/resources/log4j2-test.xml
+++ b/worker/src/test/resources/log4j2-test.xml
@@ -21,7 +21,7 @@
<Console name="stdout" target="SYSTEM_OUT">
<PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
<Filters>
- <ThresholdFilter level="FATAL"/>
+ <ThresholdFilter level="ERROR"/>
</Filters>
</Console>
<File name="file" fileName="target/unit-tests.log">