[GitHub] [druid] FrankChen021 commented on pull request #10363: fix injection failure of StorageLocationSelectorStrategy objects

[GitBox <gi...@apache.org>]

FrankChen021 commented on pull request #10363:
URL: https://github.com/apache/druid/pull/10363#issuecomment-705021331


   Hi @suneet-s , in this PR a log is added in the ctor of `SegmentLoaderLocalCacheManager` to print the class name of the strategy object. The log shows as follows if `druid.segmentCache.locationSelector.strategy` is set to `roundRobin`
   
   > 2020-10-07T15:22:55,251` INFO [main] org.apache.druid.segment.loading.SegmentLoaderLocalCacheManager - Using storage location strategy: [RoundRobinStorageLocationSelectorStrategy]
   
    In this way, I know whether the configuration takes effect.
   
   As the test cases, I've added some unit test cases to test whether this configuration takes effect by setting `druid.segmentCache.locationSelector.strategy` to different values. I think these cases would guard our code in case of future modification.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org