You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/03 11:49:55 UTC
[GitHub] [fineract] vorburger opened a new pull request #808: un-static-ify SchedulerJobHelper
vorburger opened a new pull request #808:
URL: https://github.com/apache/fineract/pull/808
TODO Un-Draft and rebase once other issues in SchedulerJobHelper are solved, and tests un-ignored
re. FINERACT-922
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #808: un-static-ify SchedulerJobHelper
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #808:
URL: https://github.com/apache/fineract/pull/808#issuecomment-636700410
I've actually done most of what was in this PR was actually done in other PRs meanwwhile, but there were 2 very small changes left here after we re-base which we could still merge (very minor).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger closed pull request #808: un-static-ify SchedulerJobHelper
Posted by GitBox <gi...@apache.org>.
vorburger closed pull request #808:
URL: https://github.com/apache/fineract/pull/808
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #808: un-static-ify SchedulerJobHelper
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #808:
URL: https://github.com/apache/fineract/pull/808#issuecomment-623146841
Most of this is now in #809 #811 #814 - I'll hold this, and rebase it once those are in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #808: un-static-ify SchedulerJobHelper
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #808:
URL: https://github.com/apache/fineract/pull/808#issuecomment-623150741
Ok...It all looks good. Why is the other one #814 failing.... its just weird
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #808: un-static-ify SchedulerJobHelper
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #808:
URL: https://github.com/apache/fineract/pull/808#issuecomment-637474185
Actually, what little is left here now (just removing x2 `static`) will contradict https://errorprone.info/bugpattern/MethodCanBeStatic which I'm assuming (hoping) @percyashu will shortly be adding, so let me abandon this PR instead of merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org