You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2020/05/21 06:12:18 UTC

[GitHub] [struts] lukaszlenart opened a new pull request #419: [WW-5077] Better logs

lukaszlenart opened a new pull request #419:
URL: https://github.com/apache/struts/pull/419


   Refs [WW-5077](https://issues.apache.org/jira/browse/WW-5077)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts] coveralls edited a comment on pull request #419: [WW-5077] Better logs

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #419:
URL: https://github.com/apache/struts/pull/419#issuecomment-631997239


   
   [![Coverage Status](https://coveralls.io/builds/30994465/badge)](https://coveralls.io/builds/30994465)
   
   Coverage increased (+0.001%) to 47.098% when pulling **043814b7749e42cf04e55a859c485aae8abbb81c on WW-5077-better-logs** into **0fabde9f978c476cd3b769741e5f0fed189f3e1b on struts-2-5-x**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] lukaszlenart commented on pull request #419: [WW-5077] Better logs

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #419:
URL: https://github.com/apache/struts/pull/419#issuecomment-633192968


   Cherry-pick is ready https://github.com/apache/struts/pull/420


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] sepe81 commented on a change in pull request #419: [WW-5077] Better logs

Posted by GitBox <gi...@apache.org>.
sepe81 commented on a change in pull request #419:
URL: https://github.com/apache/struts/pull/419#discussion_r428516840



##########
File path: core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
##########
@@ -101,7 +104,7 @@ static private int countOGNLCharacters(String s) {
     static final Comparator<String> rbCollator = new Comparator<String>() {
         public int compare(String s1, String s2) {
             int l1 = countOGNLCharacters(s1),
-                l2 = countOGNLCharacters(s2);
+                    l2 = countOGNLCharacters(s2);

Review comment:
       ```suggestion
               int l1 = countOGNLCharacters(s1);
               int l2 = countOGNLCharacters(s2);
   ```
   
   Maybe it's better (more clear) to split this into two separate assignments?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] lukaszlenart commented on a change in pull request #419: [WW-5077] Better logs

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on a change in pull request #419:
URL: https://github.com/apache/struts/pull/419#discussion_r429606130



##########
File path: core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
##########
@@ -18,20 +18,20 @@
  */
 package com.opensymphony.xwork2.interceptor;
 
-import com.opensymphony.xwork2.ActionContext;
-import com.opensymphony.xwork2.ActionInvocation;
-import com.opensymphony.xwork2.TextProvider;
-import com.opensymphony.xwork2.XWorkConstants;
+import com.opensymphony.xwork2.*;

Review comment:
       Strange... IDEA should use `*` in case of importing more than 5 classes from the same package, fixed!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] lukaszlenart merged pull request #419: [WW-5077] Better logs

Posted by GitBox <gi...@apache.org>.
lukaszlenart merged pull request #419:
URL: https://github.com/apache/struts/pull/419


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts] coveralls commented on pull request #419: [WW-5077] Better logs

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #419:
URL: https://github.com/apache/struts/pull/419#issuecomment-631997239


   
   [![Coverage Status](https://coveralls.io/builds/30940590/badge)](https://coveralls.io/builds/30940590)
   
   Coverage increased (+0.001%) to 47.098% when pulling **c290b0a3646b1f6796a632b2437a910450fdc7ad on WW-5077-better-logs** into **0fabde9f978c476cd3b769741e5f0fed189f3e1b on struts-2-5-x**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] lukaszlenart commented on a change in pull request #419: [WW-5077] Better logs

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on a change in pull request #419:
URL: https://github.com/apache/struts/pull/419#discussion_r428535889



##########
File path: core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
##########
@@ -101,7 +104,7 @@ static private int countOGNLCharacters(String s) {
     static final Comparator<String> rbCollator = new Comparator<String>() {
         public int compare(String s1, String s2) {
             int l1 = countOGNLCharacters(s1),
-                l2 = countOGNLCharacters(s2);
+                    l2 = countOGNLCharacters(s2);

Review comment:
       👍 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] sepe81 commented on a change in pull request #419: [WW-5077] Better logs

Posted by GitBox <gi...@apache.org>.
sepe81 commented on a change in pull request #419:
URL: https://github.com/apache/struts/pull/419#discussion_r429569612



##########
File path: core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
##########
@@ -18,20 +18,20 @@
  */
 package com.opensymphony.xwork2.interceptor;
 
-import com.opensymphony.xwork2.ActionContext;
-import com.opensymphony.xwork2.ActionInvocation;
-import com.opensymphony.xwork2.TextProvider;
-import com.opensymphony.xwork2.XWorkConstants;
+import com.opensymphony.xwork2.*;

Review comment:
       better import explicit classes like in L25-29?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org