You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/07/05 17:27:02 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6852: MINOR: Fix ordering of the aggregate_source_with_order table

alamb commented on code in PR #6852:
URL: https://github.com/apache/arrow-datafusion/pull/6852#discussion_r1253419430


##########
datafusion/core/tests/sqllogictests/test_files/explain.slt:
##########
@@ -70,7 +70,7 @@ CREATE EXTERNAL TABLE aggregate_test_100_with_order (
 STORED AS CSV
 WITH HEADER ROW
 WITH ORDER (c1 ASC)
-LOCATION '../../testing/data/csv/aggregate_test_100.csv';
+LOCATION 'tests/data/aggregate_test_100_with_order.csv';

Review Comment:
   I suggest using a name that gives some specific information about what order is present. Something like this, perhaps
   
   ```suggestion
   LOCATION 'tests/data/aggregate_test_100_order_by_c1_asc.csv';
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org