[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4959:
URL: https://github.com/apache/cloudstack/pull/4959#discussion_r624991208



##########
File path: server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
##########
@@ -238,17 +238,20 @@
     private boolean _sslEnabled = false;
     private String _consoleProxyUrlDomain;
 
-    // global load picture at zone basis
     private SystemVmLoadScanner<Long> _loadScanner;
-    private Map<Long, ZoneHostInfo> _zoneHostInfoMap; // map <zone id, info about running host in zone>
-    private Map<Long, ConsoleProxyLoadInfo> _zoneProxyCountMap; // map <zone id, info about proxy VMs count in zone>
-    private Map<Long, ConsoleProxyLoadInfo> _zoneVmCountMap; // map <zone id, info about running VMs count in zone>
+    private Map<Long, ZoneHostInfo> _zoneHostInfoMap;
+    private Map<Long, ConsoleProxyLoadInfo> _zoneProxyCountMap;
+    private Map<Long, ConsoleProxyLoadInfo> _zoneVmCountMap;

Review comment:
       while touching this anyway, we might want to remove the silly undescores.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org