You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/04/20 10:25:24 UTC
[GitHub] [incubator-hugegraph] mayelena opened a new pull request, #1838: Bugfix branch
mayelena opened a new pull request, #1838:
URL: https://github.com/apache/incubator-hugegraph/pull/1838
fix hugegraph-example/Example checkstyle issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] seagle-yuan commented on a diff in pull request #1838: fix hugegraph-example/Example checkstyle issue
Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on code in PR #1838:
URL: https://github.com/apache/incubator-hugegraph/pull/1838#discussion_r854041588
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example1.java:
##########
@@ -270,7 +270,7 @@ public static void testQuery(final HugeGraph graph) {
GraphTraversal<Vertex, Vertex> vertices = graph.traversal().V();
int size = vertices.toList().size();
assert size == 12;
- LOG.info(">>>> query all vertices: size=" + size);
+ LOG.info(">>>> query all vertices: size=", size);
Review Comment:
we need use [LOG.info(">>>> query all vertices: size {}",size);]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1838: fix hugegraph-example/Example checkstyle issue
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1838:
URL: https://github.com/apache/incubator-hugegraph/pull/1838#discussion_r855889936
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example1.java:
##########
@@ -282,8 +282,7 @@ public static void testQuery(final HugeGraph graph) {
vertices = graph.traversal().V().hasLabel("author").has("id", 1);
List<Vertex> vertexList = vertices.toList();
assert vertexList.size() == 1;
- LOG.info(">>>> query vertices by primary-values: {}",
- vertexList);
+ LOG.info(">>>> query vertices by primary-values: {}",vertexList);
Review Comment:
expect a space after ","
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #1838: fix hugegraph-example/Example checkstyle issue
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1838:
URL: https://github.com/apache/incubator-hugegraph/pull/1838#issuecomment-1106111291
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1838](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e908a2d) into [master](https://codecov.io/gh/apache/incubator-hugegraph/commit/9ec3c3c66ca3314f99f53e4294b5cc4e79fabe93?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ec3c3c) will **increase** coverage by `4.33%`.
> The diff coverage is `78.78%`.
```diff
@@ Coverage Diff @@
## master #1838 +/- ##
============================================
+ Coverage 66.58% 70.92% +4.33%
+ Complexity 982 693 -289
============================================
Files 446 446
Lines 37914 37955 +41
Branches 5400 5410 +10
============================================
+ Hits 25246 26918 +1672
+ Misses 9963 8304 -1659
- Partials 2705 2733 +28
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ugegraph/backend/serializer/TableBackendEntry.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc2VyaWFsaXplci9UYWJsZUJhY2tlbmRFbnRyeS5qYXZh) | `88.88% <ø> (ø)` | |
| [...gegraph/backend/serializer/BinaryBackendEntry.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc2VyaWFsaXplci9CaW5hcnlCYWNrZW5kRW50cnkuamF2YQ==) | `78.65% <33.33%> (+5.61%)` | :arrow_up: |
| [...om/baidu/hugegraph/backend/store/BackendEntry.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvQmFja2VuZEVudHJ5LmphdmE=) | `71.42% <80.76%> (+40.87%)` | :arrow_up: |
| [...hugegraph/backend/serializer/TextBackendEntry.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc2VyaWFsaXplci9UZXh0QmFja2VuZEVudHJ5LmphdmE=) | `83.23% <100.00%> (-0.10%)` | :arrow_down: |
| [.../hugegraph/backend/store/rocksdb/RocksDBTable.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXJvY2tzZGIvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcm9ja3NkYi9Sb2Nrc0RCVGFibGUuamF2YQ==) | `68.53% <100.00%> (+53.84%)` | :arrow_up: |
| [...du/hugegraph/backend/tx/GraphIndexTransaction.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvdHgvR3JhcGhJbmRleFRyYW5zYWN0aW9uLmphdmE=) | `83.43% <0.00%> (-0.18%)` | :arrow_down: |
| [...du/hugegraph/traversal/optimize/TraversalUtil.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3RyYXZlcnNhbC9vcHRpbWl6ZS9UcmF2ZXJzYWxVdGlsLmphdmE=) | `62.87% <0.00%> (+0.21%)` | :arrow_up: |
| [...m/baidu/hugegraph/backend/tx/GraphTransaction.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvdHgvR3JhcGhUcmFuc2FjdGlvbi5qYXZh) | `80.06% <0.00%> (+0.28%)` | :arrow_up: |
| [...du/hugegraph/schema/builder/IndexLabelBuilder.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3NjaGVtYS9idWlsZGVyL0luZGV4TGFiZWxCdWlsZGVyLmphdmE=) | `88.69% <0.00%> (+0.28%)` | :arrow_up: |
| [.../com/baidu/hugegraph/auth/StandardAuthManager.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2F1dGgvU3RhbmRhcmRBdXRoTWFuYWdlci5qYXZh) | `92.81% <0.00%> (+0.32%)` | :arrow_up: |
| ... and [115 more](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [74c0e2d...e908a2d](https://codecov.io/gh/apache/incubator-hugegraph/pull/1838?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] seagle-yuan commented on a diff in pull request #1838: fix hugegraph-example/Example checkstyle issue
Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on code in PR #1838:
URL: https://github.com/apache/incubator-hugegraph/pull/1838#discussion_r854078672
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example1.java:
##########
@@ -382,39 +382,39 @@ public static void testQuery(final HugeGraph graph) {
vertices = graph.traversal().V().hasLabel("book");
size = vertices.toList().size();
assert size == 5;
- LOG.info(">>>> query all books: size=" + size);
+ LOG.info(">>>> query all books: size {}", size);
// query by vertex label and key-name
vertices = graph.traversal().V().hasLabel("person").has("age");
size = vertices.toList().size();
assert size == 5;
- LOG.info(">>>> query all persons with age: size=" + size);
+ LOG.info(">>>> query all persons with age: size {}", size);
// query by vertex props
vertices = graph.traversal().V().hasLabel("person")
.has("city", "Taipei");
vertexList = vertices.toList();
assert vertexList.size() == 1;
- LOG.info(">>>> query all persons in Taipei: " + vertexList);
+ LOG.info(">>>> query all persons in Taipei: {}", vertexList);
vertices = graph.traversal().V().hasLabel("person").has("age", 19);
vertexList = vertices.toList();
assert vertexList.size() == 1;
- LOG.info(">>>> query all persons age==19: " + vertexList);
+ LOG.info(">>>> query all persons age==19: {}", vertexList);
vertices = graph.traversal().V().hasLabel("person")
.has("age", P.lt(19));
vertexList = vertices.toList();
assert vertexList.size() == 1;
assert vertexList.get(0).property("age").value().equals(3);
- LOG.info(">>>> query all persons age<19: " + vertexList);
+ LOG.info(">>>> query all persons age<19: {}", vertexList);
String addr = "Bay Area";
vertices = graph.traversal().V().hasLabel("author")
.has("lived", Text.contains(addr));
vertexList = vertices.toList();
assert vertexList.size() == 1;
- LOG.info(String.format(">>>> query all authors lived %s: %s",
+ LOG.info(String.format(">>>> query all authors lived {}: {}",
addr, vertexList));
}
Review Comment:
can we use LOG.info(">>>> query all authors lived {}: {}",addr, vertexList);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] seagle-yuan commented on a diff in pull request #1838: fix hugegraph-example/Example checkstyle issue
Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on code in PR #1838:
URL: https://github.com/apache/incubator-hugegraph/pull/1838#discussion_r853984467
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example1.java:
##########
@@ -268,19 +270,19 @@ public static void testQuery(final HugeGraph graph) {
GraphTraversal<Vertex, Vertex> vertices = graph.traversal().V();
int size = vertices.toList().size();
assert size == 12;
- System.out.println(">>>> query all vertices: size=" + size);
+ LOG.info(">>>> query all vertices: size=" + size);
Review Comment:
we can use [LOG.info(">>>> query all vertices: size {}",size);]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1838: fix hugegraph-example/Example checkstyle issue
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1838:
URL: https://github.com/apache/incubator-hugegraph/pull/1838#discussion_r855051714
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example1.java:
##########
@@ -268,19 +270,19 @@ public static void testQuery(final HugeGraph graph) {
GraphTraversal<Vertex, Vertex> vertices = graph.traversal().V();
int size = vertices.toList().size();
assert size == 12;
- System.out.println(">>>> query all vertices: size=" + size);
+ LOG.info(">>>> query all vertices: size {}", size);
// query by label
vertices = graph.traversal().V().hasLabel("person");
size = vertices.toList().size();
assert size == 5;
- System.out.println(">>>> query all persons: size=" + size);
+ LOG.info(">>>> query all persons: size {}", size);
// query vertex by primary-values
vertices = graph.traversal().V().hasLabel("author").has("id", 1);
List<Vertex> vertexList = vertices.toList();
assert vertexList.size() == 1;
- System.out.println(">>>> query vertices by primary-values: " +
+ LOG.info(">>>> query vertices by primary-values: {}",
Review Comment:
please update alignment of the next line
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example1.java:
##########
@@ -382,39 +382,39 @@ public static void testQuery(final HugeGraph graph) {
vertices = graph.traversal().V().hasLabel("book");
size = vertices.toList().size();
assert size == 5;
- LOG.info(">>>> query all books: size=" + size);
+ LOG.info(">>>> query all books: size {}", size);
// query by vertex label and key-name
vertices = graph.traversal().V().hasLabel("person").has("age");
size = vertices.toList().size();
assert size == 5;
- LOG.info(">>>> query all persons with age: size=" + size);
+ LOG.info(">>>> query all persons with age: size {}", size);
// query by vertex props
vertices = graph.traversal().V().hasLabel("person")
.has("city", "Taipei");
vertexList = vertices.toList();
assert vertexList.size() == 1;
- LOG.info(">>>> query all persons in Taipei: " + vertexList);
+ LOG.info(">>>> query all persons in Taipei: {}", vertexList);
vertices = graph.traversal().V().hasLabel("person").has("age", 19);
vertexList = vertices.toList();
assert vertexList.size() == 1;
- LOG.info(">>>> query all persons age==19: " + vertexList);
+ LOG.info(">>>> query all persons age==19: {}", vertexList);
vertices = graph.traversal().V().hasLabel("person")
.has("age", P.lt(19));
vertexList = vertices.toList();
assert vertexList.size() == 1;
assert vertexList.get(0).property("age").value().equals(3);
- LOG.info(">>>> query all persons age<19: " + vertexList);
+ LOG.info(">>>> query all persons age<19: {}", vertexList);
String addr = "Bay Area";
vertices = graph.traversal().V().hasLabel("author")
.has("lived", Text.contains(addr));
vertexList = vertices.toList();
assert vertexList.size() == 1;
- LOG.info(String.format(">>>> query all authors lived %s: %s",
+ LOG.info(String.format(">>>> query all authors lived {}: {}",
Review Comment:
need to remove "String.format(" here
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example1.java:
##########
@@ -368,10 +370,10 @@ public static void testQuery(final HugeGraph graph) {
q.key(HugeKeys.PROPERTIES, contribution.id());
Iterator<Edge> edges3 = graph.edges(q);
assert edges3.hasNext();
- System.out.println(">>>> queryEdges(contribution): " +
+ LOG.info(">>>> queryEdges(contribution): {}",
Review Comment:
ditto
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example2.java:
##########
@@ -58,41 +58,41 @@ public static void traversal(final HugeGraph graph) {
GraphTraversalSource g = graph.traversal();
GraphTraversal<Vertex, Vertex> vertices = g.V();
- System.out.println(">>>> query all vertices: size=" +
+ LOG.info(">>>> query all vertices: size=" +
vertices.toList().size());
List<Edge> edges = g.E().toList();
- System.out.println(">>>> query all edges: size=" +
+ LOG.info(">>>> query all edges: size=" +
edges.size());
List<Object> names = g.V().inE("knows").limit(2)
.outV().values("name").toList();
- System.out.println(">>>> query vertex(with props) of edges: " + names);
+ LOG.info(">>>> query vertex(with props) of edges: " + names);
Review Comment:
can we also use "{}" style?
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example2.java:
##########
@@ -58,41 +58,41 @@ public static void traversal(final HugeGraph graph) {
GraphTraversalSource g = graph.traversal();
GraphTraversal<Vertex, Vertex> vertices = g.V();
- System.out.println(">>>> query all vertices: size=" +
+ LOG.info(">>>> query all vertices: size=" +
Review Comment:
can we also use "... size={}" style?
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example1.java:
##########
@@ -368,10 +370,10 @@ public static void testQuery(final HugeGraph graph) {
q.key(HugeKeys.PROPERTIES, contribution.id());
Iterator<Edge> edges3 = graph.edges(q);
assert edges3.hasNext();
- System.out.println(">>>> queryEdges(contribution): " +
+ LOG.info(">>>> queryEdges(contribution): {}",
edges3.hasNext());
while (edges3.hasNext()) {
- System.out.println(">>>> queryEdges(contribution): " +
+ LOG.info(">>>> queryEdges(contribution): {}",
Review Comment:
ditto
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example1.java:
##########
@@ -355,10 +357,10 @@ public static void testQuery(final HugeGraph graph) {
Iterator<Edge> edges2 = graph.edges(q);
assert edges2.hasNext();
- System.out.println(">>>> queryEdges(id-condition): " +
+ LOG.info(">>>> queryEdges(id-condition): {}",
edges2.hasNext());
while (edges2.hasNext()) {
- System.out.println(">>>> queryEdges(id-condition): " +
+ LOG.info(">>>> queryEdges(id-condition): {}",
Review Comment:
ditto
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example2.java:
##########
@@ -58,41 +58,41 @@ public static void traversal(final HugeGraph graph) {
GraphTraversalSource g = graph.traversal();
GraphTraversal<Vertex, Vertex> vertices = g.V();
- System.out.println(">>>> query all vertices: size=" +
+ LOG.info(">>>> query all vertices: size=" +
vertices.toList().size());
List<Edge> edges = g.E().toList();
- System.out.println(">>>> query all edges: size=" +
+ LOG.info(">>>> query all edges: size=" +
Review Comment:
ditto
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example1.java:
##########
@@ -355,10 +357,10 @@ public static void testQuery(final HugeGraph graph) {
Iterator<Edge> edges2 = graph.edges(q);
assert edges2.hasNext();
- System.out.println(">>>> queryEdges(id-condition): " +
+ LOG.info(">>>> queryEdges(id-condition): {}",
Review Comment:
ditto
##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example1.java:
##########
@@ -291,19 +293,19 @@ public static void testQuery(final HugeGraph graph) {
GraphTraversal<Vertex, Edge> edgesOfVertex = vertices.outE("created");
List<Edge> edgeList = edgesOfVertex.toList();
assert edgeList.size() == 1;
- System.out.println(">>>> query edges of vertex: " + edgeList);
+ LOG.info(">>>> query edges of vertex: {}", edgeList);
vertices = graph.traversal().V(authorId);
vertexList = vertices.out("created").toList();
assert vertexList.size() == 1;
- System.out.println(">>>> query vertices of vertex: " + vertexList);
+ LOG.info(">>>> query vertices of vertex: {}", vertexList);
// query edge by sort-values
vertices = graph.traversal().V(authorId);
edgesOfVertex = vertices.outE("write").has("time", "2017-4-28");
edgeList = edgesOfVertex.toList();
assert edgeList.size() == 2;
- System.out.println(">>>> query edges of vertex by sort-values: " +
+ LOG.info(">>>> query edges of vertex by sort-values: " +
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin merged pull request #1838: fix hugegraph-example/Example checkstyle issue
Posted by GitBox <gi...@apache.org>.
imbajin merged PR #1838:
URL: https://github.com/apache/incubator-hugegraph/pull/1838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org