You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2024/02/06 17:09:10 UTC
[I] continue in TabletGroupWatcher circumvents incrementing stats [accumulo]
keith-turner opened a new issue, #4233:
URL: https://github.com/apache/accumulo/issues/4233
This [continue](https://github.com/apache/accumulo/blob/b1cf91cc5cf02795ab720c9e47fbc5ab83aadc25/server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java#L556) in TabletGroupWatcher will prevent this [increment](https://github.com/apache/accumulo/blob/b1cf91cc5cf02795ab720c9e47fbc5ab83aadc25/server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java#L613). Not sure if this matters, need to determine if it does. Given the size of this method it may be best to refactor the code to remove the continue, its too easy to miss in code modifications.
Saw this in elasticity, did not look at earlier branches. If this is a bug and it exists in earlier branches then may need fix there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] continue in TabletGroupWatcher circumvents incrementing stats [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on issue #4233:
URL: https://github.com/apache/accumulo/issues/4233#issuecomment-1930446989
I think it will get missed when the exception is thrown for BAD_STATE. My guess is that those stats could be incremented right after state is set at https://github.com/apache/accumulo/blob/elasticity/server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java#L446. I don't think it's set after that point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] continue in TabletGroupWatcher circumvents incrementing stats [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion closed issue #4233: continue in TabletGroupWatcher circumvents incrementing stats
URL: https://github.com/apache/accumulo/issues/4233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] continue in TabletGroupWatcher circumvents incrementing stats [accumulo]
Posted by "ArbaazKhan1 (via GitHub)" <gi...@apache.org>.
ArbaazKhan1 commented on issue #4233:
URL: https://github.com/apache/accumulo/issues/4233#issuecomment-1930798102
I think [Issue#4087](https://github.com/apache/accumulo/issues/4087) might affect this ticket as well. I you follow the conditional, for [Continue](https://github.com/apache/accumulo/blob/b1cf91cc5cf02795ab720c9e47fbc5ab83aadc25/server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java#L556), down its line you end up at the class [RecoverPath](https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/manager/recovery/RecoveryPath.java) which I am working on removing/refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] continue in TabletGroupWatcher circumvents incrementing stats [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #4233:
URL: https://github.com/apache/accumulo/issues/4233#issuecomment-1930464006
> I think it will also get missed when the exception is thrown for BAD_STATE.
That is a good point. One thing I have not done is look at the bigger picture of what uses these stats and what does it mean if they are missed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org