[GitHub] [incubator-superset] rusackas commented on a change in pull request #11428: fix: Explore popovers issues

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #11428:
URL: https://github.com/apache/incubator-superset/pull/11428#discussion_r512173231



##########
File path: superset-frontend/src/explore/components/AdhocFilterOption.jsx
##########
@@ -60,16 +60,27 @@ class AdhocFilterOption extends React.PureComponent {
     // isNew is used to indicate whether to automatically open the overlay
     // once the overlay has been opened, the metric/filter will never be
     // considered new again.
-    this.props.adhocFilter.isNew = false;
     this.setState({ overlayShown: true });
   }
 
   onOverlayExited() {
     this.setState({ overlayShown: false });
   }
 
-  closeFilterEditOverlay() {
-    this.setState({ overlayShown: false });
+  getContent() {
+    const { adhocFilter } = this.props;
+    adhocFilter.isNew = false;
+    return (
+      <AdhocFilterEditPopover
+        onResize={this.onPopoverResize}
+        adhocFilter={adhocFilter}
+        onChange={this.props.onFilterEdit}
+        onClose={this.onOverlayExited}
+        options={this.props.options}

Review comment:
       NIT: Seems like we might as well destructure these other props above, for consistency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org