You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2019/03/29 16:21:00 UTC
[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12893
Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04
......................................................................
IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04
Tweak bin/bootstrap_system.sh to automate the preparation of
an Impala development environment on Ubuntu 18.04.
The following changes were required:
- extend the OS recognition logic to Ubuntu 18.04
- add 'ant' to the list of onstalled packages
- request OpenJDK 8 as the default Java environment (Ubuntu 18.04
defaults to OpenJDK 11)
These changes enable bootstratp_system.sh to set up an Impala development
environment where Impala can be successfully built.
Note that the patch does not attempt to pass the tests yet; this change
prepares only the environment. Bugs specific to Ubuntu 18 will be fixed
by follow-up commits.
Tested in the following environments:
- in a Docker container, using
"docker/test-with-docker.py --base-image:ubuntu:18.04"
- on an AWS EC2 m5.4xlarge instance
Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f
---
M bin/bootstrap_system.sh
1 file changed, 40 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/12893/1
--
To view, visit http://gerrit.cloudera.org:8080/12893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f
Gerrit-Change-Number: 12893
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12893 )
Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2591/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f
Gerrit-Change-Number: 12893
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 17:06:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12893
to look at the new patch set (#2).
Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04
......................................................................
IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04
Tweak bin/bootstrap_system.sh to automate the preparation of
an Impala development environment on Ubuntu 18.04.
The following changes were required:
- extend the OS recognition logic to Ubuntu 18.04
- add 'ant' to the list of installed packages
- request OpenJDK 8 as the default Java environment (Ubuntu 18.04
defaults to OpenJDK 11)
These changes enable bootstrap_system.sh to set up an Impala development
environment where Impala can be successfully built.
Note that the patch does not attempt to pass the tests yet; this change
prepares only the environment. Bugs specific to Ubuntu 18 will be fixed
by follow-up commits.
Tested in the following environments:
- in a Docker container, using
"docker/test-with-docker.py --base-image:ubuntu:18.04"
- on an AWS EC2 m5.4xlarge instance
Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f
---
M bin/bootstrap_system.sh
1 file changed, 40 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/12893/2
--
To view, visit http://gerrit.cloudera.org:8080/12893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f
Gerrit-Change-Number: 12893
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12893 )
Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04
......................................................................
IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04
Tweak bin/bootstrap_system.sh to automate the preparation of
an Impala development environment on Ubuntu 18.04.
The following changes were required:
- extend the OS recognition logic to Ubuntu 18.04
- add 'ant' to the list of installed packages
- request OpenJDK 8 as the default Java environment (Ubuntu 18.04
defaults to OpenJDK 11)
These changes enable bootstrap_system.sh to set up an Impala development
environment where Impala can be successfully built.
Note that the patch does not attempt to pass the tests yet; this change
prepares only the environment. Bugs specific to Ubuntu 18 will be fixed
by follow-up commits.
Tested in the following environments:
- in a Docker container, using
"docker/test-with-docker.py --base-image:ubuntu:18.04"
- on an AWS EC2 m5.4xlarge instance
Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f
Reviewed-on: http://gerrit.cloudera.org:8080/12893
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_system.sh
1 file changed, 40 insertions(+), 10 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f
Gerrit-Change-Number: 12893
Gerrit-PatchSet: 5
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12893 )
Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f
Gerrit-Change-Number: 12893
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Apr 2019 23:42:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12893 )
Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f
Gerrit-Change-Number: 12893
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Apr 2019 19:01:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12893 )
Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12893/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12893/1//COMMIT_MSG@13
PS1, Line 13: - add 'ant' to the list of installed packages
> typo: installed
Done
http://gerrit.cloudera.org:8080/#/c/12893/1//COMMIT_MSG@17
PS1, Line 17: These changes enable bootstrap_system.sh to set up an Impala development
> typo: bootstrap
Done
--
To view, visit http://gerrit.cloudera.org:8080/12893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f
Gerrit-Change-Number: 12893
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Sat, 30 Mar 2019 22:24:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12893 )
Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
LGTM
http://gerrit.cloudera.org:8080/#/c/12893/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12893/1//COMMIT_MSG@13
PS1, Line 13: - add 'ant' to the list of onstalled packages
typo: installed
http://gerrit.cloudera.org:8080/#/c/12893/1//COMMIT_MSG@17
PS1, Line 17: These changes enable bootstratp_system.sh to set up an Impala development
typo: bootstrap
--
To view, visit http://gerrit.cloudera.org:8080/12893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f
Gerrit-Change-Number: 12893
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 30 Mar 2019 00:01:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12893 )
Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Thanks for doing this! I think it gets started setting up new Impala developers so they won't have to install a 3-year old Ubuntu version.
http://gerrit.cloudera.org:8080/#/c/12893/3/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:
http://gerrit.cloudera.org:8080/#/c/12893/3/bin/bootstrap_system.sh@107
PS3, Line 107: echo "This script only supports 16.04 or 18.04 of Ubuntu" >&2
nit: "... only supports Ubuntu 16.04 or 18.04"
--
To view, visit http://gerrit.cloudera.org:8080/12893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f
Gerrit-Change-Number: 12893
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Sat, 30 Mar 2019 23:09:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12893 )
Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3974/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f
Gerrit-Change-Number: 12893
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Apr 2019 19:01:30 +0000
Gerrit-HasComments: No