[GitHub] [arrow] jonkeane commented on a change in pull request #9999: ARROW-11755: [R] Add tests from dplyr/test-mutate.r

[GitBox <gi...@apache.org>]

jonkeane commented on a change in pull request #9999:
URL: https://github.com/apache/arrow/pull/9999#discussion_r626080217



##########
File path: r/tests/testthat/test-dplyr-mutate.R
##########
@@ -32,59 +47,23 @@ test_that("mutate() is lazy", {
   )
 })
 
-test_that("basic mutate", {
-  expect_dplyr_equal(
-    input %>%
-      select(int, chr) %>%
-      filter(int > 5) %>%
-      mutate(int = int + 6L) %>%
-      collect(),
-    tbl
-  )
-})
-
-test_that("mutate() with NULL inputs", {
-  expect_dplyr_equal(
-    input %>%
-      mutate(int = NULL) %>%
-      collect(),
-    tbl
-  )
-})
+# similar to https://github.com/tidyverse/dplyr/blob/master/tests/testthat/test-mutate.r#L1-L10

Review comment:
       I don't think you addressed the second point Ian made here. You can get a permanent link like Ian mentions and use the current commit hash in the URL. One easy way to do this is to use "copy permalink" on the three dots menu when you click next to the line number in the github UI




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org