You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/09 14:18:14 UTC

[GitHub] [arrow] HedgehogCode commented on pull request #8363: ARROW-10174: [Java] Fix reading/writing dict structs

HedgehogCode commented on pull request #8363:
URL: https://github.com/apache/arrow/pull/8363#issuecomment-706193122


   I implemented the changes and force pushed them.
   
   Thank you for the advice with the `RangeEqualsVisitor`. Using it I discovered another bug in `DictionaryUtility`. The field for the Dictionary was always created with `nullable=false` but this is incorrect because dictionaries can be nullable. Therefore, I replaced this with the nullability read from the schema.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org