You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/16 18:38:48 UTC

[GitHub] [arrow] westonpace commented on a change in pull request #10118: ARROW-12468: Expose ScannerBuilder::UseAsync to python & R

westonpace commented on a change in pull request #10118:
URL: https://github.com/apache/arrow/pull/10118#discussion_r633123955



##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -2746,6 +2746,10 @@ cdef class Scanner(_Weakrefable):
     use_threads : bool, default True
         If enabled, then maximum parallelism will be used determined by
         the number of available CPU cores.
+    use_async : bool, default False
+        If enabled, the an async scanner will be used that should offer
+        better performance with high-latency/highly-parallel filesystems
+        (e.g. S3)

Review comment:
       I updated all the tests so that they are parameterized on use_threads/use_async.  This helped identify the spots in _populate_builder, etc. where I had missed passing the flag through.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org