You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/15 10:43:34 UTC

[GitHub] [apisix] liuxiran commented on pull request #2421: feat:limit-count plugin supports consumer name field

liuxiran commented on pull request #2421:
URL: https://github.com/apache/apisix/pull/2421#issuecomment-709148517


   > Looks good to me from codes style and schema structure, but not sure if this key is needed.
   
   LGTM， I also think the key: consumer_name is useful to limit the api count at the user level, and it is also a key supported by the plugin. 
   
   cc @membphis any  thoughts on this :) ? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org