You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Michael Mior <mm...@apache.org> on 2018/06/28 16:48:37 UTC
Re: [DISCUSS] Towards Calcite 1.17.0
Just wanted to check in with how we're doing with progress towards a
release. It's not a rush at all, but I'm preparing the board report for
July and wondering if I should wait to include the 1.17.0 release. It
sounds like there are a few other things that still need to be wrapped up,
so I'm fine if we don't release for another couple weeks.
Thanks again Volodymyr for taking this on!
--
Michael Mior
mmior@apache.org
Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <vo...@apache.org> a
écrit :
> Calcite 1.16.0 was released on March 19 (more than two months ago).
> We have solved over 48 issues[1] since then, therefore we should start
> discussing about releasing Calcite 1.17.0.
>
> I have created [2] to track the release.
>
> We will start a release process after the Avatica 1.12 is released.
>
> I went through the list of opened PRs during the last month, and here is
> the list of Jiras which possibly be merged before the release:
>
> CALCITE-2303: Support DECADE time unit in EXTRACT function - changes are
> done, depends on the Avatica release
> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN operator with the
> constant from the left side more optimally - I will make required changes
> at the beginning of next week
>
> * CALCITE-2321: Support ragged fixed length value union be variable -
> In review (Julian)*
>
> * CALCITE-2291: Add rule to push Project past Correlate - I will pick up
> this next week*
>
> List of other pull requests which require review or additional rework:
>
> CALCITE-2327: In 3 valued logic mode (b and not b) may not be simplified to
> false
> CALCITE-2302 / CALCITE-2325: Implicit type cast support - Julian added a
> comment into the Jira
> CALCITE-2331: evaluation of predicate (A or B) and C is failing for some
> adapters - created PR only with a test for this Jira
> CALCITE-2209: Support loading JSON model file through URL - Shuyi Chen
> added a comment into the Jira
> CALCITE-2324: Extract seconds, minutes from date works not correct in some
> cases
> CALCITE-2319: Druid Expressions - Output Type of Boolean expressions should
> be set to FLOAT.
> CALCITE-500: Ensure EnumerableJoin hashes the smallest input - PR is
> created
> CALCITE-2301: Remove the 10-second-timeout restriction in
> ResultSetEnumerable - needs additional rework.
>
> Please let me know, if there are any Jiras should be included into this
> release.
>
> [1]
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> [2] https://issues.apache.org/jira/browse/CALCITE-2337
>
> Kind regards,
> Volodymyr Vysotskyi
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Volodymyr Vysotskyi <vo...@apache.org>.
Hello Stamatis,
Do you have ETA for the fix for this Jira?
If it will be solved in the next couple of days, we can include it to 1.17.
Kind regards,
Volodymyr Vysotskyi
ср, 11 лип. 2018 о 13:30 Stamatis Zampetakis <za...@gmail.com> пише:
> Hello,
>
> I would like to bring your attention towards a new issue namely
> https://issues.apache.org/jira/browse/CALCITE-2404 concerning access on
> structured types.
> Basically, any query involving fields of Record type cannot be executed by
> the runtime (in Enumerable/Bindable convention).
>
> At least for me, it appears as an important issue that it would be good if
> it can be resolved before the next release. Now, I leave the decision up to
> you.
>
> Best,
> Stamatis
>
> 2018-07-11 11:39 GMT+02:00 Volodymyr Vysotskyi <vo...@apache.org>:
>
> > Both blocking the release issues were fixed
> > and almost all "nice to have" fixes from the list were merged
> > into the master, thanks a lot for this to everyone!
> >
> > Regarding PRs which may be included into the release,
> > looks like work for CALCITE-2366
> > <https://issues.apache.org/jira/browse/CALCITE-2366> is finished.
> >
> > Are there other PRs which may be merged before starting
> > the release process or new blocking issues?
> >
> > Kind regards,
> > Volodymyr Vysotskyi
> >
> >
> > пт, 6 лип. 2018 о 17:58 Andrei Sereda <an...@sereda.cc> пише:
> >
> > > I have created PR-753 <https://github.com/apache/calcite/pull/753> for
> > > CALCITE-2331. Please note it fixes only ES adapter (mongo is also
> > > affected).
> > >
> > > On Thu, Jun 28, 2018 at 1:54 PM Michael Mior <mm...@apache.org> wrote:
> > >
> > > > I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is
> > > > working on a PR and this would be a good bug to have fixed.
> > > >
> > > > * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
> > > > predicate (A or B) and C is failing for some adapters
> > > >
> > > > --
> > > > Michael Mior
> > > > mmior@apache.org
> > > >
> > > >
> > > >
> > > > Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a
> écrit :
> > > >
> > > > > To answer Michael's question: I don't think we should delay the
> > > > > report, nor should we hurry the release. It's fair to say that 1.17
> > is
> > > > > in its final stages. There was a lot of activity on avatica-1.12
> from
> > > > > a lot of individuals, and the community is in great shape.
> > > > >
> > > > > Here are the cases listed by Volodymyr, converted into links:
> > > > >
> > > > > Must:
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2384 Performance
> > issue
> > > > > in getPulledUpPredicates - Zoltan
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
> > Avatica -
> > > > > Julian
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT -
> > Julian
> > > > >
> > > > > Nice:
> > > > > * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
> > MongoDB
> > > > > - Volodymyr
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax
> -
> > > > Kevin
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2280 Babel -
> Julian
> > > > > (blocked by 2259)
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
> > > > > timestamps - Julian to review
> > > > >
> > > > > Julian
> > > > >
> > > > >
> > > > > On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> > > > > <vo...@apache.org> wrote:
> > > > > > Hi Michael,
> > > > > >
> > > > > > There are several Jiras, which I think are blockers for the
> > > > > > release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
> > CALCITE-2303.
> > > > > > Also, there is a list of the Jiras, which would be good to
> include
> > to
> > > > > > 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> > > > > >
> > > > > > So I think we need at least couple of weeks to resolve these
> issues
> > > and
> > > > > > release 1.17.
> > > > > >
> > > > > > Also, please let me know if there are other issues-blockers for
> the
> > > > > > release, or if some of these issues may be omitted.
> > > > > >
> > > > > > Kind regards,
> > > > > > Volodymyr Vysotskyi
> > > > > >
> > > > > >
> > > > > > чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com>
> > > пише:
> > > > > >
> > > > > >> It also would be great to have at least a BETA version of Babel
> > > parser
> > > > > >>
> > > > > >> Enrico
> > > > > >>
> > > > > >> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
> > > scritto:
> > > > > >>
> > > > > >> > Just wanted to check in with how we're doing with progress
> > > towards a
> > > > > >> > release. It's not a rush at all, but I'm preparing the board
> > > report
> > > > > for
> > > > > >> > July and wondering if I should wait to include the 1.17.0
> > release.
> > > > It
> > > > > >> > sounds like there are a few other things that still need to be
> > > > wrapped
> > > > > >> up,
> > > > > >> > so I'm fine if we don't release for another couple weeks.
> > > > > >> >
> > > > > >> > Thanks again Volodymyr for taking this on!
> > > > > >> >
> > > > > >> > --
> > > > > >> > Michael Mior
> > > > > >> > mmior@apache.org
> > > > > >> >
> > > > > >> >
> > > > > >> >
> > > > > >> > Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> > > > > volodymyr@apache.org>
> > > > > >> a
> > > > > >> > écrit :
> > > > > >> >
> > > > > >> > > Calcite 1.16.0 was released on March 19 (more than two
> months
> > > > ago).
> > > > > >> > > We have solved over 48 issues[1] since then, therefore we
> > should
> > > > > start
> > > > > >> > > discussing about releasing Calcite 1.17.0.
> > > > > >> > >
> > > > > >> > > I have created [2] to track the release.
> > > > > >> > >
> > > > > >> > > We will start a release process after the Avatica 1.12 is
> > > > released.
> > > > > >> > >
> > > > > >> > > I went through the list of opened PRs during the last month,
> > and
> > > > > here
> > > > > >> is
> > > > > >> > > the list of Jiras which possibly be merged before the
> release:
> > > > > >> > >
> > > > > >> > > CALCITE-2303: Support DECADE time unit in EXTRACT function -
> > > > changes
> > > > > >> are
> > > > > >> > > done, depends on the Avatica release
> > > > > >> > > CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
> > operator
> > > > with
> > > > > >> the
> > > > > >> > > constant from the left side more optimally - I will make
> > > required
> > > > > >> changes
> > > > > >> > > at the beginning of next week
> > > > > >> > >
> > > > > >> > > * CALCITE-2321: Support ragged fixed length value union be
> > > > variable
> > > > > -
> > > > > >> > > In review (Julian)*
> > > > > >> > >
> > > > > >> > > * CALCITE-2291: Add rule to push Project past Correlate - I
> > will
> > > > > pick
> > > > > >> up
> > > > > >> > > this next week*
> > > > > >> > >
> > > > > >> > > List of other pull requests which require review or
> additional
> > > > > rework:
> > > > > >> > >
> > > > > >> > > CALCITE-2327: In 3 valued logic mode (b and not b) may not
> be
> > > > > >> simplified
> > > > > >> > to
> > > > > >> > > false
> > > > > >> > > CALCITE-2302 / CALCITE-2325: Implicit type cast support -
> > Julian
> > > > > added
> > > > > >> a
> > > > > >> > > comment into the Jira
> > > > > >> > > CALCITE-2331: evaluation of predicate (A or B) and C is
> > failing
> > > > for
> > > > > >> some
> > > > > >> > > adapters - created PR only with a test for this Jira
> > > > > >> > > CALCITE-2209: Support loading JSON model file through URL -
> > > Shuyi
> > > > > Chen
> > > > > >> > > added a comment into the Jira
> > > > > >> > > CALCITE-2324: Extract seconds, minutes from date works not
> > > correct
> > > > > in
> > > > > >> > some
> > > > > >> > > cases
> > > > > >> > > CALCITE-2319: Druid Expressions - Output Type of Boolean
> > > > expressions
> > > > > >> > should
> > > > > >> > > be set to FLOAT.
> > > > > >> > > CALCITE-500: Ensure EnumerableJoin hashes the smallest
> input -
> > > PR
> > > > is
> > > > > >> > > created
> > > > > >> > > CALCITE-2301: Remove the 10-second-timeout restriction in
> > > > > >> > > ResultSetEnumerable - needs additional rework.
> > > > > >> > >
> > > > > >> > > Please let me know, if there are any Jiras should be
> included
> > > into
> > > > > this
> > > > > >> > > release.
> > > > > >> > >
> > > > > >> > > [1]
> > > > > >> > >
> > > > > >> > >
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > > https://issues.apache.org/jira/issues/?jql=project%20%
> > 3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%
> > 20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> > > > > >> > > [2] https://issues.apache.org/jira/browse/CALCITE-2337
> > > > > >> > >
> > > > > >> > > Kind regards,
> > > > > >> > > Volodymyr Vysotskyi
> > > > > >> > >
> > > > > >> >
> > > > > >> --
> > > > > >>
> > > > > >>
> > > > > >> -- Enrico Olivelli
> > > > > >>
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Volodymyr Vysotskyi <vo...@apache.org>.
Sorry, missed timezone: 14 Jun, 6:00 AM UTC
Kind regards,
Volodymyr Vysotskyi
пт, 13 лип. 2018 о 17:03 Volodymyr Vysotskyi <vo...@apache.org> пише:
> Hi all,
>
> I think the next Monday (Jun, 16) is a good time for publishing
> the RC for Apache Calcite, therefore if there any PRs
> which should be included in this release, please merge them before 14
> Jun, 6:00 AM
> to reserve some time for additional checks and testing.
>
> I'll take care of CALCITE-2409
> <https://issues.apache.org/jira/browse/CALCITE-2409>.
>
> Kind regards,
> Volodymyr Vysotskyi
>
>
> чт, 12 лип. 2018 о 00:53 Stamatis Zampetakis <za...@gmail.com> пише:
>
>> Hi Volodymyr,
>>
>> I hope to be done with
>> https://issues.apache.org/jira/browse/CALCITE-2404 before
>> the end of next week.
>> Personally, I don't mind if it does not make it to this release since for
>> my use-case I can patch the code directly.
>>
>> Best,
>> Stamatis
>>
>> 2018-07-11 17:13 GMT+02:00 Julian Hyde <jh...@gmail.com>:
>>
>> > I think this release train has waited long enough. We should wait for
>> > issues that people are fixing themselves, within the next 24 hours. And
>> > review PRs that have already been submitted.
>> >
>> > We release regularly, so there will be another train in a couple of
>> months.
>> >
>> > Julian
>> >
>> > > On Jul 11, 2018, at 07:34, Andrei Sereda <an...@sereda.cc> wrote:
>> > >
>> > > Hello,
>> > >
>> > > If people on this list don't mind, I would like to finish two more
>> issues
>> > > for ES adapter:
>> > > 1) CALCITE-2408 enable aggregate functions in ES adapter
>> > > 2) CALCITE-2411 expose a table for each ES index (by default) - this
>> was
>> > > discussed <https://markmail.org/thread/jryg6ptmu26krezp> on dev list
>> > last
>> > > week.
>> > >
>> > > They should be done next week.
>> > > Regards,
>> > > Andrei.
>> > >
>> > >> On Wed, Jul 11, 2018 at 7:00 AM Michael Mior <mm...@uwaterloo.ca>
>> > wrote:
>> > >>
>> > >> It would be good if someone else could also have a look at the PR
>> > >> below for CALCITE-2331 as it's basically ready to merge pending a
>> > >> decision on a behaviour change.
>> > >>
>> > >> https://github.com/apache/calcite/pull/755
>> > >>
>> > >> --
>> > >> Michael Mior
>> > >> mmior@uwaterloo.ca
>> > >>
>> > >> Le mer. 11 juil. 2018 à 06:30, Stamatis Zampetakis <
>> zabetak@gmail.com>
>> > a
>> > >> écrit :
>> > >>>
>> > >>> Hello,
>> > >>>
>> > >>> I would like to bring your attention towards a new issue namely
>> > >>> https://issues.apache.org/jira/browse/CALCITE-2404 concerning
>> access
>> > on
>> > >>> structured types.
>> > >>> Basically, any query involving fields of Record type cannot be
>> executed
>> > >> by
>> > >>> the runtime (in Enumerable/Bindable convention).
>> > >>>
>> > >>> At least for me, it appears as an important issue that it would be
>> good
>> > >> if
>> > >>> it can be resolved before the next release. Now, I leave the
>> decision
>> > up
>> > >> to
>> > >>> you.
>> > >>>
>> > >>> Best,
>> > >>> Stamatis
>> > >>>
>> > >>> 2018-07-11 11:39 GMT+02:00 Volodymyr Vysotskyi <
>> volodymyr@apache.org>:
>> > >>>
>> > >>>> Both blocking the release issues were fixed
>> > >>>> and almost all "nice to have" fixes from the list were merged
>> > >>>> into the master, thanks a lot for this to everyone!
>> > >>>>
>> > >>>> Regarding PRs which may be included into the release,
>> > >>>> looks like work for CALCITE-2366
>> > >>>> <https://issues.apache.org/jira/browse/CALCITE-2366> is finished.
>> > >>>>
>> > >>>> Are there other PRs which may be merged before starting
>> > >>>> the release process or new blocking issues?
>> > >>>>
>> > >>>> Kind regards,
>> > >>>> Volodymyr Vysotskyi
>> > >>>>
>> > >>>>
>> > >>>> пт, 6 лип. 2018 о 17:58 Andrei Sereda <an...@sereda.cc> пише:
>> > >>>>
>> > >>>>> I have created PR-753 <https://github.com/apache/calcite/pull/753
>> >
>> > >> for
>> > >>>>> CALCITE-2331. Please note it fixes only ES adapter (mongo is also
>> > >>>>> affected).
>> > >>>>>
>> > >>>>> On Thu, Jun 28, 2018 at 1:54 PM Michael Mior <mm...@apache.org>
>> > >> wrote:
>> > >>>>>
>> > >>>>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe
>> Andrei
>> > >> is
>> > >>>>>> working on a PR and this would be a good bug to have fixed.
>> > >>>>>>
>> > >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation
>> of
>> > >>>>>> predicate (A or B) and C is failing for some adapters
>> > >>>>>>
>> > >>>>>> --
>> > >>>>>> Michael Mior
>> > >>>>>> mmior@apache.org
>> > >>>>>>
>> > >>>>>>
>> > >>>>>>
>> > >>>>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a
>> > >> écrit :
>> > >>>>>>
>> > >>>>>>> To answer Michael's question: I don't think we should delay the
>> > >>>>>>> report, nor should we hurry the release. It's fair to say that
>> > >> 1.17
>> > >>>> is
>> > >>>>>>> in its final stages. There was a lot of activity on avatica-1.12
>> > >> from
>> > >>>>>>> a lot of individuals, and the community is in great shape.
>> > >>>>>>>
>> > >>>>>>> Here are the cases listed by Volodymyr, converted into links:
>> > >>>>>>>
>> > >>>>>>> Must:
>> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
>> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2384
>> Performance
>> > >>>> issue
>> > >>>>>>> in getPulledUpPredicates - Zoltan
>> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
>> > >>>> Avatica -
>> > >>>>>>> Julian
>> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT -
>> > >>>> Julian
>> > >>>>>>>
>> > >>>>>>> Nice:
>> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
>> > >>>> MongoDB
>> > >>>>>>> - Volodymyr
>> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8
>> > >> syntax -
>> > >>>>>> Kevin
>> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel -
>> > >> Julian
>> > >>>>>>> (blocked by 2259)
>> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC
>> > >> adapter
>> > >>>>>>> timestamps - Julian to review
>> > >>>>>>>
>> > >>>>>>> Julian
>> > >>>>>>>
>> > >>>>>>>
>> > >>>>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
>> > >>>>>>> <vo...@apache.org> wrote:
>> > >>>>>>>> Hi Michael,
>> > >>>>>>>>
>> > >>>>>>>> There are several Jiras, which I think are blockers for the
>> > >>>>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
>> > >>>> CALCITE-2303.
>> > >>>>>>>> Also, there is a list of the Jiras, which would be good to
>> > >> include
>> > >>>> to
>> > >>>>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
>> > >>>>>>>>
>> > >>>>>>>> So I think we need at least couple of weeks to resolve these
>> > >> issues
>> > >>>>> and
>> > >>>>>>>> release 1.17.
>> > >>>>>>>>
>> > >>>>>>>> Also, please let me know if there are other issues-blockers
>> > >> for the
>> > >>>>>>>> release, or if some of these issues may be omitted.
>> > >>>>>>>>
>> > >>>>>>>> Kind regards,
>> > >>>>>>>> Volodymyr Vysotskyi
>> > >>>>>>>>
>> > >>>>>>>>
>> > >>>>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eolivelli@gmail.com
>> > >>>
>> > >>>>> пише:
>> > >>>>>>>>
>> > >>>>>>>>> It also would be great to have at least a BETA version of
>> > >> Babel
>> > >>>>> parser
>> > >>>>>>>>>
>> > >>>>>>>>> Enrico
>> > >>>>>>>>>
>> > >>>>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
>> > >>>>> scritto:
>> > >>>>>>>>>
>> > >>>>>>>>>> Just wanted to check in with how we're doing with progress
>> > >>>>> towards a
>> > >>>>>>>>>> release. It's not a rush at all, but I'm preparing the board
>> > >>>>> report
>> > >>>>>>> for
>> > >>>>>>>>>> July and wondering if I should wait to include the 1.17.0
>> > >>>> release.
>> > >>>>>> It
>> > >>>>>>>>>> sounds like there are a few other things that still need to
>> > >> be
>> > >>>>>> wrapped
>> > >>>>>>>>> up,
>> > >>>>>>>>>> so I'm fine if we don't release for another couple weeks.
>> > >>>>>>>>>>
>> > >>>>>>>>>> Thanks again Volodymyr for taking this on!
>> > >>>>>>>>>>
>> > >>>>>>>>>> --
>> > >>>>>>>>>> Michael Mior
>> > >>>>>>>>>> mmior@apache.org
>> > >>>>>>>>>>
>> > >>>>>>>>>>
>> > >>>>>>>>>>
>> > >>>>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
>> > >>>>>>> volodymyr@apache.org>
>> > >>>>>>>>> a
>> > >>>>>>>>>> écrit :
>> > >>>>>>>>>>
>> > >>>>>>>>>>> Calcite 1.16.0 was released on March 19 (more than two
>> > >> months
>> > >>>>>> ago).
>> > >>>>>>>>>>> We have solved over 48 issues[1] since then, therefore we
>> > >>>> should
>> > >>>>>>> start
>> > >>>>>>>>>>> discussing about releasing Calcite 1.17.0.
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> I have created [2] to track the release.
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> We will start a release process after the Avatica 1.12 is
>> > >>>>>> released.
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> I went through the list of opened PRs during the last
>> > >> month,
>> > >>>> and
>> > >>>>>>> here
>> > >>>>>>>>> is
>> > >>>>>>>>>>> the list of Jiras which possibly be merged before the
>> > >> release:
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT
>> > >> function -
>> > >>>>>> changes
>> > >>>>>>>>> are
>> > >>>>>>>>>>> done, depends on the Avatica release
>> > >>>>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
>> > >>>> operator
>> > >>>>>> with
>> > >>>>>>>>> the
>> > >>>>>>>>>>> constant from the left side more optimally - I will make
>> > >>>>> required
>> > >>>>>>>>> changes
>> > >>>>>>>>>>> at the beginning of next week
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> * CALCITE-2321: Support ragged fixed length value union be
>> > >>>>>> variable
>> > >>>>>>> -
>> > >>>>>>>>>>> In review (Julian)*
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate -
>> > >> I
>> > >>>> will
>> > >>>>>>> pick
>> > >>>>>>>>> up
>> > >>>>>>>>>>> this next week*
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> List of other pull requests which require review or
>> > >> additional
>> > >>>>>>> rework:
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may
>> > >> not be
>> > >>>>>>>>> simplified
>> > >>>>>>>>>> to
>> > >>>>>>>>>>> false
>> > >>>>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support -
>> > >>>> Julian
>> > >>>>>>> added
>> > >>>>>>>>> a
>> > >>>>>>>>>>> comment into the Jira
>> > >>>>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is
>> > >>>> failing
>> > >>>>>> for
>> > >>>>>>>>> some
>> > >>>>>>>>>>> adapters - created PR only with a test for this Jira
>> > >>>>>>>>>>> CALCITE-2209: Support loading JSON model file through URL
>> > >> -
>> > >>>>> Shuyi
>> > >>>>>>> Chen
>> > >>>>>>>>>>> added a comment into the Jira
>> > >>>>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works not
>> > >>>>> correct
>> > >>>>>>> in
>> > >>>>>>>>>> some
>> > >>>>>>>>>>> cases
>> > >>>>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean
>> > >>>>>> expressions
>> > >>>>>>>>>> should
>> > >>>>>>>>>>> be set to FLOAT.
>> > >>>>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest
>> > >> input -
>> > >>>>> PR
>> > >>>>>> is
>> > >>>>>>>>>>> created
>> > >>>>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
>> > >>>>>>>>>>> ResultSetEnumerable - needs additional rework.
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> Please let me know, if there are any Jiras should be
>> > >> included
>> > >>>>> into
>> > >>>>>>> this
>> > >>>>>>>>>>> release.
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> [1]
>> > >>>>>>>>>>>
>> > >>>>>>>>>>>
>> > >>>>>>>>>>
>> > >>>>>>>>>
>> > >>>>>>>
>> > >>>>>>
>> > >>>>> https://issues.apache.org/jira/issues/?jql=project%20%
>> > >>>> 3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%
>> > >>>> 20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
>> > >>>>>>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> Kind regards,
>> > >>>>>>>>>>> Volodymyr Vysotskyi
>> > >>>>>>>>>>>
>> > >>>>>>>>>>
>> > >>>>>>>>> --
>> > >>>>>>>>>
>> > >>>>>>>>>
>> > >>>>>>>>> -- Enrico Olivelli
>> > >>>>>>>>>
>> > >>>>>>>
>> > >>>>>>
>> > >>>>>
>> > >>>>
>> > >>
>> >
>>
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Volodymyr Vysotskyi <vo...@apache.org>.
Hi all,
I think the next Monday (Jun, 16) is a good time for publishing
the RC for Apache Calcite, therefore if there any PRs
which should be included in this release, please merge them before 14 Jun,
6:00 AM
to reserve some time for additional checks and testing.
I'll take care of CALCITE-2409
<https://issues.apache.org/jira/browse/CALCITE-2409>.
Kind regards,
Volodymyr Vysotskyi
чт, 12 лип. 2018 о 00:53 Stamatis Zampetakis <za...@gmail.com> пише:
> Hi Volodymyr,
>
> I hope to be done with
> https://issues.apache.org/jira/browse/CALCITE-2404 before
> the end of next week.
> Personally, I don't mind if it does not make it to this release since for
> my use-case I can patch the code directly.
>
> Best,
> Stamatis
>
> 2018-07-11 17:13 GMT+02:00 Julian Hyde <jh...@gmail.com>:
>
> > I think this release train has waited long enough. We should wait for
> > issues that people are fixing themselves, within the next 24 hours. And
> > review PRs that have already been submitted.
> >
> > We release regularly, so there will be another train in a couple of
> months.
> >
> > Julian
> >
> > > On Jul 11, 2018, at 07:34, Andrei Sereda <an...@sereda.cc> wrote:
> > >
> > > Hello,
> > >
> > > If people on this list don't mind, I would like to finish two more
> issues
> > > for ES adapter:
> > > 1) CALCITE-2408 enable aggregate functions in ES adapter
> > > 2) CALCITE-2411 expose a table for each ES index (by default) - this
> was
> > > discussed <https://markmail.org/thread/jryg6ptmu26krezp> on dev list
> > last
> > > week.
> > >
> > > They should be done next week.
> > > Regards,
> > > Andrei.
> > >
> > >> On Wed, Jul 11, 2018 at 7:00 AM Michael Mior <mm...@uwaterloo.ca>
> > wrote:
> > >>
> > >> It would be good if someone else could also have a look at the PR
> > >> below for CALCITE-2331 as it's basically ready to merge pending a
> > >> decision on a behaviour change.
> > >>
> > >> https://github.com/apache/calcite/pull/755
> > >>
> > >> --
> > >> Michael Mior
> > >> mmior@uwaterloo.ca
> > >>
> > >> Le mer. 11 juil. 2018 à 06:30, Stamatis Zampetakis <zabetak@gmail.com
> >
> > a
> > >> écrit :
> > >>>
> > >>> Hello,
> > >>>
> > >>> I would like to bring your attention towards a new issue namely
> > >>> https://issues.apache.org/jira/browse/CALCITE-2404 concerning access
> > on
> > >>> structured types.
> > >>> Basically, any query involving fields of Record type cannot be
> executed
> > >> by
> > >>> the runtime (in Enumerable/Bindable convention).
> > >>>
> > >>> At least for me, it appears as an important issue that it would be
> good
> > >> if
> > >>> it can be resolved before the next release. Now, I leave the decision
> > up
> > >> to
> > >>> you.
> > >>>
> > >>> Best,
> > >>> Stamatis
> > >>>
> > >>> 2018-07-11 11:39 GMT+02:00 Volodymyr Vysotskyi <volodymyr@apache.org
> >:
> > >>>
> > >>>> Both blocking the release issues were fixed
> > >>>> and almost all "nice to have" fixes from the list were merged
> > >>>> into the master, thanks a lot for this to everyone!
> > >>>>
> > >>>> Regarding PRs which may be included into the release,
> > >>>> looks like work for CALCITE-2366
> > >>>> <https://issues.apache.org/jira/browse/CALCITE-2366> is finished.
> > >>>>
> > >>>> Are there other PRs which may be merged before starting
> > >>>> the release process or new blocking issues?
> > >>>>
> > >>>> Kind regards,
> > >>>> Volodymyr Vysotskyi
> > >>>>
> > >>>>
> > >>>> пт, 6 лип. 2018 о 17:58 Andrei Sereda <an...@sereda.cc> пише:
> > >>>>
> > >>>>> I have created PR-753 <https://github.com/apache/calcite/pull/753>
> > >> for
> > >>>>> CALCITE-2331. Please note it fixes only ES adapter (mongo is also
> > >>>>> affected).
> > >>>>>
> > >>>>> On Thu, Jun 28, 2018 at 1:54 PM Michael Mior <mm...@apache.org>
> > >> wrote:
> > >>>>>
> > >>>>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei
> > >> is
> > >>>>>> working on a PR and this would be a good bug to have fixed.
> > >>>>>>
> > >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation
> of
> > >>>>>> predicate (A or B) and C is failing for some adapters
> > >>>>>>
> > >>>>>> --
> > >>>>>> Michael Mior
> > >>>>>> mmior@apache.org
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a
> > >> écrit :
> > >>>>>>
> > >>>>>>> To answer Michael's question: I don't think we should delay the
> > >>>>>>> report, nor should we hurry the release. It's fair to say that
> > >> 1.17
> > >>>> is
> > >>>>>>> in its final stages. There was a lot of activity on avatica-1.12
> > >> from
> > >>>>>>> a lot of individuals, and the community is in great shape.
> > >>>>>>>
> > >>>>>>> Here are the cases listed by Volodymyr, converted into links:
> > >>>>>>>
> > >>>>>>> Must:
> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2384 Performance
> > >>>> issue
> > >>>>>>> in getPulledUpPredicates - Zoltan
> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
> > >>>> Avatica -
> > >>>>>>> Julian
> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT -
> > >>>> Julian
> > >>>>>>>
> > >>>>>>> Nice:
> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
> > >>>> MongoDB
> > >>>>>>> - Volodymyr
> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8
> > >> syntax -
> > >>>>>> Kevin
> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel -
> > >> Julian
> > >>>>>>> (blocked by 2259)
> > >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC
> > >> adapter
> > >>>>>>> timestamps - Julian to review
> > >>>>>>>
> > >>>>>>> Julian
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> > >>>>>>> <vo...@apache.org> wrote:
> > >>>>>>>> Hi Michael,
> > >>>>>>>>
> > >>>>>>>> There are several Jiras, which I think are blockers for the
> > >>>>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
> > >>>> CALCITE-2303.
> > >>>>>>>> Also, there is a list of the Jiras, which would be good to
> > >> include
> > >>>> to
> > >>>>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> > >>>>>>>>
> > >>>>>>>> So I think we need at least couple of weeks to resolve these
> > >> issues
> > >>>>> and
> > >>>>>>>> release 1.17.
> > >>>>>>>>
> > >>>>>>>> Also, please let me know if there are other issues-blockers
> > >> for the
> > >>>>>>>> release, or if some of these issues may be omitted.
> > >>>>>>>>
> > >>>>>>>> Kind regards,
> > >>>>>>>> Volodymyr Vysotskyi
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eolivelli@gmail.com
> > >>>
> > >>>>> пише:
> > >>>>>>>>
> > >>>>>>>>> It also would be great to have at least a BETA version of
> > >> Babel
> > >>>>> parser
> > >>>>>>>>>
> > >>>>>>>>> Enrico
> > >>>>>>>>>
> > >>>>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
> > >>>>> scritto:
> > >>>>>>>>>
> > >>>>>>>>>> Just wanted to check in with how we're doing with progress
> > >>>>> towards a
> > >>>>>>>>>> release. It's not a rush at all, but I'm preparing the board
> > >>>>> report
> > >>>>>>> for
> > >>>>>>>>>> July and wondering if I should wait to include the 1.17.0
> > >>>> release.
> > >>>>>> It
> > >>>>>>>>>> sounds like there are a few other things that still need to
> > >> be
> > >>>>>> wrapped
> > >>>>>>>>> up,
> > >>>>>>>>>> so I'm fine if we don't release for another couple weeks.
> > >>>>>>>>>>
> > >>>>>>>>>> Thanks again Volodymyr for taking this on!
> > >>>>>>>>>>
> > >>>>>>>>>> --
> > >>>>>>>>>> Michael Mior
> > >>>>>>>>>> mmior@apache.org
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> > >>>>>>> volodymyr@apache.org>
> > >>>>>>>>> a
> > >>>>>>>>>> écrit :
> > >>>>>>>>>>
> > >>>>>>>>>>> Calcite 1.16.0 was released on March 19 (more than two
> > >> months
> > >>>>>> ago).
> > >>>>>>>>>>> We have solved over 48 issues[1] since then, therefore we
> > >>>> should
> > >>>>>>> start
> > >>>>>>>>>>> discussing about releasing Calcite 1.17.0.
> > >>>>>>>>>>>
> > >>>>>>>>>>> I have created [2] to track the release.
> > >>>>>>>>>>>
> > >>>>>>>>>>> We will start a release process after the Avatica 1.12 is
> > >>>>>> released.
> > >>>>>>>>>>>
> > >>>>>>>>>>> I went through the list of opened PRs during the last
> > >> month,
> > >>>> and
> > >>>>>>> here
> > >>>>>>>>> is
> > >>>>>>>>>>> the list of Jiras which possibly be merged before the
> > >> release:
> > >>>>>>>>>>>
> > >>>>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT
> > >> function -
> > >>>>>> changes
> > >>>>>>>>> are
> > >>>>>>>>>>> done, depends on the Avatica release
> > >>>>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
> > >>>> operator
> > >>>>>> with
> > >>>>>>>>> the
> > >>>>>>>>>>> constant from the left side more optimally - I will make
> > >>>>> required
> > >>>>>>>>> changes
> > >>>>>>>>>>> at the beginning of next week
> > >>>>>>>>>>>
> > >>>>>>>>>>> * CALCITE-2321: Support ragged fixed length value union be
> > >>>>>> variable
> > >>>>>>> -
> > >>>>>>>>>>> In review (Julian)*
> > >>>>>>>>>>>
> > >>>>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate -
> > >> I
> > >>>> will
> > >>>>>>> pick
> > >>>>>>>>> up
> > >>>>>>>>>>> this next week*
> > >>>>>>>>>>>
> > >>>>>>>>>>> List of other pull requests which require review or
> > >> additional
> > >>>>>>> rework:
> > >>>>>>>>>>>
> > >>>>>>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may
> > >> not be
> > >>>>>>>>> simplified
> > >>>>>>>>>> to
> > >>>>>>>>>>> false
> > >>>>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support -
> > >>>> Julian
> > >>>>>>> added
> > >>>>>>>>> a
> > >>>>>>>>>>> comment into the Jira
> > >>>>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is
> > >>>> failing
> > >>>>>> for
> > >>>>>>>>> some
> > >>>>>>>>>>> adapters - created PR only with a test for this Jira
> > >>>>>>>>>>> CALCITE-2209: Support loading JSON model file through URL
> > >> -
> > >>>>> Shuyi
> > >>>>>>> Chen
> > >>>>>>>>>>> added a comment into the Jira
> > >>>>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works not
> > >>>>> correct
> > >>>>>>> in
> > >>>>>>>>>> some
> > >>>>>>>>>>> cases
> > >>>>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean
> > >>>>>> expressions
> > >>>>>>>>>> should
> > >>>>>>>>>>> be set to FLOAT.
> > >>>>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest
> > >> input -
> > >>>>> PR
> > >>>>>> is
> > >>>>>>>>>>> created
> > >>>>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
> > >>>>>>>>>>> ResultSetEnumerable - needs additional rework.
> > >>>>>>>>>>>
> > >>>>>>>>>>> Please let me know, if there are any Jiras should be
> > >> included
> > >>>>> into
> > >>>>>>> this
> > >>>>>>>>>>> release.
> > >>>>>>>>>>>
> > >>>>>>>>>>> [1]
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>
> > >>>>>>
> > >>>>> https://issues.apache.org/jira/issues/?jql=project%20%
> > >>>> 3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%
> > >>>> 20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> > >>>>>>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
> > >>>>>>>>>>>
> > >>>>>>>>>>> Kind regards,
> > >>>>>>>>>>> Volodymyr Vysotskyi
> > >>>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>> --
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>> -- Enrico Olivelli
> > >>>>>>>>>
> > >>>>>>>
> > >>>>>>
> > >>>>>
> > >>>>
> > >>
> >
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Stamatis Zampetakis <za...@gmail.com>.
Hi Volodymyr,
I hope to be done with
https://issues.apache.org/jira/browse/CALCITE-2404 before
the end of next week.
Personally, I don't mind if it does not make it to this release since for
my use-case I can patch the code directly.
Best,
Stamatis
2018-07-11 17:13 GMT+02:00 Julian Hyde <jh...@gmail.com>:
> I think this release train has waited long enough. We should wait for
> issues that people are fixing themselves, within the next 24 hours. And
> review PRs that have already been submitted.
>
> We release regularly, so there will be another train in a couple of months.
>
> Julian
>
> > On Jul 11, 2018, at 07:34, Andrei Sereda <an...@sereda.cc> wrote:
> >
> > Hello,
> >
> > If people on this list don't mind, I would like to finish two more issues
> > for ES adapter:
> > 1) CALCITE-2408 enable aggregate functions in ES adapter
> > 2) CALCITE-2411 expose a table for each ES index (by default) - this was
> > discussed <https://markmail.org/thread/jryg6ptmu26krezp> on dev list
> last
> > week.
> >
> > They should be done next week.
> > Regards,
> > Andrei.
> >
> >> On Wed, Jul 11, 2018 at 7:00 AM Michael Mior <mm...@uwaterloo.ca>
> wrote:
> >>
> >> It would be good if someone else could also have a look at the PR
> >> below for CALCITE-2331 as it's basically ready to merge pending a
> >> decision on a behaviour change.
> >>
> >> https://github.com/apache/calcite/pull/755
> >>
> >> --
> >> Michael Mior
> >> mmior@uwaterloo.ca
> >>
> >> Le mer. 11 juil. 2018 à 06:30, Stamatis Zampetakis <za...@gmail.com>
> a
> >> écrit :
> >>>
> >>> Hello,
> >>>
> >>> I would like to bring your attention towards a new issue namely
> >>> https://issues.apache.org/jira/browse/CALCITE-2404 concerning access
> on
> >>> structured types.
> >>> Basically, any query involving fields of Record type cannot be executed
> >> by
> >>> the runtime (in Enumerable/Bindable convention).
> >>>
> >>> At least for me, it appears as an important issue that it would be good
> >> if
> >>> it can be resolved before the next release. Now, I leave the decision
> up
> >> to
> >>> you.
> >>>
> >>> Best,
> >>> Stamatis
> >>>
> >>> 2018-07-11 11:39 GMT+02:00 Volodymyr Vysotskyi <vo...@apache.org>:
> >>>
> >>>> Both blocking the release issues were fixed
> >>>> and almost all "nice to have" fixes from the list were merged
> >>>> into the master, thanks a lot for this to everyone!
> >>>>
> >>>> Regarding PRs which may be included into the release,
> >>>> looks like work for CALCITE-2366
> >>>> <https://issues.apache.org/jira/browse/CALCITE-2366> is finished.
> >>>>
> >>>> Are there other PRs which may be merged before starting
> >>>> the release process or new blocking issues?
> >>>>
> >>>> Kind regards,
> >>>> Volodymyr Vysotskyi
> >>>>
> >>>>
> >>>> пт, 6 лип. 2018 о 17:58 Andrei Sereda <an...@sereda.cc> пише:
> >>>>
> >>>>> I have created PR-753 <https://github.com/apache/calcite/pull/753>
> >> for
> >>>>> CALCITE-2331. Please note it fixes only ES adapter (mongo is also
> >>>>> affected).
> >>>>>
> >>>>> On Thu, Jun 28, 2018 at 1:54 PM Michael Mior <mm...@apache.org>
> >> wrote:
> >>>>>
> >>>>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei
> >> is
> >>>>>> working on a PR and this would be a good bug to have fixed.
> >>>>>>
> >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
> >>>>>> predicate (A or B) and C is failing for some adapters
> >>>>>>
> >>>>>> --
> >>>>>> Michael Mior
> >>>>>> mmior@apache.org
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a
> >> écrit :
> >>>>>>
> >>>>>>> To answer Michael's question: I don't think we should delay the
> >>>>>>> report, nor should we hurry the release. It's fair to say that
> >> 1.17
> >>>> is
> >>>>>>> in its final stages. There was a lot of activity on avatica-1.12
> >> from
> >>>>>>> a lot of individuals, and the community is in great shape.
> >>>>>>>
> >>>>>>> Here are the cases listed by Volodymyr, converted into links:
> >>>>>>>
> >>>>>>> Must:
> >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
> >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2384 Performance
> >>>> issue
> >>>>>>> in getPulledUpPredicates - Zoltan
> >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
> >>>> Avatica -
> >>>>>>> Julian
> >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT -
> >>>> Julian
> >>>>>>>
> >>>>>>> Nice:
> >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
> >>>> MongoDB
> >>>>>>> - Volodymyr
> >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8
> >> syntax -
> >>>>>> Kevin
> >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel -
> >> Julian
> >>>>>>> (blocked by 2259)
> >>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC
> >> adapter
> >>>>>>> timestamps - Julian to review
> >>>>>>>
> >>>>>>> Julian
> >>>>>>>
> >>>>>>>
> >>>>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> >>>>>>> <vo...@apache.org> wrote:
> >>>>>>>> Hi Michael,
> >>>>>>>>
> >>>>>>>> There are several Jiras, which I think are blockers for the
> >>>>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
> >>>> CALCITE-2303.
> >>>>>>>> Also, there is a list of the Jiras, which would be good to
> >> include
> >>>> to
> >>>>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> >>>>>>>>
> >>>>>>>> So I think we need at least couple of weeks to resolve these
> >> issues
> >>>>> and
> >>>>>>>> release 1.17.
> >>>>>>>>
> >>>>>>>> Also, please let me know if there are other issues-blockers
> >> for the
> >>>>>>>> release, or if some of these issues may be omitted.
> >>>>>>>>
> >>>>>>>> Kind regards,
> >>>>>>>> Volodymyr Vysotskyi
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eolivelli@gmail.com
> >>>
> >>>>> пише:
> >>>>>>>>
> >>>>>>>>> It also would be great to have at least a BETA version of
> >> Babel
> >>>>> parser
> >>>>>>>>>
> >>>>>>>>> Enrico
> >>>>>>>>>
> >>>>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
> >>>>> scritto:
> >>>>>>>>>
> >>>>>>>>>> Just wanted to check in with how we're doing with progress
> >>>>> towards a
> >>>>>>>>>> release. It's not a rush at all, but I'm preparing the board
> >>>>> report
> >>>>>>> for
> >>>>>>>>>> July and wondering if I should wait to include the 1.17.0
> >>>> release.
> >>>>>> It
> >>>>>>>>>> sounds like there are a few other things that still need to
> >> be
> >>>>>> wrapped
> >>>>>>>>> up,
> >>>>>>>>>> so I'm fine if we don't release for another couple weeks.
> >>>>>>>>>>
> >>>>>>>>>> Thanks again Volodymyr for taking this on!
> >>>>>>>>>>
> >>>>>>>>>> --
> >>>>>>>>>> Michael Mior
> >>>>>>>>>> mmior@apache.org
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> >>>>>>> volodymyr@apache.org>
> >>>>>>>>> a
> >>>>>>>>>> écrit :
> >>>>>>>>>>
> >>>>>>>>>>> Calcite 1.16.0 was released on March 19 (more than two
> >> months
> >>>>>> ago).
> >>>>>>>>>>> We have solved over 48 issues[1] since then, therefore we
> >>>> should
> >>>>>>> start
> >>>>>>>>>>> discussing about releasing Calcite 1.17.0.
> >>>>>>>>>>>
> >>>>>>>>>>> I have created [2] to track the release.
> >>>>>>>>>>>
> >>>>>>>>>>> We will start a release process after the Avatica 1.12 is
> >>>>>> released.
> >>>>>>>>>>>
> >>>>>>>>>>> I went through the list of opened PRs during the last
> >> month,
> >>>> and
> >>>>>>> here
> >>>>>>>>> is
> >>>>>>>>>>> the list of Jiras which possibly be merged before the
> >> release:
> >>>>>>>>>>>
> >>>>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT
> >> function -
> >>>>>> changes
> >>>>>>>>> are
> >>>>>>>>>>> done, depends on the Avatica release
> >>>>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
> >>>> operator
> >>>>>> with
> >>>>>>>>> the
> >>>>>>>>>>> constant from the left side more optimally - I will make
> >>>>> required
> >>>>>>>>> changes
> >>>>>>>>>>> at the beginning of next week
> >>>>>>>>>>>
> >>>>>>>>>>> * CALCITE-2321: Support ragged fixed length value union be
> >>>>>> variable
> >>>>>>> -
> >>>>>>>>>>> In review (Julian)*
> >>>>>>>>>>>
> >>>>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate -
> >> I
> >>>> will
> >>>>>>> pick
> >>>>>>>>> up
> >>>>>>>>>>> this next week*
> >>>>>>>>>>>
> >>>>>>>>>>> List of other pull requests which require review or
> >> additional
> >>>>>>> rework:
> >>>>>>>>>>>
> >>>>>>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may
> >> not be
> >>>>>>>>> simplified
> >>>>>>>>>> to
> >>>>>>>>>>> false
> >>>>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support -
> >>>> Julian
> >>>>>>> added
> >>>>>>>>> a
> >>>>>>>>>>> comment into the Jira
> >>>>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is
> >>>> failing
> >>>>>> for
> >>>>>>>>> some
> >>>>>>>>>>> adapters - created PR only with a test for this Jira
> >>>>>>>>>>> CALCITE-2209: Support loading JSON model file through URL
> >> -
> >>>>> Shuyi
> >>>>>>> Chen
> >>>>>>>>>>> added a comment into the Jira
> >>>>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works not
> >>>>> correct
> >>>>>>> in
> >>>>>>>>>> some
> >>>>>>>>>>> cases
> >>>>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean
> >>>>>> expressions
> >>>>>>>>>> should
> >>>>>>>>>>> be set to FLOAT.
> >>>>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest
> >> input -
> >>>>> PR
> >>>>>> is
> >>>>>>>>>>> created
> >>>>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
> >>>>>>>>>>> ResultSetEnumerable - needs additional rework.
> >>>>>>>>>>>
> >>>>>>>>>>> Please let me know, if there are any Jiras should be
> >> included
> >>>>> into
> >>>>>>> this
> >>>>>>>>>>> release.
> >>>>>>>>>>>
> >>>>>>>>>>> [1]
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>> https://issues.apache.org/jira/issues/?jql=project%20%
> >>>> 3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%
> >>>> 20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> >>>>>>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
> >>>>>>>>>>>
> >>>>>>>>>>> Kind regards,
> >>>>>>>>>>> Volodymyr Vysotskyi
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>> --
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> -- Enrico Olivelli
> >>>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Julian Hyde <jh...@gmail.com>.
I think this release train has waited long enough. We should wait for issues that people are fixing themselves, within the next 24 hours. And review PRs that have already been submitted.
We release regularly, so there will be another train in a couple of months.
Julian
> On Jul 11, 2018, at 07:34, Andrei Sereda <an...@sereda.cc> wrote:
>
> Hello,
>
> If people on this list don't mind, I would like to finish two more issues
> for ES adapter:
> 1) CALCITE-2408 enable aggregate functions in ES adapter
> 2) CALCITE-2411 expose a table for each ES index (by default) - this was
> discussed <https://markmail.org/thread/jryg6ptmu26krezp> on dev list last
> week.
>
> They should be done next week.
> Regards,
> Andrei.
>
>> On Wed, Jul 11, 2018 at 7:00 AM Michael Mior <mm...@uwaterloo.ca> wrote:
>>
>> It would be good if someone else could also have a look at the PR
>> below for CALCITE-2331 as it's basically ready to merge pending a
>> decision on a behaviour change.
>>
>> https://github.com/apache/calcite/pull/755
>>
>> --
>> Michael Mior
>> mmior@uwaterloo.ca
>>
>> Le mer. 11 juil. 2018 à 06:30, Stamatis Zampetakis <za...@gmail.com> a
>> écrit :
>>>
>>> Hello,
>>>
>>> I would like to bring your attention towards a new issue namely
>>> https://issues.apache.org/jira/browse/CALCITE-2404 concerning access on
>>> structured types.
>>> Basically, any query involving fields of Record type cannot be executed
>> by
>>> the runtime (in Enumerable/Bindable convention).
>>>
>>> At least for me, it appears as an important issue that it would be good
>> if
>>> it can be resolved before the next release. Now, I leave the decision up
>> to
>>> you.
>>>
>>> Best,
>>> Stamatis
>>>
>>> 2018-07-11 11:39 GMT+02:00 Volodymyr Vysotskyi <vo...@apache.org>:
>>>
>>>> Both blocking the release issues were fixed
>>>> and almost all "nice to have" fixes from the list were merged
>>>> into the master, thanks a lot for this to everyone!
>>>>
>>>> Regarding PRs which may be included into the release,
>>>> looks like work for CALCITE-2366
>>>> <https://issues.apache.org/jira/browse/CALCITE-2366> is finished.
>>>>
>>>> Are there other PRs which may be merged before starting
>>>> the release process or new blocking issues?
>>>>
>>>> Kind regards,
>>>> Volodymyr Vysotskyi
>>>>
>>>>
>>>> пт, 6 лип. 2018 о 17:58 Andrei Sereda <an...@sereda.cc> пише:
>>>>
>>>>> I have created PR-753 <https://github.com/apache/calcite/pull/753>
>> for
>>>>> CALCITE-2331. Please note it fixes only ES adapter (mongo is also
>>>>> affected).
>>>>>
>>>>> On Thu, Jun 28, 2018 at 1:54 PM Michael Mior <mm...@apache.org>
>> wrote:
>>>>>
>>>>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei
>> is
>>>>>> working on a PR and this would be a good bug to have fixed.
>>>>>>
>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
>>>>>> predicate (A or B) and C is failing for some adapters
>>>>>>
>>>>>> --
>>>>>> Michael Mior
>>>>>> mmior@apache.org
>>>>>>
>>>>>>
>>>>>>
>>>>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a
>> écrit :
>>>>>>
>>>>>>> To answer Michael's question: I don't think we should delay the
>>>>>>> report, nor should we hurry the release. It's fair to say that
>> 1.17
>>>> is
>>>>>>> in its final stages. There was a lot of activity on avatica-1.12
>> from
>>>>>>> a lot of individuals, and the community is in great shape.
>>>>>>>
>>>>>>> Here are the cases listed by Volodymyr, converted into links:
>>>>>>>
>>>>>>> Must:
>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2384 Performance
>>>> issue
>>>>>>> in getPulledUpPredicates - Zoltan
>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
>>>> Avatica -
>>>>>>> Julian
>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT -
>>>> Julian
>>>>>>>
>>>>>>> Nice:
>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
>>>> MongoDB
>>>>>>> - Volodymyr
>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8
>> syntax -
>>>>>> Kevin
>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel -
>> Julian
>>>>>>> (blocked by 2259)
>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC
>> adapter
>>>>>>> timestamps - Julian to review
>>>>>>>
>>>>>>> Julian
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
>>>>>>> <vo...@apache.org> wrote:
>>>>>>>> Hi Michael,
>>>>>>>>
>>>>>>>> There are several Jiras, which I think are blockers for the
>>>>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
>>>> CALCITE-2303.
>>>>>>>> Also, there is a list of the Jiras, which would be good to
>> include
>>>> to
>>>>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
>>>>>>>>
>>>>>>>> So I think we need at least couple of weeks to resolve these
>> issues
>>>>> and
>>>>>>>> release 1.17.
>>>>>>>>
>>>>>>>> Also, please let me know if there are other issues-blockers
>> for the
>>>>>>>> release, or if some of these issues may be omitted.
>>>>>>>>
>>>>>>>> Kind regards,
>>>>>>>> Volodymyr Vysotskyi
>>>>>>>>
>>>>>>>>
>>>>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eolivelli@gmail.com
>>>
>>>>> пише:
>>>>>>>>
>>>>>>>>> It also would be great to have at least a BETA version of
>> Babel
>>>>> parser
>>>>>>>>>
>>>>>>>>> Enrico
>>>>>>>>>
>>>>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
>>>>> scritto:
>>>>>>>>>
>>>>>>>>>> Just wanted to check in with how we're doing with progress
>>>>> towards a
>>>>>>>>>> release. It's not a rush at all, but I'm preparing the board
>>>>> report
>>>>>>> for
>>>>>>>>>> July and wondering if I should wait to include the 1.17.0
>>>> release.
>>>>>> It
>>>>>>>>>> sounds like there are a few other things that still need to
>> be
>>>>>> wrapped
>>>>>>>>> up,
>>>>>>>>>> so I'm fine if we don't release for another couple weeks.
>>>>>>>>>>
>>>>>>>>>> Thanks again Volodymyr for taking this on!
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Michael Mior
>>>>>>>>>> mmior@apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
>>>>>>> volodymyr@apache.org>
>>>>>>>>> a
>>>>>>>>>> écrit :
>>>>>>>>>>
>>>>>>>>>>> Calcite 1.16.0 was released on March 19 (more than two
>> months
>>>>>> ago).
>>>>>>>>>>> We have solved over 48 issues[1] since then, therefore we
>>>> should
>>>>>>> start
>>>>>>>>>>> discussing about releasing Calcite 1.17.0.
>>>>>>>>>>>
>>>>>>>>>>> I have created [2] to track the release.
>>>>>>>>>>>
>>>>>>>>>>> We will start a release process after the Avatica 1.12 is
>>>>>> released.
>>>>>>>>>>>
>>>>>>>>>>> I went through the list of opened PRs during the last
>> month,
>>>> and
>>>>>>> here
>>>>>>>>> is
>>>>>>>>>>> the list of Jiras which possibly be merged before the
>> release:
>>>>>>>>>>>
>>>>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT
>> function -
>>>>>> changes
>>>>>>>>> are
>>>>>>>>>>> done, depends on the Avatica release
>>>>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
>>>> operator
>>>>>> with
>>>>>>>>> the
>>>>>>>>>>> constant from the left side more optimally - I will make
>>>>> required
>>>>>>>>> changes
>>>>>>>>>>> at the beginning of next week
>>>>>>>>>>>
>>>>>>>>>>> * CALCITE-2321: Support ragged fixed length value union be
>>>>>> variable
>>>>>>> -
>>>>>>>>>>> In review (Julian)*
>>>>>>>>>>>
>>>>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate -
>> I
>>>> will
>>>>>>> pick
>>>>>>>>> up
>>>>>>>>>>> this next week*
>>>>>>>>>>>
>>>>>>>>>>> List of other pull requests which require review or
>> additional
>>>>>>> rework:
>>>>>>>>>>>
>>>>>>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may
>> not be
>>>>>>>>> simplified
>>>>>>>>>> to
>>>>>>>>>>> false
>>>>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support -
>>>> Julian
>>>>>>> added
>>>>>>>>> a
>>>>>>>>>>> comment into the Jira
>>>>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is
>>>> failing
>>>>>> for
>>>>>>>>> some
>>>>>>>>>>> adapters - created PR only with a test for this Jira
>>>>>>>>>>> CALCITE-2209: Support loading JSON model file through URL
>> -
>>>>> Shuyi
>>>>>>> Chen
>>>>>>>>>>> added a comment into the Jira
>>>>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works not
>>>>> correct
>>>>>>> in
>>>>>>>>>> some
>>>>>>>>>>> cases
>>>>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean
>>>>>> expressions
>>>>>>>>>> should
>>>>>>>>>>> be set to FLOAT.
>>>>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest
>> input -
>>>>> PR
>>>>>> is
>>>>>>>>>>> created
>>>>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
>>>>>>>>>>> ResultSetEnumerable - needs additional rework.
>>>>>>>>>>>
>>>>>>>>>>> Please let me know, if there are any Jiras should be
>> included
>>>>> into
>>>>>>> this
>>>>>>>>>>> release.
>>>>>>>>>>>
>>>>>>>>>>> [1]
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>
>>>>> https://issues.apache.org/jira/issues/?jql=project%20%
>>>> 3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%
>>>> 20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
>>>>>>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
>>>>>>>>>>>
>>>>>>>>>>> Kind regards,
>>>>>>>>>>> Volodymyr Vysotskyi
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> --
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> -- Enrico Olivelli
>>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Andrei Sereda <an...@sereda.cc>.
Hello,
If people on this list don't mind, I would like to finish two more issues
for ES adapter:
1) CALCITE-2408 enable aggregate functions in ES adapter
2) CALCITE-2411 expose a table for each ES index (by default) - this was
discussed <https://markmail.org/thread/jryg6ptmu26krezp> on dev list last
week.
They should be done next week.
Regards,
Andrei.
On Wed, Jul 11, 2018 at 7:00 AM Michael Mior <mm...@uwaterloo.ca> wrote:
> It would be good if someone else could also have a look at the PR
> below for CALCITE-2331 as it's basically ready to merge pending a
> decision on a behaviour change.
>
> https://github.com/apache/calcite/pull/755
>
> --
> Michael Mior
> mmior@uwaterloo.ca
>
> Le mer. 11 juil. 2018 à 06:30, Stamatis Zampetakis <za...@gmail.com> a
> écrit :
> >
> > Hello,
> >
> > I would like to bring your attention towards a new issue namely
> > https://issues.apache.org/jira/browse/CALCITE-2404 concerning access on
> > structured types.
> > Basically, any query involving fields of Record type cannot be executed
> by
> > the runtime (in Enumerable/Bindable convention).
> >
> > At least for me, it appears as an important issue that it would be good
> if
> > it can be resolved before the next release. Now, I leave the decision up
> to
> > you.
> >
> > Best,
> > Stamatis
> >
> > 2018-07-11 11:39 GMT+02:00 Volodymyr Vysotskyi <vo...@apache.org>:
> >
> > > Both blocking the release issues were fixed
> > > and almost all "nice to have" fixes from the list were merged
> > > into the master, thanks a lot for this to everyone!
> > >
> > > Regarding PRs which may be included into the release,
> > > looks like work for CALCITE-2366
> > > <https://issues.apache.org/jira/browse/CALCITE-2366> is finished.
> > >
> > > Are there other PRs which may be merged before starting
> > > the release process or new blocking issues?
> > >
> > > Kind regards,
> > > Volodymyr Vysotskyi
> > >
> > >
> > > пт, 6 лип. 2018 о 17:58 Andrei Sereda <an...@sereda.cc> пише:
> > >
> > > > I have created PR-753 <https://github.com/apache/calcite/pull/753>
> for
> > > > CALCITE-2331. Please note it fixes only ES adapter (mongo is also
> > > > affected).
> > > >
> > > > On Thu, Jun 28, 2018 at 1:54 PM Michael Mior <mm...@apache.org>
> wrote:
> > > >
> > > > > I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei
> is
> > > > > working on a PR and this would be a good bug to have fixed.
> > > > >
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
> > > > > predicate (A or B) and C is failing for some adapters
> > > > >
> > > > > --
> > > > > Michael Mior
> > > > > mmior@apache.org
> > > > >
> > > > >
> > > > >
> > > > > Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a
> écrit :
> > > > >
> > > > > > To answer Michael's question: I don't think we should delay the
> > > > > > report, nor should we hurry the release. It's fair to say that
> 1.17
> > > is
> > > > > > in its final stages. There was a lot of activity on avatica-1.12
> from
> > > > > > a lot of individuals, and the community is in great shape.
> > > > > >
> > > > > > Here are the cases listed by Volodymyr, converted into links:
> > > > > >
> > > > > > Must:
> > > > > > * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
> > > > > > * https://issues.apache.org/jira/browse/CALCITE-2384 Performance
> > > issue
> > > > > > in getPulledUpPredicates - Zoltan
> > > > > > * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
> > > Avatica -
> > > > > > Julian
> > > > > > * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT -
> > > Julian
> > > > > >
> > > > > > Nice:
> > > > > > * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
> > > MongoDB
> > > > > > - Volodymyr
> > > > > > * https://issues.apache.org/jira/browse/CALCITE-2259 Java8
> syntax -
> > > > > Kevin
> > > > > > * https://issues.apache.org/jira/browse/CALCITE-2280 Babel -
> Julian
> > > > > > (blocked by 2259)
> > > > > > * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC
> adapter
> > > > > > timestamps - Julian to review
> > > > > >
> > > > > > Julian
> > > > > >
> > > > > >
> > > > > > On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> > > > > > <vo...@apache.org> wrote:
> > > > > > > Hi Michael,
> > > > > > >
> > > > > > > There are several Jiras, which I think are blockers for the
> > > > > > > release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
> > > CALCITE-2303.
> > > > > > > Also, there is a list of the Jiras, which would be good to
> include
> > > to
> > > > > > > 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> > > > > > >
> > > > > > > So I think we need at least couple of weeks to resolve these
> issues
> > > > and
> > > > > > > release 1.17.
> > > > > > >
> > > > > > > Also, please let me know if there are other issues-blockers
> for the
> > > > > > > release, or if some of these issues may be omitted.
> > > > > > >
> > > > > > > Kind regards,
> > > > > > > Volodymyr Vysotskyi
> > > > > > >
> > > > > > >
> > > > > > > чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eolivelli@gmail.com
> >
> > > > пише:
> > > > > > >
> > > > > > >> It also would be great to have at least a BETA version of
> Babel
> > > > parser
> > > > > > >>
> > > > > > >> Enrico
> > > > > > >>
> > > > > > >> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
> > > > scritto:
> > > > > > >>
> > > > > > >> > Just wanted to check in with how we're doing with progress
> > > > towards a
> > > > > > >> > release. It's not a rush at all, but I'm preparing the board
> > > > report
> > > > > > for
> > > > > > >> > July and wondering if I should wait to include the 1.17.0
> > > release.
> > > > > It
> > > > > > >> > sounds like there are a few other things that still need to
> be
> > > > > wrapped
> > > > > > >> up,
> > > > > > >> > so I'm fine if we don't release for another couple weeks.
> > > > > > >> >
> > > > > > >> > Thanks again Volodymyr for taking this on!
> > > > > > >> >
> > > > > > >> > --
> > > > > > >> > Michael Mior
> > > > > > >> > mmior@apache.org
> > > > > > >> >
> > > > > > >> >
> > > > > > >> >
> > > > > > >> > Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> > > > > > volodymyr@apache.org>
> > > > > > >> a
> > > > > > >> > écrit :
> > > > > > >> >
> > > > > > >> > > Calcite 1.16.0 was released on March 19 (more than two
> months
> > > > > ago).
> > > > > > >> > > We have solved over 48 issues[1] since then, therefore we
> > > should
> > > > > > start
> > > > > > >> > > discussing about releasing Calcite 1.17.0.
> > > > > > >> > >
> > > > > > >> > > I have created [2] to track the release.
> > > > > > >> > >
> > > > > > >> > > We will start a release process after the Avatica 1.12 is
> > > > > released.
> > > > > > >> > >
> > > > > > >> > > I went through the list of opened PRs during the last
> month,
> > > and
> > > > > > here
> > > > > > >> is
> > > > > > >> > > the list of Jiras which possibly be merged before the
> release:
> > > > > > >> > >
> > > > > > >> > > CALCITE-2303: Support DECADE time unit in EXTRACT
> function -
> > > > > changes
> > > > > > >> are
> > > > > > >> > > done, depends on the Avatica release
> > > > > > >> > > CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
> > > operator
> > > > > with
> > > > > > >> the
> > > > > > >> > > constant from the left side more optimally - I will make
> > > > required
> > > > > > >> changes
> > > > > > >> > > at the beginning of next week
> > > > > > >> > >
> > > > > > >> > > * CALCITE-2321: Support ragged fixed length value union be
> > > > > variable
> > > > > > -
> > > > > > >> > > In review (Julian)*
> > > > > > >> > >
> > > > > > >> > > * CALCITE-2291: Add rule to push Project past Correlate -
> I
> > > will
> > > > > > pick
> > > > > > >> up
> > > > > > >> > > this next week*
> > > > > > >> > >
> > > > > > >> > > List of other pull requests which require review or
> additional
> > > > > > rework:
> > > > > > >> > >
> > > > > > >> > > CALCITE-2327: In 3 valued logic mode (b and not b) may
> not be
> > > > > > >> simplified
> > > > > > >> > to
> > > > > > >> > > false
> > > > > > >> > > CALCITE-2302 / CALCITE-2325: Implicit type cast support -
> > > Julian
> > > > > > added
> > > > > > >> a
> > > > > > >> > > comment into the Jira
> > > > > > >> > > CALCITE-2331: evaluation of predicate (A or B) and C is
> > > failing
> > > > > for
> > > > > > >> some
> > > > > > >> > > adapters - created PR only with a test for this Jira
> > > > > > >> > > CALCITE-2209: Support loading JSON model file through URL
> -
> > > > Shuyi
> > > > > > Chen
> > > > > > >> > > added a comment into the Jira
> > > > > > >> > > CALCITE-2324: Extract seconds, minutes from date works not
> > > > correct
> > > > > > in
> > > > > > >> > some
> > > > > > >> > > cases
> > > > > > >> > > CALCITE-2319: Druid Expressions - Output Type of Boolean
> > > > > expressions
> > > > > > >> > should
> > > > > > >> > > be set to FLOAT.
> > > > > > >> > > CALCITE-500: Ensure EnumerableJoin hashes the smallest
> input -
> > > > PR
> > > > > is
> > > > > > >> > > created
> > > > > > >> > > CALCITE-2301: Remove the 10-second-timeout restriction in
> > > > > > >> > > ResultSetEnumerable - needs additional rework.
> > > > > > >> > >
> > > > > > >> > > Please let me know, if there are any Jiras should be
> included
> > > > into
> > > > > > this
> > > > > > >> > > release.
> > > > > > >> > >
> > > > > > >> > > [1]
> > > > > > >> > >
> > > > > > >> > >
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > > https://issues.apache.org/jira/issues/?jql=project%20%
> > > 3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%
> > > 20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> > > > > > >> > > [2] https://issues.apache.org/jira/browse/CALCITE-2337
> > > > > > >> > >
> > > > > > >> > > Kind regards,
> > > > > > >> > > Volodymyr Vysotskyi
> > > > > > >> > >
> > > > > > >> >
> > > > > > >> --
> > > > > > >>
> > > > > > >>
> > > > > > >> -- Enrico Olivelli
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Michael Mior <mm...@uwaterloo.ca>.
It would be good if someone else could also have a look at the PR
below for CALCITE-2331 as it's basically ready to merge pending a
decision on a behaviour change.
https://github.com/apache/calcite/pull/755
--
Michael Mior
mmior@uwaterloo.ca
Le mer. 11 juil. 2018 à 06:30, Stamatis Zampetakis <za...@gmail.com> a écrit :
>
> Hello,
>
> I would like to bring your attention towards a new issue namely
> https://issues.apache.org/jira/browse/CALCITE-2404 concerning access on
> structured types.
> Basically, any query involving fields of Record type cannot be executed by
> the runtime (in Enumerable/Bindable convention).
>
> At least for me, it appears as an important issue that it would be good if
> it can be resolved before the next release. Now, I leave the decision up to
> you.
>
> Best,
> Stamatis
>
> 2018-07-11 11:39 GMT+02:00 Volodymyr Vysotskyi <vo...@apache.org>:
>
> > Both blocking the release issues were fixed
> > and almost all "nice to have" fixes from the list were merged
> > into the master, thanks a lot for this to everyone!
> >
> > Regarding PRs which may be included into the release,
> > looks like work for CALCITE-2366
> > <https://issues.apache.org/jira/browse/CALCITE-2366> is finished.
> >
> > Are there other PRs which may be merged before starting
> > the release process or new blocking issues?
> >
> > Kind regards,
> > Volodymyr Vysotskyi
> >
> >
> > пт, 6 лип. 2018 о 17:58 Andrei Sereda <an...@sereda.cc> пише:
> >
> > > I have created PR-753 <https://github.com/apache/calcite/pull/753> for
> > > CALCITE-2331. Please note it fixes only ES adapter (mongo is also
> > > affected).
> > >
> > > On Thu, Jun 28, 2018 at 1:54 PM Michael Mior <mm...@apache.org> wrote:
> > >
> > > > I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is
> > > > working on a PR and this would be a good bug to have fixed.
> > > >
> > > > * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
> > > > predicate (A or B) and C is failing for some adapters
> > > >
> > > > --
> > > > Michael Mior
> > > > mmior@apache.org
> > > >
> > > >
> > > >
> > > > Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a écrit :
> > > >
> > > > > To answer Michael's question: I don't think we should delay the
> > > > > report, nor should we hurry the release. It's fair to say that 1.17
> > is
> > > > > in its final stages. There was a lot of activity on avatica-1.12 from
> > > > > a lot of individuals, and the community is in great shape.
> > > > >
> > > > > Here are the cases listed by Volodymyr, converted into links:
> > > > >
> > > > > Must:
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2384 Performance
> > issue
> > > > > in getPulledUpPredicates - Zoltan
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
> > Avatica -
> > > > > Julian
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT -
> > Julian
> > > > >
> > > > > Nice:
> > > > > * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
> > MongoDB
> > > > > - Volodymyr
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax -
> > > > Kevin
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2280 Babel - Julian
> > > > > (blocked by 2259)
> > > > > * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
> > > > > timestamps - Julian to review
> > > > >
> > > > > Julian
> > > > >
> > > > >
> > > > > On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> > > > > <vo...@apache.org> wrote:
> > > > > > Hi Michael,
> > > > > >
> > > > > > There are several Jiras, which I think are blockers for the
> > > > > > release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
> > CALCITE-2303.
> > > > > > Also, there is a list of the Jiras, which would be good to include
> > to
> > > > > > 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> > > > > >
> > > > > > So I think we need at least couple of weeks to resolve these issues
> > > and
> > > > > > release 1.17.
> > > > > >
> > > > > > Also, please let me know if there are other issues-blockers for the
> > > > > > release, or if some of these issues may be omitted.
> > > > > >
> > > > > > Kind regards,
> > > > > > Volodymyr Vysotskyi
> > > > > >
> > > > > >
> > > > > > чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com>
> > > пише:
> > > > > >
> > > > > >> It also would be great to have at least a BETA version of Babel
> > > parser
> > > > > >>
> > > > > >> Enrico
> > > > > >>
> > > > > >> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
> > > scritto:
> > > > > >>
> > > > > >> > Just wanted to check in with how we're doing with progress
> > > towards a
> > > > > >> > release. It's not a rush at all, but I'm preparing the board
> > > report
> > > > > for
> > > > > >> > July and wondering if I should wait to include the 1.17.0
> > release.
> > > > It
> > > > > >> > sounds like there are a few other things that still need to be
> > > > wrapped
> > > > > >> up,
> > > > > >> > so I'm fine if we don't release for another couple weeks.
> > > > > >> >
> > > > > >> > Thanks again Volodymyr for taking this on!
> > > > > >> >
> > > > > >> > --
> > > > > >> > Michael Mior
> > > > > >> > mmior@apache.org
> > > > > >> >
> > > > > >> >
> > > > > >> >
> > > > > >> > Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> > > > > volodymyr@apache.org>
> > > > > >> a
> > > > > >> > écrit :
> > > > > >> >
> > > > > >> > > Calcite 1.16.0 was released on March 19 (more than two months
> > > > ago).
> > > > > >> > > We have solved over 48 issues[1] since then, therefore we
> > should
> > > > > start
> > > > > >> > > discussing about releasing Calcite 1.17.0.
> > > > > >> > >
> > > > > >> > > I have created [2] to track the release.
> > > > > >> > >
> > > > > >> > > We will start a release process after the Avatica 1.12 is
> > > > released.
> > > > > >> > >
> > > > > >> > > I went through the list of opened PRs during the last month,
> > and
> > > > > here
> > > > > >> is
> > > > > >> > > the list of Jiras which possibly be merged before the release:
> > > > > >> > >
> > > > > >> > > CALCITE-2303: Support DECADE time unit in EXTRACT function -
> > > > changes
> > > > > >> are
> > > > > >> > > done, depends on the Avatica release
> > > > > >> > > CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
> > operator
> > > > with
> > > > > >> the
> > > > > >> > > constant from the left side more optimally - I will make
> > > required
> > > > > >> changes
> > > > > >> > > at the beginning of next week
> > > > > >> > >
> > > > > >> > > * CALCITE-2321: Support ragged fixed length value union be
> > > > variable
> > > > > -
> > > > > >> > > In review (Julian)*
> > > > > >> > >
> > > > > >> > > * CALCITE-2291: Add rule to push Project past Correlate - I
> > will
> > > > > pick
> > > > > >> up
> > > > > >> > > this next week*
> > > > > >> > >
> > > > > >> > > List of other pull requests which require review or additional
> > > > > rework:
> > > > > >> > >
> > > > > >> > > CALCITE-2327: In 3 valued logic mode (b and not b) may not be
> > > > > >> simplified
> > > > > >> > to
> > > > > >> > > false
> > > > > >> > > CALCITE-2302 / CALCITE-2325: Implicit type cast support -
> > Julian
> > > > > added
> > > > > >> a
> > > > > >> > > comment into the Jira
> > > > > >> > > CALCITE-2331: evaluation of predicate (A or B) and C is
> > failing
> > > > for
> > > > > >> some
> > > > > >> > > adapters - created PR only with a test for this Jira
> > > > > >> > > CALCITE-2209: Support loading JSON model file through URL -
> > > Shuyi
> > > > > Chen
> > > > > >> > > added a comment into the Jira
> > > > > >> > > CALCITE-2324: Extract seconds, minutes from date works not
> > > correct
> > > > > in
> > > > > >> > some
> > > > > >> > > cases
> > > > > >> > > CALCITE-2319: Druid Expressions - Output Type of Boolean
> > > > expressions
> > > > > >> > should
> > > > > >> > > be set to FLOAT.
> > > > > >> > > CALCITE-500: Ensure EnumerableJoin hashes the smallest input -
> > > PR
> > > > is
> > > > > >> > > created
> > > > > >> > > CALCITE-2301: Remove the 10-second-timeout restriction in
> > > > > >> > > ResultSetEnumerable - needs additional rework.
> > > > > >> > >
> > > > > >> > > Please let me know, if there are any Jiras should be included
> > > into
> > > > > this
> > > > > >> > > release.
> > > > > >> > >
> > > > > >> > > [1]
> > > > > >> > >
> > > > > >> > >
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > > https://issues.apache.org/jira/issues/?jql=project%20%
> > 3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%
> > 20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> > > > > >> > > [2] https://issues.apache.org/jira/browse/CALCITE-2337
> > > > > >> > >
> > > > > >> > > Kind regards,
> > > > > >> > > Volodymyr Vysotskyi
> > > > > >> > >
> > > > > >> >
> > > > > >> --
> > > > > >>
> > > > > >>
> > > > > >> -- Enrico Olivelli
> > > > > >>
> > > > >
> > > >
> > >
> >
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Stamatis Zampetakis <za...@gmail.com>.
Hello,
I would like to bring your attention towards a new issue namely
https://issues.apache.org/jira/browse/CALCITE-2404 concerning access on
structured types.
Basically, any query involving fields of Record type cannot be executed by
the runtime (in Enumerable/Bindable convention).
At least for me, it appears as an important issue that it would be good if
it can be resolved before the next release. Now, I leave the decision up to
you.
Best,
Stamatis
2018-07-11 11:39 GMT+02:00 Volodymyr Vysotskyi <vo...@apache.org>:
> Both blocking the release issues were fixed
> and almost all "nice to have" fixes from the list were merged
> into the master, thanks a lot for this to everyone!
>
> Regarding PRs which may be included into the release,
> looks like work for CALCITE-2366
> <https://issues.apache.org/jira/browse/CALCITE-2366> is finished.
>
> Are there other PRs which may be merged before starting
> the release process or new blocking issues?
>
> Kind regards,
> Volodymyr Vysotskyi
>
>
> пт, 6 лип. 2018 о 17:58 Andrei Sereda <an...@sereda.cc> пише:
>
> > I have created PR-753 <https://github.com/apache/calcite/pull/753> for
> > CALCITE-2331. Please note it fixes only ES adapter (mongo is also
> > affected).
> >
> > On Thu, Jun 28, 2018 at 1:54 PM Michael Mior <mm...@apache.org> wrote:
> >
> > > I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is
> > > working on a PR and this would be a good bug to have fixed.
> > >
> > > * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
> > > predicate (A or B) and C is failing for some adapters
> > >
> > > --
> > > Michael Mior
> > > mmior@apache.org
> > >
> > >
> > >
> > > Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a écrit :
> > >
> > > > To answer Michael's question: I don't think we should delay the
> > > > report, nor should we hurry the release. It's fair to say that 1.17
> is
> > > > in its final stages. There was a lot of activity on avatica-1.12 from
> > > > a lot of individuals, and the community is in great shape.
> > > >
> > > > Here are the cases listed by Volodymyr, converted into links:
> > > >
> > > > Must:
> > > > * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
> > > > * https://issues.apache.org/jira/browse/CALCITE-2384 Performance
> issue
> > > > in getPulledUpPredicates - Zoltan
> > > > * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
> Avatica -
> > > > Julian
> > > > * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT -
> Julian
> > > >
> > > > Nice:
> > > > * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
> MongoDB
> > > > - Volodymyr
> > > > * https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax -
> > > Kevin
> > > > * https://issues.apache.org/jira/browse/CALCITE-2280 Babel - Julian
> > > > (blocked by 2259)
> > > > * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
> > > > timestamps - Julian to review
> > > >
> > > > Julian
> > > >
> > > >
> > > > On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> > > > <vo...@apache.org> wrote:
> > > > > Hi Michael,
> > > > >
> > > > > There are several Jiras, which I think are blockers for the
> > > > > release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
> CALCITE-2303.
> > > > > Also, there is a list of the Jiras, which would be good to include
> to
> > > > > 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> > > > >
> > > > > So I think we need at least couple of weeks to resolve these issues
> > and
> > > > > release 1.17.
> > > > >
> > > > > Also, please let me know if there are other issues-blockers for the
> > > > > release, or if some of these issues may be omitted.
> > > > >
> > > > > Kind regards,
> > > > > Volodymyr Vysotskyi
> > > > >
> > > > >
> > > > > чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com>
> > пише:
> > > > >
> > > > >> It also would be great to have at least a BETA version of Babel
> > parser
> > > > >>
> > > > >> Enrico
> > > > >>
> > > > >> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
> > scritto:
> > > > >>
> > > > >> > Just wanted to check in with how we're doing with progress
> > towards a
> > > > >> > release. It's not a rush at all, but I'm preparing the board
> > report
> > > > for
> > > > >> > July and wondering if I should wait to include the 1.17.0
> release.
> > > It
> > > > >> > sounds like there are a few other things that still need to be
> > > wrapped
> > > > >> up,
> > > > >> > so I'm fine if we don't release for another couple weeks.
> > > > >> >
> > > > >> > Thanks again Volodymyr for taking this on!
> > > > >> >
> > > > >> > --
> > > > >> > Michael Mior
> > > > >> > mmior@apache.org
> > > > >> >
> > > > >> >
> > > > >> >
> > > > >> > Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> > > > volodymyr@apache.org>
> > > > >> a
> > > > >> > écrit :
> > > > >> >
> > > > >> > > Calcite 1.16.0 was released on March 19 (more than two months
> > > ago).
> > > > >> > > We have solved over 48 issues[1] since then, therefore we
> should
> > > > start
> > > > >> > > discussing about releasing Calcite 1.17.0.
> > > > >> > >
> > > > >> > > I have created [2] to track the release.
> > > > >> > >
> > > > >> > > We will start a release process after the Avatica 1.12 is
> > > released.
> > > > >> > >
> > > > >> > > I went through the list of opened PRs during the last month,
> and
> > > > here
> > > > >> is
> > > > >> > > the list of Jiras which possibly be merged before the release:
> > > > >> > >
> > > > >> > > CALCITE-2303: Support DECADE time unit in EXTRACT function -
> > > changes
> > > > >> are
> > > > >> > > done, depends on the Avatica release
> > > > >> > > CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
> operator
> > > with
> > > > >> the
> > > > >> > > constant from the left side more optimally - I will make
> > required
> > > > >> changes
> > > > >> > > at the beginning of next week
> > > > >> > >
> > > > >> > > * CALCITE-2321: Support ragged fixed length value union be
> > > variable
> > > > -
> > > > >> > > In review (Julian)*
> > > > >> > >
> > > > >> > > * CALCITE-2291: Add rule to push Project past Correlate - I
> will
> > > > pick
> > > > >> up
> > > > >> > > this next week*
> > > > >> > >
> > > > >> > > List of other pull requests which require review or additional
> > > > rework:
> > > > >> > >
> > > > >> > > CALCITE-2327: In 3 valued logic mode (b and not b) may not be
> > > > >> simplified
> > > > >> > to
> > > > >> > > false
> > > > >> > > CALCITE-2302 / CALCITE-2325: Implicit type cast support -
> Julian
> > > > added
> > > > >> a
> > > > >> > > comment into the Jira
> > > > >> > > CALCITE-2331: evaluation of predicate (A or B) and C is
> failing
> > > for
> > > > >> some
> > > > >> > > adapters - created PR only with a test for this Jira
> > > > >> > > CALCITE-2209: Support loading JSON model file through URL -
> > Shuyi
> > > > Chen
> > > > >> > > added a comment into the Jira
> > > > >> > > CALCITE-2324: Extract seconds, minutes from date works not
> > correct
> > > > in
> > > > >> > some
> > > > >> > > cases
> > > > >> > > CALCITE-2319: Druid Expressions - Output Type of Boolean
> > > expressions
> > > > >> > should
> > > > >> > > be set to FLOAT.
> > > > >> > > CALCITE-500: Ensure EnumerableJoin hashes the smallest input -
> > PR
> > > is
> > > > >> > > created
> > > > >> > > CALCITE-2301: Remove the 10-second-timeout restriction in
> > > > >> > > ResultSetEnumerable - needs additional rework.
> > > > >> > >
> > > > >> > > Please let me know, if there are any Jiras should be included
> > into
> > > > this
> > > > >> > > release.
> > > > >> > >
> > > > >> > > [1]
> > > > >> > >
> > > > >> > >
> > > > >> >
> > > > >>
> > > >
> > >
> > https://issues.apache.org/jira/issues/?jql=project%20%
> 3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%
> 20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> > > > >> > > [2] https://issues.apache.org/jira/browse/CALCITE-2337
> > > > >> > >
> > > > >> > > Kind regards,
> > > > >> > > Volodymyr Vysotskyi
> > > > >> > >
> > > > >> >
> > > > >> --
> > > > >>
> > > > >>
> > > > >> -- Enrico Olivelli
> > > > >>
> > > >
> > >
> >
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Volodymyr Vysotskyi <vo...@apache.org>.
Both blocking the release issues were fixed
and almost all "nice to have" fixes from the list were merged
into the master, thanks a lot for this to everyone!
Regarding PRs which may be included into the release,
looks like work for CALCITE-2366
<https://issues.apache.org/jira/browse/CALCITE-2366> is finished.
Are there other PRs which may be merged before starting
the release process or new blocking issues?
Kind regards,
Volodymyr Vysotskyi
пт, 6 лип. 2018 о 17:58 Andrei Sereda <an...@sereda.cc> пише:
> I have created PR-753 <https://github.com/apache/calcite/pull/753> for
> CALCITE-2331. Please note it fixes only ES adapter (mongo is also
> affected).
>
> On Thu, Jun 28, 2018 at 1:54 PM Michael Mior <mm...@apache.org> wrote:
>
> > I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is
> > working on a PR and this would be a good bug to have fixed.
> >
> > * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
> > predicate (A or B) and C is failing for some adapters
> >
> > --
> > Michael Mior
> > mmior@apache.org
> >
> >
> >
> > Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a écrit :
> >
> > > To answer Michael's question: I don't think we should delay the
> > > report, nor should we hurry the release. It's fair to say that 1.17 is
> > > in its final stages. There was a lot of activity on avatica-1.12 from
> > > a lot of individuals, and the community is in great shape.
> > >
> > > Here are the cases listed by Volodymyr, converted into links:
> > >
> > > Must:
> > > * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
> > > * https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
> > > in getPulledUpPredicates - Zoltan
> > > * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade Avatica -
> > > Julian
> > > * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT - Julian
> > >
> > > Nice:
> > > * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB
> > > - Volodymyr
> > > * https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax -
> > Kevin
> > > * https://issues.apache.org/jira/browse/CALCITE-2280 Babel - Julian
> > > (blocked by 2259)
> > > * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
> > > timestamps - Julian to review
> > >
> > > Julian
> > >
> > >
> > > On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> > > <vo...@apache.org> wrote:
> > > > Hi Michael,
> > > >
> > > > There are several Jiras, which I think are blockers for the
> > > > release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 + CALCITE-2303.
> > > > Also, there is a list of the Jiras, which would be good to include to
> > > > 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> > > >
> > > > So I think we need at least couple of weeks to resolve these issues
> and
> > > > release 1.17.
> > > >
> > > > Also, please let me know if there are other issues-blockers for the
> > > > release, or if some of these issues may be omitted.
> > > >
> > > > Kind regards,
> > > > Volodymyr Vysotskyi
> > > >
> > > >
> > > > чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com>
> пише:
> > > >
> > > >> It also would be great to have at least a BETA version of Babel
> parser
> > > >>
> > > >> Enrico
> > > >>
> > > >> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
> scritto:
> > > >>
> > > >> > Just wanted to check in with how we're doing with progress
> towards a
> > > >> > release. It's not a rush at all, but I'm preparing the board
> report
> > > for
> > > >> > July and wondering if I should wait to include the 1.17.0 release.
> > It
> > > >> > sounds like there are a few other things that still need to be
> > wrapped
> > > >> up,
> > > >> > so I'm fine if we don't release for another couple weeks.
> > > >> >
> > > >> > Thanks again Volodymyr for taking this on!
> > > >> >
> > > >> > --
> > > >> > Michael Mior
> > > >> > mmior@apache.org
> > > >> >
> > > >> >
> > > >> >
> > > >> > Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> > > volodymyr@apache.org>
> > > >> a
> > > >> > écrit :
> > > >> >
> > > >> > > Calcite 1.16.0 was released on March 19 (more than two months
> > ago).
> > > >> > > We have solved over 48 issues[1] since then, therefore we should
> > > start
> > > >> > > discussing about releasing Calcite 1.17.0.
> > > >> > >
> > > >> > > I have created [2] to track the release.
> > > >> > >
> > > >> > > We will start a release process after the Avatica 1.12 is
> > released.
> > > >> > >
> > > >> > > I went through the list of opened PRs during the last month, and
> > > here
> > > >> is
> > > >> > > the list of Jiras which possibly be merged before the release:
> > > >> > >
> > > >> > > CALCITE-2303: Support DECADE time unit in EXTRACT function -
> > changes
> > > >> are
> > > >> > > done, depends on the Avatica release
> > > >> > > CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN operator
> > with
> > > >> the
> > > >> > > constant from the left side more optimally - I will make
> required
> > > >> changes
> > > >> > > at the beginning of next week
> > > >> > >
> > > >> > > * CALCITE-2321: Support ragged fixed length value union be
> > variable
> > > -
> > > >> > > In review (Julian)*
> > > >> > >
> > > >> > > * CALCITE-2291: Add rule to push Project past Correlate - I will
> > > pick
> > > >> up
> > > >> > > this next week*
> > > >> > >
> > > >> > > List of other pull requests which require review or additional
> > > rework:
> > > >> > >
> > > >> > > CALCITE-2327: In 3 valued logic mode (b and not b) may not be
> > > >> simplified
> > > >> > to
> > > >> > > false
> > > >> > > CALCITE-2302 / CALCITE-2325: Implicit type cast support - Julian
> > > added
> > > >> a
> > > >> > > comment into the Jira
> > > >> > > CALCITE-2331: evaluation of predicate (A or B) and C is failing
> > for
> > > >> some
> > > >> > > adapters - created PR only with a test for this Jira
> > > >> > > CALCITE-2209: Support loading JSON model file through URL -
> Shuyi
> > > Chen
> > > >> > > added a comment into the Jira
> > > >> > > CALCITE-2324: Extract seconds, minutes from date works not
> correct
> > > in
> > > >> > some
> > > >> > > cases
> > > >> > > CALCITE-2319: Druid Expressions - Output Type of Boolean
> > expressions
> > > >> > should
> > > >> > > be set to FLOAT.
> > > >> > > CALCITE-500: Ensure EnumerableJoin hashes the smallest input -
> PR
> > is
> > > >> > > created
> > > >> > > CALCITE-2301: Remove the 10-second-timeout restriction in
> > > >> > > ResultSetEnumerable - needs additional rework.
> > > >> > >
> > > >> > > Please let me know, if there are any Jiras should be included
> into
> > > this
> > > >> > > release.
> > > >> > >
> > > >> > > [1]
> > > >> > >
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> > > >> > > [2] https://issues.apache.org/jira/browse/CALCITE-2337
> > > >> > >
> > > >> > > Kind regards,
> > > >> > > Volodymyr Vysotskyi
> > > >> > >
> > > >> >
> > > >> --
> > > >>
> > > >>
> > > >> -- Enrico Olivelli
> > > >>
> > >
> >
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Andrei Sereda <an...@sereda.cc>.
I have created PR-753 <https://github.com/apache/calcite/pull/753> for
CALCITE-2331. Please note it fixes only ES adapter (mongo is also affected).
On Thu, Jun 28, 2018 at 1:54 PM Michael Mior <mm...@apache.org> wrote:
> I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is
> working on a PR and this would be a good bug to have fixed.
>
> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
> predicate (A or B) and C is failing for some adapters
>
> --
> Michael Mior
> mmior@apache.org
>
>
>
> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a écrit :
>
> > To answer Michael's question: I don't think we should delay the
> > report, nor should we hurry the release. It's fair to say that 1.17 is
> > in its final stages. There was a lot of activity on avatica-1.12 from
> > a lot of individuals, and the community is in great shape.
> >
> > Here are the cases listed by Volodymyr, converted into links:
> >
> > Must:
> > * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
> > * https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
> > in getPulledUpPredicates - Zoltan
> > * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade Avatica -
> > Julian
> > * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT - Julian
> >
> > Nice:
> > * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB
> > - Volodymyr
> > * https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax -
> Kevin
> > * https://issues.apache.org/jira/browse/CALCITE-2280 Babel - Julian
> > (blocked by 2259)
> > * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
> > timestamps - Julian to review
> >
> > Julian
> >
> >
> > On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> > <vo...@apache.org> wrote:
> > > Hi Michael,
> > >
> > > There are several Jiras, which I think are blockers for the
> > > release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 + CALCITE-2303.
> > > Also, there is a list of the Jiras, which would be good to include to
> > > 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> > >
> > > So I think we need at least couple of weeks to resolve these issues and
> > > release 1.17.
> > >
> > > Also, please let me know if there are other issues-blockers for the
> > > release, or if some of these issues may be omitted.
> > >
> > > Kind regards,
> > > Volodymyr Vysotskyi
> > >
> > >
> > > чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com> пише:
> > >
> > >> It also would be great to have at least a BETA version of Babel parser
> > >>
> > >> Enrico
> > >>
> > >> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha scritto:
> > >>
> > >> > Just wanted to check in with how we're doing with progress towards a
> > >> > release. It's not a rush at all, but I'm preparing the board report
> > for
> > >> > July and wondering if I should wait to include the 1.17.0 release.
> It
> > >> > sounds like there are a few other things that still need to be
> wrapped
> > >> up,
> > >> > so I'm fine if we don't release for another couple weeks.
> > >> >
> > >> > Thanks again Volodymyr for taking this on!
> > >> >
> > >> > --
> > >> > Michael Mior
> > >> > mmior@apache.org
> > >> >
> > >> >
> > >> >
> > >> > Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> > volodymyr@apache.org>
> > >> a
> > >> > écrit :
> > >> >
> > >> > > Calcite 1.16.0 was released on March 19 (more than two months
> ago).
> > >> > > We have solved over 48 issues[1] since then, therefore we should
> > start
> > >> > > discussing about releasing Calcite 1.17.0.
> > >> > >
> > >> > > I have created [2] to track the release.
> > >> > >
> > >> > > We will start a release process after the Avatica 1.12 is
> released.
> > >> > >
> > >> > > I went through the list of opened PRs during the last month, and
> > here
> > >> is
> > >> > > the list of Jiras which possibly be merged before the release:
> > >> > >
> > >> > > CALCITE-2303: Support DECADE time unit in EXTRACT function -
> changes
> > >> are
> > >> > > done, depends on the Avatica release
> > >> > > CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN operator
> with
> > >> the
> > >> > > constant from the left side more optimally - I will make required
> > >> changes
> > >> > > at the beginning of next week
> > >> > >
> > >> > > * CALCITE-2321: Support ragged fixed length value union be
> variable
> > -
> > >> > > In review (Julian)*
> > >> > >
> > >> > > * CALCITE-2291: Add rule to push Project past Correlate - I will
> > pick
> > >> up
> > >> > > this next week*
> > >> > >
> > >> > > List of other pull requests which require review or additional
> > rework:
> > >> > >
> > >> > > CALCITE-2327: In 3 valued logic mode (b and not b) may not be
> > >> simplified
> > >> > to
> > >> > > false
> > >> > > CALCITE-2302 / CALCITE-2325: Implicit type cast support - Julian
> > added
> > >> a
> > >> > > comment into the Jira
> > >> > > CALCITE-2331: evaluation of predicate (A or B) and C is failing
> for
> > >> some
> > >> > > adapters - created PR only with a test for this Jira
> > >> > > CALCITE-2209: Support loading JSON model file through URL - Shuyi
> > Chen
> > >> > > added a comment into the Jira
> > >> > > CALCITE-2324: Extract seconds, minutes from date works not correct
> > in
> > >> > some
> > >> > > cases
> > >> > > CALCITE-2319: Druid Expressions - Output Type of Boolean
> expressions
> > >> > should
> > >> > > be set to FLOAT.
> > >> > > CALCITE-500: Ensure EnumerableJoin hashes the smallest input - PR
> is
> > >> > > created
> > >> > > CALCITE-2301: Remove the 10-second-timeout restriction in
> > >> > > ResultSetEnumerable - needs additional rework.
> > >> > >
> > >> > > Please let me know, if there are any Jiras should be included into
> > this
> > >> > > release.
> > >> > >
> > >> > > [1]
> > >> > >
> > >> > >
> > >> >
> > >>
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> > >> > > [2] https://issues.apache.org/jira/browse/CALCITE-2337
> > >> > >
> > >> > > Kind regards,
> > >> > > Volodymyr Vysotskyi
> > >> > >
> > >> >
> > >> --
> > >>
> > >>
> > >> -- Enrico Olivelli
> > >>
> >
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Zoltan Haindrich <ki...@rxd.hu>.
Hello,
I made the feature toggle a private method - so its only accessible from within RexSimplify; I've also added a reference to what needs to be fixed in the longterm using the Bug class.
cheers,
Zoltan
On 4 July 2018 03:32:16 CEST, Julian Hyde <jh...@apache.org> wrote:
>I saw you introduced a config parameter to disable previous behavior.
>That’s fine, but let’s do it in such a way that the parameter can
>disappear in a (near) future release. I hate config parameters.
>
>Julian
>
>
>> On Jul 3, 2018, at 1:26 AM, Zoltan Haindrich <ki...@rxd.hu> wrote:
>>
>> Hello,
>>
>> I plan to submit a patch to restore earlier performance today - I
>think I've came up with a plan to make a more complete fix; but that
>will definetly take more time than a few days...and of course there is
>a risk that I'm wrong :)
>>
>> cheers,
>> Zoltan
>>
>>
>> On 07/02/2018 09:13 PM, Volodymyr Vysotskyi wrote:
>>> I think I can finish CALCITE-2392 on Wed or Thursday.
>>> Kind regards,
>>> Volodymyr Vysotskyi
>>> пн, 2 лип. 2018 о 21:22 Julian Hyde <jh...@apache.org> пише:
>>>> OK, so 2384 and 2392 are the critical path.
>>>>
>>>> Zoltan, when do you think you can finish 2392?
>>>>
>>>> Volodymr, when do you think you can finish 2384?
>>>>
>>>> When we have these answers we can set a target date for the RC.
>>>>
>>>> Julian
>>>>
>>>>
>>>>> On Jul 2, 2018, at 11:13 AM, Volodymyr Vysotskyi
><vo...@apache.org>
>>>> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Here is the list of the Jiras, which in my opinions should be
>fixed
>>>> before
>>>>> the release:
>>>>> - https://issues.apache.org/jira/browse/CALCITE-2384 Performance
>issue
>>>>> - https://issues.apache.org/jira/browse/CALCITE-2392 Regression
>>>>> appeared after 1.16 (not sure about blocker status for this Jira)
>>>>> - https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - I will
>>>> merge PR
>>>>> soon
>>>>>
>>>>> Nice to have fixes (most of them from the previous list):
>>>>> - https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
>MongoDB -
>>>>> AFAIK, Igor Kryvenko is working on the moving calcite-test-dataset
>to
>>>>> docker, so after that, we can merge it.
>>>>> - https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax
>>>>> - https://issues.apache.org/jira/browse/CALCITE-2280 Babel
>(blocked by
>>>> 2259)
>>>>> - https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
>>>> timestamp
>>>>> arithmetic
>>>>>
>>>>> Depending on the time, required to fix CALCITE-2384
>>>>> <https://issues.apache.org/jira/browse/CALCITE-2384> and
>CALCITE-2392
>>>>> <https://issues.apache.org/jira/browse/CALCITE-2392>, we can set a
>>>> target
>>>>> date for the first RC, but I don't know the complexity of these
>issues
>>>> and
>>>>> current status for CALCITE-2384
>>>>> <https://issues.apache.org/jira/browse/CALCITE-2384>.
>>>>>
>>>>> Kind regards,
>>>>> Volodymyr Vysotskyi
>>>>>
>>>>>
>>>>> пн, 2 лип. 2018 о 20:42 Julian Hyde <jh...@apache.org> пише:
>>>>>
>>>>>>> On Jun 29, 2018, at 7:29 PM, Francis Chuang
><francischuang@apache.org
>>>>>> <ma...@apache.org> wrote:
>>>>>>>
>>>>>>> Can someone please confirm that the following PRs can be closed?
>>>>>>> https://github.com/apache/calcite/pull/180 <
>>>>>> https://github.com/apache/calcite/pull/180>
>>>>>>> https://github.com/apache/calcite/pull/17 <
>>>>>> https://github.com/apache/calcite/pull/17>
>>>>>>> https://github.com/apache/calcite/pull/422 <
>>>>>> https://github.com/apache/calcite/pull/422>
>>>>>>
>>>>>> I reviewed those PRs. They can be closed. I added comments asking
>the
>>>>>> original contributors to close the PRs. This is always the
>preferred
>>>> option.
>>>>>>
>>>>>> Are we agreed that adding ‘Close #NNN’ to another commit - while
>not
>>>>>> perfect - is the least bad option for closing abandoned PRs? If
>so I’ll
>>>> do
>>>>>> that for these PRs in about 24 hours.
>>>>>>
>>>>>> Volodymyr,
>>>>>>
>>>>>> Do we have a list of what’s left for 1.17? I think we can set a
>target
>>>>>> date for the first RC.
>>>>>>
>>>>>> Julian
>>>>>>
>>>>>>
>>>>
>>>>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Julian Hyde <jh...@apache.org>.
I saw you introduced a config parameter to disable previous behavior. That’s fine, but let’s do it in such a way that the parameter can disappear in a (near) future release. I hate config parameters.
Julian
> On Jul 3, 2018, at 1:26 AM, Zoltan Haindrich <ki...@rxd.hu> wrote:
>
> Hello,
>
> I plan to submit a patch to restore earlier performance today - I think I've came up with a plan to make a more complete fix; but that will definetly take more time than a few days...and of course there is a risk that I'm wrong :)
>
> cheers,
> Zoltan
>
>
> On 07/02/2018 09:13 PM, Volodymyr Vysotskyi wrote:
>> I think I can finish CALCITE-2392 on Wed or Thursday.
>> Kind regards,
>> Volodymyr Vysotskyi
>> пн, 2 лип. 2018 о 21:22 Julian Hyde <jh...@apache.org> пише:
>>> OK, so 2384 and 2392 are the critical path.
>>>
>>> Zoltan, when do you think you can finish 2392?
>>>
>>> Volodymr, when do you think you can finish 2384?
>>>
>>> When we have these answers we can set a target date for the RC.
>>>
>>> Julian
>>>
>>>
>>>> On Jul 2, 2018, at 11:13 AM, Volodymyr Vysotskyi <vo...@apache.org>
>>> wrote:
>>>>
>>>> Hi,
>>>>
>>>> Here is the list of the Jiras, which in my opinions should be fixed
>>> before
>>>> the release:
>>>> - https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
>>>> - https://issues.apache.org/jira/browse/CALCITE-2392 Regression
>>>> appeared after 1.16 (not sure about blocker status for this Jira)
>>>> - https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - I will
>>> merge PR
>>>> soon
>>>>
>>>> Nice to have fixes (most of them from the previous list):
>>>> - https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB -
>>>> AFAIK, Igor Kryvenko is working on the moving calcite-test-dataset to
>>>> docker, so after that, we can merge it.
>>>> - https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax
>>>> - https://issues.apache.org/jira/browse/CALCITE-2280 Babel (blocked by
>>> 2259)
>>>> - https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
>>> timestamp
>>>> arithmetic
>>>>
>>>> Depending on the time, required to fix CALCITE-2384
>>>> <https://issues.apache.org/jira/browse/CALCITE-2384> and CALCITE-2392
>>>> <https://issues.apache.org/jira/browse/CALCITE-2392>, we can set a
>>> target
>>>> date for the first RC, but I don't know the complexity of these issues
>>> and
>>>> current status for CALCITE-2384
>>>> <https://issues.apache.org/jira/browse/CALCITE-2384>.
>>>>
>>>> Kind regards,
>>>> Volodymyr Vysotskyi
>>>>
>>>>
>>>> пн, 2 лип. 2018 о 20:42 Julian Hyde <jh...@apache.org> пише:
>>>>
>>>>>> On Jun 29, 2018, at 7:29 PM, Francis Chuang <francischuang@apache.org
>>>>> <ma...@apache.org> wrote:
>>>>>>
>>>>>> Can someone please confirm that the following PRs can be closed?
>>>>>> https://github.com/apache/calcite/pull/180 <
>>>>> https://github.com/apache/calcite/pull/180>
>>>>>> https://github.com/apache/calcite/pull/17 <
>>>>> https://github.com/apache/calcite/pull/17>
>>>>>> https://github.com/apache/calcite/pull/422 <
>>>>> https://github.com/apache/calcite/pull/422>
>>>>>
>>>>> I reviewed those PRs. They can be closed. I added comments asking the
>>>>> original contributors to close the PRs. This is always the preferred
>>> option.
>>>>>
>>>>> Are we agreed that adding ‘Close #NNN’ to another commit - while not
>>>>> perfect - is the least bad option for closing abandoned PRs? If so I’ll
>>> do
>>>>> that for these PRs in about 24 hours.
>>>>>
>>>>> Volodymyr,
>>>>>
>>>>> Do we have a list of what’s left for 1.17? I think we can set a target
>>>>> date for the first RC.
>>>>>
>>>>> Julian
>>>>>
>>>>>
>>>
>>>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Zoltan Haindrich <ki...@rxd.hu>.
Hello,
I plan to submit a patch to restore earlier performance today - I think I've came up with a plan to make a more complete fix; but that will definetly take more time than a
few days...and of course there is a risk that I'm wrong :)
cheers,
Zoltan
On 07/02/2018 09:13 PM, Volodymyr Vysotskyi wrote:
> I think I can finish CALCITE-2392 on Wed or Thursday.
>
> Kind regards,
> Volodymyr Vysotskyi
>
>
> пн, 2 лип. 2018 о 21:22 Julian Hyde <jh...@apache.org> пише:
>
>> OK, so 2384 and 2392 are the critical path.
>>
>> Zoltan, when do you think you can finish 2392?
>>
>> Volodymr, when do you think you can finish 2384?
>>
>> When we have these answers we can set a target date for the RC.
>>
>> Julian
>>
>>
>>> On Jul 2, 2018, at 11:13 AM, Volodymyr Vysotskyi <vo...@apache.org>
>> wrote:
>>>
>>> Hi,
>>>
>>> Here is the list of the Jiras, which in my opinions should be fixed
>> before
>>> the release:
>>> - https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
>>> - https://issues.apache.org/jira/browse/CALCITE-2392 Regression
>>> appeared after 1.16 (not sure about blocker status for this Jira)
>>> - https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - I will
>> merge PR
>>> soon
>>>
>>> Nice to have fixes (most of them from the previous list):
>>> - https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB -
>>> AFAIK, Igor Kryvenko is working on the moving calcite-test-dataset to
>>> docker, so after that, we can merge it.
>>> - https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax
>>> - https://issues.apache.org/jira/browse/CALCITE-2280 Babel (blocked by
>> 2259)
>>> - https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
>> timestamp
>>> arithmetic
>>>
>>> Depending on the time, required to fix CALCITE-2384
>>> <https://issues.apache.org/jira/browse/CALCITE-2384> and CALCITE-2392
>>> <https://issues.apache.org/jira/browse/CALCITE-2392>, we can set a
>> target
>>> date for the first RC, but I don't know the complexity of these issues
>> and
>>> current status for CALCITE-2384
>>> <https://issues.apache.org/jira/browse/CALCITE-2384>.
>>>
>>> Kind regards,
>>> Volodymyr Vysotskyi
>>>
>>>
>>> пн, 2 лип. 2018 о 20:42 Julian Hyde <jh...@apache.org> пише:
>>>
>>>>> On Jun 29, 2018, at 7:29 PM, Francis Chuang <francischuang@apache.org
>>>> <ma...@apache.org> wrote:
>>>>>
>>>>> Can someone please confirm that the following PRs can be closed?
>>>>> https://github.com/apache/calcite/pull/180 <
>>>> https://github.com/apache/calcite/pull/180>
>>>>> https://github.com/apache/calcite/pull/17 <
>>>> https://github.com/apache/calcite/pull/17>
>>>>> https://github.com/apache/calcite/pull/422 <
>>>> https://github.com/apache/calcite/pull/422>
>>>>
>>>> I reviewed those PRs. They can be closed. I added comments asking the
>>>> original contributors to close the PRs. This is always the preferred
>> option.
>>>>
>>>> Are we agreed that adding ‘Close #NNN’ to another commit - while not
>>>> perfect - is the least bad option for closing abandoned PRs? If so I’ll
>> do
>>>> that for these PRs in about 24 hours.
>>>>
>>>> Volodymyr,
>>>>
>>>> Do we have a list of what’s left for 1.17? I think we can set a target
>>>> date for the first RC.
>>>>
>>>> Julian
>>>>
>>>>
>>
>>
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Volodymyr Vysotskyi <vo...@apache.org>.
I think I can finish CALCITE-2392 on Wed or Thursday.
Kind regards,
Volodymyr Vysotskyi
пн, 2 лип. 2018 о 21:22 Julian Hyde <jh...@apache.org> пише:
> OK, so 2384 and 2392 are the critical path.
>
> Zoltan, when do you think you can finish 2392?
>
> Volodymr, when do you think you can finish 2384?
>
> When we have these answers we can set a target date for the RC.
>
> Julian
>
>
> > On Jul 2, 2018, at 11:13 AM, Volodymyr Vysotskyi <vo...@apache.org>
> wrote:
> >
> > Hi,
> >
> > Here is the list of the Jiras, which in my opinions should be fixed
> before
> > the release:
> > - https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
> > - https://issues.apache.org/jira/browse/CALCITE-2392 Regression
> > appeared after 1.16 (not sure about blocker status for this Jira)
> > - https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - I will
> merge PR
> > soon
> >
> > Nice to have fixes (most of them from the previous list):
> > - https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB -
> > AFAIK, Igor Kryvenko is working on the moving calcite-test-dataset to
> > docker, so after that, we can merge it.
> > - https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax
> > - https://issues.apache.org/jira/browse/CALCITE-2280 Babel (blocked by
> 2259)
> > - https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
> timestamp
> > arithmetic
> >
> > Depending on the time, required to fix CALCITE-2384
> > <https://issues.apache.org/jira/browse/CALCITE-2384> and CALCITE-2392
> > <https://issues.apache.org/jira/browse/CALCITE-2392>, we can set a
> target
> > date for the first RC, but I don't know the complexity of these issues
> and
> > current status for CALCITE-2384
> > <https://issues.apache.org/jira/browse/CALCITE-2384>.
> >
> > Kind regards,
> > Volodymyr Vysotskyi
> >
> >
> > пн, 2 лип. 2018 о 20:42 Julian Hyde <jh...@apache.org> пише:
> >
> >>> On Jun 29, 2018, at 7:29 PM, Francis Chuang <francischuang@apache.org
> >> <ma...@apache.org> wrote:
> >>>
> >>> Can someone please confirm that the following PRs can be closed?
> >>> https://github.com/apache/calcite/pull/180 <
> >> https://github.com/apache/calcite/pull/180>
> >>> https://github.com/apache/calcite/pull/17 <
> >> https://github.com/apache/calcite/pull/17>
> >>> https://github.com/apache/calcite/pull/422 <
> >> https://github.com/apache/calcite/pull/422>
> >>
> >> I reviewed those PRs. They can be closed. I added comments asking the
> >> original contributors to close the PRs. This is always the preferred
> option.
> >>
> >> Are we agreed that adding ‘Close #NNN’ to another commit - while not
> >> perfect - is the least bad option for closing abandoned PRs? If so I’ll
> do
> >> that for these PRs in about 24 hours.
> >>
> >> Volodymyr,
> >>
> >> Do we have a list of what’s left for 1.17? I think we can set a target
> >> date for the first RC.
> >>
> >> Julian
> >>
> >>
>
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Julian Hyde <jh...@apache.org>.
OK, so 2384 and 2392 are the critical path.
Zoltan, when do you think you can finish 2392?
Volodymr, when do you think you can finish 2384?
When we have these answers we can set a target date for the RC.
Julian
> On Jul 2, 2018, at 11:13 AM, Volodymyr Vysotskyi <vo...@apache.org> wrote:
>
> Hi,
>
> Here is the list of the Jiras, which in my opinions should be fixed before
> the release:
> - https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
> - https://issues.apache.org/jira/browse/CALCITE-2392 Regression
> appeared after 1.16 (not sure about blocker status for this Jira)
> - https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - I will merge PR
> soon
>
> Nice to have fixes (most of them from the previous list):
> - https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB -
> AFAIK, Igor Kryvenko is working on the moving calcite-test-dataset to
> docker, so after that, we can merge it.
> - https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax
> - https://issues.apache.org/jira/browse/CALCITE-2280 Babel (blocked by 2259)
> - https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter timestamp
> arithmetic
>
> Depending on the time, required to fix CALCITE-2384
> <https://issues.apache.org/jira/browse/CALCITE-2384> and CALCITE-2392
> <https://issues.apache.org/jira/browse/CALCITE-2392>, we can set a target
> date for the first RC, but I don't know the complexity of these issues and
> current status for CALCITE-2384
> <https://issues.apache.org/jira/browse/CALCITE-2384>.
>
> Kind regards,
> Volodymyr Vysotskyi
>
>
> пн, 2 лип. 2018 о 20:42 Julian Hyde <jh...@apache.org> пише:
>
>>> On Jun 29, 2018, at 7:29 PM, Francis Chuang <francischuang@apache.org
>> <ma...@apache.org> wrote:
>>>
>>> Can someone please confirm that the following PRs can be closed?
>>> https://github.com/apache/calcite/pull/180 <
>> https://github.com/apache/calcite/pull/180>
>>> https://github.com/apache/calcite/pull/17 <
>> https://github.com/apache/calcite/pull/17>
>>> https://github.com/apache/calcite/pull/422 <
>> https://github.com/apache/calcite/pull/422>
>>
>> I reviewed those PRs. They can be closed. I added comments asking the
>> original contributors to close the PRs. This is always the preferred option.
>>
>> Are we agreed that adding ‘Close #NNN’ to another commit - while not
>> perfect - is the least bad option for closing abandoned PRs? If so I’ll do
>> that for these PRs in about 24 hours.
>>
>> Volodymyr,
>>
>> Do we have a list of what’s left for 1.17? I think we can set a target
>> date for the first RC.
>>
>> Julian
>>
>>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Volodymyr Vysotskyi <vo...@apache.org>.
Hi,
Here is the list of the Jiras, which in my opinions should be fixed before
the release:
- https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
- https://issues.apache.org/jira/browse/CALCITE-2392 Regression
appeared after 1.16 (not sure about blocker status for this Jira)
- https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - I will merge PR
soon
Nice to have fixes (most of them from the previous list):
- https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB -
AFAIK, Igor Kryvenko is working on the moving calcite-test-dataset to
docker, so after that, we can merge it.
- https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax
- https://issues.apache.org/jira/browse/CALCITE-2280 Babel (blocked by 2259)
- https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter timestamp
arithmetic
Depending on the time, required to fix CALCITE-2384
<https://issues.apache.org/jira/browse/CALCITE-2384> and CALCITE-2392
<https://issues.apache.org/jira/browse/CALCITE-2392>, we can set a target
date for the first RC, but I don't know the complexity of these issues and
current status for CALCITE-2384
<https://issues.apache.org/jira/browse/CALCITE-2384>.
Kind regards,
Volodymyr Vysotskyi
пн, 2 лип. 2018 о 20:42 Julian Hyde <jh...@apache.org> пише:
> > On Jun 29, 2018, at 7:29 PM, Francis Chuang <francischuang@apache.org
> <ma...@apache.org> wrote:
> >
> > Can someone please confirm that the following PRs can be closed?
> > https://github.com/apache/calcite/pull/180 <
> https://github.com/apache/calcite/pull/180>
> > https://github.com/apache/calcite/pull/17 <
> https://github.com/apache/calcite/pull/17>
> > https://github.com/apache/calcite/pull/422 <
> https://github.com/apache/calcite/pull/422>
>
> I reviewed those PRs. They can be closed. I added comments asking the
> original contributors to close the PRs. This is always the preferred option.
>
> Are we agreed that adding ‘Close #NNN’ to another commit - while not
> perfect - is the least bad option for closing abandoned PRs? If so I’ll do
> that for these PRs in about 24 hours.
>
> Volodymyr,
>
> Do we have a list of what’s left for 1.17? I think we can set a target
> date for the first RC.
>
> Julian
>
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Julian Hyde <jh...@apache.org>.
> On Jun 29, 2018, at 7:29 PM, Francis Chuang <francischuang@apache.org <ma...@apache.org> wrote:
>
> Can someone please confirm that the following PRs can be closed?
> https://github.com/apache/calcite/pull/180 <https://github.com/apache/calcite/pull/180>
> https://github.com/apache/calcite/pull/17 <https://github.com/apache/calcite/pull/17>
> https://github.com/apache/calcite/pull/422 <https://github.com/apache/calcite/pull/422>
I reviewed those PRs. They can be closed. I added comments asking the original contributors to close the PRs. This is always the preferred option.
Are we agreed that adding ‘Close #NNN’ to another commit - while not perfect - is the least bad option for closing abandoned PRs? If so I’ll do that for these PRs in about 24 hours.
Volodymyr,
Do we have a list of what’s left for 1.17? I think we can set a target date for the first RC.
Julian
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Michael Mior <mm...@apache.org>.
I asked INFRA and they can only close issues on request. They can't grant
permissions.
--
Michael Mior
mmior@apache.org
Le lun. 2 juil. 2018 à 08:17, Enrico Olivelli <eo...@gmail.com> a
écrit :
> Il giorno lun 2 lug 2018 alle ore 14:12 Michael Mior <mm...@apache.org> ha
> scritto:
>
> > It's not really that I think closing stale PRs warrants an entry in the
> > commit log, it's that I don't like the idea of polluting other commits.
> But
> > it's not really that big of a deal so if others prefer that route, fine
> by
> > me. As far as Enrico's suggestion, I've always had my Apache ID
> associated
> > with my GitHub user and it doesn't allow me close PRs.
> >
>
> Michael, as you are the PMCC, I think you can ask INFRA the permission to
> manage the account.
>
> If it is not possible, I think the only feasible way is to switch to
> GitBox, it is not an huge effort but you will have to change a bunch of
> things, like:
> 1) merge procedures
> 2) release procedures
> 3) docs (only some link to the repo I think)
> 4) make committers have a github account, linked to Apache ID
>
> Many projects in ASF already switched to full GitBox, but it would be a
> step to be decided by the community.
>
> Enrico
>
>
>
> > --
> > Michael Mior
> > mmior@apache.org
> >
> >
> >
> > Le lun. 2 juil. 2018 à 02:49, Enrico Olivelli <eo...@gmail.com> a
> > écrit :
> >
> > > Il lun 2 lug 2018, 06:33 Julian Hyde <jh...@apache.org> ha scritto:
> > >
> > > > I disagree with Michael. Closing rejected PRs is not important enough
> > to
> > > > warrant making an entry in the commit log.
> > > >
> > >
> > > I agree with Julian
> > >
> > >
> > > > Regarding Enrico’s comments. I would be nice if there was a way for
> > > > committers to close PRs, and there probably is. I don’t have the time
> > and
> > > > energy to find out, but I won’t stand in someone else’s way.
> > > >
> > >
> > > Some committer could try to bind his apache id with his github id,
> using
> > > https://gitbox.apache.org/setup/
> > > You will have to enable Two factor auth on GitHub.
> > > I am not sure this will be enough to do the trick, on Apache BookKeeper
> > we
> > > moved completely to Gitbox so in that case it is all simpler
> > >
> > > I will be happy to help
> > >
> > > Enrico
> > >
> > >
> > >
> > >
> > >
> > > > Julian
> > > >
> > > >
> > > > > On Jun 30, 2018, at 7:42 AM, Enrico Olivelli <eo...@gmail.com>
> > > > wrote:
> > > > >
> > > > > Jumping on this train....
> > > > > In theory committers should be able to close prs using thethe
> button.
> > > > >
> > > > > Ask infra to have this permission, at least the Pmc
> > > > >
> > > > > Enrico
> > > > >
> > > > > Il sab 30 giu 2018, 16:07 Michael Mior <mm...@apache.org> ha
> > scritto:
> > > > >
> > > > >> I'd suggest just using the --allow-empty flag to git commit to
> > create
> > > a
> > > > >> commit with no changes so at least we have a distinct entry in the
> > > > commit
> > > > >> log to record closing the PRs.
> > > > >>
> > > > >> I'd say close 17 and 180 given how old they are. If anything that
> > old
> > > is
> > > > >> important, it can always be reopened or a new PR created. I don't
> > know
> > > > the
> > > > >> context for 422.
> > > > >>
> > > > >> --
> > > > >> Michael Mior
> > > > >> mmior@apache.org
> > > > >>
> > > > >>
> > > > >>
> > > > >> Le sam. 30 juin 2018 à 03:41, Julian Hyde <jhyde.apache@gmail.com
> >
> > a
> > > > >> écrit :
> > > > >>
> > > > >>> When we decide to close these, rather than bothering INFRA, I’ll
> > just
> > > > add
> > > > >>> “close apache/calcite#nnn” to the next commit that I merge to
> > master.
> > > > >>>
> > > > >>> Julian
> > > > >>>
> > > > >>>> On Jun 29, 2018, at 7:29 PM, Francis Chuang <
> > > francischuang@apache.org
> > > > >
> > > > >>> wrote:
> > > > >>>>
> > > > >>>> Thanks Julian + Sergey!
> > > > >>>>
> > > > >>>> Can someone please confirm that the following PRs can be closed?
> > > > >>>> https://github.com/apache/calcite/pull/180
> > > > >>>> https://github.com/apache/calcite/pull/17
> > > > >>>> https://github.com/apache/calcite/pull/422
> > > > >>>>
> > > > >>>> If so, I'll open a case with INFRA to close them.
> > > > >>>>
> > > > >>>> Francis
> > > > >>>>
> > > > >>>>> On 30/06/2018 7:14 AM, Julian Hyde wrote:
> > > > >>>>> Thanks for bringing this up, Francis. Note that sometimes there
> > are
> > > > >>>>> comments on the JIRA case (and so sometimes the ball might be
> in
> > > the
> > > > >>>>> contributor's court). But yes, let's either review all of these
> > or
> > > > >>>>> close them as stale.
> > > > >>>>>
> > > > >>>>> As it happens, I picked up a half-finished patch
> > > > >>>>> https://issues.apache.org/jira/browse/CALCITE-2281 yesterday,
> > > > >> finished
> > > > >>>>> it, and merged it. This is never a small amount of work.
> > > Contributors
> > > > >>>>> need to realize that if they do not provide clean, running code
> > > with
> > > > a
> > > > >>>>> test case, then their PR is unlikely to make it. I could have
> > > watched
> > > > >>>>> a full-length movie with my kids in the time it took to get
> that
> > PR
> > > > >>>>> into shape.
> > > > >>>>>
> > > > >>>>> Julian
> > > > >>>>>
> > > > >>>>>
> > > > >>>>> On Fri, Jun 29, 2018 at 8:29 AM, Sergey Nuyanzin <
> > > > snuyanzin@gmail.com
> > > > >>>
> > > > >>> wrote:
> > > > >>>>>>>> [CALCITE-1866]
> > > > >>>>>> adapted existing changes to current master + added tests
> > > > >>>>>>
> > > > >>>>>> On Fri, Jun 29, 2018 at 2:14 AM, Francis Chuang <
> > > > >>> francischuang@apache.org>
> > > > >>>>>> wrote:
> > > > >>>>>>
> > > > >>>>>>> I would love to see if we can close out/merge some of the
> > really
> > > > >>> stale PRs
> > > > >>>>>>> on Github.
> > > > >>>>>>>
> > > > >>>>>>> Here are a few that I think we should resolve before the
> > release:
> > > > >>>>>>>
> > > > >>>>>>> [CALCITE-1025] Add support for HTTP Basic auth (for proxies)
> in
> > > > >>> Avatica:
> > > > >>>>>>> https://github.com/apache/calcite/pull/180 (JIRA is marked
> as
> > > > >>> resolved
> > > > >>>>>>> and this PR is probably irrelevant since Avatica is now in a
> > > > >>> different repo)
> > > > >>>>>>>
> > > > >>>>>>> Add support for converting a MongoDB date to a SQL timestamp
> > > type:
> > > > >>>>>>> https://github.com/apache/calcite/pull/17 (Could not find
> > > relevant
> > > > >>> JIRA.
> > > > >>>>>>> No tests. Original contributor probably lost context, since
> > it's
> > > > >>> almost 4
> > > > >>>>>>> years old)
> > > > >>>>>>>
> > > > >>>>>>> CALCITE-1681 Provide a way to copy RelNode trees between
> > > clusters:
> > > > >>>>>>> https://github.com/apache/calcite/pull/392 (No review,
> despite
> > > the
> > > > >>>>>>> contributor asking for one. Do you think it would be possible
> > to
> > > > >>> finish
> > > > >>>>>>> this? PR is more than a year old, so contributor might have
> > lost
> > > > >>> context)
> > > > >>>>>>>
> > > > >>>>>>> CALCITE-1748: make method getSchema to be overridable:
> > > > >>>>>>> https://github.com/apache/calcite/pull/422 (The proposed
> > > solution
> > > > >>>>>>> appeared to be unnecessary according to the comments on JIRA,
> > so
> > > > >> this
> > > > >>> is
> > > > >>>>>>> probably safe to close. Can the JIRA issue be marked as
> > resolved
> > > or
> > > > >>> do we
> > > > >>>>>>> still need to work on it?)
> > > > >>>>>>>
> > > > >>>>>>> [CALCITE-1866] dateTime FLOOR to HOUR cause MySQL connector
> > throw
> > > > >>>>>>> SQLException: https://github.com/apache/calcite/pull/488
> > > (Original
> > > > >>>>>>> contribution missing a test case. Seems to be abandoned by
> the
> > > > >>> contributor.
> > > > >>>>>>> I think it shouldn't be too onerous if someone could carry
> the
> > PR
> > > > >> and
> > > > >>> add a
> > > > >>>>>>> test).
> > > > >>>>>>>
> > > > >>>>>>> [CALCITE-1882] Can't obtain the user defined aggregate
> function
> > > > such
> > > > >>> as
> > > > >>>>>>> sum,avg by calcite:
> https://github.com/apache/calcite/pull/502
> > > > (Was
> > > > >>> dead
> > > > >>>>>>> for a while, but contributor addressed comments 2 months ago.
> > Can
> > > > >>> someone
> > > > >>>>>>> please review so we can get this in?)
> > > > >>>>>>>
> > > > >>>>>>> These are just some PRs I found from a quick look through
> > > Github. I
> > > > >>> think
> > > > >>>>>>> a few of them should be easy to carry so that we can get them
> > > into
> > > > >> the
> > > > >>>>>>> release. For PRs #180 and #422 can someone confirm if they
> are
> > > safe
> > > > >> to
> > > > >>>>>>> close? If so, I'll ask INFRA to close them.
> > > > >>>>>>>
> > > > >>>>>>> There are also a bunch of PRs from a year ago that are going
> > > stale.
> > > > >> If
> > > > >>>>>>> possible we should review, carry, close or merge them.
> Having
> > a
> > > > lot
> > > > >>> of
> > > > >>>>>>> stale PRs without any activity or review may deter
> contributors
> > > new
> > > > >>> to the
> > > > >>>>>>> community from contributing.
> > > > >>>>>>>
> > > > >>>>>>> Francis
> > > > >>>>>>>
> > > > >>>>>>>
> > > > >>>>>>>> On 29/06/2018 3:54 AM, Michael Mior wrote:
> > > > >>>>>>>>
> > > > >>>>>>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe
> > > Andrei
> > > > >> is
> > > > >>>>>>>> working on a PR and this would be a good bug to have fixed.
> > > > >>>>>>>>
> > > > >>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2331
> > evaluation
> > > > of
> > > > >>>>>>>> predicate (A or B) and C is failing for some adapters
> > > > >>>>>>>>
> > > > >>>>>>>> --
> > > > >>>>>>>> Michael Mior
> > > > >>>>>>>> mmior@apache.org
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jhyde@apache.org
> >
> > a
> > > > >>> écrit :
> > > > >>>>>>>>
> > > > >>>>>>>> To answer Michael's question: I don't think we should delay
> > the
> > > > >>>>>>>>> report, nor should we hurry the release. It's fair to say
> > that
> > > > >> 1.17
> > > > >>> is
> > > > >>>>>>>>> in its final stages. There was a lot of activity on
> > > avatica-1.12
> > > > >>> from
> > > > >>>>>>>>> a lot of individuals, and the community is in great shape.
> > > > >>>>>>>>>
> > > > >>>>>>>>> Here are the cases listed by Volodymyr, converted into
> links:
> > > > >>>>>>>>>
> > > > >>>>>>>>> Must:
> > > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS
> -
> > ?
> > > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2384
> > > Performance
> > > > >>> issue
> > > > >>>>>>>>> in getPulledUpPredicates - Zoltan
> > > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2365
> Upgrade
> > > > >>> Avatica -
> > > > >>>>>>>>> Julian
> > > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2303
> > EXTRACT -
> > > > >>> Julian
> > > > >>>>>>>>>
> > > > >>>>>>>>> Nice:
> > > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays
> > in
> > > > >>> MongoDB
> > > > >>>>>>>>> - Volodymyr
> > > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8
> > > > >> syntax -
> > > > >>>>>>>>> Kevin
> > > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2280
> Babel -
> > > > >> Julian
> > > > >>>>>>>>> (blocked by 2259)
> > > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC
> > > > adapter
> > > > >>>>>>>>> timestamps - Julian to review
> > > > >>>>>>>>>
> > > > >>>>>>>>> Julian
> > > > >>>>>>>>>
> > > > >>>>>>>>>
> > > > >>>>>>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> > > > >>>>>>>>> <vo...@apache.org> wrote:
> > > > >>>>>>>>>
> > > > >>>>>>>>>> Hi Michael,
> > > > >>>>>>>>>>
> > > > >>>>>>>>>> There are several Jiras, which I think are blockers for
> the
> > > > >>>>>>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
> > > > >>> CALCITE-2303.
> > > > >>>>>>>>>> Also, there is a list of the Jiras, which would be good to
> > > > >> include
> > > > >>> to
> > > > >>>>>>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280,
> CALCITE-2339.
> > > > >>>>>>>>>>
> > > > >>>>>>>>>> So I think we need at least couple of weeks to resolve
> these
> > > > >>> issues and
> > > > >>>>>>>>>> release 1.17.
> > > > >>>>>>>>>>
> > > > >>>>>>>>>> Also, please let me know if there are other
> issues-blockers
> > > for
> > > > >> the
> > > > >>>>>>>>>> release, or if some of these issues may be omitted.
> > > > >>>>>>>>>>
> > > > >>>>>>>>>> Kind regards,
> > > > >>>>>>>>>> Volodymyr Vysotskyi
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>
> > > > >>>>>>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <
> > > eolivelli@gmail.com>
> > > > >>> пише:
> > > > >>>>>>>>>>
> > > > >>>>>>>>>> It also would be great to have at least a BETA version of
> > > Babel
> > > > >>> parser
> > > > >>>>>>>>>>> Enrico
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mmior@apache.org
> >
> > ha
> > > > >>> scritto:
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>> Just wanted to check in with how we're doing with
> progress
> > > > >>> towards a
> > > > >>>>>>>>>>>> release. It's not a rush at all, but I'm preparing the
> > board
> > > > >>> report
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>> for
> > > > >>>>>>>>>> July and wondering if I should wait to include the 1.17.0
> > > > >> release.
> > > > >>> It
> > > > >>>>>>>>>>>> sounds like there are a few other things that still need
> > to
> > > be
> > > > >>> wrapped
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>> up,
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>>> so I'm fine if we don't release for another couple
> weeks.
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>>> Thanks again Volodymyr for taking this on!
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>>> --
> > > > >>>>>>>>>>>> Michael Mior
> > > > >>>>>>>>>>>> mmior@apache.org
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>> volodymyr@apache.org>
> > > > >>>>>>>>>> a
> > > > >>>>>>>>>>>> écrit :
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>>> Calcite 1.16.0 was released on March 19 (more than two
> > > months
> > > > >>> ago).
> > > > >>>>>>>>>>>>> We have solved over 48 issues[1] since then, therefore
> we
> > > > >> should
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> start
> > > > >>>>>>>>>> discussing about releasing Calcite 1.17.0.
> > > > >>>>>>>>>>>>> I have created [2] to track the release.
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>>> We will start a release process after the Avatica 1.12
> is
> > > > >>> released.
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>>> I went through the list of opened PRs during the last
> > > month,
> > > > >> and
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> here
> > > > >>>>>>>>>> is
> > > > >>>>>>>>>>>> the list of Jiras which possibly be merged before the
> > > release:
> > > > >>>>>>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT
> > function
> > > -
> > > > >>> changes
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> are
> > > > >>>>>>>>>>>> done, depends on the Avatica release
> > > > >>>>>>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
> > > > >> operator
> > > > >>> with
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> the
> > > > >>>>>>>>>>>> constant from the left side more optimally - I will make
> > > > >> required
> > > > >>>>>>>>>>>> changes
> > > > >>>>>>>>>>>> at the beginning of next week
> > > > >>>>>>>>>>>>> * CALCITE-2321: Support ragged fixed length value union
> > be
> > > > >>> variable
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> -
> > > > >>>>>>>>>> In review (Julian)*
> > > > >>>>>>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate
> > - I
> > > > >> will
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> pick
> > > > >>>>>>>>>> up
> > > > >>>>>>>>>>>> this next week*
> > > > >>>>>>>>>>>>> List of other pull requests which require review or
> > > > additional
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> rework:
> > > > >>>>>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may not
> > be
> > > > >>>>>>>>>>>> simplified
> > > > >>>>>>>>>>>> to
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>>>> false
> > > > >>>>>>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast
> support -
> > > > >> Julian
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> added
> > > > >>>>>>>>>> a
> > > > >>>>>>>>>>>> comment into the Jira
> > > > >>>>>>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is
> > > > >> failing
> > > > >>> for
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> some
> > > > >>>>>>>>>>>> adapters - created PR only with a test for this Jira
> > > > >>>>>>>>>>>>> CALCITE-2209: Support loading JSON model file through
> > URL -
> > > > >>> Shuyi
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> Chen
> > > > >>>>>>>>>> added a comment into the Jira
> > > > >>>>>>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works
> > not
> > > > >>> correct
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> in
> > > > >>>>>>>>>> some
> > > > >>>>>>>>>>>>> cases
> > > > >>>>>>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of
> Boolean
> > > > >>> expressions
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> should
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>>>> be set to FLOAT.
> > > > >>>>>>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest
> > > input
> > > > -
> > > > >>> PR is
> > > > >>>>>>>>>>>>> created
> > > > >>>>>>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction
> in
> > > > >>>>>>>>>>>>> ResultSetEnumerable - needs additional rework.
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>>> Please let me know, if there are any Jiras should be
> > > included
> > > > >>> into
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> this
> > > > >>>>>>>>>> release.
> > > > >>>>>>>>>>>>> [1]
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>
> > https://issues.apache.org/jira/issues/?jql=project%20%3D%
> > > > >>>>>>>>> 20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resoluti
> > > > >>>>>>>>> on%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> > > > >>>>>>>>>
> > > > >>>>>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
> > > > >>>>>>>>>>>>> Kind regards,
> > > > >>>>>>>>>>>>> Volodymyr Vysotskyi
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>>> --
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>> -- Enrico Olivelli
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>>
> > > > >>>>>>
> > > > >>>>>> --
> > > > >>>>>> Best regards,
> > > > >>>>>> Sergey
> > > > >>>>
> > > > >>>>
> > > > >>>
> > > > >>
> > > > > --
> > > > >
> > > > >
> > > > > -- Enrico Olivelli
> > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Enrico Olivelli <eo...@gmail.com>.
Il giorno lun 2 lug 2018 alle ore 14:12 Michael Mior <mm...@apache.org> ha
scritto:
> It's not really that I think closing stale PRs warrants an entry in the
> commit log, it's that I don't like the idea of polluting other commits. But
> it's not really that big of a deal so if others prefer that route, fine by
> me. As far as Enrico's suggestion, I've always had my Apache ID associated
> with my GitHub user and it doesn't allow me close PRs.
>
Michael, as you are the PMCC, I think you can ask INFRA the permission to
manage the account.
If it is not possible, I think the only feasible way is to switch to
GitBox, it is not an huge effort but you will have to change a bunch of
things, like:
1) merge procedures
2) release procedures
3) docs (only some link to the repo I think)
4) make committers have a github account, linked to Apache ID
Many projects in ASF already switched to full GitBox, but it would be a
step to be decided by the community.
Enrico
> --
> Michael Mior
> mmior@apache.org
>
>
>
> Le lun. 2 juil. 2018 à 02:49, Enrico Olivelli <eo...@gmail.com> a
> écrit :
>
> > Il lun 2 lug 2018, 06:33 Julian Hyde <jh...@apache.org> ha scritto:
> >
> > > I disagree with Michael. Closing rejected PRs is not important enough
> to
> > > warrant making an entry in the commit log.
> > >
> >
> > I agree with Julian
> >
> >
> > > Regarding Enrico’s comments. I would be nice if there was a way for
> > > committers to close PRs, and there probably is. I don’t have the time
> and
> > > energy to find out, but I won’t stand in someone else’s way.
> > >
> >
> > Some committer could try to bind his apache id with his github id, using
> > https://gitbox.apache.org/setup/
> > You will have to enable Two factor auth on GitHub.
> > I am not sure this will be enough to do the trick, on Apache BookKeeper
> we
> > moved completely to Gitbox so in that case it is all simpler
> >
> > I will be happy to help
> >
> > Enrico
> >
> >
> >
> >
> >
> > > Julian
> > >
> > >
> > > > On Jun 30, 2018, at 7:42 AM, Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > > >
> > > > Jumping on this train....
> > > > In theory committers should be able to close prs using thethe button.
> > > >
> > > > Ask infra to have this permission, at least the Pmc
> > > >
> > > > Enrico
> > > >
> > > > Il sab 30 giu 2018, 16:07 Michael Mior <mm...@apache.org> ha
> scritto:
> > > >
> > > >> I'd suggest just using the --allow-empty flag to git commit to
> create
> > a
> > > >> commit with no changes so at least we have a distinct entry in the
> > > commit
> > > >> log to record closing the PRs.
> > > >>
> > > >> I'd say close 17 and 180 given how old they are. If anything that
> old
> > is
> > > >> important, it can always be reopened or a new PR created. I don't
> know
> > > the
> > > >> context for 422.
> > > >>
> > > >> --
> > > >> Michael Mior
> > > >> mmior@apache.org
> > > >>
> > > >>
> > > >>
> > > >> Le sam. 30 juin 2018 à 03:41, Julian Hyde <jh...@gmail.com>
> a
> > > >> écrit :
> > > >>
> > > >>> When we decide to close these, rather than bothering INFRA, I’ll
> just
> > > add
> > > >>> “close apache/calcite#nnn” to the next commit that I merge to
> master.
> > > >>>
> > > >>> Julian
> > > >>>
> > > >>>> On Jun 29, 2018, at 7:29 PM, Francis Chuang <
> > francischuang@apache.org
> > > >
> > > >>> wrote:
> > > >>>>
> > > >>>> Thanks Julian + Sergey!
> > > >>>>
> > > >>>> Can someone please confirm that the following PRs can be closed?
> > > >>>> https://github.com/apache/calcite/pull/180
> > > >>>> https://github.com/apache/calcite/pull/17
> > > >>>> https://github.com/apache/calcite/pull/422
> > > >>>>
> > > >>>> If so, I'll open a case with INFRA to close them.
> > > >>>>
> > > >>>> Francis
> > > >>>>
> > > >>>>> On 30/06/2018 7:14 AM, Julian Hyde wrote:
> > > >>>>> Thanks for bringing this up, Francis. Note that sometimes there
> are
> > > >>>>> comments on the JIRA case (and so sometimes the ball might be in
> > the
> > > >>>>> contributor's court). But yes, let's either review all of these
> or
> > > >>>>> close them as stale.
> > > >>>>>
> > > >>>>> As it happens, I picked up a half-finished patch
> > > >>>>> https://issues.apache.org/jira/browse/CALCITE-2281 yesterday,
> > > >> finished
> > > >>>>> it, and merged it. This is never a small amount of work.
> > Contributors
> > > >>>>> need to realize that if they do not provide clean, running code
> > with
> > > a
> > > >>>>> test case, then their PR is unlikely to make it. I could have
> > watched
> > > >>>>> a full-length movie with my kids in the time it took to get that
> PR
> > > >>>>> into shape.
> > > >>>>>
> > > >>>>> Julian
> > > >>>>>
> > > >>>>>
> > > >>>>> On Fri, Jun 29, 2018 at 8:29 AM, Sergey Nuyanzin <
> > > snuyanzin@gmail.com
> > > >>>
> > > >>> wrote:
> > > >>>>>>>> [CALCITE-1866]
> > > >>>>>> adapted existing changes to current master + added tests
> > > >>>>>>
> > > >>>>>> On Fri, Jun 29, 2018 at 2:14 AM, Francis Chuang <
> > > >>> francischuang@apache.org>
> > > >>>>>> wrote:
> > > >>>>>>
> > > >>>>>>> I would love to see if we can close out/merge some of the
> really
> > > >>> stale PRs
> > > >>>>>>> on Github.
> > > >>>>>>>
> > > >>>>>>> Here are a few that I think we should resolve before the
> release:
> > > >>>>>>>
> > > >>>>>>> [CALCITE-1025] Add support for HTTP Basic auth (for proxies) in
> > > >>> Avatica:
> > > >>>>>>> https://github.com/apache/calcite/pull/180 (JIRA is marked as
> > > >>> resolved
> > > >>>>>>> and this PR is probably irrelevant since Avatica is now in a
> > > >>> different repo)
> > > >>>>>>>
> > > >>>>>>> Add support for converting a MongoDB date to a SQL timestamp
> > type:
> > > >>>>>>> https://github.com/apache/calcite/pull/17 (Could not find
> > relevant
> > > >>> JIRA.
> > > >>>>>>> No tests. Original contributor probably lost context, since
> it's
> > > >>> almost 4
> > > >>>>>>> years old)
> > > >>>>>>>
> > > >>>>>>> CALCITE-1681 Provide a way to copy RelNode trees between
> > clusters:
> > > >>>>>>> https://github.com/apache/calcite/pull/392 (No review, despite
> > the
> > > >>>>>>> contributor asking for one. Do you think it would be possible
> to
> > > >>> finish
> > > >>>>>>> this? PR is more than a year old, so contributor might have
> lost
> > > >>> context)
> > > >>>>>>>
> > > >>>>>>> CALCITE-1748: make method getSchema to be overridable:
> > > >>>>>>> https://github.com/apache/calcite/pull/422 (The proposed
> > solution
> > > >>>>>>> appeared to be unnecessary according to the comments on JIRA,
> so
> > > >> this
> > > >>> is
> > > >>>>>>> probably safe to close. Can the JIRA issue be marked as
> resolved
> > or
> > > >>> do we
> > > >>>>>>> still need to work on it?)
> > > >>>>>>>
> > > >>>>>>> [CALCITE-1866] dateTime FLOOR to HOUR cause MySQL connector
> throw
> > > >>>>>>> SQLException: https://github.com/apache/calcite/pull/488
> > (Original
> > > >>>>>>> contribution missing a test case. Seems to be abandoned by the
> > > >>> contributor.
> > > >>>>>>> I think it shouldn't be too onerous if someone could carry the
> PR
> > > >> and
> > > >>> add a
> > > >>>>>>> test).
> > > >>>>>>>
> > > >>>>>>> [CALCITE-1882] Can't obtain the user defined aggregate function
> > > such
> > > >>> as
> > > >>>>>>> sum,avg by calcite: https://github.com/apache/calcite/pull/502
> > > (Was
> > > >>> dead
> > > >>>>>>> for a while, but contributor addressed comments 2 months ago.
> Can
> > > >>> someone
> > > >>>>>>> please review so we can get this in?)
> > > >>>>>>>
> > > >>>>>>> These are just some PRs I found from a quick look through
> > Github. I
> > > >>> think
> > > >>>>>>> a few of them should be easy to carry so that we can get them
> > into
> > > >> the
> > > >>>>>>> release. For PRs #180 and #422 can someone confirm if they are
> > safe
> > > >> to
> > > >>>>>>> close? If so, I'll ask INFRA to close them.
> > > >>>>>>>
> > > >>>>>>> There are also a bunch of PRs from a year ago that are going
> > stale.
> > > >> If
> > > >>>>>>> possible we should review, carry, close or merge them. Having
> a
> > > lot
> > > >>> of
> > > >>>>>>> stale PRs without any activity or review may deter contributors
> > new
> > > >>> to the
> > > >>>>>>> community from contributing.
> > > >>>>>>>
> > > >>>>>>> Francis
> > > >>>>>>>
> > > >>>>>>>
> > > >>>>>>>> On 29/06/2018 3:54 AM, Michael Mior wrote:
> > > >>>>>>>>
> > > >>>>>>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe
> > Andrei
> > > >> is
> > > >>>>>>>> working on a PR and this would be a good bug to have fixed.
> > > >>>>>>>>
> > > >>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2331
> evaluation
> > > of
> > > >>>>>>>> predicate (A or B) and C is failing for some adapters
> > > >>>>>>>>
> > > >>>>>>>> --
> > > >>>>>>>> Michael Mior
> > > >>>>>>>> mmior@apache.org
> > > >>>>>>>>
> > > >>>>>>>>
> > > >>>>>>>>
> > > >>>>>>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org>
> a
> > > >>> écrit :
> > > >>>>>>>>
> > > >>>>>>>> To answer Michael's question: I don't think we should delay
> the
> > > >>>>>>>>> report, nor should we hurry the release. It's fair to say
> that
> > > >> 1.17
> > > >>> is
> > > >>>>>>>>> in its final stages. There was a lot of activity on
> > avatica-1.12
> > > >>> from
> > > >>>>>>>>> a lot of individuals, and the community is in great shape.
> > > >>>>>>>>>
> > > >>>>>>>>> Here are the cases listed by Volodymyr, converted into links:
> > > >>>>>>>>>
> > > >>>>>>>>> Must:
> > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS -
> ?
> > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2384
> > Performance
> > > >>> issue
> > > >>>>>>>>> in getPulledUpPredicates - Zoltan
> > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
> > > >>> Avatica -
> > > >>>>>>>>> Julian
> > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2303
> EXTRACT -
> > > >>> Julian
> > > >>>>>>>>>
> > > >>>>>>>>> Nice:
> > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays
> in
> > > >>> MongoDB
> > > >>>>>>>>> - Volodymyr
> > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8
> > > >> syntax -
> > > >>>>>>>>> Kevin
> > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel -
> > > >> Julian
> > > >>>>>>>>> (blocked by 2259)
> > > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC
> > > adapter
> > > >>>>>>>>> timestamps - Julian to review
> > > >>>>>>>>>
> > > >>>>>>>>> Julian
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> > > >>>>>>>>> <vo...@apache.org> wrote:
> > > >>>>>>>>>
> > > >>>>>>>>>> Hi Michael,
> > > >>>>>>>>>>
> > > >>>>>>>>>> There are several Jiras, which I think are blockers for the
> > > >>>>>>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
> > > >>> CALCITE-2303.
> > > >>>>>>>>>> Also, there is a list of the Jiras, which would be good to
> > > >> include
> > > >>> to
> > > >>>>>>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> > > >>>>>>>>>>
> > > >>>>>>>>>> So I think we need at least couple of weeks to resolve these
> > > >>> issues and
> > > >>>>>>>>>> release 1.17.
> > > >>>>>>>>>>
> > > >>>>>>>>>> Also, please let me know if there are other issues-blockers
> > for
> > > >> the
> > > >>>>>>>>>> release, or if some of these issues may be omitted.
> > > >>>>>>>>>>
> > > >>>>>>>>>> Kind regards,
> > > >>>>>>>>>> Volodymyr Vysotskyi
> > > >>>>>>>>>>
> > > >>>>>>>>>>
> > > >>>>>>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <
> > eolivelli@gmail.com>
> > > >>> пише:
> > > >>>>>>>>>>
> > > >>>>>>>>>> It also would be great to have at least a BETA version of
> > Babel
> > > >>> parser
> > > >>>>>>>>>>> Enrico
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org>
> ha
> > > >>> scritto:
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> Just wanted to check in with how we're doing with progress
> > > >>> towards a
> > > >>>>>>>>>>>> release. It's not a rush at all, but I'm preparing the
> board
> > > >>> report
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>> for
> > > >>>>>>>>>> July and wondering if I should wait to include the 1.17.0
> > > >> release.
> > > >>> It
> > > >>>>>>>>>>>> sounds like there are a few other things that still need
> to
> > be
> > > >>> wrapped
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>> up,
> > > >>>>>>>>>>>
> > > >>>>>>>>>>>> so I'm fine if we don't release for another couple weeks.
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Thanks again Volodymyr for taking this on!
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> --
> > > >>>>>>>>>>>> Michael Mior
> > > >>>>>>>>>>>> mmior@apache.org
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>> volodymyr@apache.org>
> > > >>>>>>>>>> a
> > > >>>>>>>>>>>> écrit :
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Calcite 1.16.0 was released on March 19 (more than two
> > months
> > > >>> ago).
> > > >>>>>>>>>>>>> We have solved over 48 issues[1] since then, therefore we
> > > >> should
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>> start
> > > >>>>>>>>>> discussing about releasing Calcite 1.17.0.
> > > >>>>>>>>>>>>> I have created [2] to track the release.
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> We will start a release process after the Avatica 1.12 is
> > > >>> released.
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> I went through the list of opened PRs during the last
> > month,
> > > >> and
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>> here
> > > >>>>>>>>>> is
> > > >>>>>>>>>>>> the list of Jiras which possibly be merged before the
> > release:
> > > >>>>>>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT
> function
> > -
> > > >>> changes
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>> are
> > > >>>>>>>>>>>> done, depends on the Avatica release
> > > >>>>>>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
> > > >> operator
> > > >>> with
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>> the
> > > >>>>>>>>>>>> constant from the left side more optimally - I will make
> > > >> required
> > > >>>>>>>>>>>> changes
> > > >>>>>>>>>>>> at the beginning of next week
> > > >>>>>>>>>>>>> * CALCITE-2321: Support ragged fixed length value union
> be
> > > >>> variable
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>> -
> > > >>>>>>>>>> In review (Julian)*
> > > >>>>>>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate
> - I
> > > >> will
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>> pick
> > > >>>>>>>>>> up
> > > >>>>>>>>>>>> this next week*
> > > >>>>>>>>>>>>> List of other pull requests which require review or
> > > additional
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>> rework:
> > > >>>>>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may not
> be
> > > >>>>>>>>>>>> simplified
> > > >>>>>>>>>>>> to
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>> false
> > > >>>>>>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support -
> > > >> Julian
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>> added
> > > >>>>>>>>>> a
> > > >>>>>>>>>>>> comment into the Jira
> > > >>>>>>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is
> > > >> failing
> > > >>> for
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>> some
> > > >>>>>>>>>>>> adapters - created PR only with a test for this Jira
> > > >>>>>>>>>>>>> CALCITE-2209: Support loading JSON model file through
> URL -
> > > >>> Shuyi
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>> Chen
> > > >>>>>>>>>> added a comment into the Jira
> > > >>>>>>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works
> not
> > > >>> correct
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>> in
> > > >>>>>>>>>> some
> > > >>>>>>>>>>>>> cases
> > > >>>>>>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean
> > > >>> expressions
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>> should
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>> be set to FLOAT.
> > > >>>>>>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest
> > input
> > > -
> > > >>> PR is
> > > >>>>>>>>>>>>> created
> > > >>>>>>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
> > > >>>>>>>>>>>>> ResultSetEnumerable - needs additional rework.
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> Please let me know, if there are any Jiras should be
> > included
> > > >>> into
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>> this
> > > >>>>>>>>>> release.
> > > >>>>>>>>>>>>> [1]
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%
> > > >>>>>>>>> 20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resoluti
> > > >>>>>>>>> on%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> > > >>>>>>>>>
> > > >>>>>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
> > > >>>>>>>>>>>>> Kind regards,
> > > >>>>>>>>>>>>> Volodymyr Vysotskyi
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> --
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> -- Enrico Olivelli
> > > >>>>>>>>>>>
> > > >>>>>>>>>>>
> > > >>>>>>
> > > >>>>>> --
> > > >>>>>> Best regards,
> > > >>>>>> Sergey
> > > >>>>
> > > >>>>
> > > >>>
> > > >>
> > > > --
> > > >
> > > >
> > > > -- Enrico Olivelli
> > >
> > >
> >
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Michael Mior <mm...@apache.org>.
It's not really that I think closing stale PRs warrants an entry in the
commit log, it's that I don't like the idea of polluting other commits. But
it's not really that big of a deal so if others prefer that route, fine by
me. As far as Enrico's suggestion, I've always had my Apache ID associated
with my GitHub user and it doesn't allow me close PRs.
--
Michael Mior
mmior@apache.org
Le lun. 2 juil. 2018 à 02:49, Enrico Olivelli <eo...@gmail.com> a
écrit :
> Il lun 2 lug 2018, 06:33 Julian Hyde <jh...@apache.org> ha scritto:
>
> > I disagree with Michael. Closing rejected PRs is not important enough to
> > warrant making an entry in the commit log.
> >
>
> I agree with Julian
>
>
> > Regarding Enrico’s comments. I would be nice if there was a way for
> > committers to close PRs, and there probably is. I don’t have the time and
> > energy to find out, but I won’t stand in someone else’s way.
> >
>
> Some committer could try to bind his apache id with his github id, using
> https://gitbox.apache.org/setup/
> You will have to enable Two factor auth on GitHub.
> I am not sure this will be enough to do the trick, on Apache BookKeeper we
> moved completely to Gitbox so in that case it is all simpler
>
> I will be happy to help
>
> Enrico
>
>
>
>
>
> > Julian
> >
> >
> > > On Jun 30, 2018, at 7:42 AM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> > >
> > > Jumping on this train....
> > > In theory committers should be able to close prs using thethe button.
> > >
> > > Ask infra to have this permission, at least the Pmc
> > >
> > > Enrico
> > >
> > > Il sab 30 giu 2018, 16:07 Michael Mior <mm...@apache.org> ha scritto:
> > >
> > >> I'd suggest just using the --allow-empty flag to git commit to create
> a
> > >> commit with no changes so at least we have a distinct entry in the
> > commit
> > >> log to record closing the PRs.
> > >>
> > >> I'd say close 17 and 180 given how old they are. If anything that old
> is
> > >> important, it can always be reopened or a new PR created. I don't know
> > the
> > >> context for 422.
> > >>
> > >> --
> > >> Michael Mior
> > >> mmior@apache.org
> > >>
> > >>
> > >>
> > >> Le sam. 30 juin 2018 à 03:41, Julian Hyde <jh...@gmail.com> a
> > >> écrit :
> > >>
> > >>> When we decide to close these, rather than bothering INFRA, I’ll just
> > add
> > >>> “close apache/calcite#nnn” to the next commit that I merge to master.
> > >>>
> > >>> Julian
> > >>>
> > >>>> On Jun 29, 2018, at 7:29 PM, Francis Chuang <
> francischuang@apache.org
> > >
> > >>> wrote:
> > >>>>
> > >>>> Thanks Julian + Sergey!
> > >>>>
> > >>>> Can someone please confirm that the following PRs can be closed?
> > >>>> https://github.com/apache/calcite/pull/180
> > >>>> https://github.com/apache/calcite/pull/17
> > >>>> https://github.com/apache/calcite/pull/422
> > >>>>
> > >>>> If so, I'll open a case with INFRA to close them.
> > >>>>
> > >>>> Francis
> > >>>>
> > >>>>> On 30/06/2018 7:14 AM, Julian Hyde wrote:
> > >>>>> Thanks for bringing this up, Francis. Note that sometimes there are
> > >>>>> comments on the JIRA case (and so sometimes the ball might be in
> the
> > >>>>> contributor's court). But yes, let's either review all of these or
> > >>>>> close them as stale.
> > >>>>>
> > >>>>> As it happens, I picked up a half-finished patch
> > >>>>> https://issues.apache.org/jira/browse/CALCITE-2281 yesterday,
> > >> finished
> > >>>>> it, and merged it. This is never a small amount of work.
> Contributors
> > >>>>> need to realize that if they do not provide clean, running code
> with
> > a
> > >>>>> test case, then their PR is unlikely to make it. I could have
> watched
> > >>>>> a full-length movie with my kids in the time it took to get that PR
> > >>>>> into shape.
> > >>>>>
> > >>>>> Julian
> > >>>>>
> > >>>>>
> > >>>>> On Fri, Jun 29, 2018 at 8:29 AM, Sergey Nuyanzin <
> > snuyanzin@gmail.com
> > >>>
> > >>> wrote:
> > >>>>>>>> [CALCITE-1866]
> > >>>>>> adapted existing changes to current master + added tests
> > >>>>>>
> > >>>>>> On Fri, Jun 29, 2018 at 2:14 AM, Francis Chuang <
> > >>> francischuang@apache.org>
> > >>>>>> wrote:
> > >>>>>>
> > >>>>>>> I would love to see if we can close out/merge some of the really
> > >>> stale PRs
> > >>>>>>> on Github.
> > >>>>>>>
> > >>>>>>> Here are a few that I think we should resolve before the release:
> > >>>>>>>
> > >>>>>>> [CALCITE-1025] Add support for HTTP Basic auth (for proxies) in
> > >>> Avatica:
> > >>>>>>> https://github.com/apache/calcite/pull/180 (JIRA is marked as
> > >>> resolved
> > >>>>>>> and this PR is probably irrelevant since Avatica is now in a
> > >>> different repo)
> > >>>>>>>
> > >>>>>>> Add support for converting a MongoDB date to a SQL timestamp
> type:
> > >>>>>>> https://github.com/apache/calcite/pull/17 (Could not find
> relevant
> > >>> JIRA.
> > >>>>>>> No tests. Original contributor probably lost context, since it's
> > >>> almost 4
> > >>>>>>> years old)
> > >>>>>>>
> > >>>>>>> CALCITE-1681 Provide a way to copy RelNode trees between
> clusters:
> > >>>>>>> https://github.com/apache/calcite/pull/392 (No review, despite
> the
> > >>>>>>> contributor asking for one. Do you think it would be possible to
> > >>> finish
> > >>>>>>> this? PR is more than a year old, so contributor might have lost
> > >>> context)
> > >>>>>>>
> > >>>>>>> CALCITE-1748: make method getSchema to be overridable:
> > >>>>>>> https://github.com/apache/calcite/pull/422 (The proposed
> solution
> > >>>>>>> appeared to be unnecessary according to the comments on JIRA, so
> > >> this
> > >>> is
> > >>>>>>> probably safe to close. Can the JIRA issue be marked as resolved
> or
> > >>> do we
> > >>>>>>> still need to work on it?)
> > >>>>>>>
> > >>>>>>> [CALCITE-1866] dateTime FLOOR to HOUR cause MySQL connector throw
> > >>>>>>> SQLException: https://github.com/apache/calcite/pull/488
> (Original
> > >>>>>>> contribution missing a test case. Seems to be abandoned by the
> > >>> contributor.
> > >>>>>>> I think it shouldn't be too onerous if someone could carry the PR
> > >> and
> > >>> add a
> > >>>>>>> test).
> > >>>>>>>
> > >>>>>>> [CALCITE-1882] Can't obtain the user defined aggregate function
> > such
> > >>> as
> > >>>>>>> sum,avg by calcite: https://github.com/apache/calcite/pull/502
> > (Was
> > >>> dead
> > >>>>>>> for a while, but contributor addressed comments 2 months ago. Can
> > >>> someone
> > >>>>>>> please review so we can get this in?)
> > >>>>>>>
> > >>>>>>> These are just some PRs I found from a quick look through
> Github. I
> > >>> think
> > >>>>>>> a few of them should be easy to carry so that we can get them
> into
> > >> the
> > >>>>>>> release. For PRs #180 and #422 can someone confirm if they are
> safe
> > >> to
> > >>>>>>> close? If so, I'll ask INFRA to close them.
> > >>>>>>>
> > >>>>>>> There are also a bunch of PRs from a year ago that are going
> stale.
> > >> If
> > >>>>>>> possible we should review, carry, close or merge them. Having a
> > lot
> > >>> of
> > >>>>>>> stale PRs without any activity or review may deter contributors
> new
> > >>> to the
> > >>>>>>> community from contributing.
> > >>>>>>>
> > >>>>>>> Francis
> > >>>>>>>
> > >>>>>>>
> > >>>>>>>> On 29/06/2018 3:54 AM, Michael Mior wrote:
> > >>>>>>>>
> > >>>>>>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe
> Andrei
> > >> is
> > >>>>>>>> working on a PR and this would be a good bug to have fixed.
> > >>>>>>>>
> > >>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation
> > of
> > >>>>>>>> predicate (A or B) and C is failing for some adapters
> > >>>>>>>>
> > >>>>>>>> --
> > >>>>>>>> Michael Mior
> > >>>>>>>> mmior@apache.org
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a
> > >>> écrit :
> > >>>>>>>>
> > >>>>>>>> To answer Michael's question: I don't think we should delay the
> > >>>>>>>>> report, nor should we hurry the release. It's fair to say that
> > >> 1.17
> > >>> is
> > >>>>>>>>> in its final stages. There was a lot of activity on
> avatica-1.12
> > >>> from
> > >>>>>>>>> a lot of individuals, and the community is in great shape.
> > >>>>>>>>>
> > >>>>>>>>> Here are the cases listed by Volodymyr, converted into links:
> > >>>>>>>>>
> > >>>>>>>>> Must:
> > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
> > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2384
> Performance
> > >>> issue
> > >>>>>>>>> in getPulledUpPredicates - Zoltan
> > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
> > >>> Avatica -
> > >>>>>>>>> Julian
> > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT -
> > >>> Julian
> > >>>>>>>>>
> > >>>>>>>>> Nice:
> > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
> > >>> MongoDB
> > >>>>>>>>> - Volodymyr
> > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8
> > >> syntax -
> > >>>>>>>>> Kevin
> > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel -
> > >> Julian
> > >>>>>>>>> (blocked by 2259)
> > >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC
> > adapter
> > >>>>>>>>> timestamps - Julian to review
> > >>>>>>>>>
> > >>>>>>>>> Julian
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> > >>>>>>>>> <vo...@apache.org> wrote:
> > >>>>>>>>>
> > >>>>>>>>>> Hi Michael,
> > >>>>>>>>>>
> > >>>>>>>>>> There are several Jiras, which I think are blockers for the
> > >>>>>>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
> > >>> CALCITE-2303.
> > >>>>>>>>>> Also, there is a list of the Jiras, which would be good to
> > >> include
> > >>> to
> > >>>>>>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> > >>>>>>>>>>
> > >>>>>>>>>> So I think we need at least couple of weeks to resolve these
> > >>> issues and
> > >>>>>>>>>> release 1.17.
> > >>>>>>>>>>
> > >>>>>>>>>> Also, please let me know if there are other issues-blockers
> for
> > >> the
> > >>>>>>>>>> release, or if some of these issues may be omitted.
> > >>>>>>>>>>
> > >>>>>>>>>> Kind regards,
> > >>>>>>>>>> Volodymyr Vysotskyi
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <
> eolivelli@gmail.com>
> > >>> пише:
> > >>>>>>>>>>
> > >>>>>>>>>> It also would be great to have at least a BETA version of
> Babel
> > >>> parser
> > >>>>>>>>>>> Enrico
> > >>>>>>>>>>>
> > >>>>>>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
> > >>> scritto:
> > >>>>>>>>>>>
> > >>>>>>>>>>> Just wanted to check in with how we're doing with progress
> > >>> towards a
> > >>>>>>>>>>>> release. It's not a rush at all, but I'm preparing the board
> > >>> report
> > >>>>>>>>>>>>
> > >>>>>>>>>>> for
> > >>>>>>>>>> July and wondering if I should wait to include the 1.17.0
> > >> release.
> > >>> It
> > >>>>>>>>>>>> sounds like there are a few other things that still need to
> be
> > >>> wrapped
> > >>>>>>>>>>>>
> > >>>>>>>>>>> up,
> > >>>>>>>>>>>
> > >>>>>>>>>>>> so I'm fine if we don't release for another couple weeks.
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> Thanks again Volodymyr for taking this on!
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> --
> > >>>>>>>>>>>> Michael Mior
> > >>>>>>>>>>>> mmior@apache.org
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> > >>>>>>>>>>>>
> > >>>>>>>>>>> volodymyr@apache.org>
> > >>>>>>>>>> a
> > >>>>>>>>>>>> écrit :
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> Calcite 1.16.0 was released on March 19 (more than two
> months
> > >>> ago).
> > >>>>>>>>>>>>> We have solved over 48 issues[1] since then, therefore we
> > >> should
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>> start
> > >>>>>>>>>> discussing about releasing Calcite 1.17.0.
> > >>>>>>>>>>>>> I have created [2] to track the release.
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> We will start a release process after the Avatica 1.12 is
> > >>> released.
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> I went through the list of opened PRs during the last
> month,
> > >> and
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>> here
> > >>>>>>>>>> is
> > >>>>>>>>>>>> the list of Jiras which possibly be merged before the
> release:
> > >>>>>>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT function
> -
> > >>> changes
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>> are
> > >>>>>>>>>>>> done, depends on the Avatica release
> > >>>>>>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
> > >> operator
> > >>> with
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>> the
> > >>>>>>>>>>>> constant from the left side more optimally - I will make
> > >> required
> > >>>>>>>>>>>> changes
> > >>>>>>>>>>>> at the beginning of next week
> > >>>>>>>>>>>>> * CALCITE-2321: Support ragged fixed length value union be
> > >>> variable
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>> -
> > >>>>>>>>>> In review (Julian)*
> > >>>>>>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate - I
> > >> will
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>> pick
> > >>>>>>>>>> up
> > >>>>>>>>>>>> this next week*
> > >>>>>>>>>>>>> List of other pull requests which require review or
> > additional
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>> rework:
> > >>>>>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may not be
> > >>>>>>>>>>>> simplified
> > >>>>>>>>>>>> to
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>> false
> > >>>>>>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support -
> > >> Julian
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>> added
> > >>>>>>>>>> a
> > >>>>>>>>>>>> comment into the Jira
> > >>>>>>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is
> > >> failing
> > >>> for
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>> some
> > >>>>>>>>>>>> adapters - created PR only with a test for this Jira
> > >>>>>>>>>>>>> CALCITE-2209: Support loading JSON model file through URL -
> > >>> Shuyi
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>> Chen
> > >>>>>>>>>> added a comment into the Jira
> > >>>>>>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works not
> > >>> correct
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>> in
> > >>>>>>>>>> some
> > >>>>>>>>>>>>> cases
> > >>>>>>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean
> > >>> expressions
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>> should
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>> be set to FLOAT.
> > >>>>>>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest
> input
> > -
> > >>> PR is
> > >>>>>>>>>>>>> created
> > >>>>>>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
> > >>>>>>>>>>>>> ResultSetEnumerable - needs additional rework.
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> Please let me know, if there are any Jiras should be
> included
> > >>> into
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>> this
> > >>>>>>>>>> release.
> > >>>>>>>>>>>>> [1]
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%
> > >>>>>>>>> 20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resoluti
> > >>>>>>>>> on%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> > >>>>>>>>>
> > >>>>>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
> > >>>>>>>>>>>>> Kind regards,
> > >>>>>>>>>>>>> Volodymyr Vysotskyi
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> --
> > >>>>>>>>>>>
> > >>>>>>>>>>> -- Enrico Olivelli
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>
> > >>>>>> --
> > >>>>>> Best regards,
> > >>>>>> Sergey
> > >>>>
> > >>>>
> > >>>
> > >>
> > > --
> > >
> > >
> > > -- Enrico Olivelli
> >
> >
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Enrico Olivelli <eo...@gmail.com>.
Il lun 2 lug 2018, 06:33 Julian Hyde <jh...@apache.org> ha scritto:
> I disagree with Michael. Closing rejected PRs is not important enough to
> warrant making an entry in the commit log.
>
I agree with Julian
> Regarding Enrico’s comments. I would be nice if there was a way for
> committers to close PRs, and there probably is. I don’t have the time and
> energy to find out, but I won’t stand in someone else’s way.
>
Some committer could try to bind his apache id with his github id, using
https://gitbox.apache.org/setup/
You will have to enable Two factor auth on GitHub.
I am not sure this will be enough to do the trick, on Apache BookKeeper we
moved completely to Gitbox so in that case it is all simpler
I will be happy to help
Enrico
> Julian
>
>
> > On Jun 30, 2018, at 7:42 AM, Enrico Olivelli <eo...@gmail.com>
> wrote:
> >
> > Jumping on this train....
> > In theory committers should be able to close prs using thethe button.
> >
> > Ask infra to have this permission, at least the Pmc
> >
> > Enrico
> >
> > Il sab 30 giu 2018, 16:07 Michael Mior <mm...@apache.org> ha scritto:
> >
> >> I'd suggest just using the --allow-empty flag to git commit to create a
> >> commit with no changes so at least we have a distinct entry in the
> commit
> >> log to record closing the PRs.
> >>
> >> I'd say close 17 and 180 given how old they are. If anything that old is
> >> important, it can always be reopened or a new PR created. I don't know
> the
> >> context for 422.
> >>
> >> --
> >> Michael Mior
> >> mmior@apache.org
> >>
> >>
> >>
> >> Le sam. 30 juin 2018 à 03:41, Julian Hyde <jh...@gmail.com> a
> >> écrit :
> >>
> >>> When we decide to close these, rather than bothering INFRA, I’ll just
> add
> >>> “close apache/calcite#nnn” to the next commit that I merge to master.
> >>>
> >>> Julian
> >>>
> >>>> On Jun 29, 2018, at 7:29 PM, Francis Chuang <francischuang@apache.org
> >
> >>> wrote:
> >>>>
> >>>> Thanks Julian + Sergey!
> >>>>
> >>>> Can someone please confirm that the following PRs can be closed?
> >>>> https://github.com/apache/calcite/pull/180
> >>>> https://github.com/apache/calcite/pull/17
> >>>> https://github.com/apache/calcite/pull/422
> >>>>
> >>>> If so, I'll open a case with INFRA to close them.
> >>>>
> >>>> Francis
> >>>>
> >>>>> On 30/06/2018 7:14 AM, Julian Hyde wrote:
> >>>>> Thanks for bringing this up, Francis. Note that sometimes there are
> >>>>> comments on the JIRA case (and so sometimes the ball might be in the
> >>>>> contributor's court). But yes, let's either review all of these or
> >>>>> close them as stale.
> >>>>>
> >>>>> As it happens, I picked up a half-finished patch
> >>>>> https://issues.apache.org/jira/browse/CALCITE-2281 yesterday,
> >> finished
> >>>>> it, and merged it. This is never a small amount of work. Contributors
> >>>>> need to realize that if they do not provide clean, running code with
> a
> >>>>> test case, then their PR is unlikely to make it. I could have watched
> >>>>> a full-length movie with my kids in the time it took to get that PR
> >>>>> into shape.
> >>>>>
> >>>>> Julian
> >>>>>
> >>>>>
> >>>>> On Fri, Jun 29, 2018 at 8:29 AM, Sergey Nuyanzin <
> snuyanzin@gmail.com
> >>>
> >>> wrote:
> >>>>>>>> [CALCITE-1866]
> >>>>>> adapted existing changes to current master + added tests
> >>>>>>
> >>>>>> On Fri, Jun 29, 2018 at 2:14 AM, Francis Chuang <
> >>> francischuang@apache.org>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> I would love to see if we can close out/merge some of the really
> >>> stale PRs
> >>>>>>> on Github.
> >>>>>>>
> >>>>>>> Here are a few that I think we should resolve before the release:
> >>>>>>>
> >>>>>>> [CALCITE-1025] Add support for HTTP Basic auth (for proxies) in
> >>> Avatica:
> >>>>>>> https://github.com/apache/calcite/pull/180 (JIRA is marked as
> >>> resolved
> >>>>>>> and this PR is probably irrelevant since Avatica is now in a
> >>> different repo)
> >>>>>>>
> >>>>>>> Add support for converting a MongoDB date to a SQL timestamp type:
> >>>>>>> https://github.com/apache/calcite/pull/17 (Could not find relevant
> >>> JIRA.
> >>>>>>> No tests. Original contributor probably lost context, since it's
> >>> almost 4
> >>>>>>> years old)
> >>>>>>>
> >>>>>>> CALCITE-1681 Provide a way to copy RelNode trees between clusters:
> >>>>>>> https://github.com/apache/calcite/pull/392 (No review, despite the
> >>>>>>> contributor asking for one. Do you think it would be possible to
> >>> finish
> >>>>>>> this? PR is more than a year old, so contributor might have lost
> >>> context)
> >>>>>>>
> >>>>>>> CALCITE-1748: make method getSchema to be overridable:
> >>>>>>> https://github.com/apache/calcite/pull/422 (The proposed solution
> >>>>>>> appeared to be unnecessary according to the comments on JIRA, so
> >> this
> >>> is
> >>>>>>> probably safe to close. Can the JIRA issue be marked as resolved or
> >>> do we
> >>>>>>> still need to work on it?)
> >>>>>>>
> >>>>>>> [CALCITE-1866] dateTime FLOOR to HOUR cause MySQL connector throw
> >>>>>>> SQLException: https://github.com/apache/calcite/pull/488 (Original
> >>>>>>> contribution missing a test case. Seems to be abandoned by the
> >>> contributor.
> >>>>>>> I think it shouldn't be too onerous if someone could carry the PR
> >> and
> >>> add a
> >>>>>>> test).
> >>>>>>>
> >>>>>>> [CALCITE-1882] Can't obtain the user defined aggregate function
> such
> >>> as
> >>>>>>> sum,avg by calcite: https://github.com/apache/calcite/pull/502
> (Was
> >>> dead
> >>>>>>> for a while, but contributor addressed comments 2 months ago. Can
> >>> someone
> >>>>>>> please review so we can get this in?)
> >>>>>>>
> >>>>>>> These are just some PRs I found from a quick look through Github. I
> >>> think
> >>>>>>> a few of them should be easy to carry so that we can get them into
> >> the
> >>>>>>> release. For PRs #180 and #422 can someone confirm if they are safe
> >> to
> >>>>>>> close? If so, I'll ask INFRA to close them.
> >>>>>>>
> >>>>>>> There are also a bunch of PRs from a year ago that are going stale.
> >> If
> >>>>>>> possible we should review, carry, close or merge them. Having a
> lot
> >>> of
> >>>>>>> stale PRs without any activity or review may deter contributors new
> >>> to the
> >>>>>>> community from contributing.
> >>>>>>>
> >>>>>>> Francis
> >>>>>>>
> >>>>>>>
> >>>>>>>> On 29/06/2018 3:54 AM, Michael Mior wrote:
> >>>>>>>>
> >>>>>>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei
> >> is
> >>>>>>>> working on a PR and this would be a good bug to have fixed.
> >>>>>>>>
> >>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation
> of
> >>>>>>>> predicate (A or B) and C is failing for some adapters
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> Michael Mior
> >>>>>>>> mmior@apache.org
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a
> >>> écrit :
> >>>>>>>>
> >>>>>>>> To answer Michael's question: I don't think we should delay the
> >>>>>>>>> report, nor should we hurry the release. It's fair to say that
> >> 1.17
> >>> is
> >>>>>>>>> in its final stages. There was a lot of activity on avatica-1.12
> >>> from
> >>>>>>>>> a lot of individuals, and the community is in great shape.
> >>>>>>>>>
> >>>>>>>>> Here are the cases listed by Volodymyr, converted into links:
> >>>>>>>>>
> >>>>>>>>> Must:
> >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
> >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2384 Performance
> >>> issue
> >>>>>>>>> in getPulledUpPredicates - Zoltan
> >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
> >>> Avatica -
> >>>>>>>>> Julian
> >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT -
> >>> Julian
> >>>>>>>>>
> >>>>>>>>> Nice:
> >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
> >>> MongoDB
> >>>>>>>>> - Volodymyr
> >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8
> >> syntax -
> >>>>>>>>> Kevin
> >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel -
> >> Julian
> >>>>>>>>> (blocked by 2259)
> >>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC
> adapter
> >>>>>>>>> timestamps - Julian to review
> >>>>>>>>>
> >>>>>>>>> Julian
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> >>>>>>>>> <vo...@apache.org> wrote:
> >>>>>>>>>
> >>>>>>>>>> Hi Michael,
> >>>>>>>>>>
> >>>>>>>>>> There are several Jiras, which I think are blockers for the
> >>>>>>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
> >>> CALCITE-2303.
> >>>>>>>>>> Also, there is a list of the Jiras, which would be good to
> >> include
> >>> to
> >>>>>>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> >>>>>>>>>>
> >>>>>>>>>> So I think we need at least couple of weeks to resolve these
> >>> issues and
> >>>>>>>>>> release 1.17.
> >>>>>>>>>>
> >>>>>>>>>> Also, please let me know if there are other issues-blockers for
> >> the
> >>>>>>>>>> release, or if some of these issues may be omitted.
> >>>>>>>>>>
> >>>>>>>>>> Kind regards,
> >>>>>>>>>> Volodymyr Vysotskyi
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com>
> >>> пише:
> >>>>>>>>>>
> >>>>>>>>>> It also would be great to have at least a BETA version of Babel
> >>> parser
> >>>>>>>>>>> Enrico
> >>>>>>>>>>>
> >>>>>>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
> >>> scritto:
> >>>>>>>>>>>
> >>>>>>>>>>> Just wanted to check in with how we're doing with progress
> >>> towards a
> >>>>>>>>>>>> release. It's not a rush at all, but I'm preparing the board
> >>> report
> >>>>>>>>>>>>
> >>>>>>>>>>> for
> >>>>>>>>>> July and wondering if I should wait to include the 1.17.0
> >> release.
> >>> It
> >>>>>>>>>>>> sounds like there are a few other things that still need to be
> >>> wrapped
> >>>>>>>>>>>>
> >>>>>>>>>>> up,
> >>>>>>>>>>>
> >>>>>>>>>>>> so I'm fine if we don't release for another couple weeks.
> >>>>>>>>>>>>
> >>>>>>>>>>>> Thanks again Volodymyr for taking this on!
> >>>>>>>>>>>>
> >>>>>>>>>>>> --
> >>>>>>>>>>>> Michael Mior
> >>>>>>>>>>>> mmior@apache.org
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> >>>>>>>>>>>>
> >>>>>>>>>>> volodymyr@apache.org>
> >>>>>>>>>> a
> >>>>>>>>>>>> écrit :
> >>>>>>>>>>>>
> >>>>>>>>>>>> Calcite 1.16.0 was released on March 19 (more than two months
> >>> ago).
> >>>>>>>>>>>>> We have solved over 48 issues[1] since then, therefore we
> >> should
> >>>>>>>>>>>>>
> >>>>>>>>>>>> start
> >>>>>>>>>> discussing about releasing Calcite 1.17.0.
> >>>>>>>>>>>>> I have created [2] to track the release.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> We will start a release process after the Avatica 1.12 is
> >>> released.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> I went through the list of opened PRs during the last month,
> >> and
> >>>>>>>>>>>>>
> >>>>>>>>>>>> here
> >>>>>>>>>> is
> >>>>>>>>>>>> the list of Jiras which possibly be merged before the release:
> >>>>>>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT function -
> >>> changes
> >>>>>>>>>>>>>
> >>>>>>>>>>>> are
> >>>>>>>>>>>> done, depends on the Avatica release
> >>>>>>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
> >> operator
> >>> with
> >>>>>>>>>>>>>
> >>>>>>>>>>>> the
> >>>>>>>>>>>> constant from the left side more optimally - I will make
> >> required
> >>>>>>>>>>>> changes
> >>>>>>>>>>>> at the beginning of next week
> >>>>>>>>>>>>> * CALCITE-2321: Support ragged fixed length value union be
> >>> variable
> >>>>>>>>>>>>>
> >>>>>>>>>>>> -
> >>>>>>>>>> In review (Julian)*
> >>>>>>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate - I
> >> will
> >>>>>>>>>>>>>
> >>>>>>>>>>>> pick
> >>>>>>>>>> up
> >>>>>>>>>>>> this next week*
> >>>>>>>>>>>>> List of other pull requests which require review or
> additional
> >>>>>>>>>>>>>
> >>>>>>>>>>>> rework:
> >>>>>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may not be
> >>>>>>>>>>>> simplified
> >>>>>>>>>>>> to
> >>>>>>>>>>>>
> >>>>>>>>>>>>> false
> >>>>>>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support -
> >> Julian
> >>>>>>>>>>>>>
> >>>>>>>>>>>> added
> >>>>>>>>>> a
> >>>>>>>>>>>> comment into the Jira
> >>>>>>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is
> >> failing
> >>> for
> >>>>>>>>>>>>>
> >>>>>>>>>>>> some
> >>>>>>>>>>>> adapters - created PR only with a test for this Jira
> >>>>>>>>>>>>> CALCITE-2209: Support loading JSON model file through URL -
> >>> Shuyi
> >>>>>>>>>>>>>
> >>>>>>>>>>>> Chen
> >>>>>>>>>> added a comment into the Jira
> >>>>>>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works not
> >>> correct
> >>>>>>>>>>>>>
> >>>>>>>>>>>> in
> >>>>>>>>>> some
> >>>>>>>>>>>>> cases
> >>>>>>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean
> >>> expressions
> >>>>>>>>>>>>>
> >>>>>>>>>>>> should
> >>>>>>>>>>>>
> >>>>>>>>>>>>> be set to FLOAT.
> >>>>>>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest input
> -
> >>> PR is
> >>>>>>>>>>>>> created
> >>>>>>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
> >>>>>>>>>>>>> ResultSetEnumerable - needs additional rework.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Please let me know, if there are any Jiras should be included
> >>> into
> >>>>>>>>>>>>>
> >>>>>>>>>>>> this
> >>>>>>>>>> release.
> >>>>>>>>>>>>> [1]
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%
> >>>>>>>>> 20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resoluti
> >>>>>>>>> on%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> >>>>>>>>>
> >>>>>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
> >>>>>>>>>>>>> Kind regards,
> >>>>>>>>>>>>> Volodymyr Vysotskyi
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> --
> >>>>>>>>>>>
> >>>>>>>>>>> -- Enrico Olivelli
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>
> >>>>>> --
> >>>>>> Best regards,
> >>>>>> Sergey
> >>>>
> >>>>
> >>>
> >>
> > --
> >
> >
> > -- Enrico Olivelli
>
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Julian Hyde <jh...@apache.org>.
I disagree with Michael. Closing rejected PRs is not important enough to warrant making an entry in the commit log.
Regarding Enrico’s comments. I would be nice if there was a way for committers to close PRs, and there probably is. I don’t have the time and energy to find out, but I won’t stand in someone else’s way.
Julian
> On Jun 30, 2018, at 7:42 AM, Enrico Olivelli <eo...@gmail.com> wrote:
>
> Jumping on this train....
> In theory committers should be able to close prs using thethe button.
>
> Ask infra to have this permission, at least the Pmc
>
> Enrico
>
> Il sab 30 giu 2018, 16:07 Michael Mior <mm...@apache.org> ha scritto:
>
>> I'd suggest just using the --allow-empty flag to git commit to create a
>> commit with no changes so at least we have a distinct entry in the commit
>> log to record closing the PRs.
>>
>> I'd say close 17 and 180 given how old they are. If anything that old is
>> important, it can always be reopened or a new PR created. I don't know the
>> context for 422.
>>
>> --
>> Michael Mior
>> mmior@apache.org
>>
>>
>>
>> Le sam. 30 juin 2018 à 03:41, Julian Hyde <jh...@gmail.com> a
>> écrit :
>>
>>> When we decide to close these, rather than bothering INFRA, I’ll just add
>>> “close apache/calcite#nnn” to the next commit that I merge to master.
>>>
>>> Julian
>>>
>>>> On Jun 29, 2018, at 7:29 PM, Francis Chuang <fr...@apache.org>
>>> wrote:
>>>>
>>>> Thanks Julian + Sergey!
>>>>
>>>> Can someone please confirm that the following PRs can be closed?
>>>> https://github.com/apache/calcite/pull/180
>>>> https://github.com/apache/calcite/pull/17
>>>> https://github.com/apache/calcite/pull/422
>>>>
>>>> If so, I'll open a case with INFRA to close them.
>>>>
>>>> Francis
>>>>
>>>>> On 30/06/2018 7:14 AM, Julian Hyde wrote:
>>>>> Thanks for bringing this up, Francis. Note that sometimes there are
>>>>> comments on the JIRA case (and so sometimes the ball might be in the
>>>>> contributor's court). But yes, let's either review all of these or
>>>>> close them as stale.
>>>>>
>>>>> As it happens, I picked up a half-finished patch
>>>>> https://issues.apache.org/jira/browse/CALCITE-2281 yesterday,
>> finished
>>>>> it, and merged it. This is never a small amount of work. Contributors
>>>>> need to realize that if they do not provide clean, running code with a
>>>>> test case, then their PR is unlikely to make it. I could have watched
>>>>> a full-length movie with my kids in the time it took to get that PR
>>>>> into shape.
>>>>>
>>>>> Julian
>>>>>
>>>>>
>>>>> On Fri, Jun 29, 2018 at 8:29 AM, Sergey Nuyanzin <snuyanzin@gmail.com
>>>
>>> wrote:
>>>>>>>> [CALCITE-1866]
>>>>>> adapted existing changes to current master + added tests
>>>>>>
>>>>>> On Fri, Jun 29, 2018 at 2:14 AM, Francis Chuang <
>>> francischuang@apache.org>
>>>>>> wrote:
>>>>>>
>>>>>>> I would love to see if we can close out/merge some of the really
>>> stale PRs
>>>>>>> on Github.
>>>>>>>
>>>>>>> Here are a few that I think we should resolve before the release:
>>>>>>>
>>>>>>> [CALCITE-1025] Add support for HTTP Basic auth (for proxies) in
>>> Avatica:
>>>>>>> https://github.com/apache/calcite/pull/180 (JIRA is marked as
>>> resolved
>>>>>>> and this PR is probably irrelevant since Avatica is now in a
>>> different repo)
>>>>>>>
>>>>>>> Add support for converting a MongoDB date to a SQL timestamp type:
>>>>>>> https://github.com/apache/calcite/pull/17 (Could not find relevant
>>> JIRA.
>>>>>>> No tests. Original contributor probably lost context, since it's
>>> almost 4
>>>>>>> years old)
>>>>>>>
>>>>>>> CALCITE-1681 Provide a way to copy RelNode trees between clusters:
>>>>>>> https://github.com/apache/calcite/pull/392 (No review, despite the
>>>>>>> contributor asking for one. Do you think it would be possible to
>>> finish
>>>>>>> this? PR is more than a year old, so contributor might have lost
>>> context)
>>>>>>>
>>>>>>> CALCITE-1748: make method getSchema to be overridable:
>>>>>>> https://github.com/apache/calcite/pull/422 (The proposed solution
>>>>>>> appeared to be unnecessary according to the comments on JIRA, so
>> this
>>> is
>>>>>>> probably safe to close. Can the JIRA issue be marked as resolved or
>>> do we
>>>>>>> still need to work on it?)
>>>>>>>
>>>>>>> [CALCITE-1866] dateTime FLOOR to HOUR cause MySQL connector throw
>>>>>>> SQLException: https://github.com/apache/calcite/pull/488 (Original
>>>>>>> contribution missing a test case. Seems to be abandoned by the
>>> contributor.
>>>>>>> I think it shouldn't be too onerous if someone could carry the PR
>> and
>>> add a
>>>>>>> test).
>>>>>>>
>>>>>>> [CALCITE-1882] Can't obtain the user defined aggregate function such
>>> as
>>>>>>> sum,avg by calcite: https://github.com/apache/calcite/pull/502 (Was
>>> dead
>>>>>>> for a while, but contributor addressed comments 2 months ago. Can
>>> someone
>>>>>>> please review so we can get this in?)
>>>>>>>
>>>>>>> These are just some PRs I found from a quick look through Github. I
>>> think
>>>>>>> a few of them should be easy to carry so that we can get them into
>> the
>>>>>>> release. For PRs #180 and #422 can someone confirm if they are safe
>> to
>>>>>>> close? If so, I'll ask INFRA to close them.
>>>>>>>
>>>>>>> There are also a bunch of PRs from a year ago that are going stale.
>> If
>>>>>>> possible we should review, carry, close or merge them. Having a lot
>>> of
>>>>>>> stale PRs without any activity or review may deter contributors new
>>> to the
>>>>>>> community from contributing.
>>>>>>>
>>>>>>> Francis
>>>>>>>
>>>>>>>
>>>>>>>> On 29/06/2018 3:54 AM, Michael Mior wrote:
>>>>>>>>
>>>>>>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei
>> is
>>>>>>>> working on a PR and this would be a good bug to have fixed.
>>>>>>>>
>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
>>>>>>>> predicate (A or B) and C is failing for some adapters
>>>>>>>>
>>>>>>>> --
>>>>>>>> Michael Mior
>>>>>>>> mmior@apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a
>>> écrit :
>>>>>>>>
>>>>>>>> To answer Michael's question: I don't think we should delay the
>>>>>>>>> report, nor should we hurry the release. It's fair to say that
>> 1.17
>>> is
>>>>>>>>> in its final stages. There was a lot of activity on avatica-1.12
>>> from
>>>>>>>>> a lot of individuals, and the community is in great shape.
>>>>>>>>>
>>>>>>>>> Here are the cases listed by Volodymyr, converted into links:
>>>>>>>>>
>>>>>>>>> Must:
>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2384 Performance
>>> issue
>>>>>>>>> in getPulledUpPredicates - Zoltan
>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
>>> Avatica -
>>>>>>>>> Julian
>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT -
>>> Julian
>>>>>>>>>
>>>>>>>>> Nice:
>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
>>> MongoDB
>>>>>>>>> - Volodymyr
>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8
>> syntax -
>>>>>>>>> Kevin
>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel -
>> Julian
>>>>>>>>> (blocked by 2259)
>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
>>>>>>>>> timestamps - Julian to review
>>>>>>>>>
>>>>>>>>> Julian
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
>>>>>>>>> <vo...@apache.org> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Michael,
>>>>>>>>>>
>>>>>>>>>> There are several Jiras, which I think are blockers for the
>>>>>>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
>>> CALCITE-2303.
>>>>>>>>>> Also, there is a list of the Jiras, which would be good to
>> include
>>> to
>>>>>>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
>>>>>>>>>>
>>>>>>>>>> So I think we need at least couple of weeks to resolve these
>>> issues and
>>>>>>>>>> release 1.17.
>>>>>>>>>>
>>>>>>>>>> Also, please let me know if there are other issues-blockers for
>> the
>>>>>>>>>> release, or if some of these issues may be omitted.
>>>>>>>>>>
>>>>>>>>>> Kind regards,
>>>>>>>>>> Volodymyr Vysotskyi
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com>
>>> пише:
>>>>>>>>>>
>>>>>>>>>> It also would be great to have at least a BETA version of Babel
>>> parser
>>>>>>>>>>> Enrico
>>>>>>>>>>>
>>>>>>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
>>> scritto:
>>>>>>>>>>>
>>>>>>>>>>> Just wanted to check in with how we're doing with progress
>>> towards a
>>>>>>>>>>>> release. It's not a rush at all, but I'm preparing the board
>>> report
>>>>>>>>>>>>
>>>>>>>>>>> for
>>>>>>>>>> July and wondering if I should wait to include the 1.17.0
>> release.
>>> It
>>>>>>>>>>>> sounds like there are a few other things that still need to be
>>> wrapped
>>>>>>>>>>>>
>>>>>>>>>>> up,
>>>>>>>>>>>
>>>>>>>>>>>> so I'm fine if we don't release for another couple weeks.
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks again Volodymyr for taking this on!
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Michael Mior
>>>>>>>>>>>> mmior@apache.org
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
>>>>>>>>>>>>
>>>>>>>>>>> volodymyr@apache.org>
>>>>>>>>>> a
>>>>>>>>>>>> écrit :
>>>>>>>>>>>>
>>>>>>>>>>>> Calcite 1.16.0 was released on March 19 (more than two months
>>> ago).
>>>>>>>>>>>>> We have solved over 48 issues[1] since then, therefore we
>> should
>>>>>>>>>>>>>
>>>>>>>>>>>> start
>>>>>>>>>> discussing about releasing Calcite 1.17.0.
>>>>>>>>>>>>> I have created [2] to track the release.
>>>>>>>>>>>>>
>>>>>>>>>>>>> We will start a release process after the Avatica 1.12 is
>>> released.
>>>>>>>>>>>>>
>>>>>>>>>>>>> I went through the list of opened PRs during the last month,
>> and
>>>>>>>>>>>>>
>>>>>>>>>>>> here
>>>>>>>>>> is
>>>>>>>>>>>> the list of Jiras which possibly be merged before the release:
>>>>>>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT function -
>>> changes
>>>>>>>>>>>>>
>>>>>>>>>>>> are
>>>>>>>>>>>> done, depends on the Avatica release
>>>>>>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
>> operator
>>> with
>>>>>>>>>>>>>
>>>>>>>>>>>> the
>>>>>>>>>>>> constant from the left side more optimally - I will make
>> required
>>>>>>>>>>>> changes
>>>>>>>>>>>> at the beginning of next week
>>>>>>>>>>>>> * CALCITE-2321: Support ragged fixed length value union be
>>> variable
>>>>>>>>>>>>>
>>>>>>>>>>>> -
>>>>>>>>>> In review (Julian)*
>>>>>>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate - I
>> will
>>>>>>>>>>>>>
>>>>>>>>>>>> pick
>>>>>>>>>> up
>>>>>>>>>>>> this next week*
>>>>>>>>>>>>> List of other pull requests which require review or additional
>>>>>>>>>>>>>
>>>>>>>>>>>> rework:
>>>>>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may not be
>>>>>>>>>>>> simplified
>>>>>>>>>>>> to
>>>>>>>>>>>>
>>>>>>>>>>>>> false
>>>>>>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support -
>> Julian
>>>>>>>>>>>>>
>>>>>>>>>>>> added
>>>>>>>>>> a
>>>>>>>>>>>> comment into the Jira
>>>>>>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is
>> failing
>>> for
>>>>>>>>>>>>>
>>>>>>>>>>>> some
>>>>>>>>>>>> adapters - created PR only with a test for this Jira
>>>>>>>>>>>>> CALCITE-2209: Support loading JSON model file through URL -
>>> Shuyi
>>>>>>>>>>>>>
>>>>>>>>>>>> Chen
>>>>>>>>>> added a comment into the Jira
>>>>>>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works not
>>> correct
>>>>>>>>>>>>>
>>>>>>>>>>>> in
>>>>>>>>>> some
>>>>>>>>>>>>> cases
>>>>>>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean
>>> expressions
>>>>>>>>>>>>>
>>>>>>>>>>>> should
>>>>>>>>>>>>
>>>>>>>>>>>>> be set to FLOAT.
>>>>>>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest input -
>>> PR is
>>>>>>>>>>>>> created
>>>>>>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
>>>>>>>>>>>>> ResultSetEnumerable - needs additional rework.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Please let me know, if there are any Jiras should be included
>>> into
>>>>>>>>>>>>>
>>>>>>>>>>>> this
>>>>>>>>>> release.
>>>>>>>>>>>>> [1]
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%
>>>>>>>>> 20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resoluti
>>>>>>>>> on%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
>>>>>>>>>
>>>>>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
>>>>>>>>>>>>> Kind regards,
>>>>>>>>>>>>> Volodymyr Vysotskyi
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>
>>>>>>>>>>> -- Enrico Olivelli
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Best regards,
>>>>>> Sergey
>>>>
>>>>
>>>
>>
> --
>
>
> -- Enrico Olivelli
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Enrico Olivelli <eo...@gmail.com>.
Jumping on this train....
In theory committers should be able to close prs using thethe button.
Ask infra to have this permission, at least the Pmc
Enrico
Il sab 30 giu 2018, 16:07 Michael Mior <mm...@apache.org> ha scritto:
> I'd suggest just using the --allow-empty flag to git commit to create a
> commit with no changes so at least we have a distinct entry in the commit
> log to record closing the PRs.
>
> I'd say close 17 and 180 given how old they are. If anything that old is
> important, it can always be reopened or a new PR created. I don't know the
> context for 422.
>
> --
> Michael Mior
> mmior@apache.org
>
>
>
> Le sam. 30 juin 2018 à 03:41, Julian Hyde <jh...@gmail.com> a
> écrit :
>
> > When we decide to close these, rather than bothering INFRA, I’ll just add
> > “close apache/calcite#nnn” to the next commit that I merge to master.
> >
> > Julian
> >
> > > On Jun 29, 2018, at 7:29 PM, Francis Chuang <fr...@apache.org>
> > wrote:
> > >
> > > Thanks Julian + Sergey!
> > >
> > > Can someone please confirm that the following PRs can be closed?
> > > https://github.com/apache/calcite/pull/180
> > > https://github.com/apache/calcite/pull/17
> > > https://github.com/apache/calcite/pull/422
> > >
> > > If so, I'll open a case with INFRA to close them.
> > >
> > > Francis
> > >
> > >> On 30/06/2018 7:14 AM, Julian Hyde wrote:
> > >> Thanks for bringing this up, Francis. Note that sometimes there are
> > >> comments on the JIRA case (and so sometimes the ball might be in the
> > >> contributor's court). But yes, let's either review all of these or
> > >> close them as stale.
> > >>
> > >> As it happens, I picked up a half-finished patch
> > >> https://issues.apache.org/jira/browse/CALCITE-2281 yesterday,
> finished
> > >> it, and merged it. This is never a small amount of work. Contributors
> > >> need to realize that if they do not provide clean, running code with a
> > >> test case, then their PR is unlikely to make it. I could have watched
> > >> a full-length movie with my kids in the time it took to get that PR
> > >> into shape.
> > >>
> > >> Julian
> > >>
> > >>
> > >> On Fri, Jun 29, 2018 at 8:29 AM, Sergey Nuyanzin <snuyanzin@gmail.com
> >
> > wrote:
> > >>>>> [CALCITE-1866]
> > >>> adapted existing changes to current master + added tests
> > >>>
> > >>> On Fri, Jun 29, 2018 at 2:14 AM, Francis Chuang <
> > francischuang@apache.org>
> > >>> wrote:
> > >>>
> > >>>> I would love to see if we can close out/merge some of the really
> > stale PRs
> > >>>> on Github.
> > >>>>
> > >>>> Here are a few that I think we should resolve before the release:
> > >>>>
> > >>>> [CALCITE-1025] Add support for HTTP Basic auth (for proxies) in
> > Avatica:
> > >>>> https://github.com/apache/calcite/pull/180 (JIRA is marked as
> > resolved
> > >>>> and this PR is probably irrelevant since Avatica is now in a
> > different repo)
> > >>>>
> > >>>> Add support for converting a MongoDB date to a SQL timestamp type:
> > >>>> https://github.com/apache/calcite/pull/17 (Could not find relevant
> > JIRA.
> > >>>> No tests. Original contributor probably lost context, since it's
> > almost 4
> > >>>> years old)
> > >>>>
> > >>>> CALCITE-1681 Provide a way to copy RelNode trees between clusters:
> > >>>> https://github.com/apache/calcite/pull/392 (No review, despite the
> > >>>> contributor asking for one. Do you think it would be possible to
> > finish
> > >>>> this? PR is more than a year old, so contributor might have lost
> > context)
> > >>>>
> > >>>> CALCITE-1748: make method getSchema to be overridable:
> > >>>> https://github.com/apache/calcite/pull/422 (The proposed solution
> > >>>> appeared to be unnecessary according to the comments on JIRA, so
> this
> > is
> > >>>> probably safe to close. Can the JIRA issue be marked as resolved or
> > do we
> > >>>> still need to work on it?)
> > >>>>
> > >>>> [CALCITE-1866] dateTime FLOOR to HOUR cause MySQL connector throw
> > >>>> SQLException: https://github.com/apache/calcite/pull/488 (Original
> > >>>> contribution missing a test case. Seems to be abandoned by the
> > contributor.
> > >>>> I think it shouldn't be too onerous if someone could carry the PR
> and
> > add a
> > >>>> test).
> > >>>>
> > >>>> [CALCITE-1882] Can't obtain the user defined aggregate function such
> > as
> > >>>> sum,avg by calcite: https://github.com/apache/calcite/pull/502 (Was
> > dead
> > >>>> for a while, but contributor addressed comments 2 months ago. Can
> > someone
> > >>>> please review so we can get this in?)
> > >>>>
> > >>>> These are just some PRs I found from a quick look through Github. I
> > think
> > >>>> a few of them should be easy to carry so that we can get them into
> the
> > >>>> release. For PRs #180 and #422 can someone confirm if they are safe
> to
> > >>>> close? If so, I'll ask INFRA to close them.
> > >>>>
> > >>>> There are also a bunch of PRs from a year ago that are going stale.
> If
> > >>>> possible we should review, carry, close or merge them. Having a lot
> > of
> > >>>> stale PRs without any activity or review may deter contributors new
> > to the
> > >>>> community from contributing.
> > >>>>
> > >>>> Francis
> > >>>>
> > >>>>
> > >>>>> On 29/06/2018 3:54 AM, Michael Mior wrote:
> > >>>>>
> > >>>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei
> is
> > >>>>> working on a PR and this would be a good bug to have fixed.
> > >>>>>
> > >>>>> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
> > >>>>> predicate (A or B) and C is failing for some adapters
> > >>>>>
> > >>>>> --
> > >>>>> Michael Mior
> > >>>>> mmior@apache.org
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a
> > écrit :
> > >>>>>
> > >>>>> To answer Michael's question: I don't think we should delay the
> > >>>>>> report, nor should we hurry the release. It's fair to say that
> 1.17
> > is
> > >>>>>> in its final stages. There was a lot of activity on avatica-1.12
> > from
> > >>>>>> a lot of individuals, and the community is in great shape.
> > >>>>>>
> > >>>>>> Here are the cases listed by Volodymyr, converted into links:
> > >>>>>>
> > >>>>>> Must:
> > >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
> > >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2384 Performance
> > issue
> > >>>>>> in getPulledUpPredicates - Zoltan
> > >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
> > Avatica -
> > >>>>>> Julian
> > >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT -
> > Julian
> > >>>>>>
> > >>>>>> Nice:
> > >>>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
> > MongoDB
> > >>>>>> - Volodymyr
> > >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8
> syntax -
> > >>>>>> Kevin
> > >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel -
> Julian
> > >>>>>> (blocked by 2259)
> > >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
> > >>>>>> timestamps - Julian to review
> > >>>>>>
> > >>>>>> Julian
> > >>>>>>
> > >>>>>>
> > >>>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> > >>>>>> <vo...@apache.org> wrote:
> > >>>>>>
> > >>>>>>> Hi Michael,
> > >>>>>>>
> > >>>>>>> There are several Jiras, which I think are blockers for the
> > >>>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
> > CALCITE-2303.
> > >>>>>>> Also, there is a list of the Jiras, which would be good to
> include
> > to
> > >>>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> > >>>>>>>
> > >>>>>>> So I think we need at least couple of weeks to resolve these
> > issues and
> > >>>>>>> release 1.17.
> > >>>>>>>
> > >>>>>>> Also, please let me know if there are other issues-blockers for
> the
> > >>>>>>> release, or if some of these issues may be omitted.
> > >>>>>>>
> > >>>>>>> Kind regards,
> > >>>>>>> Volodymyr Vysotskyi
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com>
> > пише:
> > >>>>>>>
> > >>>>>>> It also would be great to have at least a BETA version of Babel
> > parser
> > >>>>>>>> Enrico
> > >>>>>>>>
> > >>>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
> > scritto:
> > >>>>>>>>
> > >>>>>>>> Just wanted to check in with how we're doing with progress
> > towards a
> > >>>>>>>>> release. It's not a rush at all, but I'm preparing the board
> > report
> > >>>>>>>>>
> > >>>>>>>> for
> > >>>>>>> July and wondering if I should wait to include the 1.17.0
> release.
> > It
> > >>>>>>>>> sounds like there are a few other things that still need to be
> > wrapped
> > >>>>>>>>>
> > >>>>>>>> up,
> > >>>>>>>>
> > >>>>>>>>> so I'm fine if we don't release for another couple weeks.
> > >>>>>>>>>
> > >>>>>>>>> Thanks again Volodymyr for taking this on!
> > >>>>>>>>>
> > >>>>>>>>> --
> > >>>>>>>>> Michael Mior
> > >>>>>>>>> mmior@apache.org
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> > >>>>>>>>>
> > >>>>>>>> volodymyr@apache.org>
> > >>>>>>> a
> > >>>>>>>>> écrit :
> > >>>>>>>>>
> > >>>>>>>>> Calcite 1.16.0 was released on March 19 (more than two months
> > ago).
> > >>>>>>>>>> We have solved over 48 issues[1] since then, therefore we
> should
> > >>>>>>>>>>
> > >>>>>>>>> start
> > >>>>>>> discussing about releasing Calcite 1.17.0.
> > >>>>>>>>>> I have created [2] to track the release.
> > >>>>>>>>>>
> > >>>>>>>>>> We will start a release process after the Avatica 1.12 is
> > released.
> > >>>>>>>>>>
> > >>>>>>>>>> I went through the list of opened PRs during the last month,
> and
> > >>>>>>>>>>
> > >>>>>>>>> here
> > >>>>>>> is
> > >>>>>>>>> the list of Jiras which possibly be merged before the release:
> > >>>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT function -
> > changes
> > >>>>>>>>>>
> > >>>>>>>>> are
> > >>>>>>>>> done, depends on the Avatica release
> > >>>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN
> operator
> > with
> > >>>>>>>>>>
> > >>>>>>>>> the
> > >>>>>>>>> constant from the left side more optimally - I will make
> required
> > >>>>>>>>> changes
> > >>>>>>>>> at the beginning of next week
> > >>>>>>>>>> * CALCITE-2321: Support ragged fixed length value union be
> > variable
> > >>>>>>>>>>
> > >>>>>>>>> -
> > >>>>>>> In review (Julian)*
> > >>>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate - I
> will
> > >>>>>>>>>>
> > >>>>>>>>> pick
> > >>>>>>> up
> > >>>>>>>>> this next week*
> > >>>>>>>>>> List of other pull requests which require review or additional
> > >>>>>>>>>>
> > >>>>>>>>> rework:
> > >>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may not be
> > >>>>>>>>> simplified
> > >>>>>>>>> to
> > >>>>>>>>>
> > >>>>>>>>>> false
> > >>>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support -
> Julian
> > >>>>>>>>>>
> > >>>>>>>>> added
> > >>>>>>> a
> > >>>>>>>>> comment into the Jira
> > >>>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is
> failing
> > for
> > >>>>>>>>>>
> > >>>>>>>>> some
> > >>>>>>>>> adapters - created PR only with a test for this Jira
> > >>>>>>>>>> CALCITE-2209: Support loading JSON model file through URL -
> > Shuyi
> > >>>>>>>>>>
> > >>>>>>>>> Chen
> > >>>>>>> added a comment into the Jira
> > >>>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works not
> > correct
> > >>>>>>>>>>
> > >>>>>>>>> in
> > >>>>>>> some
> > >>>>>>>>>> cases
> > >>>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean
> > expressions
> > >>>>>>>>>>
> > >>>>>>>>> should
> > >>>>>>>>>
> > >>>>>>>>>> be set to FLOAT.
> > >>>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest input -
> > PR is
> > >>>>>>>>>> created
> > >>>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
> > >>>>>>>>>> ResultSetEnumerable - needs additional rework.
> > >>>>>>>>>>
> > >>>>>>>>>> Please let me know, if there are any Jiras should be included
> > into
> > >>>>>>>>>>
> > >>>>>>>>> this
> > >>>>>>> release.
> > >>>>>>>>>> [1]
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%
> > >>>>>> 20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resoluti
> > >>>>>> on%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> > >>>>>>
> > >>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
> > >>>>>>>>>> Kind regards,
> > >>>>>>>>>> Volodymyr Vysotskyi
> > >>>>>>>>>>
> > >>>>>>>>>> --
> > >>>>>>>>
> > >>>>>>>> -- Enrico Olivelli
> > >>>>>>>>
> > >>>>>>>>
> > >>>
> > >>> --
> > >>> Best regards,
> > >>> Sergey
> > >
> > >
> >
>
--
-- Enrico Olivelli
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Michael Mior <mm...@apache.org>.
I'd suggest just using the --allow-empty flag to git commit to create a
commit with no changes so at least we have a distinct entry in the commit
log to record closing the PRs.
I'd say close 17 and 180 given how old they are. If anything that old is
important, it can always be reopened or a new PR created. I don't know the
context for 422.
--
Michael Mior
mmior@apache.org
Le sam. 30 juin 2018 à 03:41, Julian Hyde <jh...@gmail.com> a écrit :
> When we decide to close these, rather than bothering INFRA, I’ll just add
> “close apache/calcite#nnn” to the next commit that I merge to master.
>
> Julian
>
> > On Jun 29, 2018, at 7:29 PM, Francis Chuang <fr...@apache.org>
> wrote:
> >
> > Thanks Julian + Sergey!
> >
> > Can someone please confirm that the following PRs can be closed?
> > https://github.com/apache/calcite/pull/180
> > https://github.com/apache/calcite/pull/17
> > https://github.com/apache/calcite/pull/422
> >
> > If so, I'll open a case with INFRA to close them.
> >
> > Francis
> >
> >> On 30/06/2018 7:14 AM, Julian Hyde wrote:
> >> Thanks for bringing this up, Francis. Note that sometimes there are
> >> comments on the JIRA case (and so sometimes the ball might be in the
> >> contributor's court). But yes, let's either review all of these or
> >> close them as stale.
> >>
> >> As it happens, I picked up a half-finished patch
> >> https://issues.apache.org/jira/browse/CALCITE-2281 yesterday, finished
> >> it, and merged it. This is never a small amount of work. Contributors
> >> need to realize that if they do not provide clean, running code with a
> >> test case, then their PR is unlikely to make it. I could have watched
> >> a full-length movie with my kids in the time it took to get that PR
> >> into shape.
> >>
> >> Julian
> >>
> >>
> >> On Fri, Jun 29, 2018 at 8:29 AM, Sergey Nuyanzin <sn...@gmail.com>
> wrote:
> >>>>> [CALCITE-1866]
> >>> adapted existing changes to current master + added tests
> >>>
> >>> On Fri, Jun 29, 2018 at 2:14 AM, Francis Chuang <
> francischuang@apache.org>
> >>> wrote:
> >>>
> >>>> I would love to see if we can close out/merge some of the really
> stale PRs
> >>>> on Github.
> >>>>
> >>>> Here are a few that I think we should resolve before the release:
> >>>>
> >>>> [CALCITE-1025] Add support for HTTP Basic auth (for proxies) in
> Avatica:
> >>>> https://github.com/apache/calcite/pull/180 (JIRA is marked as
> resolved
> >>>> and this PR is probably irrelevant since Avatica is now in a
> different repo)
> >>>>
> >>>> Add support for converting a MongoDB date to a SQL timestamp type:
> >>>> https://github.com/apache/calcite/pull/17 (Could not find relevant
> JIRA.
> >>>> No tests. Original contributor probably lost context, since it's
> almost 4
> >>>> years old)
> >>>>
> >>>> CALCITE-1681 Provide a way to copy RelNode trees between clusters:
> >>>> https://github.com/apache/calcite/pull/392 (No review, despite the
> >>>> contributor asking for one. Do you think it would be possible to
> finish
> >>>> this? PR is more than a year old, so contributor might have lost
> context)
> >>>>
> >>>> CALCITE-1748: make method getSchema to be overridable:
> >>>> https://github.com/apache/calcite/pull/422 (The proposed solution
> >>>> appeared to be unnecessary according to the comments on JIRA, so this
> is
> >>>> probably safe to close. Can the JIRA issue be marked as resolved or
> do we
> >>>> still need to work on it?)
> >>>>
> >>>> [CALCITE-1866] dateTime FLOOR to HOUR cause MySQL connector throw
> >>>> SQLException: https://github.com/apache/calcite/pull/488 (Original
> >>>> contribution missing a test case. Seems to be abandoned by the
> contributor.
> >>>> I think it shouldn't be too onerous if someone could carry the PR and
> add a
> >>>> test).
> >>>>
> >>>> [CALCITE-1882] Can't obtain the user defined aggregate function such
> as
> >>>> sum,avg by calcite: https://github.com/apache/calcite/pull/502 (Was
> dead
> >>>> for a while, but contributor addressed comments 2 months ago. Can
> someone
> >>>> please review so we can get this in?)
> >>>>
> >>>> These are just some PRs I found from a quick look through Github. I
> think
> >>>> a few of them should be easy to carry so that we can get them into the
> >>>> release. For PRs #180 and #422 can someone confirm if they are safe to
> >>>> close? If so, I'll ask INFRA to close them.
> >>>>
> >>>> There are also a bunch of PRs from a year ago that are going stale. If
> >>>> possible we should review, carry, close or merge them. Having a lot
> of
> >>>> stale PRs without any activity or review may deter contributors new
> to the
> >>>> community from contributing.
> >>>>
> >>>> Francis
> >>>>
> >>>>
> >>>>> On 29/06/2018 3:54 AM, Michael Mior wrote:
> >>>>>
> >>>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is
> >>>>> working on a PR and this would be a good bug to have fixed.
> >>>>>
> >>>>> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
> >>>>> predicate (A or B) and C is failing for some adapters
> >>>>>
> >>>>> --
> >>>>> Michael Mior
> >>>>> mmior@apache.org
> >>>>>
> >>>>>
> >>>>>
> >>>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a
> écrit :
> >>>>>
> >>>>> To answer Michael's question: I don't think we should delay the
> >>>>>> report, nor should we hurry the release. It's fair to say that 1.17
> is
> >>>>>> in its final stages. There was a lot of activity on avatica-1.12
> from
> >>>>>> a lot of individuals, and the community is in great shape.
> >>>>>>
> >>>>>> Here are the cases listed by Volodymyr, converted into links:
> >>>>>>
> >>>>>> Must:
> >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
> >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2384 Performance
> issue
> >>>>>> in getPulledUpPredicates - Zoltan
> >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade
> Avatica -
> >>>>>> Julian
> >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT -
> Julian
> >>>>>>
> >>>>>> Nice:
> >>>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in
> MongoDB
> >>>>>> - Volodymyr
> >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax -
> >>>>>> Kevin
> >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel - Julian
> >>>>>> (blocked by 2259)
> >>>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
> >>>>>> timestamps - Julian to review
> >>>>>>
> >>>>>> Julian
> >>>>>>
> >>>>>>
> >>>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> >>>>>> <vo...@apache.org> wrote:
> >>>>>>
> >>>>>>> Hi Michael,
> >>>>>>>
> >>>>>>> There are several Jiras, which I think are blockers for the
> >>>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 +
> CALCITE-2303.
> >>>>>>> Also, there is a list of the Jiras, which would be good to include
> to
> >>>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> >>>>>>>
> >>>>>>> So I think we need at least couple of weeks to resolve these
> issues and
> >>>>>>> release 1.17.
> >>>>>>>
> >>>>>>> Also, please let me know if there are other issues-blockers for the
> >>>>>>> release, or if some of these issues may be omitted.
> >>>>>>>
> >>>>>>> Kind regards,
> >>>>>>> Volodymyr Vysotskyi
> >>>>>>>
> >>>>>>>
> >>>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com>
> пише:
> >>>>>>>
> >>>>>>> It also would be great to have at least a BETA version of Babel
> parser
> >>>>>>>> Enrico
> >>>>>>>>
> >>>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha
> scritto:
> >>>>>>>>
> >>>>>>>> Just wanted to check in with how we're doing with progress
> towards a
> >>>>>>>>> release. It's not a rush at all, but I'm preparing the board
> report
> >>>>>>>>>
> >>>>>>>> for
> >>>>>>> July and wondering if I should wait to include the 1.17.0 release.
> It
> >>>>>>>>> sounds like there are a few other things that still need to be
> wrapped
> >>>>>>>>>
> >>>>>>>> up,
> >>>>>>>>
> >>>>>>>>> so I'm fine if we don't release for another couple weeks.
> >>>>>>>>>
> >>>>>>>>> Thanks again Volodymyr for taking this on!
> >>>>>>>>>
> >>>>>>>>> --
> >>>>>>>>> Michael Mior
> >>>>>>>>> mmior@apache.org
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> >>>>>>>>>
> >>>>>>>> volodymyr@apache.org>
> >>>>>>> a
> >>>>>>>>> écrit :
> >>>>>>>>>
> >>>>>>>>> Calcite 1.16.0 was released on March 19 (more than two months
> ago).
> >>>>>>>>>> We have solved over 48 issues[1] since then, therefore we should
> >>>>>>>>>>
> >>>>>>>>> start
> >>>>>>> discussing about releasing Calcite 1.17.0.
> >>>>>>>>>> I have created [2] to track the release.
> >>>>>>>>>>
> >>>>>>>>>> We will start a release process after the Avatica 1.12 is
> released.
> >>>>>>>>>>
> >>>>>>>>>> I went through the list of opened PRs during the last month, and
> >>>>>>>>>>
> >>>>>>>>> here
> >>>>>>> is
> >>>>>>>>> the list of Jiras which possibly be merged before the release:
> >>>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT function -
> changes
> >>>>>>>>>>
> >>>>>>>>> are
> >>>>>>>>> done, depends on the Avatica release
> >>>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN operator
> with
> >>>>>>>>>>
> >>>>>>>>> the
> >>>>>>>>> constant from the left side more optimally - I will make required
> >>>>>>>>> changes
> >>>>>>>>> at the beginning of next week
> >>>>>>>>>> * CALCITE-2321: Support ragged fixed length value union be
> variable
> >>>>>>>>>>
> >>>>>>>>> -
> >>>>>>> In review (Julian)*
> >>>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate - I will
> >>>>>>>>>>
> >>>>>>>>> pick
> >>>>>>> up
> >>>>>>>>> this next week*
> >>>>>>>>>> List of other pull requests which require review or additional
> >>>>>>>>>>
> >>>>>>>>> rework:
> >>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may not be
> >>>>>>>>> simplified
> >>>>>>>>> to
> >>>>>>>>>
> >>>>>>>>>> false
> >>>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support - Julian
> >>>>>>>>>>
> >>>>>>>>> added
> >>>>>>> a
> >>>>>>>>> comment into the Jira
> >>>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is failing
> for
> >>>>>>>>>>
> >>>>>>>>> some
> >>>>>>>>> adapters - created PR only with a test for this Jira
> >>>>>>>>>> CALCITE-2209: Support loading JSON model file through URL -
> Shuyi
> >>>>>>>>>>
> >>>>>>>>> Chen
> >>>>>>> added a comment into the Jira
> >>>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works not
> correct
> >>>>>>>>>>
> >>>>>>>>> in
> >>>>>>> some
> >>>>>>>>>> cases
> >>>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean
> expressions
> >>>>>>>>>>
> >>>>>>>>> should
> >>>>>>>>>
> >>>>>>>>>> be set to FLOAT.
> >>>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest input -
> PR is
> >>>>>>>>>> created
> >>>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
> >>>>>>>>>> ResultSetEnumerable - needs additional rework.
> >>>>>>>>>>
> >>>>>>>>>> Please let me know, if there are any Jiras should be included
> into
> >>>>>>>>>>
> >>>>>>>>> this
> >>>>>>> release.
> >>>>>>>>>> [1]
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%
> >>>>>> 20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resoluti
> >>>>>> on%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> >>>>>>
> >>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
> >>>>>>>>>> Kind regards,
> >>>>>>>>>> Volodymyr Vysotskyi
> >>>>>>>>>>
> >>>>>>>>>> --
> >>>>>>>>
> >>>>>>>> -- Enrico Olivelli
> >>>>>>>>
> >>>>>>>>
> >>>
> >>> --
> >>> Best regards,
> >>> Sergey
> >
> >
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Julian Hyde <jh...@gmail.com>.
When we decide to close these, rather than bothering INFRA, I’ll just add “close apache/calcite#nnn” to the next commit that I merge to master.
Julian
> On Jun 29, 2018, at 7:29 PM, Francis Chuang <fr...@apache.org> wrote:
>
> Thanks Julian + Sergey!
>
> Can someone please confirm that the following PRs can be closed?
> https://github.com/apache/calcite/pull/180
> https://github.com/apache/calcite/pull/17
> https://github.com/apache/calcite/pull/422
>
> If so, I'll open a case with INFRA to close them.
>
> Francis
>
>> On 30/06/2018 7:14 AM, Julian Hyde wrote:
>> Thanks for bringing this up, Francis. Note that sometimes there are
>> comments on the JIRA case (and so sometimes the ball might be in the
>> contributor's court). But yes, let's either review all of these or
>> close them as stale.
>>
>> As it happens, I picked up a half-finished patch
>> https://issues.apache.org/jira/browse/CALCITE-2281 yesterday, finished
>> it, and merged it. This is never a small amount of work. Contributors
>> need to realize that if they do not provide clean, running code with a
>> test case, then their PR is unlikely to make it. I could have watched
>> a full-length movie with my kids in the time it took to get that PR
>> into shape.
>>
>> Julian
>>
>>
>> On Fri, Jun 29, 2018 at 8:29 AM, Sergey Nuyanzin <sn...@gmail.com> wrote:
>>>>> [CALCITE-1866]
>>> adapted existing changes to current master + added tests
>>>
>>> On Fri, Jun 29, 2018 at 2:14 AM, Francis Chuang <fr...@apache.org>
>>> wrote:
>>>
>>>> I would love to see if we can close out/merge some of the really stale PRs
>>>> on Github.
>>>>
>>>> Here are a few that I think we should resolve before the release:
>>>>
>>>> [CALCITE-1025] Add support for HTTP Basic auth (for proxies) in Avatica:
>>>> https://github.com/apache/calcite/pull/180 (JIRA is marked as resolved
>>>> and this PR is probably irrelevant since Avatica is now in a different repo)
>>>>
>>>> Add support for converting a MongoDB date to a SQL timestamp type:
>>>> https://github.com/apache/calcite/pull/17 (Could not find relevant JIRA.
>>>> No tests. Original contributor probably lost context, since it's almost 4
>>>> years old)
>>>>
>>>> CALCITE-1681 Provide a way to copy RelNode trees between clusters:
>>>> https://github.com/apache/calcite/pull/392 (No review, despite the
>>>> contributor asking for one. Do you think it would be possible to finish
>>>> this? PR is more than a year old, so contributor might have lost context)
>>>>
>>>> CALCITE-1748: make method getSchema to be overridable:
>>>> https://github.com/apache/calcite/pull/422 (The proposed solution
>>>> appeared to be unnecessary according to the comments on JIRA, so this is
>>>> probably safe to close. Can the JIRA issue be marked as resolved or do we
>>>> still need to work on it?)
>>>>
>>>> [CALCITE-1866] dateTime FLOOR to HOUR cause MySQL connector throw
>>>> SQLException: https://github.com/apache/calcite/pull/488 (Original
>>>> contribution missing a test case. Seems to be abandoned by the contributor.
>>>> I think it shouldn't be too onerous if someone could carry the PR and add a
>>>> test).
>>>>
>>>> [CALCITE-1882] Can't obtain the user defined aggregate function such as
>>>> sum,avg by calcite: https://github.com/apache/calcite/pull/502 (Was dead
>>>> for a while, but contributor addressed comments 2 months ago. Can someone
>>>> please review so we can get this in?)
>>>>
>>>> These are just some PRs I found from a quick look through Github. I think
>>>> a few of them should be easy to carry so that we can get them into the
>>>> release. For PRs #180 and #422 can someone confirm if they are safe to
>>>> close? If so, I'll ask INFRA to close them.
>>>>
>>>> There are also a bunch of PRs from a year ago that are going stale. If
>>>> possible we should review, carry, close or merge them. Having a lot of
>>>> stale PRs without any activity or review may deter contributors new to the
>>>> community from contributing.
>>>>
>>>> Francis
>>>>
>>>>
>>>>> On 29/06/2018 3:54 AM, Michael Mior wrote:
>>>>>
>>>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is
>>>>> working on a PR and this would be a good bug to have fixed.
>>>>>
>>>>> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
>>>>> predicate (A or B) and C is failing for some adapters
>>>>>
>>>>> --
>>>>> Michael Mior
>>>>> mmior@apache.org
>>>>>
>>>>>
>>>>>
>>>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a écrit :
>>>>>
>>>>> To answer Michael's question: I don't think we should delay the
>>>>>> report, nor should we hurry the release. It's fair to say that 1.17 is
>>>>>> in its final stages. There was a lot of activity on avatica-1.12 from
>>>>>> a lot of individuals, and the community is in great shape.
>>>>>>
>>>>>> Here are the cases listed by Volodymyr, converted into links:
>>>>>>
>>>>>> Must:
>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
>>>>>> in getPulledUpPredicates - Zoltan
>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade Avatica -
>>>>>> Julian
>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT - Julian
>>>>>>
>>>>>> Nice:
>>>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB
>>>>>> - Volodymyr
>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax -
>>>>>> Kevin
>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel - Julian
>>>>>> (blocked by 2259)
>>>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
>>>>>> timestamps - Julian to review
>>>>>>
>>>>>> Julian
>>>>>>
>>>>>>
>>>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
>>>>>> <vo...@apache.org> wrote:
>>>>>>
>>>>>>> Hi Michael,
>>>>>>>
>>>>>>> There are several Jiras, which I think are blockers for the
>>>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 + CALCITE-2303.
>>>>>>> Also, there is a list of the Jiras, which would be good to include to
>>>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
>>>>>>>
>>>>>>> So I think we need at least couple of weeks to resolve these issues and
>>>>>>> release 1.17.
>>>>>>>
>>>>>>> Also, please let me know if there are other issues-blockers for the
>>>>>>> release, or if some of these issues may be omitted.
>>>>>>>
>>>>>>> Kind regards,
>>>>>>> Volodymyr Vysotskyi
>>>>>>>
>>>>>>>
>>>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com> пише:
>>>>>>>
>>>>>>> It also would be great to have at least a BETA version of Babel parser
>>>>>>>> Enrico
>>>>>>>>
>>>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha scritto:
>>>>>>>>
>>>>>>>> Just wanted to check in with how we're doing with progress towards a
>>>>>>>>> release. It's not a rush at all, but I'm preparing the board report
>>>>>>>>>
>>>>>>>> for
>>>>>>> July and wondering if I should wait to include the 1.17.0 release. It
>>>>>>>>> sounds like there are a few other things that still need to be wrapped
>>>>>>>>>
>>>>>>>> up,
>>>>>>>>
>>>>>>>>> so I'm fine if we don't release for another couple weeks.
>>>>>>>>>
>>>>>>>>> Thanks again Volodymyr for taking this on!
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Michael Mior
>>>>>>>>> mmior@apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
>>>>>>>>>
>>>>>>>> volodymyr@apache.org>
>>>>>>> a
>>>>>>>>> écrit :
>>>>>>>>>
>>>>>>>>> Calcite 1.16.0 was released on March 19 (more than two months ago).
>>>>>>>>>> We have solved over 48 issues[1] since then, therefore we should
>>>>>>>>>>
>>>>>>>>> start
>>>>>>> discussing about releasing Calcite 1.17.0.
>>>>>>>>>> I have created [2] to track the release.
>>>>>>>>>>
>>>>>>>>>> We will start a release process after the Avatica 1.12 is released.
>>>>>>>>>>
>>>>>>>>>> I went through the list of opened PRs during the last month, and
>>>>>>>>>>
>>>>>>>>> here
>>>>>>> is
>>>>>>>>> the list of Jiras which possibly be merged before the release:
>>>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT function - changes
>>>>>>>>>>
>>>>>>>>> are
>>>>>>>>> done, depends on the Avatica release
>>>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN operator with
>>>>>>>>>>
>>>>>>>>> the
>>>>>>>>> constant from the left side more optimally - I will make required
>>>>>>>>> changes
>>>>>>>>> at the beginning of next week
>>>>>>>>>> * CALCITE-2321: Support ragged fixed length value union be variable
>>>>>>>>>>
>>>>>>>>> -
>>>>>>> In review (Julian)*
>>>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate - I will
>>>>>>>>>>
>>>>>>>>> pick
>>>>>>> up
>>>>>>>>> this next week*
>>>>>>>>>> List of other pull requests which require review or additional
>>>>>>>>>>
>>>>>>>>> rework:
>>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may not be
>>>>>>>>> simplified
>>>>>>>>> to
>>>>>>>>>
>>>>>>>>>> false
>>>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support - Julian
>>>>>>>>>>
>>>>>>>>> added
>>>>>>> a
>>>>>>>>> comment into the Jira
>>>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is failing for
>>>>>>>>>>
>>>>>>>>> some
>>>>>>>>> adapters - created PR only with a test for this Jira
>>>>>>>>>> CALCITE-2209: Support loading JSON model file through URL - Shuyi
>>>>>>>>>>
>>>>>>>>> Chen
>>>>>>> added a comment into the Jira
>>>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works not correct
>>>>>>>>>>
>>>>>>>>> in
>>>>>>> some
>>>>>>>>>> cases
>>>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean expressions
>>>>>>>>>>
>>>>>>>>> should
>>>>>>>>>
>>>>>>>>>> be set to FLOAT.
>>>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest input - PR is
>>>>>>>>>> created
>>>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
>>>>>>>>>> ResultSetEnumerable - needs additional rework.
>>>>>>>>>>
>>>>>>>>>> Please let me know, if there are any Jiras should be included into
>>>>>>>>>>
>>>>>>>>> this
>>>>>>> release.
>>>>>>>>>> [1]
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%
>>>>>> 20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resoluti
>>>>>> on%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
>>>>>>
>>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
>>>>>>>>>> Kind regards,
>>>>>>>>>> Volodymyr Vysotskyi
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>
>>>>>>>> -- Enrico Olivelli
>>>>>>>>
>>>>>>>>
>>>
>>> --
>>> Best regards,
>>> Sergey
>
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Francis Chuang <fr...@apache.org>.
Thanks Julian + Sergey!
Can someone please confirm that the following PRs can be closed?
https://github.com/apache/calcite/pull/180
https://github.com/apache/calcite/pull/17
https://github.com/apache/calcite/pull/422
If so, I'll open a case with INFRA to close them.
Francis
On 30/06/2018 7:14 AM, Julian Hyde wrote:
> Thanks for bringing this up, Francis. Note that sometimes there are
> comments on the JIRA case (and so sometimes the ball might be in the
> contributor's court). But yes, let's either review all of these or
> close them as stale.
>
> As it happens, I picked up a half-finished patch
> https://issues.apache.org/jira/browse/CALCITE-2281 yesterday, finished
> it, and merged it. This is never a small amount of work. Contributors
> need to realize that if they do not provide clean, running code with a
> test case, then their PR is unlikely to make it. I could have watched
> a full-length movie with my kids in the time it took to get that PR
> into shape.
>
> Julian
>
>
> On Fri, Jun 29, 2018 at 8:29 AM, Sergey Nuyanzin <sn...@gmail.com> wrote:
>>>> [CALCITE-1866]
>> adapted existing changes to current master + added tests
>>
>> On Fri, Jun 29, 2018 at 2:14 AM, Francis Chuang <fr...@apache.org>
>> wrote:
>>
>>> I would love to see if we can close out/merge some of the really stale PRs
>>> on Github.
>>>
>>> Here are a few that I think we should resolve before the release:
>>>
>>> [CALCITE-1025] Add support for HTTP Basic auth (for proxies) in Avatica:
>>> https://github.com/apache/calcite/pull/180 (JIRA is marked as resolved
>>> and this PR is probably irrelevant since Avatica is now in a different repo)
>>>
>>> Add support for converting a MongoDB date to a SQL timestamp type:
>>> https://github.com/apache/calcite/pull/17 (Could not find relevant JIRA.
>>> No tests. Original contributor probably lost context, since it's almost 4
>>> years old)
>>>
>>> CALCITE-1681 Provide a way to copy RelNode trees between clusters:
>>> https://github.com/apache/calcite/pull/392 (No review, despite the
>>> contributor asking for one. Do you think it would be possible to finish
>>> this? PR is more than a year old, so contributor might have lost context)
>>>
>>> CALCITE-1748: make method getSchema to be overridable:
>>> https://github.com/apache/calcite/pull/422 (The proposed solution
>>> appeared to be unnecessary according to the comments on JIRA, so this is
>>> probably safe to close. Can the JIRA issue be marked as resolved or do we
>>> still need to work on it?)
>>>
>>> [CALCITE-1866] dateTime FLOOR to HOUR cause MySQL connector throw
>>> SQLException: https://github.com/apache/calcite/pull/488 (Original
>>> contribution missing a test case. Seems to be abandoned by the contributor.
>>> I think it shouldn't be too onerous if someone could carry the PR and add a
>>> test).
>>>
>>> [CALCITE-1882] Can't obtain the user defined aggregate function such as
>>> sum,avg by calcite: https://github.com/apache/calcite/pull/502 (Was dead
>>> for a while, but contributor addressed comments 2 months ago. Can someone
>>> please review so we can get this in?)
>>>
>>> These are just some PRs I found from a quick look through Github. I think
>>> a few of them should be easy to carry so that we can get them into the
>>> release. For PRs #180 and #422 can someone confirm if they are safe to
>>> close? If so, I'll ask INFRA to close them.
>>>
>>> There are also a bunch of PRs from a year ago that are going stale. If
>>> possible we should review, carry, close or merge them. Having a lot of
>>> stale PRs without any activity or review may deter contributors new to the
>>> community from contributing.
>>>
>>> Francis
>>>
>>>
>>> On 29/06/2018 3:54 AM, Michael Mior wrote:
>>>
>>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is
>>>> working on a PR and this would be a good bug to have fixed.
>>>>
>>>> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
>>>> predicate (A or B) and C is failing for some adapters
>>>>
>>>> --
>>>> Michael Mior
>>>> mmior@apache.org
>>>>
>>>>
>>>>
>>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a écrit :
>>>>
>>>> To answer Michael's question: I don't think we should delay the
>>>>> report, nor should we hurry the release. It's fair to say that 1.17 is
>>>>> in its final stages. There was a lot of activity on avatica-1.12 from
>>>>> a lot of individuals, and the community is in great shape.
>>>>>
>>>>> Here are the cases listed by Volodymyr, converted into links:
>>>>>
>>>>> Must:
>>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
>>>>> * https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
>>>>> in getPulledUpPredicates - Zoltan
>>>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade Avatica -
>>>>> Julian
>>>>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT - Julian
>>>>>
>>>>> Nice:
>>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB
>>>>> - Volodymyr
>>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax -
>>>>> Kevin
>>>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel - Julian
>>>>> (blocked by 2259)
>>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
>>>>> timestamps - Julian to review
>>>>>
>>>>> Julian
>>>>>
>>>>>
>>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
>>>>> <vo...@apache.org> wrote:
>>>>>
>>>>>> Hi Michael,
>>>>>>
>>>>>> There are several Jiras, which I think are blockers for the
>>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 + CALCITE-2303.
>>>>>> Also, there is a list of the Jiras, which would be good to include to
>>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
>>>>>>
>>>>>> So I think we need at least couple of weeks to resolve these issues and
>>>>>> release 1.17.
>>>>>>
>>>>>> Also, please let me know if there are other issues-blockers for the
>>>>>> release, or if some of these issues may be omitted.
>>>>>>
>>>>>> Kind regards,
>>>>>> Volodymyr Vysotskyi
>>>>>>
>>>>>>
>>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com> пише:
>>>>>>
>>>>>> It also would be great to have at least a BETA version of Babel parser
>>>>>>> Enrico
>>>>>>>
>>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha scritto:
>>>>>>>
>>>>>>> Just wanted to check in with how we're doing with progress towards a
>>>>>>>> release. It's not a rush at all, but I'm preparing the board report
>>>>>>>>
>>>>>>> for
>>>>>> July and wondering if I should wait to include the 1.17.0 release. It
>>>>>>>> sounds like there are a few other things that still need to be wrapped
>>>>>>>>
>>>>>>> up,
>>>>>>>
>>>>>>>> so I'm fine if we don't release for another couple weeks.
>>>>>>>>
>>>>>>>> Thanks again Volodymyr for taking this on!
>>>>>>>>
>>>>>>>> --
>>>>>>>> Michael Mior
>>>>>>>> mmior@apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
>>>>>>>>
>>>>>>> volodymyr@apache.org>
>>>>>> a
>>>>>>>> écrit :
>>>>>>>>
>>>>>>>> Calcite 1.16.0 was released on March 19 (more than two months ago).
>>>>>>>>> We have solved over 48 issues[1] since then, therefore we should
>>>>>>>>>
>>>>>>>> start
>>>>>> discussing about releasing Calcite 1.17.0.
>>>>>>>>> I have created [2] to track the release.
>>>>>>>>>
>>>>>>>>> We will start a release process after the Avatica 1.12 is released.
>>>>>>>>>
>>>>>>>>> I went through the list of opened PRs during the last month, and
>>>>>>>>>
>>>>>>>> here
>>>>>> is
>>>>>>>> the list of Jiras which possibly be merged before the release:
>>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT function - changes
>>>>>>>>>
>>>>>>>> are
>>>>>>>> done, depends on the Avatica release
>>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN operator with
>>>>>>>>>
>>>>>>>> the
>>>>>>>> constant from the left side more optimally - I will make required
>>>>>>>> changes
>>>>>>>> at the beginning of next week
>>>>>>>>> * CALCITE-2321: Support ragged fixed length value union be variable
>>>>>>>>>
>>>>>>>> -
>>>>>> In review (Julian)*
>>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate - I will
>>>>>>>>>
>>>>>>>> pick
>>>>>> up
>>>>>>>> this next week*
>>>>>>>>> List of other pull requests which require review or additional
>>>>>>>>>
>>>>>>>> rework:
>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may not be
>>>>>>>> simplified
>>>>>>>> to
>>>>>>>>
>>>>>>>>> false
>>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support - Julian
>>>>>>>>>
>>>>>>>> added
>>>>>> a
>>>>>>>> comment into the Jira
>>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is failing for
>>>>>>>>>
>>>>>>>> some
>>>>>>>> adapters - created PR only with a test for this Jira
>>>>>>>>> CALCITE-2209: Support loading JSON model file through URL - Shuyi
>>>>>>>>>
>>>>>>>> Chen
>>>>>> added a comment into the Jira
>>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works not correct
>>>>>>>>>
>>>>>>>> in
>>>>>> some
>>>>>>>>> cases
>>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean expressions
>>>>>>>>>
>>>>>>>> should
>>>>>>>>
>>>>>>>>> be set to FLOAT.
>>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest input - PR is
>>>>>>>>> created
>>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
>>>>>>>>> ResultSetEnumerable - needs additional rework.
>>>>>>>>>
>>>>>>>>> Please let me know, if there are any Jiras should be included into
>>>>>>>>>
>>>>>>>> this
>>>>>> release.
>>>>>>>>> [1]
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%
>>>>> 20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resoluti
>>>>> on%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
>>>>>
>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
>>>>>>>>> Kind regards,
>>>>>>>>> Volodymyr Vysotskyi
>>>>>>>>>
>>>>>>>>> --
>>>>>>>
>>>>>>> -- Enrico Olivelli
>>>>>>>
>>>>>>>
>>
>> --
>> Best regards,
>> Sergey
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Julian Hyde <jh...@apache.org>.
Thanks for bringing this up, Francis. Note that sometimes there are
comments on the JIRA case (and so sometimes the ball might be in the
contributor's court). But yes, let's either review all of these or
close them as stale.
As it happens, I picked up a half-finished patch
https://issues.apache.org/jira/browse/CALCITE-2281 yesterday, finished
it, and merged it. This is never a small amount of work. Contributors
need to realize that if they do not provide clean, running code with a
test case, then their PR is unlikely to make it. I could have watched
a full-length movie with my kids in the time it took to get that PR
into shape.
Julian
On Fri, Jun 29, 2018 at 8:29 AM, Sergey Nuyanzin <sn...@gmail.com> wrote:
>>>[CALCITE-1866]
> adapted existing changes to current master + added tests
>
> On Fri, Jun 29, 2018 at 2:14 AM, Francis Chuang <fr...@apache.org>
> wrote:
>
>> I would love to see if we can close out/merge some of the really stale PRs
>> on Github.
>>
>> Here are a few that I think we should resolve before the release:
>>
>> [CALCITE-1025] Add support for HTTP Basic auth (for proxies) in Avatica:
>> https://github.com/apache/calcite/pull/180 (JIRA is marked as resolved
>> and this PR is probably irrelevant since Avatica is now in a different repo)
>>
>> Add support for converting a MongoDB date to a SQL timestamp type:
>> https://github.com/apache/calcite/pull/17 (Could not find relevant JIRA.
>> No tests. Original contributor probably lost context, since it's almost 4
>> years old)
>>
>> CALCITE-1681 Provide a way to copy RelNode trees between clusters:
>> https://github.com/apache/calcite/pull/392 (No review, despite the
>> contributor asking for one. Do you think it would be possible to finish
>> this? PR is more than a year old, so contributor might have lost context)
>>
>> CALCITE-1748: make method getSchema to be overridable:
>> https://github.com/apache/calcite/pull/422 (The proposed solution
>> appeared to be unnecessary according to the comments on JIRA, so this is
>> probably safe to close. Can the JIRA issue be marked as resolved or do we
>> still need to work on it?)
>>
>> [CALCITE-1866] dateTime FLOOR to HOUR cause MySQL connector throw
>> SQLException: https://github.com/apache/calcite/pull/488 (Original
>> contribution missing a test case. Seems to be abandoned by the contributor.
>> I think it shouldn't be too onerous if someone could carry the PR and add a
>> test).
>>
>> [CALCITE-1882] Can't obtain the user defined aggregate function such as
>> sum,avg by calcite: https://github.com/apache/calcite/pull/502 (Was dead
>> for a while, but contributor addressed comments 2 months ago. Can someone
>> please review so we can get this in?)
>>
>> These are just some PRs I found from a quick look through Github. I think
>> a few of them should be easy to carry so that we can get them into the
>> release. For PRs #180 and #422 can someone confirm if they are safe to
>> close? If so, I'll ask INFRA to close them.
>>
>> There are also a bunch of PRs from a year ago that are going stale. If
>> possible we should review, carry, close or merge them. Having a lot of
>> stale PRs without any activity or review may deter contributors new to the
>> community from contributing.
>>
>> Francis
>>
>>
>> On 29/06/2018 3:54 AM, Michael Mior wrote:
>>
>>> I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is
>>> working on a PR and this would be a good bug to have fixed.
>>>
>>> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
>>> predicate (A or B) and C is failing for some adapters
>>>
>>> --
>>> Michael Mior
>>> mmior@apache.org
>>>
>>>
>>>
>>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a écrit :
>>>
>>> To answer Michael's question: I don't think we should delay the
>>>> report, nor should we hurry the release. It's fair to say that 1.17 is
>>>> in its final stages. There was a lot of activity on avatica-1.12 from
>>>> a lot of individuals, and the community is in great shape.
>>>>
>>>> Here are the cases listed by Volodymyr, converted into links:
>>>>
>>>> Must:
>>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
>>>> * https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
>>>> in getPulledUpPredicates - Zoltan
>>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade Avatica -
>>>> Julian
>>>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT - Julian
>>>>
>>>> Nice:
>>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB
>>>> - Volodymyr
>>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax -
>>>> Kevin
>>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel - Julian
>>>> (blocked by 2259)
>>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
>>>> timestamps - Julian to review
>>>>
>>>> Julian
>>>>
>>>>
>>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
>>>> <vo...@apache.org> wrote:
>>>>
>>>>> Hi Michael,
>>>>>
>>>>> There are several Jiras, which I think are blockers for the
>>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 + CALCITE-2303.
>>>>> Also, there is a list of the Jiras, which would be good to include to
>>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
>>>>>
>>>>> So I think we need at least couple of weeks to resolve these issues and
>>>>> release 1.17.
>>>>>
>>>>> Also, please let me know if there are other issues-blockers for the
>>>>> release, or if some of these issues may be omitted.
>>>>>
>>>>> Kind regards,
>>>>> Volodymyr Vysotskyi
>>>>>
>>>>>
>>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com> пише:
>>>>>
>>>>> It also would be great to have at least a BETA version of Babel parser
>>>>>>
>>>>>> Enrico
>>>>>>
>>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha scritto:
>>>>>>
>>>>>> Just wanted to check in with how we're doing with progress towards a
>>>>>>> release. It's not a rush at all, but I'm preparing the board report
>>>>>>>
>>>>>> for
>>>>
>>>>> July and wondering if I should wait to include the 1.17.0 release. It
>>>>>>> sounds like there are a few other things that still need to be wrapped
>>>>>>>
>>>>>> up,
>>>>>>
>>>>>>> so I'm fine if we don't release for another couple weeks.
>>>>>>>
>>>>>>> Thanks again Volodymyr for taking this on!
>>>>>>>
>>>>>>> --
>>>>>>> Michael Mior
>>>>>>> mmior@apache.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
>>>>>>>
>>>>>> volodymyr@apache.org>
>>>>
>>>>> a
>>>>>>
>>>>>>> écrit :
>>>>>>>
>>>>>>> Calcite 1.16.0 was released on March 19 (more than two months ago).
>>>>>>>> We have solved over 48 issues[1] since then, therefore we should
>>>>>>>>
>>>>>>> start
>>>>
>>>>> discussing about releasing Calcite 1.17.0.
>>>>>>>>
>>>>>>>> I have created [2] to track the release.
>>>>>>>>
>>>>>>>> We will start a release process after the Avatica 1.12 is released.
>>>>>>>>
>>>>>>>> I went through the list of opened PRs during the last month, and
>>>>>>>>
>>>>>>> here
>>>>
>>>>> is
>>>>>>
>>>>>>> the list of Jiras which possibly be merged before the release:
>>>>>>>>
>>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT function - changes
>>>>>>>>
>>>>>>> are
>>>>>>
>>>>>>> done, depends on the Avatica release
>>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN operator with
>>>>>>>>
>>>>>>> the
>>>>>>
>>>>>>> constant from the left side more optimally - I will make required
>>>>>>>>
>>>>>>> changes
>>>>>>
>>>>>>> at the beginning of next week
>>>>>>>>
>>>>>>>> * CALCITE-2321: Support ragged fixed length value union be variable
>>>>>>>>
>>>>>>> -
>>>>
>>>>> In review (Julian)*
>>>>>>>>
>>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate - I will
>>>>>>>>
>>>>>>> pick
>>>>
>>>>> up
>>>>>>
>>>>>>> this next week*
>>>>>>>>
>>>>>>>> List of other pull requests which require review or additional
>>>>>>>>
>>>>>>> rework:
>>>>
>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may not be
>>>>>>>>
>>>>>>> simplified
>>>>>>
>>>>>>> to
>>>>>>>
>>>>>>>> false
>>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support - Julian
>>>>>>>>
>>>>>>> added
>>>>
>>>>> a
>>>>>>
>>>>>>> comment into the Jira
>>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is failing for
>>>>>>>>
>>>>>>> some
>>>>>>
>>>>>>> adapters - created PR only with a test for this Jira
>>>>>>>> CALCITE-2209: Support loading JSON model file through URL - Shuyi
>>>>>>>>
>>>>>>> Chen
>>>>
>>>>> added a comment into the Jira
>>>>>>>> CALCITE-2324: Extract seconds, minutes from date works not correct
>>>>>>>>
>>>>>>> in
>>>>
>>>>> some
>>>>>>>
>>>>>>>> cases
>>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean expressions
>>>>>>>>
>>>>>>> should
>>>>>>>
>>>>>>>> be set to FLOAT.
>>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest input - PR is
>>>>>>>> created
>>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
>>>>>>>> ResultSetEnumerable - needs additional rework.
>>>>>>>>
>>>>>>>> Please let me know, if there are any Jiras should be included into
>>>>>>>>
>>>>>>> this
>>>>
>>>>> release.
>>>>>>>>
>>>>>>>> [1]
>>>>>>>>
>>>>>>>>
>>>>>>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%
>>>> 20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resoluti
>>>> on%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
>>>>
>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
>>>>>>>>
>>>>>>>> Kind regards,
>>>>>>>> Volodymyr Vysotskyi
>>>>>>>>
>>>>>>>> --
>>>>>>
>>>>>>
>>>>>> -- Enrico Olivelli
>>>>>>
>>>>>>
>>
>
>
> --
> Best regards,
> Sergey
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Sergey Nuyanzin <sn...@gmail.com>.
>>[CALCITE-1866]
adapted existing changes to current master + added tests
On Fri, Jun 29, 2018 at 2:14 AM, Francis Chuang <fr...@apache.org>
wrote:
> I would love to see if we can close out/merge some of the really stale PRs
> on Github.
>
> Here are a few that I think we should resolve before the release:
>
> [CALCITE-1025] Add support for HTTP Basic auth (for proxies) in Avatica:
> https://github.com/apache/calcite/pull/180 (JIRA is marked as resolved
> and this PR is probably irrelevant since Avatica is now in a different repo)
>
> Add support for converting a MongoDB date to a SQL timestamp type:
> https://github.com/apache/calcite/pull/17 (Could not find relevant JIRA.
> No tests. Original contributor probably lost context, since it's almost 4
> years old)
>
> CALCITE-1681 Provide a way to copy RelNode trees between clusters:
> https://github.com/apache/calcite/pull/392 (No review, despite the
> contributor asking for one. Do you think it would be possible to finish
> this? PR is more than a year old, so contributor might have lost context)
>
> CALCITE-1748: make method getSchema to be overridable:
> https://github.com/apache/calcite/pull/422 (The proposed solution
> appeared to be unnecessary according to the comments on JIRA, so this is
> probably safe to close. Can the JIRA issue be marked as resolved or do we
> still need to work on it?)
>
> [CALCITE-1866] dateTime FLOOR to HOUR cause MySQL connector throw
> SQLException: https://github.com/apache/calcite/pull/488 (Original
> contribution missing a test case. Seems to be abandoned by the contributor.
> I think it shouldn't be too onerous if someone could carry the PR and add a
> test).
>
> [CALCITE-1882] Can't obtain the user defined aggregate function such as
> sum,avg by calcite: https://github.com/apache/calcite/pull/502 (Was dead
> for a while, but contributor addressed comments 2 months ago. Can someone
> please review so we can get this in?)
>
> These are just some PRs I found from a quick look through Github. I think
> a few of them should be easy to carry so that we can get them into the
> release. For PRs #180 and #422 can someone confirm if they are safe to
> close? If so, I'll ask INFRA to close them.
>
> There are also a bunch of PRs from a year ago that are going stale. If
> possible we should review, carry, close or merge them. Having a lot of
> stale PRs without any activity or review may deter contributors new to the
> community from contributing.
>
> Francis
>
>
> On 29/06/2018 3:54 AM, Michael Mior wrote:
>
>> I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is
>> working on a PR and this would be a good bug to have fixed.
>>
>> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
>> predicate (A or B) and C is failing for some adapters
>>
>> --
>> Michael Mior
>> mmior@apache.org
>>
>>
>>
>> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a écrit :
>>
>> To answer Michael's question: I don't think we should delay the
>>> report, nor should we hurry the release. It's fair to say that 1.17 is
>>> in its final stages. There was a lot of activity on avatica-1.12 from
>>> a lot of individuals, and the community is in great shape.
>>>
>>> Here are the cases listed by Volodymyr, converted into links:
>>>
>>> Must:
>>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
>>> * https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
>>> in getPulledUpPredicates - Zoltan
>>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade Avatica -
>>> Julian
>>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT - Julian
>>>
>>> Nice:
>>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB
>>> - Volodymyr
>>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax -
>>> Kevin
>>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel - Julian
>>> (blocked by 2259)
>>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
>>> timestamps - Julian to review
>>>
>>> Julian
>>>
>>>
>>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
>>> <vo...@apache.org> wrote:
>>>
>>>> Hi Michael,
>>>>
>>>> There are several Jiras, which I think are blockers for the
>>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 + CALCITE-2303.
>>>> Also, there is a list of the Jiras, which would be good to include to
>>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
>>>>
>>>> So I think we need at least couple of weeks to resolve these issues and
>>>> release 1.17.
>>>>
>>>> Also, please let me know if there are other issues-blockers for the
>>>> release, or if some of these issues may be omitted.
>>>>
>>>> Kind regards,
>>>> Volodymyr Vysotskyi
>>>>
>>>>
>>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com> пише:
>>>>
>>>> It also would be great to have at least a BETA version of Babel parser
>>>>>
>>>>> Enrico
>>>>>
>>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha scritto:
>>>>>
>>>>> Just wanted to check in with how we're doing with progress towards a
>>>>>> release. It's not a rush at all, but I'm preparing the board report
>>>>>>
>>>>> for
>>>
>>>> July and wondering if I should wait to include the 1.17.0 release. It
>>>>>> sounds like there are a few other things that still need to be wrapped
>>>>>>
>>>>> up,
>>>>>
>>>>>> so I'm fine if we don't release for another couple weeks.
>>>>>>
>>>>>> Thanks again Volodymyr for taking this on!
>>>>>>
>>>>>> --
>>>>>> Michael Mior
>>>>>> mmior@apache.org
>>>>>>
>>>>>>
>>>>>>
>>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
>>>>>>
>>>>> volodymyr@apache.org>
>>>
>>>> a
>>>>>
>>>>>> écrit :
>>>>>>
>>>>>> Calcite 1.16.0 was released on March 19 (more than two months ago).
>>>>>>> We have solved over 48 issues[1] since then, therefore we should
>>>>>>>
>>>>>> start
>>>
>>>> discussing about releasing Calcite 1.17.0.
>>>>>>>
>>>>>>> I have created [2] to track the release.
>>>>>>>
>>>>>>> We will start a release process after the Avatica 1.12 is released.
>>>>>>>
>>>>>>> I went through the list of opened PRs during the last month, and
>>>>>>>
>>>>>> here
>>>
>>>> is
>>>>>
>>>>>> the list of Jiras which possibly be merged before the release:
>>>>>>>
>>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT function - changes
>>>>>>>
>>>>>> are
>>>>>
>>>>>> done, depends on the Avatica release
>>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN operator with
>>>>>>>
>>>>>> the
>>>>>
>>>>>> constant from the left side more optimally - I will make required
>>>>>>>
>>>>>> changes
>>>>>
>>>>>> at the beginning of next week
>>>>>>>
>>>>>>> * CALCITE-2321: Support ragged fixed length value union be variable
>>>>>>>
>>>>>> -
>>>
>>>> In review (Julian)*
>>>>>>>
>>>>>>> * CALCITE-2291: Add rule to push Project past Correlate - I will
>>>>>>>
>>>>>> pick
>>>
>>>> up
>>>>>
>>>>>> this next week*
>>>>>>>
>>>>>>> List of other pull requests which require review or additional
>>>>>>>
>>>>>> rework:
>>>
>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may not be
>>>>>>>
>>>>>> simplified
>>>>>
>>>>>> to
>>>>>>
>>>>>>> false
>>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support - Julian
>>>>>>>
>>>>>> added
>>>
>>>> a
>>>>>
>>>>>> comment into the Jira
>>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is failing for
>>>>>>>
>>>>>> some
>>>>>
>>>>>> adapters - created PR only with a test for this Jira
>>>>>>> CALCITE-2209: Support loading JSON model file through URL - Shuyi
>>>>>>>
>>>>>> Chen
>>>
>>>> added a comment into the Jira
>>>>>>> CALCITE-2324: Extract seconds, minutes from date works not correct
>>>>>>>
>>>>>> in
>>>
>>>> some
>>>>>>
>>>>>>> cases
>>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean expressions
>>>>>>>
>>>>>> should
>>>>>>
>>>>>>> be set to FLOAT.
>>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest input - PR is
>>>>>>> created
>>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
>>>>>>> ResultSetEnumerable - needs additional rework.
>>>>>>>
>>>>>>> Please let me know, if there are any Jiras should be included into
>>>>>>>
>>>>>> this
>>>
>>>> release.
>>>>>>>
>>>>>>> [1]
>>>>>>>
>>>>>>>
>>>>>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%
>>> 20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resoluti
>>> on%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
>>>
>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
>>>>>>>
>>>>>>> Kind regards,
>>>>>>> Volodymyr Vysotskyi
>>>>>>>
>>>>>>> --
>>>>>
>>>>>
>>>>> -- Enrico Olivelli
>>>>>
>>>>>
>
--
Best regards,
Sergey
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Francis Chuang <fr...@apache.org>.
I would love to see if we can close out/merge some of the really stale
PRs on Github.
Here are a few that I think we should resolve before the release:
[CALCITE-1025] Add support for HTTP Basic auth (for proxies) in Avatica:
https://github.com/apache/calcite/pull/180 (JIRA is marked as resolved
and this PR is probably irrelevant since Avatica is now in a different repo)
Add support for converting a MongoDB date to a SQL timestamp type:
https://github.com/apache/calcite/pull/17 (Could not find relevant JIRA.
No tests. Original contributor probably lost context, since it's almost
4 years old)
CALCITE-1681 Provide a way to copy RelNode trees between clusters:
https://github.com/apache/calcite/pull/392 (No review, despite the
contributor asking for one. Do you think it would be possible to finish
this? PR is more than a year old, so contributor might have lost context)
CALCITE-1748: make method getSchema to be overridable:
https://github.com/apache/calcite/pull/422 (The proposed solution
appeared to be unnecessary according to the comments on JIRA, so this is
probably safe to close. Can the JIRA issue be marked as resolved or do
we still need to work on it?)
[CALCITE-1866] dateTime FLOOR to HOUR cause MySQL connector throw
SQLException: https://github.com/apache/calcite/pull/488 (Original
contribution missing a test case. Seems to be abandoned by the
contributor. I think it shouldn't be too onerous if someone could carry
the PR and add a test).
[CALCITE-1882] Can't obtain the user defined aggregate function such as
sum,avg by calcite: https://github.com/apache/calcite/pull/502 (Was dead
for a while, but contributor addressed comments 2 months ago. Can
someone please review so we can get this in?)
These are just some PRs I found from a quick look through Github. I
think a few of them should be easy to carry so that we can get them into
the release. For PRs #180 and #422 can someone confirm if they are safe
to close? If so, I'll ask INFRA to close them.
There are also a bunch of PRs from a year ago that are going stale. If
possible we should review, carry, close or merge them. Having a lot of
stale PRs without any activity or review may deter contributors new to
the community from contributing.
Francis
On 29/06/2018 3:54 AM, Michael Mior wrote:
> I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is
> working on a PR and this would be a good bug to have fixed.
>
> * https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
> predicate (A or B) and C is failing for some adapters
>
> --
> Michael Mior
> mmior@apache.org
>
>
>
> Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a écrit :
>
>> To answer Michael's question: I don't think we should delay the
>> report, nor should we hurry the release. It's fair to say that 1.17 is
>> in its final stages. There was a lot of activity on avatica-1.12 from
>> a lot of individuals, and the community is in great shape.
>>
>> Here are the cases listed by Volodymyr, converted into links:
>>
>> Must:
>> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
>> * https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
>> in getPulledUpPredicates - Zoltan
>> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade Avatica -
>> Julian
>> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT - Julian
>>
>> Nice:
>> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB
>> - Volodymyr
>> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax - Kevin
>> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel - Julian
>> (blocked by 2259)
>> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
>> timestamps - Julian to review
>>
>> Julian
>>
>>
>> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
>> <vo...@apache.org> wrote:
>>> Hi Michael,
>>>
>>> There are several Jiras, which I think are blockers for the
>>> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 + CALCITE-2303.
>>> Also, there is a list of the Jiras, which would be good to include to
>>> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
>>>
>>> So I think we need at least couple of weeks to resolve these issues and
>>> release 1.17.
>>>
>>> Also, please let me know if there are other issues-blockers for the
>>> release, or if some of these issues may be omitted.
>>>
>>> Kind regards,
>>> Volodymyr Vysotskyi
>>>
>>>
>>> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com> пише:
>>>
>>>> It also would be great to have at least a BETA version of Babel parser
>>>>
>>>> Enrico
>>>>
>>>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha scritto:
>>>>
>>>>> Just wanted to check in with how we're doing with progress towards a
>>>>> release. It's not a rush at all, but I'm preparing the board report
>> for
>>>>> July and wondering if I should wait to include the 1.17.0 release. It
>>>>> sounds like there are a few other things that still need to be wrapped
>>>> up,
>>>>> so I'm fine if we don't release for another couple weeks.
>>>>>
>>>>> Thanks again Volodymyr for taking this on!
>>>>>
>>>>> --
>>>>> Michael Mior
>>>>> mmior@apache.org
>>>>>
>>>>>
>>>>>
>>>>> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
>> volodymyr@apache.org>
>>>> a
>>>>> écrit :
>>>>>
>>>>>> Calcite 1.16.0 was released on March 19 (more than two months ago).
>>>>>> We have solved over 48 issues[1] since then, therefore we should
>> start
>>>>>> discussing about releasing Calcite 1.17.0.
>>>>>>
>>>>>> I have created [2] to track the release.
>>>>>>
>>>>>> We will start a release process after the Avatica 1.12 is released.
>>>>>>
>>>>>> I went through the list of opened PRs during the last month, and
>> here
>>>> is
>>>>>> the list of Jiras which possibly be merged before the release:
>>>>>>
>>>>>> CALCITE-2303: Support DECADE time unit in EXTRACT function - changes
>>>> are
>>>>>> done, depends on the Avatica release
>>>>>> CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN operator with
>>>> the
>>>>>> constant from the left side more optimally - I will make required
>>>> changes
>>>>>> at the beginning of next week
>>>>>>
>>>>>> * CALCITE-2321: Support ragged fixed length value union be variable
>> -
>>>>>> In review (Julian)*
>>>>>>
>>>>>> * CALCITE-2291: Add rule to push Project past Correlate - I will
>> pick
>>>> up
>>>>>> this next week*
>>>>>>
>>>>>> List of other pull requests which require review or additional
>> rework:
>>>>>> CALCITE-2327: In 3 valued logic mode (b and not b) may not be
>>>> simplified
>>>>> to
>>>>>> false
>>>>>> CALCITE-2302 / CALCITE-2325: Implicit type cast support - Julian
>> added
>>>> a
>>>>>> comment into the Jira
>>>>>> CALCITE-2331: evaluation of predicate (A or B) and C is failing for
>>>> some
>>>>>> adapters - created PR only with a test for this Jira
>>>>>> CALCITE-2209: Support loading JSON model file through URL - Shuyi
>> Chen
>>>>>> added a comment into the Jira
>>>>>> CALCITE-2324: Extract seconds, minutes from date works not correct
>> in
>>>>> some
>>>>>> cases
>>>>>> CALCITE-2319: Druid Expressions - Output Type of Boolean expressions
>>>>> should
>>>>>> be set to FLOAT.
>>>>>> CALCITE-500: Ensure EnumerableJoin hashes the smallest input - PR is
>>>>>> created
>>>>>> CALCITE-2301: Remove the 10-second-timeout restriction in
>>>>>> ResultSetEnumerable - needs additional rework.
>>>>>>
>>>>>> Please let me know, if there are any Jiras should be included into
>> this
>>>>>> release.
>>>>>>
>>>>>> [1]
>>>>>>
>>>>>>
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-2337
>>>>>>
>>>>>> Kind regards,
>>>>>> Volodymyr Vysotskyi
>>>>>>
>>>> --
>>>>
>>>>
>>>> -- Enrico Olivelli
>>>>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Michael Mior <mm...@apache.org>.
I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is
working on a PR and this would be a good bug to have fixed.
* https://issues.apache.org/jira/browse/CALCITE-2331 evaluation of
predicate (A or B) and C is failing for some adapters
--
Michael Mior
mmior@apache.org
Le jeu. 28 juin 2018 à 13:34, Julian Hyde <jh...@apache.org> a écrit :
> To answer Michael's question: I don't think we should delay the
> report, nor should we hurry the release. It's fair to say that 1.17 is
> in its final stages. There was a lot of activity on avatica-1.12 from
> a lot of individuals, and the community is in great shape.
>
> Here are the cases listed by Volodymyr, converted into links:
>
> Must:
> * https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
> * https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
> in getPulledUpPredicates - Zoltan
> * https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade Avatica -
> Julian
> * https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT - Julian
>
> Nice:
> * https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB
> - Volodymyr
> * https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax - Kevin
> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel - Julian
> (blocked by 2259)
> * https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
> timestamps - Julian to review
>
> Julian
>
>
> On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
> <vo...@apache.org> wrote:
> > Hi Michael,
> >
> > There are several Jiras, which I think are blockers for the
> > release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 + CALCITE-2303.
> > Also, there is a list of the Jiras, which would be good to include to
> > 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
> >
> > So I think we need at least couple of weeks to resolve these issues and
> > release 1.17.
> >
> > Also, please let me know if there are other issues-blockers for the
> > release, or if some of these issues may be omitted.
> >
> > Kind regards,
> > Volodymyr Vysotskyi
> >
> >
> > чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com> пише:
> >
> >> It also would be great to have at least a BETA version of Babel parser
> >>
> >> Enrico
> >>
> >> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha scritto:
> >>
> >> > Just wanted to check in with how we're doing with progress towards a
> >> > release. It's not a rush at all, but I'm preparing the board report
> for
> >> > July and wondering if I should wait to include the 1.17.0 release. It
> >> > sounds like there are a few other things that still need to be wrapped
> >> up,
> >> > so I'm fine if we don't release for another couple weeks.
> >> >
> >> > Thanks again Volodymyr for taking this on!
> >> >
> >> > --
> >> > Michael Mior
> >> > mmior@apache.org
> >> >
> >> >
> >> >
> >> > Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <
> volodymyr@apache.org>
> >> a
> >> > écrit :
> >> >
> >> > > Calcite 1.16.0 was released on March 19 (more than two months ago).
> >> > > We have solved over 48 issues[1] since then, therefore we should
> start
> >> > > discussing about releasing Calcite 1.17.0.
> >> > >
> >> > > I have created [2] to track the release.
> >> > >
> >> > > We will start a release process after the Avatica 1.12 is released.
> >> > >
> >> > > I went through the list of opened PRs during the last month, and
> here
> >> is
> >> > > the list of Jiras which possibly be merged before the release:
> >> > >
> >> > > CALCITE-2303: Support DECADE time unit in EXTRACT function - changes
> >> are
> >> > > done, depends on the Avatica release
> >> > > CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN operator with
> >> the
> >> > > constant from the left side more optimally - I will make required
> >> changes
> >> > > at the beginning of next week
> >> > >
> >> > > * CALCITE-2321: Support ragged fixed length value union be variable
> -
> >> > > In review (Julian)*
> >> > >
> >> > > * CALCITE-2291: Add rule to push Project past Correlate - I will
> pick
> >> up
> >> > > this next week*
> >> > >
> >> > > List of other pull requests which require review or additional
> rework:
> >> > >
> >> > > CALCITE-2327: In 3 valued logic mode (b and not b) may not be
> >> simplified
> >> > to
> >> > > false
> >> > > CALCITE-2302 / CALCITE-2325: Implicit type cast support - Julian
> added
> >> a
> >> > > comment into the Jira
> >> > > CALCITE-2331: evaluation of predicate (A or B) and C is failing for
> >> some
> >> > > adapters - created PR only with a test for this Jira
> >> > > CALCITE-2209: Support loading JSON model file through URL - Shuyi
> Chen
> >> > > added a comment into the Jira
> >> > > CALCITE-2324: Extract seconds, minutes from date works not correct
> in
> >> > some
> >> > > cases
> >> > > CALCITE-2319: Druid Expressions - Output Type of Boolean expressions
> >> > should
> >> > > be set to FLOAT.
> >> > > CALCITE-500: Ensure EnumerableJoin hashes the smallest input - PR is
> >> > > created
> >> > > CALCITE-2301: Remove the 10-second-timeout restriction in
> >> > > ResultSetEnumerable - needs additional rework.
> >> > >
> >> > > Please let me know, if there are any Jiras should be included into
> this
> >> > > release.
> >> > >
> >> > > [1]
> >> > >
> >> > >
> >> >
> >>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> >> > > [2] https://issues.apache.org/jira/browse/CALCITE-2337
> >> > >
> >> > > Kind regards,
> >> > > Volodymyr Vysotskyi
> >> > >
> >> >
> >> --
> >>
> >>
> >> -- Enrico Olivelli
> >>
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Julian Hyde <jh...@apache.org>.
To answer Michael's question: I don't think we should delay the
report, nor should we hurry the release. It's fair to say that 1.17 is
in its final stages. There was a lot of activity on avatica-1.12 from
a lot of individuals, and the community is in great shape.
Here are the cases listed by Volodymyr, converted into links:
Must:
* https://issues.apache.org/jira/browse/CALCITE-2379 CVSS - ?
* https://issues.apache.org/jira/browse/CALCITE-2384 Performance issue
in getPulledUpPredicates - Zoltan
* https://issues.apache.org/jira/browse/CALCITE-2365 Upgrade Avatica - Julian
* https://issues.apache.org/jira/browse/CALCITE-2303 EXTRACT - Julian
Nice:
* https://issues.apache.org/jira/browse/CALCITE-194 Arrays in MongoDB
- Volodymyr
* https://issues.apache.org/jira/browse/CALCITE-2259 Java8 syntax - Kevin
* https://issues.apache.org/jira/browse/CALCITE-2280 Babel - Julian
(blocked by 2259)
* https://issues.apache.org/jira/browse/CALCITE-2339 JDBC adapter
timestamps - Julian to review
Julian
On Thu, Jun 28, 2018 at 10:15 AM, Volodymyr Vysotskyi
<vo...@apache.org> wrote:
> Hi Michael,
>
> There are several Jiras, which I think are blockers for the
> release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 + CALCITE-2303.
> Also, there is a list of the Jiras, which would be good to include to
> 1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
>
> So I think we need at least couple of weeks to resolve these issues and
> release 1.17.
>
> Also, please let me know if there are other issues-blockers for the
> release, or if some of these issues may be omitted.
>
> Kind regards,
> Volodymyr Vysotskyi
>
>
> чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com> пише:
>
>> It also would be great to have at least a BETA version of Babel parser
>>
>> Enrico
>>
>> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha scritto:
>>
>> > Just wanted to check in with how we're doing with progress towards a
>> > release. It's not a rush at all, but I'm preparing the board report for
>> > July and wondering if I should wait to include the 1.17.0 release. It
>> > sounds like there are a few other things that still need to be wrapped
>> up,
>> > so I'm fine if we don't release for another couple weeks.
>> >
>> > Thanks again Volodymyr for taking this on!
>> >
>> > --
>> > Michael Mior
>> > mmior@apache.org
>> >
>> >
>> >
>> > Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <vo...@apache.org>
>> a
>> > écrit :
>> >
>> > > Calcite 1.16.0 was released on March 19 (more than two months ago).
>> > > We have solved over 48 issues[1] since then, therefore we should start
>> > > discussing about releasing Calcite 1.17.0.
>> > >
>> > > I have created [2] to track the release.
>> > >
>> > > We will start a release process after the Avatica 1.12 is released.
>> > >
>> > > I went through the list of opened PRs during the last month, and here
>> is
>> > > the list of Jiras which possibly be merged before the release:
>> > >
>> > > CALCITE-2303: Support DECADE time unit in EXTRACT function - changes
>> are
>> > > done, depends on the Avatica release
>> > > CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN operator with
>> the
>> > > constant from the left side more optimally - I will make required
>> changes
>> > > at the beginning of next week
>> > >
>> > > * CALCITE-2321: Support ragged fixed length value union be variable -
>> > > In review (Julian)*
>> > >
>> > > * CALCITE-2291: Add rule to push Project past Correlate - I will pick
>> up
>> > > this next week*
>> > >
>> > > List of other pull requests which require review or additional rework:
>> > >
>> > > CALCITE-2327: In 3 valued logic mode (b and not b) may not be
>> simplified
>> > to
>> > > false
>> > > CALCITE-2302 / CALCITE-2325: Implicit type cast support - Julian added
>> a
>> > > comment into the Jira
>> > > CALCITE-2331: evaluation of predicate (A or B) and C is failing for
>> some
>> > > adapters - created PR only with a test for this Jira
>> > > CALCITE-2209: Support loading JSON model file through URL - Shuyi Chen
>> > > added a comment into the Jira
>> > > CALCITE-2324: Extract seconds, minutes from date works not correct in
>> > some
>> > > cases
>> > > CALCITE-2319: Druid Expressions - Output Type of Boolean expressions
>> > should
>> > > be set to FLOAT.
>> > > CALCITE-500: Ensure EnumerableJoin hashes the smallest input - PR is
>> > > created
>> > > CALCITE-2301: Remove the 10-second-timeout restriction in
>> > > ResultSetEnumerable - needs additional rework.
>> > >
>> > > Please let me know, if there are any Jiras should be included into this
>> > > release.
>> > >
>> > > [1]
>> > >
>> > >
>> >
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
>> > > [2] https://issues.apache.org/jira/browse/CALCITE-2337
>> > >
>> > > Kind regards,
>> > > Volodymyr Vysotskyi
>> > >
>> >
>> --
>>
>>
>> -- Enrico Olivelli
>>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Volodymyr Vysotskyi <vo...@apache.org>.
Hi Michael,
There are several Jiras, which I think are blockers for the
release: CALCITE-2379, CALCITE-2384 and CALCITE-2365 + CALCITE-2303.
Also, there is a list of the Jiras, which would be good to include to
1.17: CALCITE-194, CALCITE-2259, CALCITE-2280, CALCITE-2339.
So I think we need at least couple of weeks to resolve these issues and
release 1.17.
Also, please let me know if there are other issues-blockers for the
release, or if some of these issues may be omitted.
Kind regards,
Volodymyr Vysotskyi
чт, 28 черв. 2018 о 20:13 Enrico Olivelli <eo...@gmail.com> пише:
> It also would be great to have at least a BETA version of Babel parser
>
> Enrico
>
> Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha scritto:
>
> > Just wanted to check in with how we're doing with progress towards a
> > release. It's not a rush at all, but I'm preparing the board report for
> > July and wondering if I should wait to include the 1.17.0 release. It
> > sounds like there are a few other things that still need to be wrapped
> up,
> > so I'm fine if we don't release for another couple weeks.
> >
> > Thanks again Volodymyr for taking this on!
> >
> > --
> > Michael Mior
> > mmior@apache.org
> >
> >
> >
> > Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <vo...@apache.org>
> a
> > écrit :
> >
> > > Calcite 1.16.0 was released on March 19 (more than two months ago).
> > > We have solved over 48 issues[1] since then, therefore we should start
> > > discussing about releasing Calcite 1.17.0.
> > >
> > > I have created [2] to track the release.
> > >
> > > We will start a release process after the Avatica 1.12 is released.
> > >
> > > I went through the list of opened PRs during the last month, and here
> is
> > > the list of Jiras which possibly be merged before the release:
> > >
> > > CALCITE-2303: Support DECADE time unit in EXTRACT function - changes
> are
> > > done, depends on the Avatica release
> > > CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN operator with
> the
> > > constant from the left side more optimally - I will make required
> changes
> > > at the beginning of next week
> > >
> > > * CALCITE-2321: Support ragged fixed length value union be variable -
> > > In review (Julian)*
> > >
> > > * CALCITE-2291: Add rule to push Project past Correlate - I will pick
> up
> > > this next week*
> > >
> > > List of other pull requests which require review or additional rework:
> > >
> > > CALCITE-2327: In 3 valued logic mode (b and not b) may not be
> simplified
> > to
> > > false
> > > CALCITE-2302 / CALCITE-2325: Implicit type cast support - Julian added
> a
> > > comment into the Jira
> > > CALCITE-2331: evaluation of predicate (A or B) and C is failing for
> some
> > > adapters - created PR only with a test for this Jira
> > > CALCITE-2209: Support loading JSON model file through URL - Shuyi Chen
> > > added a comment into the Jira
> > > CALCITE-2324: Extract seconds, minutes from date works not correct in
> > some
> > > cases
> > > CALCITE-2319: Druid Expressions - Output Type of Boolean expressions
> > should
> > > be set to FLOAT.
> > > CALCITE-500: Ensure EnumerableJoin hashes the smallest input - PR is
> > > created
> > > CALCITE-2301: Remove the 10-second-timeout restriction in
> > > ResultSetEnumerable - needs additional rework.
> > >
> > > Please let me know, if there are any Jiras should be included into this
> > > release.
> > >
> > > [1]
> > >
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> > > [2] https://issues.apache.org/jira/browse/CALCITE-2337
> > >
> > > Kind regards,
> > > Volodymyr Vysotskyi
> > >
> >
> --
>
>
> -- Enrico Olivelli
>
Re: [DISCUSS] Towards Calcite 1.17.0
Posted by Enrico Olivelli <eo...@gmail.com>.
It also would be great to have at least a BETA version of Babel parser
Enrico
Il gio 28 giu 2018, 18:48 Michael Mior <mm...@apache.org> ha scritto:
> Just wanted to check in with how we're doing with progress towards a
> release. It's not a rush at all, but I'm preparing the board report for
> July and wondering if I should wait to include the 1.17.0 release. It
> sounds like there are a few other things that still need to be wrapped up,
> so I'm fine if we don't release for another couple weeks.
>
> Thanks again Volodymyr for taking this on!
>
> --
> Michael Mior
> mmior@apache.org
>
>
>
> Le mer. 30 mai 2018 à 07:44, Volodymyr Vysotskyi <vo...@apache.org> a
> écrit :
>
> > Calcite 1.16.0 was released on March 19 (more than two months ago).
> > We have solved over 48 issues[1] since then, therefore we should start
> > discussing about releasing Calcite 1.17.0.
> >
> > I have created [2] to track the release.
> >
> > We will start a release process after the Avatica 1.12 is released.
> >
> > I went through the list of opened PRs during the last month, and here is
> > the list of Jiras which possibly be merged before the release:
> >
> > CALCITE-2303: Support DECADE time unit in EXTRACT function - changes are
> > done, depends on the Avatica release
> > CALCITE-2329: Enhance SubQueryRemoveRule to rewrite IN operator with the
> > constant from the left side more optimally - I will make required changes
> > at the beginning of next week
> >
> > * CALCITE-2321: Support ragged fixed length value union be variable -
> > In review (Julian)*
> >
> > * CALCITE-2291: Add rule to push Project past Correlate - I will pick up
> > this next week*
> >
> > List of other pull requests which require review or additional rework:
> >
> > CALCITE-2327: In 3 valued logic mode (b and not b) may not be simplified
> to
> > false
> > CALCITE-2302 / CALCITE-2325: Implicit type cast support - Julian added a
> > comment into the Jira
> > CALCITE-2331: evaluation of predicate (A or B) and C is failing for some
> > adapters - created PR only with a test for this Jira
> > CALCITE-2209: Support loading JSON model file through URL - Shuyi Chen
> > added a comment into the Jira
> > CALCITE-2324: Extract seconds, minutes from date works not correct in
> some
> > cases
> > CALCITE-2319: Druid Expressions - Output Type of Boolean expressions
> should
> > be set to FLOAT.
> > CALCITE-500: Ensure EnumerableJoin hashes the smallest input - PR is
> > created
> > CALCITE-2301: Remove the 10-second-timeout restriction in
> > ResultSetEnumerable - needs additional rework.
> >
> > Please let me know, if there are any Jiras should be included into this
> > release.
> >
> > [1]
> >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Resolved%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.17.0
> > [2] https://issues.apache.org/jira/browse/CALCITE-2337
> >
> > Kind regards,
> > Volodymyr Vysotskyi
> >
>
--
-- Enrico Olivelli