You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/11/29 13:45:38 UTC
[GitHub] [incubator-pegasus] Apache9 opened a new pull request, #1266: refactor: Remove assembly and output debug output to console when running UTs for java client
Apache9 opened a new pull request, #1266:
URL: https://github.com/apache/incubator-pegasus/pull/1266
https://github.com/apache/incubator-pegasus/issues/1265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Apache9 commented on a diff in pull request #1266: refactor: Remove assembly and output debug output to console when running UTs for java client
Posted by GitBox <gi...@apache.org>.
Apache9 commented on code in PR #1266:
URL: https://github.com/apache/incubator-pegasus/pull/1266#discussion_r1034883205
##########
java-client/configuration/log4j.properties:
##########
@@ -1,42 +0,0 @@
-#
Review Comment:
In java world we use maven or gradle to download dependencies, usually a jar and its transitive dependencies, and the configuration file should be prepared by the end users, when setting up its own application which uses pegasus java client.
And for running UTs, I moved the log4j.properties and pegasus.properties to src/test/resources. This is the default place for putting test resources, and you can load these fiels with getResourceAsStream when running UTs.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1266: refactor: Remove assembly and output debug output to console when running UTs for java client
Posted by GitBox <gi...@apache.org>.
empiredan commented on code in PR #1266:
URL: https://github.com/apache/incubator-pegasus/pull/1266#discussion_r1034920048
##########
java-client/src/test/resources/log4j.properties:
##########
@@ -17,15 +17,9 @@
# under the License.
#
-meta_servers = 127.0.0.1:34601,127.0.0.1:34602,127.0.0.1:34603
-operation_timeout = 5000
-async_workers = 4
-enable_perf_counter = false
-perf_counter_tags = cluster=onebox,app=unit_test
-push_counter_interval_secs = 10
-meta_query_timeout = 5000
-auth_protocol =
-kerberos_service_name =
-kerberos_service_fqdn =
-kerberos_keytab =
-kerberos_principal =
Review Comment:
Is it necessary to also move these properties to `pegasus.properties` under `src/test/resources` as a configuration example for developers ?
```properties
meta_query_timeout = 5000
auth_protocol =
kerberos_service_name =
kerberos_service_fqdn =
kerberos_keytab =
kerberos_principal =
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on a diff in pull request #1266: refactor: Remove assembly and output debug output to console when running UTs for java client
Posted by GitBox <gi...@apache.org>.
levy5307 commented on code in PR #1266:
URL: https://github.com/apache/incubator-pegasus/pull/1266#discussion_r1034877729
##########
java-client/configuration/log4j.properties:
##########
@@ -1,42 +0,0 @@
-#
Review Comment:
Why did you remove this properties file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on a diff in pull request #1266: refactor: Remove assembly and output debug output to console when running UTs for java client
Posted by GitBox <gi...@apache.org>.
levy5307 commented on code in PR #1266:
URL: https://github.com/apache/incubator-pegasus/pull/1266#discussion_r1035495197
##########
java-client/configuration/log4j.properties:
##########
@@ -1,42 +0,0 @@
-#
Review Comment:
OK. Thanks for your reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #1266: refactor: Remove assembly and output debug output to console when running UTs for java client
Posted by GitBox <gi...@apache.org>.
acelyc111 merged PR #1266:
URL: https://github.com/apache/incubator-pegasus/pull/1266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Apache9 commented on a diff in pull request #1266: refactor: Remove assembly and output debug output to console when running UTs for java client
Posted by GitBox <gi...@apache.org>.
Apache9 commented on code in PR #1266:
URL: https://github.com/apache/incubator-pegasus/pull/1266#discussion_r1034927158
##########
java-client/src/test/resources/log4j.properties:
##########
@@ -17,15 +17,9 @@
# under the License.
#
-meta_servers = 127.0.0.1:34601,127.0.0.1:34602,127.0.0.1:34603
-operation_timeout = 5000
-async_workers = 4
-enable_perf_counter = false
-perf_counter_tags = cluster=onebox,app=unit_test
-push_counter_interval_secs = 10
-meta_query_timeout = 5000
-auth_protocol =
-kerberos_service_name =
-kerberos_service_fqdn =
-kerberos_keytab =
-kerberos_principal =
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org