You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Randall Hauch (JIRA)" <ji...@apache.org> on 2012/07/09 19:50:34 UTC

[jira] [Created] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Randall Hauch created JCR-3380:
----------------------------------

             Summary: TCK tests for shareable nodes assume moving shareable nodes is not supported
                 Key: JCR-3380
                 URL: https://issues.apache.org/jira/browse/JCR-3380
             Project: Jackrabbit Content Repository
          Issue Type: Bug
          Components: jackrabbit-jcr-tests, JCR 2.0, test
    Affects Versions: 2.5
            Reporter: Randall Hauch
             Fix For: 2.5.1, 2.6


There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.

1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.

Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410276#comment-13410276 ] 

Julian Reschke commented on JCR-3380:
-------------------------------------

As far as I understand, we should just fix the tests to actually assume that move() is allowed, mark them as "fail" for Jackrabbit, and raise an issue against jackrabbit-core. As a matter of fact, given the number of issues with respect to shareable nodes, we probably should mark them as unsupported for now.
                
> TCK tests for shareable nodes assume moving shareable nodes is not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-3380
>                 URL: https://issues.apache.org/jira/browse/JCR-3380
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests, JCR 2.0, test
>    Affects Versions: 2.5
>            Reporter: Randall Hauch
>             Fix For: 2.5.1, 2.6
>
>         Attachments: JCR-3380-fix-shareable-tests.patch
>
>
> There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.
> 1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
> 2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.
> Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Posted by "Randall Hauch (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409682#comment-13409682 ] 

Randall Hauch commented on JCR-3380:
------------------------------------

I will upload a (properly formatted) patch with a proposed fix for these methods.
                
> TCK tests for shareable nodes assume moving shareable nodes is not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-3380
>                 URL: https://issues.apache.org/jira/browse/JCR-3380
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests, JCR 2.0, test
>    Affects Versions: 2.5
>            Reporter: Randall Hauch
>             Fix For: 2.5.1, 2.6
>
>
> There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.
> 1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
> 2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.
> Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Posted by "Randall Hauch (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412754#comment-13412754 ] 

Randall Hauch commented on JCR-3380:
------------------------------------

So can this patch be applied to the "trunk" branch?
                
> TCK tests for shareable nodes assume moving shareable nodes is not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-3380
>                 URL: https://issues.apache.org/jira/browse/JCR-3380
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests, JCR 2.0, test
>    Affects Versions: 2.5
>            Reporter: Randall Hauch
>             Fix For: 2.5.1, 2.6
>
>         Attachments: JCR-3380-fix-shareable-tests.patch
>
>
> There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.
> 1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
> 2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.
> Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412789#comment-13412789 ] 

Julian Reschke commented on JCR-3380:
-------------------------------------

We should modify the tests so that the move is tried, and the outcome is checked (that is, that the move has actually changed the state of the repo as defined).

Test cases can be marked as "failing" in the pom.xml for jackrabbit-core.
                
> TCK tests for shareable nodes assume moving shareable nodes is not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-3380
>                 URL: https://issues.apache.org/jira/browse/JCR-3380
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests, JCR 2.0, test
>    Affects Versions: 2.5
>            Reporter: Randall Hauch
>             Fix For: 2.5.1, 2.6
>
>         Attachments: JCR-3380-fix-shareable-tests.patch
>
>
> There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.
> 1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
> 2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.
> Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Posted by "Randall Hauch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Randall Hauch updated JCR-3380:
-------------------------------

    Attachment: JCR-3380-fix-shareable-tests.patch

Attached a patch that fixes the two move-related test cases.
                
> TCK tests for shareable nodes assume moving shareable nodes is not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-3380
>                 URL: https://issues.apache.org/jira/browse/JCR-3380
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests, JCR 2.0, test
>    Affects Versions: 2.5
>            Reporter: Randall Hauch
>             Fix For: 2.5.1, 2.6
>
>         Attachments: JCR-3380-fix-shareable-tests.patch
>
>
> There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.
> 1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
> 2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.
> Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412757#comment-13412757 ] 

Julian Reschke commented on JCR-3380:
-------------------------------------

See my comment from July 10.
                
> TCK tests for shareable nodes assume moving shareable nodes is not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-3380
>                 URL: https://issues.apache.org/jira/browse/JCR-3380
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests, JCR 2.0, test
>    Affects Versions: 2.5
>            Reporter: Randall Hauch
>             Fix For: 2.5.1, 2.6
>
>         Attachments: JCR-3380-fix-shareable-tests.patch
>
>
> There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.
> 1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
> 2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.
> Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Posted by "Randall Hauch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Randall Hauch updated JCR-3380:
-------------------------------

    Attachment: JCR-3380-fix-shareable-tests-v2.patch

Attached a second version of the patch called "JCR-3380-fix-shareable-tests-v2.patch" that supersedes the previous patch. This new version modifies the tests as requested by Julian (to perform a move and always expect success), and it adds the two tests to the "known.issues" property in the "jackrabbit-core/pom.xml" file (as requested).

After I apply this patch locally to the latest from 'trunk', the build completes successfully.
                
> TCK tests for shareable nodes assume moving shareable nodes is not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-3380
>                 URL: https://issues.apache.org/jira/browse/JCR-3380
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests, JCR 2.0, test
>    Affects Versions: 2.5
>            Reporter: Randall Hauch
>             Fix For: 2.5.1, 2.6
>
>         Attachments: JCR-3380-fix-shareable-tests-v2.patch, JCR-3380-fix-shareable-tests.patch
>
>
> There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.
> 1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
> 2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.
> Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Reschke updated JCR-3380:
--------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.5.1)
           Status: Resolved  (was: Patch Available)

Patch applied with minor changes; thanks, Randall.
                
> TCK tests for shareable nodes assume moving shareable nodes is not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-3380
>                 URL: https://issues.apache.org/jira/browse/JCR-3380
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests, JCR 2.0, test
>    Affects Versions: 2.5
>            Reporter: Randall Hauch
>            Assignee: Julian Reschke
>             Fix For: 2.6
>
>         Attachments: JCR-3380-fix-shareable-tests-v2.patch, JCR-3380-fix-shareable-tests.patch
>
>
> There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.
> 1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
> 2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.
> Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Posted by "Randall Hauch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Randall Hauch updated JCR-3380:
-------------------------------

    Status: Patch Available  (was: Open)
    
> TCK tests for shareable nodes assume moving shareable nodes is not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-3380
>                 URL: https://issues.apache.org/jira/browse/JCR-3380
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests, JCR 2.0, test
>    Affects Versions: 2.5
>            Reporter: Randall Hauch
>             Fix For: 2.5.1, 2.6
>
>         Attachments: JCR-3380-fix-shareable-tests.patch
>
>
> There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.
> 1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
> 2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.
> Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Posted by "Randall Hauch (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412774#comment-13412774 ] 

Randall Hauch commented on JCR-3380:
------------------------------------

So do you want another patch, or can you just remove the try/catch blocks from the patch? Also, I don't know how to mark the tests as "fail" for Jackrabbit.
                
> TCK tests for shareable nodes assume moving shareable nodes is not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-3380
>                 URL: https://issues.apache.org/jira/browse/JCR-3380
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests, JCR 2.0, test
>    Affects Versions: 2.5
>            Reporter: Randall Hauch
>             Fix For: 2.5.1, 2.6
>
>         Attachments: JCR-3380-fix-shareable-tests.patch
>
>
> There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.
> 1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
> 2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.
> Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Posted by "Randall Hauch (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409700#comment-13409700 ] 

Randall Hauch commented on JCR-3380:
------------------------------------

Julian, 

Good question. Moving shareable nodes is not explicitly disallowed (or at least I can't find it). And since much of the specification addresses shareable nodes by describing how the behavior of a feature differs for shareable nodes (e.g., Chapter 14 "Shareable Nodes" specifically mentions the how importing, exporting, removing, copying, observation, locking, constraints, versioning, restore, and query are all affected by/for shareable nodes), my reading is that shareable nodes are allowed.

Interestingly, the tests don't even try to move nodes that have already been shared. Instead, they simply create a node, add the "mix:shareable" mixin, and then try to move that node.
                
> TCK tests for shareable nodes assume moving shareable nodes is not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-3380
>                 URL: https://issues.apache.org/jira/browse/JCR-3380
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests, JCR 2.0, test
>    Affects Versions: 2.5
>            Reporter: Randall Hauch
>             Fix For: 2.5.1, 2.6
>
>
> There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.
> 1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
> 2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.
> Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Reschke reassigned JCR-3380:
-----------------------------------

    Assignee: Julian Reschke
    
> TCK tests for shareable nodes assume moving shareable nodes is not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-3380
>                 URL: https://issues.apache.org/jira/browse/JCR-3380
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests, JCR 2.0, test
>    Affects Versions: 2.5
>            Reporter: Randall Hauch
>            Assignee: Julian Reschke
>             Fix For: 2.5.1, 2.6
>
>         Attachments: JCR-3380-fix-shareable-tests-v2.patch, JCR-3380-fix-shareable-tests.patch
>
>
> There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.
> 1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
> 2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.
> Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3380) TCK tests for shareable nodes assume moving shareable nodes is not supported

Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409691#comment-13409691 ] 

Julian Reschke commented on JCR-3380:
-------------------------------------

Is not supporting move() on shareable nodes indeed allowed?
                
> TCK tests for shareable nodes assume moving shareable nodes is not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-3380
>                 URL: https://issues.apache.org/jira/browse/JCR-3380
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests, JCR 2.0, test
>    Affects Versions: 2.5
>            Reporter: Randall Hauch
>             Fix For: 2.5.1, 2.6
>
>
> There are two tests in ShareableNodeTest that assume that an implementation does not support moving shareable nodes. This is inconsistent with what is required by JSR-283.
> 1) testMoveShareableNode assumes that the implementation does not support moving nodes that are 'mix:shareable' (even when they are not yet shared) using Workspace.move(...). 
> 2) testTransientMoveShareableNode makes a similar assumption to #1, except that it uses the Session.move(...) operation.
> Both of these test should be changed to allow an implementation to either not support the operation (e.g., Jackrabbit) or to properly check the results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira