You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/04/07 01:19:37 UTC
Review Request 32909: Add a test utility to check that all fields are
set on a storage entity.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32909/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
-------
I feel this utility will offer some confidence that object mapping is complete when finishing the storage migration to H2.
I originally went down the path of doing this based on generated thrift struct metadata, but as is the norm - TUnion was problematic. As it turned out, using plain reflection was far simpler.
Diffs
-----
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 98107508239e3169260fd1bea498f6d19f8f7b16
src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java d6140f5268ae046b225d39cc2d360d06399eaa5e
src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java dc27c3e8ca8137bc0b69deafcec2bfad38222dab
src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java c1217e2251cd1abbeaa6ffcdffbe0295951077ff
src/test/java/org/apache/aurora/scheduler/storage/testing/StorageEntityUtil.java PRE-CREATION
Diff: https://reviews.apache.org/r/32909/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 32909: Add a test utility to check that all fields
are set on a storage entity.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32909/#review79092
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On April 6, 2015, 11:19 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32909/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 11:19 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I feel this utility will offer some confidence that object mapping is complete when finishing the storage migration to H2.
>
> I originally went down the path of doing this based on generated thrift struct metadata, but as is the norm - TUnion was problematic. As it turned out, using plain reflection was far simpler.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 98107508239e3169260fd1bea498f6d19f8f7b16
> src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java d6140f5268ae046b225d39cc2d360d06399eaa5e
> src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java dc27c3e8ca8137bc0b69deafcec2bfad38222dab
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java c1217e2251cd1abbeaa6ffcdffbe0295951077ff
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageEntityUtil.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32909/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32909: Add a test utility to check that all fields
are set on a storage entity.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32909/#review79080
-----------------------------------------------------------
Master (6fc7f58) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE
src.test.python.apache.thermos.cli.commands.commands ..... SUCCESS
src.test.python.apache.thermos.cli.common ..... SUCCESS
src.test.python.apache.thermos.cli.main ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 6, 2015, 11:19 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32909/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 11:19 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I feel this utility will offer some confidence that object mapping is complete when finishing the storage migration to H2.
>
> I originally went down the path of doing this based on generated thrift struct metadata, but as is the norm - TUnion was problematic. As it turned out, using plain reflection was far simpler.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 98107508239e3169260fd1bea498f6d19f8f7b16
> src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java d6140f5268ae046b225d39cc2d360d06399eaa5e
> src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java dc27c3e8ca8137bc0b69deafcec2bfad38222dab
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java c1217e2251cd1abbeaa6ffcdffbe0295951077ff
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageEntityUtil.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32909/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>