You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/03/21 07:44:20 UTC
[GitHub] [ignite-3] ptupitsyn opened a new pull request #737: IGNITE-16530 Java thin: add heartbeats
ptupitsyn opened a new pull request #737:
URL: https://github.com/apache/ignite-3/pull/737
Implement heartbeats in Java thin client: https://cwiki.apache.org/confluence/display/IGNITE/IEP-83+Thin+Client+Keepalive
* Add `IgniteClientConfiguration.heartbeatInterval`, default 30 seconds.
* Add `ClientConnectorConfiguration.idleTimeout`, default 0 (disabled).
* Add `idleTimeout` to handshake.
* Set effective heartbeat interval to `Math.min(heartbeatInterval, idleTimeout / 3)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ptupitsyn commented on a change in pull request #737: IGNITE-16532 Java thin: add heartbeats
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #737:
URL: https://github.com/apache/ignite-3/pull/737#discussion_r830891610
##########
File path: modules/client/src/main/java/org/apache/ignite/internal/client/TcpClientChannel.java
##########
@@ -60,6 +63,9 @@
ProtocolVersion.V3_0_0
);
+ /** Minimum supported heartbeat interval. */
+ private static final long MIN_RECOMMENDED_HEARTBEAT_INTERVAL = 50;
Review comment:
@isapego agree, what would you suggest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ptupitsyn merged pull request #737: IGNITE-16532 Java thin: add heartbeats
Posted by GitBox <gi...@apache.org>.
ptupitsyn merged pull request #737:
URL: https://github.com/apache/ignite-3/pull/737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] isapego commented on a change in pull request #737: IGNITE-16532 Java thin: add heartbeats
Posted by GitBox <gi...@apache.org>.
isapego commented on a change in pull request #737:
URL: https://github.com/apache/ignite-3/pull/737#discussion_r830980110
##########
File path: modules/client/src/main/java/org/apache/ignite/internal/client/TcpClientChannel.java
##########
@@ -60,6 +63,9 @@
ProtocolVersion.V3_0_0
);
+ /** Minimum supported heartbeat interval. */
+ private static final long MIN_RECOMMENDED_HEARTBEAT_INTERVAL = 50;
Review comment:
I don't know really. How about 500 or at least 200-300?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ptupitsyn commented on a change in pull request #737: IGNITE-16532 Java thin: add heartbeats
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #737:
URL: https://github.com/apache/ignite-3/pull/737#discussion_r831010504
##########
File path: modules/client/src/main/java/org/apache/ignite/internal/client/TcpClientChannel.java
##########
@@ -60,6 +63,9 @@
ProtocolVersion.V3_0_0
);
+ /** Minimum supported heartbeat interval. */
+ private static final long MIN_RECOMMENDED_HEARTBEAT_INTERVAL = 50;
Review comment:
500 sounds good, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] isapego commented on a change in pull request #737: IGNITE-16532 Java thin: add heartbeats
Posted by GitBox <gi...@apache.org>.
isapego commented on a change in pull request #737:
URL: https://github.com/apache/ignite-3/pull/737#discussion_r830881204
##########
File path: modules/client/src/main/java/org/apache/ignite/internal/client/TcpClientChannel.java
##########
@@ -60,6 +63,9 @@
ProtocolVersion.V3_0_0
);
+ /** Minimum supported heartbeat interval. */
+ private static final long MIN_RECOMMENDED_HEARTBEAT_INTERVAL = 50;
Review comment:
Don't you think 50 ms is a too short for real network envirnment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org