You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/07/31 00:02:14 UTC
Review Request 71210: Removed total resources tracking in the random
sorter.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71210/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Repository: mesos
Description
-------
Random sorter is "stateless" and thus does not need information
such as agent resources and total cluster resources.
DRF sorter, on the other hand, do need to calculate shares based
on total resources. Although ideally, all sorters should take
in a client tree structure with respective sort info embedded.
But we will keep the resource info in the DRF sorter for now.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp d2658bc8997202b17bac0f765bd4f522ebee350e
src/master/allocator/mesos/hierarchical.cpp f1fa838d654816aba14ac032174bf1522b7ae033
src/master/allocator/sorter/drf/sorter.hpp 84c33ca49c5288d221f82eeb968d640461867da7
src/master/allocator/sorter/drf/sorter.cpp 9367469132e426f0b4b66a80ad300c157fba6bf2
src/master/allocator/sorter/random/sorter.hpp ca687d4590387d5d788919f81fe32b43baba6b3c
src/master/allocator/sorter/random/sorter.cpp 9899cfd570607a60dbd7980d340a8e7d9d3e6df5
src/master/allocator/sorter/sorter.hpp d56a1166a9e82b034564842ac071874ec2885004
src/tests/sorter_tests.cpp 5cd2a64cb8c06f0d27c04bc0f40d347e6e61095e
Diff: https://reviews.apache.org/r/71210/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 71210: Removed total resources tracking in the
random sorter.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71210/#review217010
-----------------------------------------------------------
src/tests/sorter_tests.cpp
Lines 1823-1859 (original)
<https://reviews.apache.org/r/71210/#comment304244>
Hm.. it still seems important to check that the DRF sorter is correctly handling shared resources in its total?
- Benjamin Mahler
On July 31, 2019, 12:02 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71210/
> -----------------------------------------------------------
>
> (Updated July 31, 2019, 12:02 a.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Random sorter is "stateless" and thus does not need information
> such as agent resources and total cluster resources.
>
> DRF sorter, on the other hand, do need to calculate shares based
> on total resources. Although ideally, all sorters should take
> in a client tree structure with respective sort info embedded.
> But we will keep the resource info in the DRF sorter for now.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp d2658bc8997202b17bac0f765bd4f522ebee350e
> src/master/allocator/mesos/hierarchical.cpp f1fa838d654816aba14ac032174bf1522b7ae033
> src/master/allocator/sorter/drf/sorter.hpp 84c33ca49c5288d221f82eeb968d640461867da7
> src/master/allocator/sorter/drf/sorter.cpp 9367469132e426f0b4b66a80ad300c157fba6bf2
> src/master/allocator/sorter/random/sorter.hpp ca687d4590387d5d788919f81fe32b43baba6b3c
> src/master/allocator/sorter/random/sorter.cpp 9899cfd570607a60dbd7980d340a8e7d9d3e6df5
> src/master/allocator/sorter/sorter.hpp d56a1166a9e82b034564842ac071874ec2885004
> src/tests/sorter_tests.cpp 5cd2a64cb8c06f0d27c04bc0f40d347e6e61095e
>
>
> Diff: https://reviews.apache.org/r/71210/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71210: Removed total resources tracking in the
random sorter.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71210/#review216991
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71210]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 31, 2019, 12:02 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71210/
> -----------------------------------------------------------
>
> (Updated July 31, 2019, 12:02 a.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Random sorter is "stateless" and thus does not need information
> such as agent resources and total cluster resources.
>
> DRF sorter, on the other hand, do need to calculate shares based
> on total resources. Although ideally, all sorters should take
> in a client tree structure with respective sort info embedded.
> But we will keep the resource info in the DRF sorter for now.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp d2658bc8997202b17bac0f765bd4f522ebee350e
> src/master/allocator/mesos/hierarchical.cpp f1fa838d654816aba14ac032174bf1522b7ae033
> src/master/allocator/sorter/drf/sorter.hpp 84c33ca49c5288d221f82eeb968d640461867da7
> src/master/allocator/sorter/drf/sorter.cpp 9367469132e426f0b4b66a80ad300c157fba6bf2
> src/master/allocator/sorter/random/sorter.hpp ca687d4590387d5d788919f81fe32b43baba6b3c
> src/master/allocator/sorter/random/sorter.cpp 9899cfd570607a60dbd7980d340a8e7d9d3e6df5
> src/master/allocator/sorter/sorter.hpp d56a1166a9e82b034564842ac071874ec2885004
> src/tests/sorter_tests.cpp 5cd2a64cb8c06f0d27c04bc0f40d347e6e61095e
>
>
> Diff: https://reviews.apache.org/r/71210/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>